Merge #18221 - Keep the criteria box collapsed by the user when un-checking the criteria checkbox

Pull-request: #18221

Signed-off-by: William Desportes <williamdes@wdes.fr>
This commit is contained in:
William Desportes 2023-05-06 11:35:27 +02:00
commit 3e023ca0e3
No known key found for this signature in database
GPG Key ID: 90A0EF1B8251A889

View File

@ -195,7 +195,10 @@ AJAX.registerOnload('database/multi_table_query.js', function () {
$('.criteria_col').each(function () {
$(this).on('change', function () {
var $anchor = $(this).siblings('.jsCriteriaButton').first();
if ($(this).is(':checked') && ! $anchor.hasClass('collapsed')) {
if (
($(this).is(':checked') && ! $anchor.hasClass('collapsed'))
|| (! $(this).is(':checked') && $anchor.hasClass('collapsed'))
) {
// Do not collapse on checkbox tick as it does not make sense
// The user has it open and wants to tick the box
return;