diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index f8d6dffb0a..f6c2613c23 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -9176,17 +9176,17 @@ parameters: path: test/classes/AdvisorTest.php - - message: "#^Parameter \\#2 \\$haystack of method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringContainsString\\(\\) expects string, mixed given\\.$#" + message: "#^Parameter \\#2 \\$haystack of static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringContainsString\\(\\) expects string, mixed given\\.$#" count: 3 path: test/classes/BrowseForeignersTest.php - - message: "#^Parameter \\#2 \\$string of method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringEndsWith\\(\\) expects string, mixed given\\.$#" + message: "#^Parameter \\#2 \\$string of static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringEndsWith\\(\\) expects string, mixed given\\.$#" count: 1 path: test/classes/BrowseForeignersTest.php - - message: "#^Parameter \\#2 \\$string of method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringStartsWith\\(\\) expects string, mixed given\\.$#" + message: "#^Parameter \\#2 \\$string of static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringStartsWith\\(\\) expects string, mixed given\\.$#" count: 1 path: test/classes/BrowseForeignersTest.php @@ -9226,17 +9226,17 @@ parameters: path: test/classes/Command/TwigLintCommandTest.php - - message: "#^Call to method PHPUnit\\\\Framework\\\\Assert\\:\\:assertFalse\\(\\) with true will always evaluate to false\\.$#" + message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertFalse\\(\\) with true will always evaluate to false\\.$#" count: 1 path: test/classes/CommonTest.php - - message: "#^Call to method PHPUnit\\\\Framework\\\\Assert\\:\\:assertTrue\\(\\) with \\*NEVER\\* will always evaluate to false\\.$#" + message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertTrue\\(\\) with \\*NEVER\\* will always evaluate to false\\.$#" count: 1 path: test/classes/CommonTest.php - - message: "#^Call to method PHPUnit\\\\Framework\\\\Assert\\:\\:assertTrue\\(\\) with false will always evaluate to false\\.$#" + message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertTrue\\(\\) with false will always evaluate to false\\.$#" count: 1 path: test/classes/CommonTest.php @@ -9251,7 +9251,17 @@ parameters: path: test/classes/Config/DescriptionTest.php - - message: "#^Call to method PHPUnit\\\\Framework\\\\Assert\\:\\:assertTrue\\(\\) with null will always evaluate to false\\.$#" + message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertSame\\(\\) with ''\\|'; Compressed export…'\\|'Compressed export…'\\|'Compressed import…' and null will always evaluate to false\\.$#" + count: 1 + path: test/classes/Config/FormDisplayTest.php + + - + message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertSame\\(\\) with 'string' and 'NULL' will always evaluate to false\\.$#" + count: 1 + path: test/classes/Config/FormDisplayTest.php + + - + message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertTrue\\(\\) with null will always evaluate to false\\.$#" count: 1 path: test/classes/Config/FormDisplayTest.php @@ -9376,7 +9386,7 @@ parameters: path: test/classes/Controllers/Database/Structure/FavoriteTableControllerTest.php - - message: "#^Parameter \\#2 \\$array of method PHPUnit\\\\Framework\\\\Assert\\:\\:assertArrayHasKey\\(\\) expects array\\|ArrayAccess, mixed given\\.$#" + message: "#^Parameter \\#2 \\$array of static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertArrayHasKey\\(\\) expects array\\|ArrayAccess, mixed given\\.$#" count: 1 path: test/classes/Controllers/Database/Structure/FavoriteTableControllerTest.php @@ -9411,17 +9421,17 @@ parameters: path: test/classes/Controllers/Database/StructureControllerTest.php - - message: "#^Parameter \\#2 \\$array of method PHPUnit\\\\Framework\\\\Assert\\:\\:assertArrayNotHasKey\\(\\) expects array\\|ArrayAccess, mixed given\\.$#" + message: "#^Parameter \\#2 \\$array of static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertArrayNotHasKey\\(\\) expects array\\|ArrayAccess, mixed given\\.$#" count: 1 path: test/classes/Controllers/Database/StructureControllerTest.php - - message: "#^Parameter \\#2 \\$haystack of method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringContainsString\\(\\) expects string, mixed given\\.$#" + message: "#^Parameter \\#2 \\$haystack of static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringContainsString\\(\\) expects string, mixed given\\.$#" count: 4 path: test/classes/Controllers/Database/StructureControllerTest.php - - message: "#^Parameter \\#2 \\$haystack of method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringNotContainsString\\(\\) expects string, mixed given\\.$#" + message: "#^Parameter \\#2 \\$haystack of static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringNotContainsString\\(\\) expects string, mixed given\\.$#" count: 1 path: test/classes/Controllers/Database/StructureControllerTest.php @@ -9511,7 +9521,7 @@ parameters: path: test/classes/Database/CentralColumnsTest.php - - message: "#^Parameter \\#1 \\$needle of method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringContainsString\\(\\) expects string, mixed given\\.$#" + message: "#^Parameter \\#1 \\$needle of static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringContainsString\\(\\) expects string, mixed given\\.$#" count: 1 path: test/classes/Database/CentralColumnsTest.php @@ -9571,12 +9581,12 @@ parameters: path: test/classes/Database/EventsTest.php - - message: "#^Parameter \\#2 \\$haystack of method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringContainsString\\(\\) expects string, mixed given\\.$#" + message: "#^Parameter \\#2 \\$haystack of static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringContainsString\\(\\) expects string, mixed given\\.$#" count: 7 path: test/classes/Database/QbeTest.php - - message: "#^Parameter \\#2 \\$haystack of method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringNotContainsString\\(\\) expects string, mixed given\\.$#" + message: "#^Parameter \\#2 \\$haystack of static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringNotContainsString\\(\\) expects string, mixed given\\.$#" count: 1 path: test/classes/Database/QbeTest.php @@ -9941,7 +9951,7 @@ parameters: path: test/classes/Display/ResultsTest.php - - message: "#^Parameter \\#2 \\$haystack of method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringContainsString\\(\\) expects string, mixed given\\.$#" + message: "#^Parameter \\#2 \\$haystack of static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringContainsString\\(\\) expects string, mixed given\\.$#" count: 9 path: test/classes/Display/ResultsTest.php @@ -10580,6 +10590,21 @@ parameters: count: 1 path: test/classes/ImportTest.php + - + message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertSame\\(\\) with 'Cardinality1' and int\\|null will always evaluate to false\\.$#" + count: 1 + path: test/classes/IndexTest.php + + - + message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertSame\\(\\) with 'PMA_Non_unique' and int will always evaluate to false\\.$#" + count: 1 + path: test/classes/IndexTest.php + + - + message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertSame\\(\\) with 'index1' and int will always evaluate to false\\.$#" + count: 1 + path: test/classes/IndexTest.php + - message: "#^Property PhpMyAdmin\\\\Tests\\\\IndexTest\\:\\:\\$params type has no value type specified in iterable type array\\.$#" count: 1 @@ -10711,7 +10736,7 @@ parameters: path: test/classes/Partitioning/TablePartitionDefinitionTest.php - - message: "#^Call to method PHPUnit\\\\Framework\\\\Assert\\:\\:assertSame\\(\\) with 32 and 0 will always evaluate to false\\.$#" + message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertSame\\(\\) with 32 and 0 will always evaluate to false\\.$#" count: 1 path: test/classes/Plugins/Auth/AuthenticationCookieTest.php @@ -10741,17 +10766,17 @@ parameters: path: test/classes/Plugins/Auth/AuthenticationHttpTest.php - - message: "#^Parameter \\#2 \\$haystack of method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringContainsString\\(\\) expects string, mixed given\\.$#" + message: "#^Parameter \\#2 \\$haystack of static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringContainsString\\(\\) expects string, mixed given\\.$#" count: 1 path: test/classes/Plugins/Export/ExportHtmlwordTest.php - - message: "#^Parameter \\#2 \\$haystack of method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringContainsString\\(\\) expects string, mixed given\\.$#" + message: "#^Parameter \\#2 \\$haystack of static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringContainsString\\(\\) expects string, mixed given\\.$#" count: 5 path: test/classes/Plugins/Export/ExportOdtTest.php - - message: "#^Parameter \\#2 \\$haystack of method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringContainsString\\(\\) expects string, mixed given\\.$#" + message: "#^Parameter \\#2 \\$haystack of static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringContainsString\\(\\) expects string, mixed given\\.$#" count: 2 path: test/classes/Plugins/Export/ExportSqlTest.php @@ -10800,6 +10825,11 @@ parameters: count: 1 path: test/classes/Plugins/Transformations/TransformationPluginsTest.php + - + message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertSame\\(\\) with 'subGroupHeader123' and PhpMyAdmin\\\\Properties\\\\PropertyItem\\|null will always evaluate to false\\.$#" + count: 1 + path: test/classes/Properties/Options/Groups/OptionsPropertySubgroupTest.php + - message: "#^Parameter \\#1 \\$subgroupHeader of method PhpMyAdmin\\\\Properties\\\\Options\\\\Groups\\\\OptionsPropertySubgroup\\:\\:setSubgroupHeader\\(\\) expects PhpMyAdmin\\\\Properties\\\\PropertyItem, string given\\.$#" count: 1 @@ -10925,11 +10955,31 @@ parameters: count: 1 path: test/classes/Stubs/ResponseRenderer.php + - + message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertFalse\\(\\) with true will always evaluate to false\\.$#" + count: 1 + path: test/classes/TableTest.php + + - + message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertSame\\(\\) with '5' and int will always evaluate to false\\.$#" + count: 1 + path: test/classes/TableTest.php + + - + message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertSame\\(\\) with array\\ and array\\{'aNonValidExampleToR…'\\} will always evaluate to false\\.$#" + count: 1 + path: test/classes/TableTest.php + - message: "#^Method PhpMyAdmin\\\\Tests\\\\TableTest\\:\\:dataValidateName\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 path: test/classes/TableTest.php + - + message: "#^Offset 'col_order' on array in isset\\(\\) always exists and is not nullable\\.$#" + count: 1 + path: test/classes/TableTest.php + - message: "#^Method PhpMyAdmin\\\\Tests\\\\TemplateTest\\:\\:providerTestDynamicRender\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 @@ -11231,12 +11281,12 @@ parameters: path: test/classes/Utils/HttpRequestTest.php - - message: "#^Parameter \\#1 \\$needle of method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringContainsString\\(\\) expects string, mixed given\\.$#" + message: "#^Parameter \\#1 \\$needle of static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringContainsString\\(\\) expects string, mixed given\\.$#" count: 1 path: test/classes/Utils/HttpRequestTest.php - - message: "#^Parameter \\#2 \\$haystack of method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringContainsString\\(\\) expects string, mixed given\\.$#" + message: "#^Parameter \\#2 \\$haystack of static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertStringContainsString\\(\\) expects string, mixed given\\.$#" count: 1 path: test/classes/Utils/HttpRequestTest.php diff --git a/psalm-baseline.xml b/psalm-baseline.xml index fa4e5af576..8860e84b2a 100644 --- a/psalm-baseline.xml +++ b/psalm-baseline.xml @@ -14723,8 +14723,7 @@ $filesFound $filesInfos - - $context + $context $context $filesFound @@ -14740,6 +14739,9 @@ array + + assertSame + assertFalse assertTrue @@ -14777,6 +14779,11 @@ $second + + + assertSame + + $_forms['pma_testform'] @@ -14841,7 +14848,8 @@ assertSame assertSame - + + assertSame assertSame assertSame assertSame @@ -15042,6 +15050,11 @@ expects + + + assertSame + + method @@ -15102,6 +15115,10 @@ $page + + assertSame + assertSame + @@ -15181,11 +15198,6 @@ expects - - - $result - - $_POST[$key] @@ -15507,17 +15519,10 @@ - + $dataSet $dataSet $queryString - $queryString - $queryString - $queryString - $queryString - $queryString - $queryString - $queryString @@ -15529,9 +15534,6 @@ - - $result - array @@ -15617,7 +15619,7 @@ $_SESSION['tmpval']['relational_display'] $_SESSION['tmpval']['relational_display'] - + $actual $actual $result @@ -15639,17 +15641,13 @@ $result $result $result - $result - $result - $result - $result - $result - $result - $result array + + assertSame + @@ -15815,9 +15813,6 @@ $result1['html'] - - $result - assertIsArray assertIsArray @@ -15838,6 +15833,11 @@ assertNotFalse + + + assertSame + + $arr->getPDFData() @@ -15863,6 +15863,9 @@ assertIsString + + assertSame + @@ -15878,14 +15881,24 @@ array + + assertSame + assertSame + assertSame + + + assertSame + - - - $result - $result - + + + assertSame + + + assertSame + $property $property @@ -15895,6 +15908,20 @@ $property $property + + assertFalse + assertSame + + + assertFalse + assertSame + assertSame + assertSame + assertSame + assertSame + assertSame + assertSame + @@ -15954,6 +15981,9 @@ $property $property + + assertSame + @@ -15981,6 +16011,9 @@ $GLOBALS['plugin_param']['single_table'] $GLOBALS['plugin_param']['single_table'] + + assertSame + @@ -16000,7 +16033,7 @@ $properties[1]->getProperties() $result - + $leaf $leaf $leaf @@ -16020,8 +16053,6 @@ $property $result $result - $result - $result getProperties @@ -16093,12 +16124,14 @@ - + $import_notice $sql_query + $sql_query - + assertFalse + assertSame @@ -16195,21 +16228,16 @@ - + $export $extra_data['new_privileges'] $extra_data['new_user_string'] $extra_data['new_user_string'] - $real_sql_query - $sql_query $title $this->serverPrivileges->extractPrivInfo(null, true) - - $returned_userGroup - getMessage getMessage @@ -16231,6 +16259,9 @@ will will + + assertNull + expects expects @@ -16262,8 +16293,7 @@ - - $result + $result @@ -16291,9 +16321,6 @@ - - $actual - array @@ -16383,14 +16410,16 @@ + + assertSame + $GLOBALS['sql_drop_table'] $_POST['old_index']['Key_name'] - + $is_define_property $sql - $sql array diff --git a/test/classes/AbstractTestCase.php b/test/classes/AbstractTestCase.php index ef7047b3b7..e273025dcf 100644 --- a/test/classes/AbstractTestCase.php +++ b/test/classes/AbstractTestCase.php @@ -104,23 +104,19 @@ abstract class AbstractTestCase extends TestCase protected function assertAllQueriesConsumed(): void { $unUsedQueries = $this->dummyDbi->getUnUsedQueries(); - $this->assertSame([], $unUsedQueries, 'Some queries where not used !'); + self::assertSame([], $unUsedQueries, 'Some queries where not used !'); } protected function assertAllSelectsConsumed(): void { $unUsedSelects = $this->dummyDbi->getUnUsedDatabaseSelects(); - $this->assertSame( - [], - $unUsedSelects, - 'Some database selects where not used !' - ); + self::assertSame([], $unUsedSelects, 'Some database selects where not used !'); } protected function assertAllErrorCodesConsumed(): void { if ($this->dummyDbi->hasUnUsedErrors() === false) { - $this->assertTrue(true);// increment the assertion count + self::assertTrue(true);// increment the assertion count return; } @@ -205,7 +201,7 @@ abstract class AbstractTestCase extends TestCase /** @var ResponseRenderer $response */ $response = $containerBuilder->get(ResponseRenderer::class); - $this->assertFalse($response->hasSuccessState(), 'expected the request to fail'); + self::assertFalse($response->hasSuccessState(), 'expected the request to fail'); } protected function assertResponseWasSuccessfull(): void @@ -214,7 +210,7 @@ abstract class AbstractTestCase extends TestCase /** @var ResponseRenderer $response */ $response = $containerBuilder->get(ResponseRenderer::class); - $this->assertTrue($response->hasSuccessState(), 'expected the request not to fail'); + self::assertTrue($response->hasSuccessState(), 'expected the request not to fail'); } protected function setGlobalDbi(): void diff --git a/test/classes/AdvisorTest.php b/test/classes/AdvisorTest.php index 35b3171bc0..2947e341dc 100644 --- a/test/classes/AdvisorTest.php +++ b/test/classes/AdvisorTest.php @@ -30,7 +30,7 @@ class AdvisorTest extends AbstractTestCase public function testAdvisorBytime(float $time, string $expected): void { $result = Advisor::byTime($time, 2); - $this->assertEquals($expected, $result); + self::assertSame($expected, $result); } public static function advisorTimes(): array @@ -73,21 +73,21 @@ class AdvisorTest extends AbstractTestCase parent::setLanguage(); $advisor = new Advisor($GLOBALS['dbi'], new ExpressionLanguage()); $parseResult = include ROOT_PATH . 'libraries/advisory_rules_generic.php'; - $this->assertIsArray($parseResult); - $this->assertArrayHasKey(0, $parseResult); - $this->assertIsArray($parseResult[0]); + self::assertIsArray($parseResult); + self::assertArrayHasKey(0, $parseResult); + self::assertIsArray($parseResult[0]); $advisor->setVariable('value', 0); $advisor->addRule('fired', $rule); $runResult = $advisor->getRunResult(); if (isset($runResult['errors']) || $error !== null) { - $this->assertEquals([$error], $runResult['errors']); + self::assertSame([$error], $runResult['errors']); } if (! isset($runResult['fired']) && $expected == []) { return; } - $this->assertEquals([$expected], $runResult['fired']); + self::assertEquals([$expected], $runResult['fired']); } public static function rulesProvider(): array diff --git a/test/classes/BookmarkTest.php b/test/classes/BookmarkTest.php index 588c77c956..4cb3291b2f 100644 --- a/test/classes/BookmarkTest.php +++ b/test/classes/BookmarkTest.php @@ -46,7 +46,7 @@ class BookmarkTest extends AbstractTestCase $GLOBALS['cfg']['Server']['user'], 'sakila' ); - $this->assertContainsOnlyInstancesOf(Bookmark::class, $actual); + self::assertContainsOnlyInstancesOf(Bookmark::class, $actual); $this->assertAllSelectsConsumed(); } @@ -56,14 +56,12 @@ class BookmarkTest extends AbstractTestCase public function testGet(): void { $this->dummyDbi->addSelectDb('phpmyadmin'); - $this->assertNull( - Bookmark::get( - $GLOBALS['dbi'], - $GLOBALS['cfg']['Server']['user'], - 'phpmyadmin', - '1' - ) - ); + self::assertNull(Bookmark::get( + $GLOBALS['dbi'], + $GLOBALS['cfg']['Server']['user'], + 'phpmyadmin', + '1' + )); $this->assertAllSelectsConsumed(); } @@ -80,9 +78,9 @@ class BookmarkTest extends AbstractTestCase ]; $bookmark = Bookmark::createBookmark($GLOBALS['dbi'], $bookmarkData); - $this->assertNotFalse($bookmark); + self::assertNotFalse($bookmark); $this->dummyDbi->addSelectDb('phpmyadmin'); - $this->assertFalse($bookmark->save()); + self::assertFalse($bookmark->save()); $this->assertAllSelectsConsumed(); } } diff --git a/test/classes/BrowseForeignersTest.php b/test/classes/BrowseForeignersTest.php index e60f7352ae..c5c30624b9 100644 --- a/test/classes/BrowseForeignersTest.php +++ b/test/classes/BrowseForeignersTest.php @@ -34,34 +34,20 @@ class BrowseForeignersTest extends AbstractTestCase */ public function testGetForeignLimit(): void { - $this->assertNull( - $this->browseForeigners->getForeignLimit('Show all') - ); + self::assertNull($this->browseForeigners->getForeignLimit('Show all')); - $this->assertEquals( - 'LIMIT 0, 25 ', - $this->browseForeigners->getForeignLimit(null) - ); + self::assertSame('LIMIT 0, 25 ', $this->browseForeigners->getForeignLimit(null)); $_POST['pos'] = 10; - $this->assertEquals( - 'LIMIT 10, 25 ', - $this->browseForeigners->getForeignLimit(null) - ); + self::assertSame('LIMIT 10, 25 ', $this->browseForeigners->getForeignLimit(null)); $GLOBALS['cfg']['MaxRows'] = 50; $browseForeigners = new BrowseForeigners(new Template()); - $this->assertEquals( - 'LIMIT 10, 50 ', - $browseForeigners->getForeignLimit(null) - ); + self::assertSame('LIMIT 10, 50 ', $browseForeigners->getForeignLimit(null)); - $this->assertEquals( - 'LIMIT 10, 50 ', - $browseForeigners->getForeignLimit('xyz') - ); + self::assertSame('LIMIT 10, 50 ', $browseForeigners->getForeignLimit('xyz')); } /** @@ -69,30 +55,24 @@ class BrowseForeignersTest extends AbstractTestCase */ public function testGetHtmlForGotoPage(): void { - $this->assertEquals( - '', - $this->callFunction( - $this->browseForeigners, - BrowseForeigners::class, - 'getHtmlForGotoPage', - [null] - ) - ); + self::assertSame('', $this->callFunction( + $this->browseForeigners, + BrowseForeigners::class, + 'getHtmlForGotoPage', + [null] + )); $_POST['pos'] = 15; $foreignData = []; $foreignData['disp_row'] = []; $foreignData['the_total'] = 5; - $this->assertEquals( - '', - $this->callFunction( - $this->browseForeigners, - BrowseForeigners::class, - 'getHtmlForGotoPage', - [$foreignData] - ) - ); + self::assertSame('', $this->callFunction( + $this->browseForeigners, + BrowseForeigners::class, + 'getHtmlForGotoPage', + [$foreignData] + )); $foreignData['the_total'] = 30; $result = $this->callFunction( @@ -102,15 +82,15 @@ class BrowseForeignersTest extends AbstractTestCase [$foreignData] ); - $this->assertStringStartsWith('Page number:', $result); + self::assertStringStartsWith('Page number:', $result); - $this->assertStringEndsWith('', $result); + self::assertStringEndsWith('', $result); - $this->assertStringContainsString('', $result); + self::assertStringContainsString('', $result); - $this->assertStringContainsString('', $result); + self::assertStringContainsString('', $result); - $this->assertStringContainsString('', $result); + self::assertStringContainsString('', $result); - $this->assertStringContainsString('
', $result); - $this->assertStringContainsString('