From 84caeb5a8a8ac5baf009a053aa382be4eb04dfab Mon Sep 17 00:00:00 2001
From: xmujay <xmujay@gmail.com>
Date: Sat, 6 Jul 2013 10:39:39 +0800
Subject: [PATCH 1/4] Unit test case for refactored functions:
 PMA_server_engines

---
 test/libraries/PMA_server_engines_test.php | 171 +++++++++++++++++++++
 1 file changed, 171 insertions(+)
 create mode 100644 test/libraries/PMA_server_engines_test.php

diff --git a/test/libraries/PMA_server_engines_test.php b/test/libraries/PMA_server_engines_test.php
new file mode 100644
index 0000000000..f02ad42de7
--- /dev/null
+++ b/test/libraries/PMA_server_engines_test.php
@@ -0,0 +1,171 @@
+<?php
+/* vim: set expandtab sw=4 ts=4 sts=4: */
+/**
+ * tests for server_engines.lib.php
+ *
+ * @package PhpMyAdmin-test
+ */
+
+/*
+ * Include to test.
+ */
+require_once 'libraries/Util.class.php';
+require_once 'libraries/php-gettext/gettext.inc';
+require_once 'libraries/url_generating.lib.php';
+require_once 'libraries/server_engines.lib.php';
+require_once 'libraries/Theme.class.php';
+require_once 'libraries/database_interface.inc.php';
+require_once 'libraries/Message.class.php';
+require_once 'libraries/sanitizing.lib.php';
+require_once 'libraries/sqlparser.lib.php';
+require_once 'libraries/js_escape.lib.php';
+require_once 'libraries/StorageEngine.class.php';
+
+class PMA_ServerEngines_Test extends PHPUnit_Framework_TestCase
+{
+    /**
+     * Prepares environment for the test.
+     *
+     * @return void
+     */
+    public function setUp()
+    {
+        //$_REQUEST
+        $_REQUEST['log'] = "index1";
+        $_REQUEST['pos'] = 3;
+        
+        //$GLOBALS
+        $GLOBALS['cfg']['MaxRows'] = 10;
+        $GLOBALS['cfg']['ServerDefault'] = "server";
+        $GLOBALS['cfg']['RememberSorting'] = true;
+        $GLOBALS['cfg']['SQP'] = array();
+        $GLOBALS['cfg']['MaxCharactersInDisplayedSQL'] = 1000;
+        $GLOBALS['cfg']['ShowSQL'] = true;
+        $GLOBALS['cfg']['SQP']['fmtType'] = 'none';
+        $GLOBALS['cfg']['TableNavigationLinksMode'] = 'icons';
+        $GLOBALS['cfg']['LimitChars'] = 100;
+        $GLOBALS['cfg']['DBG']['sql'] = false;
+        $GLOBALS['cfg']['MySQLManualType'] = 'viewable';
+        
+        $GLOBALS['table'] = "table";
+        $GLOBALS['pmaThemeImage'] = 'image';
+        
+        //$_SESSION
+        $_SESSION['PMA_Theme'] = PMA_Theme::load('./themes/pmahomme');
+        $_SESSION['PMA_Theme'] = new PMA_Theme();     
+    }
+
+    /**
+     * Test for PMA_getHtmlForServerEngines for all engines
+     *
+     * @return void
+     */
+    public function testPMA_getPluginAndModuleInfo()
+    {   
+        //Mock DBI
+        $dbi = $this->getMockBuilder('PMA_DatabaseInterface')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $GLOBALS['dbi'] = $dbi;
+        
+        //expects return value
+        $engines = array(
+        	"FEDERATED" => array(
+        	     "Engine" => "FEDERATED",
+        	     "Support" => "NO",
+        	     "Comment" => "Federated MySQL storage engine",
+        	     "Transactions" => NULL,
+        	     "Savepoints" => NULL,
+             ),
+        	"MRG_MYISAM" => array(
+        	     "Engine" => "MRG_MYISAM",
+        	     "Support" => "YES",
+        	     "Comment" => "Collection of identical MyISAM tables",
+        	     "Transactions" => "NO",
+        	     "Savepoints" => "NO",
+             )
+        );
+        
+        //expects functions
+        $dbi->expects($this->once())->method('fetchResult')
+        ->will($this->returnValue($engines));
+		
+        //test PMA_getHtmlForAllServerEngines
+        $html = PMA_getHtmlForServerEngines();
+
+        //validate 1: Item header
+        $this->assertContains(
+            '<th>Storage Engine</th>',
+            $html
+        );
+        $this->assertContains(
+            '<th>Description</th>',
+            $html
+        );
+        //validate 2: FEDERATED
+        $this->assertContains(
+            '<td>Federated MySQL storage engine</td>',
+            $html
+        );
+        $this->assertContains(
+            'FEDERATED',
+            $html
+        );
+        $this->assertContains(
+            'href="server_engines.php?engine=FEDERATED',
+            $html
+        );
+        
+        //validate 3: MRG_MYISAM
+        $this->assertContains(
+            '<td>Collection of identical MyISAM tables</td>',
+            $html
+        );
+        $this->assertContains(
+            'MRG_MYISAM',
+            $html
+        );
+        $this->assertContains(
+            'href="server_engines.php?engine=MRG_MYISAM',
+            $html
+        );
+    }
+
+    /**
+     * Test for PMA_getHtmlForServerEngines for specific engines "FEDERATED"
+     *
+     * @return void
+     */
+    public function testPMA_getPluginAndModuleInfo_Specific()
+    {   
+    	$_REQUEST['engine'] = "FEDERATED";
+        //Mock DBI
+        $dbi = $this->getMockBuilder('PMA_DatabaseInterface')
+            ->disableOriginalConstructor()
+            ->getMock();
+
+        $GLOBALS['dbi'] = $dbi;
+        		
+        //test PMA_getHtmlForAllServerEngines for specific engines "FEDERATED"
+        $html = PMA_getHtmlForServerEngines();
+
+        //validate 1: Engine header
+        $this->assertContains(
+            'FEDERATED',
+            $html
+        );
+        $this->assertContains(
+            'Federated MySQL storage engine',
+            $html
+        );
+        $this->assertContains(
+            'This MySQL server does not support the FEDERATED storage engine.',
+            $html
+        );
+        $this->assertContains(
+            'There is no detailed status information available for this storage engine',
+            $html
+        );
+    }
+}

From fbb84c49d5f7394fafe5955bf66804beaa9dcd00 Mon Sep 17 00:00:00 2001
From: xmujay <xmujay@gmail.com>
Date: Sat, 6 Jul 2013 11:18:58 +0800
Subject: [PATCH 2/4] use mock data for assertion

---
 test/libraries/PMA_server_engines_test.php | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/test/libraries/PMA_server_engines_test.php b/test/libraries/PMA_server_engines_test.php
index f02ad42de7..8bc7a634d1 100644
--- a/test/libraries/PMA_server_engines_test.php
+++ b/test/libraries/PMA_server_engines_test.php
@@ -9,12 +9,17 @@
 /*
  * Include to test.
  */
+
+if (! defined('PMA_DRIZZLE')) {
+	define('PMA_DRIZZLE', 0);
+}
+
 require_once 'libraries/Util.class.php';
 require_once 'libraries/php-gettext/gettext.inc';
 require_once 'libraries/url_generating.lib.php';
 require_once 'libraries/server_engines.lib.php';
 require_once 'libraries/Theme.class.php';
-require_once 'libraries/database_interface.inc.php';
+require_once 'libraries/DatabaseInterface.class.php';
 require_once 'libraries/Message.class.php';
 require_once 'libraries/sanitizing.lib.php';
 require_once 'libraries/sqlparser.lib.php';

From a90ae2550fc6f1b82e11765109012d50a8fb6ae6 Mon Sep 17 00:00:00 2001
From: xmujay <xmujay@gmail.com>
Date: Sat, 6 Jul 2013 11:45:38 +0800
Subject: [PATCH 3/4] add FEDERATED to DBI dummy data

---
 libraries/dbi/DBIDummy.class.php           |  5 +++
 test/classes/PMA_StorageEngine_test.php    | 17 ++++----
 test/libraries/PMA_server_engines_test.php | 50 ++++------------------
 3 files changed, 23 insertions(+), 49 deletions(-)

diff --git a/libraries/dbi/DBIDummy.class.php b/libraries/dbi/DBIDummy.class.php
index fb252c7a6e..1361629e23 100644
--- a/libraries/dbi/DBIDummy.class.php
+++ b/libraries/dbi/DBIDummy.class.php
@@ -46,6 +46,11 @@ $GLOBALS['dummy_queries'] = array(
                 'Support' => 'NO',
                 'Comment' => 'dummy2 comment'
             ),
+            array(
+                'Engine' => 'FEDERATED',
+                'Support' => 'NO',
+                'Comment' => 'Federated MySQL storage engine'
+            ),
         )
     ),
     array(
diff --git a/test/classes/PMA_StorageEngine_test.php b/test/classes/PMA_StorageEngine_test.php
index 58b9fd77fd..b245735a29 100644
--- a/test/classes/PMA_StorageEngine_test.php
+++ b/test/classes/PMA_StorageEngine_test.php
@@ -73,6 +73,11 @@ class PMA_StorageEngineTest extends PHPUnit_Framework_TestCase
                     'Support' => 'NO',
                     'Comment' => 'dummy2 comment',
                 ),
+                'FEDERATED' => array(
+                    'Engine' => 'FEDERATED',
+                    'Support' => 'NO',
+                    'Comment' => 'Federated MySQL storage engine'
+                ),
             ),
             $this->object->getStorageEngines()
         );
@@ -87,15 +92,11 @@ class PMA_StorageEngineTest extends PHPUnit_Framework_TestCase
      */
     public function testGetHtmlSelect()
     {
+    	$html = $this->object->getHtmlSelect();
 
-        $this->assertEquals(
-            '<select name="engine">
-    <option value="dummy" title="dummy comment">
-        dummy
-    </option>
-</select>
-',
-            $this->object->getHtmlSelect()
+        $this->assertContains(
+        	'<option value="dummy" title="dummy comment">',
+            $html
         );
     }
 
diff --git a/test/libraries/PMA_server_engines_test.php b/test/libraries/PMA_server_engines_test.php
index 8bc7a634d1..0b3a8109e3 100644
--- a/test/libraries/PMA_server_engines_test.php
+++ b/test/libraries/PMA_server_engines_test.php
@@ -9,17 +9,13 @@
 /*
  * Include to test.
  */
-
-if (! defined('PMA_DRIZZLE')) {
-	define('PMA_DRIZZLE', 0);
-}
-
 require_once 'libraries/Util.class.php';
 require_once 'libraries/php-gettext/gettext.inc';
 require_once 'libraries/url_generating.lib.php';
 require_once 'libraries/server_engines.lib.php';
 require_once 'libraries/Theme.class.php';
-require_once 'libraries/DatabaseInterface.class.php';
+require_once 'libraries/Tracker.class.php';
+require_once 'libraries/database_interface.inc.php';
 require_once 'libraries/Message.class.php';
 require_once 'libraries/sanitizing.lib.php';
 require_once 'libraries/sqlparser.lib.php';
@@ -66,36 +62,7 @@ class PMA_ServerEngines_Test extends PHPUnit_Framework_TestCase
      * @return void
      */
     public function testPMA_getPluginAndModuleInfo()
-    {   
-        //Mock DBI
-        $dbi = $this->getMockBuilder('PMA_DatabaseInterface')
-            ->disableOriginalConstructor()
-            ->getMock();
-
-        $GLOBALS['dbi'] = $dbi;
-        
-        //expects return value
-        $engines = array(
-        	"FEDERATED" => array(
-        	     "Engine" => "FEDERATED",
-        	     "Support" => "NO",
-        	     "Comment" => "Federated MySQL storage engine",
-        	     "Transactions" => NULL,
-        	     "Savepoints" => NULL,
-             ),
-        	"MRG_MYISAM" => array(
-        	     "Engine" => "MRG_MYISAM",
-        	     "Support" => "YES",
-        	     "Comment" => "Collection of identical MyISAM tables",
-        	     "Transactions" => "NO",
-        	     "Savepoints" => "NO",
-             )
-        );
-        
-        //expects functions
-        $dbi->expects($this->once())->method('fetchResult')
-        ->will($this->returnValue($engines));
-		
+    {	
         //test PMA_getHtmlForAllServerEngines
         $html = PMA_getHtmlForServerEngines();
 
@@ -108,6 +75,7 @@ class PMA_ServerEngines_Test extends PHPUnit_Framework_TestCase
             '<th>Description</th>',
             $html
         );
+        
         //validate 2: FEDERATED
         $this->assertContains(
             '<td>Federated MySQL storage engine</td>',
@@ -118,21 +86,21 @@ class PMA_ServerEngines_Test extends PHPUnit_Framework_TestCase
             $html
         );
         $this->assertContains(
-            'href="server_engines.php?engine=FEDERATED',
+            'server_engines.php?engine=FEDERATED',
             $html
         );
         
-        //validate 3: MRG_MYISAM
+        //validate 3: dummy
         $this->assertContains(
-            '<td>Collection of identical MyISAM tables</td>',
+            '<td>dummy comment</td>',
             $html
         );
         $this->assertContains(
-            'MRG_MYISAM',
+            'dummy',
             $html
         );
         $this->assertContains(
-            'href="server_engines.php?engine=MRG_MYISAM',
+            'server_engines.php?engine=dummy',
             $html
         );
     }

From d6be232ba30438afaa7c99774f412fab969250cd Mon Sep 17 00:00:00 2001
From: xmujay <xmujay@gmail.com>
Date: Sat, 6 Jul 2013 23:39:21 +0800
Subject: [PATCH 4/4] fix the code style for UT files

---
 test/libraries/PMA_server_binlog_test.php     | 28 +++++++++--------
 test/libraries/PMA_server_collations_test.php | 22 +++++++-------
 test/libraries/PMA_server_common_test.php     | 30 ++++++++++---------
 test/libraries/PMA_server_engines_test.php    | 12 ++++----
 test/libraries/PMA_server_plugins_test.php    |  2 +-
 5 files changed, 50 insertions(+), 44 deletions(-)

diff --git a/test/libraries/PMA_server_binlog_test.php b/test/libraries/PMA_server_binlog_test.php
index 3660a27fb8..478fef3bbd 100644
--- a/test/libraries/PMA_server_binlog_test.php
+++ b/test/libraries/PMA_server_binlog_test.php
@@ -58,7 +58,7 @@ class PMA_ServerBinlog_Test extends PHPUnit_Framework_TestCase
      *
      * @return void
      */
-    public function testPMA_getLogSelector()
+    public function testPMAGetLogSelector()
     {
         $binary_log_file_names = array();
         $binary_log_file_names[] = array("Log_name"=>"index1", "File_size"=>100);
@@ -88,7 +88,7 @@ class PMA_ServerBinlog_Test extends PHPUnit_Framework_TestCase
      *
      * @return void
      */
-    public function testPMA_getLogInfo()
+    public function testPMAGetLogInfo()
     {
         $binary_log_file_names = array();
         $binary_log_file_names[] = array("Log_name"=>"index1", "File_size"=>100);
@@ -121,27 +121,27 @@ class PMA_ServerBinlog_Test extends PHPUnit_Framework_TestCase
             )
         );
         $value = array(
-        	'Info' => "index1_Info",
-        	'Log_name' => "index1_Log_name",
-        	'Pos' => "index1_Pos",
-        	'Event_type' => "index1_Event_type",
-        	'End_log_pos' => "index1_End_log_pos",
-        	'Server_id' => "index1_Server_id",
+                'Info' => "index1_Info",
+                'Log_name' => "index1_Log_name",
+                'Pos' => "index1_Pos",
+                'Event_type' => "index1_Event_type",
+                'End_log_pos' => "index1_End_log_pos",
+                'Server_id' => "index1_Server_id",
         );   
         $count = 3;
 
         //expects functions
         $dbi->expects($this->once())->method('query')
-        ->will($this->returnValue($result));
+            ->will($this->returnValue($result));
         
         $dbi->expects($this->once())->method('numRows')
-        ->will($this->returnValue($count));
+            ->will($this->returnValue($count));
         
         $dbi->expects($this->at(0))->method('fetchAssoc')
-        ->will($this->returnValue($value));
+            ->will($this->returnValue($value));
         
         $dbi->expects($this->at(1))->method('fetchAssoc')
-        ->will($this->returnValue(false));
+            ->will($this->returnValue(false));
 
         $GLOBALS['dbi'] = $dbi;
 
@@ -164,8 +164,10 @@ class PMA_ServerBinlog_Test extends PHPUnit_Framework_TestCase
             $html
         );
         //validate 4: PMA_getNavigationRow is right
+        $urlNavigation = 'server_binlog.php?log=log&amp;dontlimitchars=1&amp;'
+            . 'pos=3&amp;server=1&amp';
         $this->assertContains(
-            'server_binlog.php?log=log&amp;dontlimitchars=1&amp;pos=3&amp;server=1&amp',
+            $urlNavigation,
             $html
         );
         $this->assertContains(
diff --git a/test/libraries/PMA_server_collations_test.php b/test/libraries/PMA_server_collations_test.php
index d9b03377b6..aad4eccb39 100644
--- a/test/libraries/PMA_server_collations_test.php
+++ b/test/libraries/PMA_server_collations_test.php
@@ -17,8 +17,8 @@ $GLOBALS['url_query'] = "url_query";
 $GLOBALS['PMA_PHP_SELF'] = PMA_getenv('PHP_SELF');
 $GLOBALS['lang'] = "en";
 $GLOBALS['available_languages']= array(
-		"en" => array("English", "US-ENGLISH"), 
-		"ch" => array("Chinese", "TW-Chinese")
+    "en" => array("English", "US-ENGLISH"), 
+    "ch" => array("Chinese", "TW-Chinese")
 );
 $GLOBALS['text_dir'] = "text_dir";
 $GLOBALS['cfg']['DBG']['sql'] = false;
@@ -73,32 +73,32 @@ class PMA_ServerCollations_Test extends PHPUnit_Framework_TestCase
      *
      * @return void
      */
-    public function testPMA_getHtmlForCharsets()
+    public function testPMAGetHtmlForCharsets()
     {
         $mysql_charsets = array("armscii8", "ascii", "big5", "binary");
         $mysql_collations = array(
-        	"armscii8" => array("armscii8"), 
+            "armscii8" => array("armscii8"), 
             "ascii" => array("ascii"), 
             "big5" => array("big5"), 
-        	"binary" => array("binary"),         		
+            "binary" => array("binary"),         		
         );
         $mysql_charsets_descriptions = array(
-        	"armscii8" => "PMA_armscii8_general_ci", 
+            "armscii8" => "PMA_armscii8_general_ci", 
             "ascii" => "PMA_ascii_general_ci", 
             "big5" => "PMA_big5_general_ci", 
-        	"binary" => "PMA_binary_general_ci",         		
+            "binary" => "PMA_binary_general_ci",         		
         );
         $mysql_default_collations = array(
-        	"armscii8" => "armscii8", 
+            "armscii8" => "armscii8", 
             "ascii" => "ascii", 
             "big5" => "big5", 
-        	"binary" => "binary",         		
+            "binary" => "binary",         		
         );
         $mysql_collations_available = array(
-        	"armscii8" => true, 
+            "armscii8" => true, 
             "ascii" => true, 
             "big5" => true, 
-        	"binary" => true,         		
+            "binary" => true,         		
         );
         
         //Mock DBI
diff --git a/test/libraries/PMA_server_common_test.php b/test/libraries/PMA_server_common_test.php
index c12e383120..ce2c20788a 100644
--- a/test/libraries/PMA_server_common_test.php
+++ b/test/libraries/PMA_server_common_test.php
@@ -32,39 +32,41 @@ class PMA_ServerCommon_Test extends PHPUnit_Framework_TestCase
      *
      * @return void
      */
-    public function testPMA_getSubPageHeader()
+    public function testPMAGetSubPageHeader()
     {
-    	//server_engines
-    	$html = PMA_getSubPageHeader("engines");
+        //server_engines
+        $html = PMA_getSubPageHeader("engines");
         $this->assertContains(
             '<img src="themes/dot.gif" title="" alt="" class="icon ic_b_engine" />',
-        	$html
+            $html
         ); 
         $this->assertContains(
             'Storage Engines',
-        	$html
+            $html
         );
         
-    	//server_databases
-    	$html = PMA_getSubPageHeader("databases");
+        //server_databases
+        $html = PMA_getSubPageHeader("databases");
         $this->assertContains(
             '<img src="themes/dot.gif" title="" alt="" class="icon ic_s_db" />',
-        	$html
+            $html
         ); 
         $this->assertContains(
             'Databases',
-        	$html
+            $html
         );
         
-    	//server_replication
-    	$html = PMA_getSubPageHeader("replication");
+        //server_replication
+        $html = PMA_getSubPageHeader("replication");
+        $replication_img = '<img src="themes/dot.gif" title="" ' 
+            . 'alt="" class="icon ic_s_replication" />';
         $this->assertContains(
-            '<img src="themes/dot.gif" title="" alt="" class="icon ic_s_replication" />',
-        	$html
+            $replication_img,
+            $html
         ); 
         $this->assertContains(
             'Replication',
-        	$html
+            $html
         );
     }
 
diff --git a/test/libraries/PMA_server_engines_test.php b/test/libraries/PMA_server_engines_test.php
index 0b3a8109e3..50702d585f 100644
--- a/test/libraries/PMA_server_engines_test.php
+++ b/test/libraries/PMA_server_engines_test.php
@@ -61,7 +61,7 @@ class PMA_ServerEngines_Test extends PHPUnit_Framework_TestCase
      *
      * @return void
      */
-    public function testPMA_getPluginAndModuleInfo()
+    public function testPMAGetPluginAndModuleInfo()
     {	
         //test PMA_getHtmlForAllServerEngines
         $html = PMA_getHtmlForServerEngines();
@@ -110,16 +110,16 @@ class PMA_ServerEngines_Test extends PHPUnit_Framework_TestCase
      *
      * @return void
      */
-    public function testPMA_getPluginAndModuleInfo_Specific()
+    public function testPMAGetPluginAndModuleInfoSpecific()
     {   
-    	$_REQUEST['engine'] = "FEDERATED";
+        $_REQUEST['engine'] = "FEDERATED";
         //Mock DBI
         $dbi = $this->getMockBuilder('PMA_DatabaseInterface')
             ->disableOriginalConstructor()
             ->getMock();
 
         $GLOBALS['dbi'] = $dbi;
-        		
+
         //test PMA_getHtmlForAllServerEngines for specific engines "FEDERATED"
         $html = PMA_getHtmlForServerEngines();
 
@@ -136,8 +136,10 @@ class PMA_ServerEngines_Test extends PHPUnit_Framework_TestCase
             'This MySQL server does not support the FEDERATED storage engine.',
             $html
         );
+        $enginer_info = 'There is no detailed status information ' 
+            . 'available for this storage engine';
         $this->assertContains(
-            'There is no detailed status information available for this storage engine',
+            $enginer_info,
             $html
         );
     }
diff --git a/test/libraries/PMA_server_plugins_test.php b/test/libraries/PMA_server_plugins_test.php
index 375edbe4d4..2a35513118 100644
--- a/test/libraries/PMA_server_plugins_test.php
+++ b/test/libraries/PMA_server_plugins_test.php
@@ -58,7 +58,7 @@ class PMA_ServerPlugins_Test extends PHPUnit_Framework_TestCase
      *
      * @return void
      */
-    public function testPMA_getPluginAndModuleInfo()
+    public function testPMAGetPluginAndModuleInfo()
     {   
         //Mock DBI
         $dbi = $this->getMockBuilder('PMA_DatabaseInterface')