From 44f7e93b36bd93bd471603a3effac8dc0ce2b397 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= <mauricio@fauth.dev>
Date: Fri, 28 Jul 2023 16:30:22 -0300
Subject: [PATCH] Remove the public/show_config_errors.php file
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

A better and safer way of showing the configuration errors should be
developed.

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
---
 libraries/classes/Config.php      |  4 +--
 libraries/classes/Sanitize.php    |  2 --
 phpstan-baseline.neon             |  5 ----
 psalm.xml                         |  1 -
 public/show_config_errors.php     | 44 -------------------------------
 scripts/check-release-excludes.sh |  2 --
 6 files changed, 1 insertion(+), 57 deletions(-)
 delete mode 100644 public/show_config_errors.php

diff --git a/libraries/classes/Config.php b/libraries/classes/Config.php
index 99d1792924..7ca2f39573 100644
--- a/libraries/classes/Config.php
+++ b/libraries/classes/Config.php
@@ -658,9 +658,7 @@ class Config
 
         $error = '[strong]' . __('Failed to read configuration file!') . '[/strong]'
             . '[br][br]'
-            . __('This usually means there is a syntax error in it, please check any errors shown below.')
-            . '[br][br]'
-            . '[conferr]';
+            . __('This usually means there is a syntax error in it.');
 
         throw new ConfigException(Sanitize::sanitizeMessage($error));
     }
diff --git a/libraries/classes/Sanitize.php b/libraries/classes/Sanitize.php
index d9eeda7d4c..982979c51a 100644
--- a/libraries/classes/Sanitize.php
+++ b/libraries/classes/Sanitize.php
@@ -191,8 +191,6 @@ class Sanitize
             '[/doc]' => '</a>',
             '[sup]' => '<sup>',
             '[/sup]' => '</sup>',
-            '[conferr]' => '<iframe src="show_config_errors.php"><a href='
-                . '"show_config_errors.php">show_config_errors.php</a></iframe>',
             // used in libraries/Util.php
             '[dochelpicon]' => Html\Generator::getImage('b_help', __('Documentation')),
         ];
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
index 7776cec5ba..bd8a9f58fd 100644
--- a/phpstan-baseline.neon
+++ b/phpstan-baseline.neon
@@ -27580,11 +27580,6 @@ parameters:
 			count: 1
 			path: public/setup/index.php
 
-		-
-			message: "#^Parameter \\#1 \\$filename of function is_readable expects string, mixed given\\.$#"
-			count: 1
-			path: public/show_config_errors.php
-
 		-
 			message: "#^Call to function in_array\\(\\) requires parameter \\#3 to be set\\.$#"
 			count: 2
diff --git a/psalm.xml b/psalm.xml
index 3ff6eb4737..837e65b3fb 100644
--- a/psalm.xml
+++ b/psalm.xml
@@ -18,7 +18,6 @@
         <directory name="test/classes"/>
         <directory name="test/selenium"/>
         <file name="public/index.php"/>
-        <file name="public/show_config_errors.php"/>
         <ignoreFiles>
             <directory name="vendor"/>
             <directory name="libraries/cache"/>
diff --git a/public/show_config_errors.php b/public/show_config_errors.php
deleted file mode 100644
index 601dd0672b..0000000000
--- a/public/show_config_errors.php
+++ /dev/null
@@ -1,44 +0,0 @@
-<?php
-/**
- * Simple wrapper just to enable error reporting and include config
- */
-
-declare(strict_types=1);
-
-if (! defined('ROOT_PATH')) {
-    // phpcs:disable PSR1.Files.SideEffects
-    define('ROOT_PATH', __DIR__ . DIRECTORY_SEPARATOR);
-    // phpcs:enable
-}
-
-// rfc2616 - Section 14.21
-header('Expires: ' . gmdate(DATE_RFC1123));
-// HTTP/1.1
-header('Cache-Control: no-store, no-cache, must-revalidate,  pre-check=0, post-check=0, max-age=0');
-
-header('Pragma: no-cache'); // HTTP/1.0
-// test case: exporting a database into a .gz file with Safari
-// would produce files not having the current time
-// (added this header for Safari but should not harm other browsers)
-header('Last-Modified: ' . gmdate(DATE_RFC1123));
-
-header('Content-Type: text/html; charset=utf-8');
-
-// phpcs:disable PSR1.Files.SideEffects
-define('PHPMYADMIN', true);
-// phpcs:enable
-
-require ROOT_PATH . 'libraries/constants.php';
-
-// issue #16256 - This only works with php 8.0+
-if (function_exists('error_reporting')) {
-    error_reporting(E_ALL);
-}
-
-/**
- * Read config file.
- */
-if (is_readable(CONFIG_FILE)) {
-    /** @psalm-suppress MissingFile */
-    include CONFIG_FILE;
-}
diff --git a/scripts/check-release-excludes.sh b/scripts/check-release-excludes.sh
index 1cbe43a064..0b49198775 100755
--- a/scripts/check-release-excludes.sh
+++ b/scripts/check-release-excludes.sh
@@ -202,8 +202,6 @@ validateExtension() {
         ;;
         config.sample.inc.php)
         ;;
-        public/show_config_errors.php)
-        ;;
         *)
             foundFileExt
         ;;