diff --git a/index.php b/index.php index 91196c12f5..c2a5a1d19c 100644 --- a/index.php +++ b/index.php @@ -156,7 +156,7 @@ if ($server > 0 || count($cfg['Servers']) > 1 . 'please do not change root, debian-sys-maint and pma users. ' . 'More information is available at %s.' ), - 'demo.phpmyadmin.net' + 'demo.phpmyadmin.net' ); echo '
'; echo ''; diff --git a/js/functions.js b/js/functions.js index 7fe97ccfd9..0017d2ea5c 100644 --- a/js/functions.js +++ b/js/functions.js @@ -4834,11 +4834,6 @@ function formatBytes(bytes, subdecimals, pointchar) { } AJAX.registerOnload('functions.js', function () { - /** - * Opens pma more themes link in themes browser, in new window instead of popup - * This way, we don't break HTML validity - */ - $("a._blank").prop("target", "_blank"); /** * Reveal the login form to users with JS enabled * and focus the appropriate input field diff --git a/libraries/Advisor.php b/libraries/Advisor.php index 8d5cadcd5d..20cf1dfab3 100644 --- a/libraries/Advisor.php +++ b/libraries/Advisor.php @@ -353,7 +353,7 @@ class Advisor */ private function replaceLinkURL($matches) { - return 'href="' . PMA_linkURL($matches[2]) . '" target="_blank"'; + return 'href="' . PMA_linkURL($matches[2]) . '" target="_blank" rel="noopener noreferrer"'; } /** diff --git a/libraries/Footer.php b/libraries/Footer.php index 59e54841c6..4d50d517ca 100644 --- a/libraries/Footer.php +++ b/libraries/Footer.php @@ -72,9 +72,9 @@ class Footer include './revision-info.php'; $message .= sprintf( __('Currently running Git revision %1$s from the %2$s branch.'), - '' + '' . $revision . '', - '' + '' . $branch . '' ); } else { @@ -193,7 +193,7 @@ class Footer $retval = ''; $retval .= ''; -$output .= ''; +$output .= ''; $output .= __('Get more themes!'); $output .= ''; $output .= '
';