From 48a6b710b46ae2e0186c2fc8eb06866c0c07dfdc Mon Sep 17 00:00:00 2001 From: William Desportes Date: Wed, 17 Feb 2021 19:11:20 +0100 Subject: [PATCH] Improve Tracker::getVersion failure case Signed-off-by: William Desportes --- libraries/classes/Tracker.php | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libraries/classes/Tracker.php b/libraries/classes/Tracker.php index 6adc61029e..42fa70108f 100644 --- a/libraries/classes/Tracker.php +++ b/libraries/classes/Tracker.php @@ -537,6 +537,7 @@ class Tracker */ public static function getVersion($dbname, $tablename, $statement = null) { + /** @var DatabaseInterface $dbi */ global $dbi; $relation = new Relation($dbi); @@ -549,7 +550,14 @@ class Tracker $sql_query .= " AND FIND_IN_SET('" . $statement . "',tracking) > 0"; } - $row = $dbi->fetchArray($relation->queryAsControlUser($sql_query, false)); + + $result = $relation->queryAsControlUser($sql_query, false); + + if ($result === false) { + return -1; + } + + $row = $dbi->fetchArray($result); return $row[0] ?? -1; }