From 4a67d88e1dc73f250b39434154afa633a8661bb1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= Date: Fri, 15 Dec 2023 00:48:34 -0300 Subject: [PATCH] Remove a db global in FavoriteTableController MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: MaurĂ­cio Meneghini Fauth --- .../Database/Structure/FavoriteTableController.php | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/Controllers/Database/Structure/FavoriteTableController.php b/src/Controllers/Database/Structure/FavoriteTableController.php index cb1d4d7660..6c5858b614 100644 --- a/src/Controllers/Database/Structure/FavoriteTableController.php +++ b/src/Controllers/Database/Structure/FavoriteTableController.php @@ -87,11 +87,7 @@ final class FavoriteTableController extends AbstractController $changes = true; /** @var string $favoriteTableName */ $favoriteTableName = $request->getParam('favorite_table', ''); - // TODO: Why is this $GLOBALS['db'] instead of $databaseName - $favoriteTable = new RecentFavoriteTable( - DatabaseName::from($GLOBALS['db']), - TableName::from($favoriteTableName), - ); + $favoriteTable = new RecentFavoriteTable($databaseName, TableName::from($favoriteTableName)); $alreadyFavorite = $favoriteInstance->contains($favoriteTable); if (isset($_REQUEST['remove_favorite'])) {