From 4bf427c2c065534526695f16f59af11414447457 Mon Sep 17 00:00:00 2001
From: William Desportes <williamdes@wdes.fr>
Date: Thu, 1 Apr 2021 01:34:08 +0200
Subject: [PATCH] Fix "Connection" label always shown on table create, should
 be hidden like the input

Signed-off-by: William Desportes <williamdes@wdes.fr>
---
 js/src/functions.js                                        | 3 +--
 templates/columns_definitions/column_definitions_form.twig | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/js/src/functions.js b/js/src/functions.js
index 7d0e798b70..82873e06c8 100644
--- a/js/src/functions.js
+++ b/js/src/functions.js
@@ -3341,8 +3341,7 @@ AJAX.registerOnload('functions.js', function () {
  */
 Functions.hideShowConnection = function ($engineSelector) {
     var $connection = $('.create_table_form input[name=connection]');
-    var index = $connection.parent('td').index();
-    var $labelTh = $connection.parents('tr').prev('tr').children('th').eq(index);
+    var $labelTh = $('.create_table_form #storage-engine-connection');
     if ($engineSelector.val() !== 'FEDERATED') {
         $connection
             .prop('disabled', true)
diff --git a/templates/columns_definitions/column_definitions_form.twig b/templates/columns_definitions/column_definitions_form.twig
index 480e167897..916a1ead42 100644
--- a/templates/columns_definitions/column_definitions_form.twig
+++ b/templates/columns_definitions/column_definitions_form.twig
@@ -78,7 +78,7 @@
                     {{ show_mysql_docu('Storage_engines') }}
                 </th>
                 <td width="25">&nbsp;</td>
-                <th>
+                <th id="storage-engine-connection">
                     {% trans 'Connection:' %}
                     {{ show_mysql_docu('federated-create-connection') }}
                 </th>