From 4c768d41c451e5d258df21fe35f305a0f753eca1 Mon Sep 17 00:00:00 2001
From: Marc Delisle <marc@infomarc.info>
Date: Fri, 27 Apr 2012 12:54:36 -0400
Subject: [PATCH] HTML attributes have to be enclosed with double-quotes This
 caused also a problem when the title contains a single-quote

---
 libraries/common.lib.php | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/libraries/common.lib.php b/libraries/common.lib.php
index 2619b00dc1..10b4dc5193 100644
--- a/libraries/common.lib.php
+++ b/libraries/common.lib.php
@@ -3435,17 +3435,17 @@ function PMA_getSupportedDatatypes($html = false, $selected = '')
                 foreach ($value as $subvalue) {
                     if ($subvalue == $selected) {
                         $retval .= sprintf(
-                            "<option selected='selected' title='%s'>%s</option>",
+                            '<option selected="selected" title="%s">%s</option>',
                             $GLOBALS['PMA_Types']->getTypeDescription($subvalue),
                             $subvalue
                         );
                     } else if ($subvalue === '-') {
-                        $retval .= "<option disabled='disabled'>";
+                        $retval .= '<option disabled="disabled">';
                         $retval .= $subvalue;
-                        $retval .= "</option>";
+                        $retval .= '</option>';
                     } else {
                         $retval .= sprintf(
-                            "<option title='%s'>%s</option>",
+                            '<option title="%s">%s</option>',
                             $GLOBALS['PMA_Types']->getTypeDescription($subvalue),
                             $subvalue
                         );
@@ -3455,13 +3455,13 @@ function PMA_getSupportedDatatypes($html = false, $selected = '')
             } else {
                 if ($selected == $value) {
                     $retval .= sprintf(
-                        "<option selected='selected' title='%s'>%s</option>",
+                        '<option selected="selected" title="%s">%s</option>',
                         $GLOBALS['PMA_Types']->getTypeDescription($value),
                         $value
                     );
                 } else {
                     $retval .= sprintf(
-                        "<option title='%s'>%s</option>",
+                        '<option title="%s">%s</option>',
                         $GLOBALS['PMA_Types']->getTypeDescription($value),
                         $value
                     );