From 4d79529fcd449617e3f76c2d4bc33931bdd1f916 Mon Sep 17 00:00:00 2001
From: Madhura Jayaratne <madhura.cj@gmail.com>
Date: Tue, 28 Apr 2015 14:53:26 +0530
Subject: [PATCH] Reduce duplication

Signed-off-by: Madhura Jayaratne <madhura.cj@gmail.com>
---
 libraries/server_privileges.lib.php | 60 +++++++++--------------------
 1 file changed, 18 insertions(+), 42 deletions(-)

diff --git a/libraries/server_privileges.lib.php b/libraries/server_privileges.lib.php
index 9e0bdc5505..1241898535 100644
--- a/libraries/server_privileges.lib.php
+++ b/libraries/server_privileges.lib.php
@@ -1086,53 +1086,29 @@ function PMA_getHtmlForNotAttachedPrivilegesToTableSpecificColumn($row)
            . ($current_grant_value == 'Y' ? 'checked="checked" ' : '')
            . 'title="';
 
-        $html_output .= (isset($GLOBALS[
-                    'strPrivDesc' . /*overload*/mb_substr(
-                        $tmp_current_grant,
-                        0,
-                        (/*overload*/mb_strlen($tmp_current_grant) - 5)
-                    )
-                ] )
-                ? $GLOBALS[
-                    'strPrivDesc' . /*overload*/mb_substr(
-                        $tmp_current_grant,
-                        0,
-                        (/*overload*/mb_strlen($tmp_current_grant) - 5)
-                    )
-                ]
-                : $GLOBALS[
-                    'strPrivDesc' . /*overload*/mb_substr(
-                        $tmp_current_grant,
-                        0,
-                        (/*overload*/mb_strlen($tmp_current_grant) - 5)
-                    ) . 'Tbl'
-                ]
+        $privGlobalName = 'strPrivDesc'
+            . /*overload*/mb_substr(
+                $tmp_current_grant,
+                0,
+                (/*overload*/mb_strlen($tmp_current_grant) - 5)
+            );
+        $html_output .= (isset($GLOBALS[$privGlobalName])
+                ? $GLOBALS[$privGlobalName]
+                : $GLOBALS[$privGlobalName . 'Tbl']
             )
             . '"/>' . "\n";
 
+        $privGlobalName1 = 'strPrivDesc'
+            . /*overload*/mb_substr(
+                $tmp_current_grant,
+                0,
+                - 5
+            );
         $html_output .= '<label for="checkbox_' . $current_grant
             . '"><code><dfn title="'
-            . (isset($GLOBALS[
-                    'strPrivDesc' . /*overload*/mb_substr(
-                        $tmp_current_grant,
-                        0,
-                        -5
-                    )
-                ])
-                ? $GLOBALS[
-                    'strPrivDesc' . /*overload*/mb_substr(
-                        $tmp_current_grant,
-                        0,
-                        -5
-                    )
-                ]
-                : $GLOBALS[
-                    'strPrivDesc' . /*overload*/mb_substr(
-                        $tmp_current_grant,
-                        0,
-                        -5
-                    ) . 'Tbl'
-                ]
+            . (isset($GLOBALS[$privGlobalName1])
+                ? $GLOBALS[$privGlobalName1]
+                : $GLOBALS[$privGlobalName1 . 'Tbl']
             )
             . '">'
             . /*overload*/mb_strtoupper(