From 70c70db1392e703346434e65d59110a6ba321367 Mon Sep 17 00:00:00 2001
From: Rouslan Placella <rouslan@placella.com>
Date: Tue, 5 Jul 2011 13:00:21 +0100
Subject: [PATCH 1/4] Fix for bug #3353856 - AJAX dialogs use wrong font-size

---
 ChangeLog                                         | 1 +
 js/db_routines.js                                 | 4 ++--
 js/functions.js                                   | 2 +-
 libraries/header_meta_style.inc.php               | 7 +++++++
 themes/original/jquery/jquery-ui-1.8.override.css | 7 +++++++
 themes/pmahomme/jquery/jquery-ui-1.8.override.css | 7 +++++++
 6 files changed, 25 insertions(+), 3 deletions(-)
 create mode 100644 themes/original/jquery/jquery-ui-1.8.override.css
 create mode 100644 themes/pmahomme/jquery/jquery-ui-1.8.override.css

diff --git a/ChangeLog b/ChangeLog
index ff4f0ae795..4ae25e9a61 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -32,6 +32,7 @@ phpMyAdmin - ChangeLog
 + Display direction (horizontal/vertical) no longer displayed by default
 + Shift/click support in database Structure
 + Show/hide column in table Browse
+- bug #3353856 [AJAX] AJAX dialogs use wrong font-size
 
 3.4.4.0 (not yet released)
 - bug #3323060 [parser] SQL parser breaks AJAX requests if query has unclosed quotes
diff --git a/js/db_routines.js b/js/db_routines.js
index 95254ca064..ceb09626dd 100644
--- a/js/db_routines.js
+++ b/js/db_routines.js
@@ -308,7 +308,7 @@ $(document).ready(function() {
                 /**
                  * Display the dialog to the user
                  */
-                $ajaxDialog = $('<div style="font-size: 0.9em;">'+data.message+'</div>').dialog({
+                $ajaxDialog = $('<div>'+data.message+'</div>').dialog({
                                 width: 700,  // TODO: make a better decision about the size
                                 height: 550, // of the dialog based on the size of the viewport
                                 buttons: button_options,
@@ -529,7 +529,7 @@ $(document).ready(function() {
                     /**
                      * Display the dialog to the user
                      */
-                    $ajaxDialog = $('<div style="font-size: 0.9em;">'+data.message+'</div>').dialog({
+                    $ajaxDialog = $('<div>'+data.message+'</div>').dialog({
                                     width: 650,  // TODO: make a better decision about the size
                                                  // of the dialog based on the size of the viewport
                                     buttons: button_options,
diff --git a/js/functions.js b/js/functions.js
index e25ec982ea..9cdb44e751 100644
--- a/js/functions.js
+++ b/js/functions.js
@@ -2445,7 +2445,7 @@ $(document).ready(function() {
                 /**
                  * Display the dialog to the user
                  */
-                var $ajaxDialog = $('<div style="font-size: 0.9em;">'+data.message+'</div>').dialog({
+                var $ajaxDialog = $('<div>'+data.message+'</div>').dialog({
                                       width: 500,
                                       buttons: button_options,
                                       title: data.title
diff --git a/libraries/header_meta_style.inc.php b/libraries/header_meta_style.inc.php
index 5e5c533da4..e78b653081 100644
--- a/libraries/header_meta_style.inc.php
+++ b/libraries/header_meta_style.inc.php
@@ -48,4 +48,11 @@ if ($GLOBALS['text_dir'] == 'ltr') {
     <link rel="stylesheet" type="text/css" href="<?php echo defined('PMA_PATH_TO_BASEDIR') ? PMA_PATH_TO_BASEDIR : ''; ?>phpmyadmin.css.php<?php echo PMA_generate_common_url(array('server' => $GLOBALS['server'])); ?>&amp;js_frame=<?php echo isset($print_view) ? 'print' : 'right'; ?>&amp;nocache=<?php echo $GLOBALS['PMA_Config']->getThemeUniqueValue(); ?>" />
     <link rel="stylesheet" type="text/css" href="<?php echo defined('PMA_PATH_TO_BASEDIR') ? PMA_PATH_TO_BASEDIR : ''; ?>print.css" media="print" />
     <link rel="stylesheet" type="text/css" href="<?php echo $GLOBALS['pmaThemePath']; ?>/jquery/jquery-ui-1.8.custom.css" />
+<?php
+    if (is_readable($GLOBALS['pmaThemePath'] . '/jquery/jquery-ui-1.8.override.css')) {
+?>
+    <link rel="stylesheet" type="text/css" href="<?php echo $GLOBALS['pmaThemePath']; ?>/jquery/jquery-ui-1.8.override.css" />
+<?php
+    }
+?>
     <meta name="robots" content="noindex,nofollow" />
diff --git a/themes/original/jquery/jquery-ui-1.8.override.css b/themes/original/jquery/jquery-ui-1.8.override.css
new file mode 100644
index 0000000000..4aee6fbb1e
--- /dev/null
+++ b/themes/original/jquery/jquery-ui-1.8.override.css
@@ -0,0 +1,7 @@
+/**
+ * Use this file to override styles set by jquery-ui-1.8.custom.css
+ */
+
+/* Component containers
+----------------------------------*/
+.ui-widget { font-size: 1em; }
diff --git a/themes/pmahomme/jquery/jquery-ui-1.8.override.css b/themes/pmahomme/jquery/jquery-ui-1.8.override.css
new file mode 100644
index 0000000000..4aee6fbb1e
--- /dev/null
+++ b/themes/pmahomme/jquery/jquery-ui-1.8.override.css
@@ -0,0 +1,7 @@
+/**
+ * Use this file to override styles set by jquery-ui-1.8.custom.css
+ */
+
+/* Component containers
+----------------------------------*/
+.ui-widget { font-size: 1em; }

From 82f83dac2f6b07bef76f6c3fb795ce7c0c417af8 Mon Sep 17 00:00:00 2001
From: Herman van Rink <rink@initfour.nl>
Date: Tue, 5 Jul 2011 14:46:13 +0200
Subject: [PATCH 2/4] Fixed XSS in unreleased RecentTable class

---
 libraries/RecentTable.class.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libraries/RecentTable.class.php b/libraries/RecentTable.class.php
index f844bbc90b..bfb60818fa 100644
--- a/libraries/RecentTable.class.php
+++ b/libraries/RecentTable.class.php
@@ -142,7 +142,7 @@ class PMA_RecentTable
         $html = '<option value="">(' . __('Recent tables') . ') ...</option>';
         if (count($this->tables)) {
             foreach ($this->tables as $table) {
-                $html .= '<option value="' . $table . '">' . $table . '</option>';
+                $html .= '<option value="' . htmlspecialchars($table) . '">' . htmlspecialchars($table) . '</option>';
             }
         } else {
             $html .= '<option value="">' . __('There are no recent tables') . '</option>';
@@ -158,7 +158,7 @@ class PMA_RecentTable
     public function getHtmlSelect()
     {
         $html  = '<input type="hidden" name="goto" id="LeftDefaultTabTable" value="' .
-                         $GLOBALS['cfg']['LeftDefaultTabTable'] . '" />';
+                         htmlspecialchars($GLOBALS['cfg']['LeftDefaultTabTable']) . '" />';
         $html .= '<select name="table" id="recentTable">';
         $html .= $this->getHtmlSelectOption();
         $html .= '</select>';

From c97ef9d53c554a4e5de6180247ca6d63709db77f Mon Sep 17 00:00:00 2001
From: Aris Feryanto <aris_feryanto@yahoo.com>
Date: Wed, 6 Jul 2011 09:54:38 +0800
Subject: [PATCH 3/4] Show/hide column: fix bug - column resizer border's
 height not updated after toggling column visibility

---
 js/makegrid.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/js/makegrid.js b/js/makegrid.js
index 8b1bd7cd0d..11bfa09f17 100644
--- a/js/makegrid.js
+++ b/js/makegrid.js
@@ -215,6 +215,7 @@
                     $cb.css('left', $this.position().left + $this.outerWidth(true))
                        .show();
                 }
+                $(this.cRsz).css('height', $(this.t).height());
             },
             
             /**

From 9e34ccf57cfc97c3cac6d7f9ceecd6e1cc89e10d Mon Sep 17 00:00:00 2001
From: Rouslan Placella <rouslan@placella.com>
Date: Wed, 6 Jul 2011 15:01:39 +0100
Subject: [PATCH 4/4] Fix for bug #3354356 - Timepicker does not work in AJAX
 dialogs

---
 ChangeLog                                         | 1 +
 themes/original/jquery/jquery-ui-1.8.override.css | 1 +
 themes/pmahomme/jquery/jquery-ui-1.8.override.css | 1 +
 3 files changed, 3 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index 4ae25e9a61..4df55e5fd7 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -33,6 +33,7 @@ phpMyAdmin - ChangeLog
 + Shift/click support in database Structure
 + Show/hide column in table Browse
 - bug #3353856 [AJAX] AJAX dialogs use wrong font-size
+- bug #3354356 [interface] Timepicker does not work in AJAX dialogs
 
 3.4.4.0 (not yet released)
 - bug #3323060 [parser] SQL parser breaks AJAX requests if query has unclosed quotes
diff --git a/themes/original/jquery/jquery-ui-1.8.override.css b/themes/original/jquery/jquery-ui-1.8.override.css
index 4aee6fbb1e..2835781529 100644
--- a/themes/original/jquery/jquery-ui-1.8.override.css
+++ b/themes/original/jquery/jquery-ui-1.8.override.css
@@ -5,3 +5,4 @@
 /* Component containers
 ----------------------------------*/
 .ui-widget { font-size: 1em; }
+#ui-timepicker-div { z-index: 1003; }
diff --git a/themes/pmahomme/jquery/jquery-ui-1.8.override.css b/themes/pmahomme/jquery/jquery-ui-1.8.override.css
index 4aee6fbb1e..2835781529 100644
--- a/themes/pmahomme/jquery/jquery-ui-1.8.override.css
+++ b/themes/pmahomme/jquery/jquery-ui-1.8.override.css
@@ -5,3 +5,4 @@
 /* Component containers
 ----------------------------------*/
 .ui-widget { font-size: 1em; }
+#ui-timepicker-div { z-index: 1003; }