Remove dead code

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
This commit is contained in:
Kamil Tekiela 2024-12-16 00:37:18 +00:00
parent 86aa9da2f2
commit 5285fa8360
7 changed files with 0 additions and 26 deletions

View File

@ -11892,12 +11892,6 @@ parameters:
count: 1
path: src/Plugins/Auth/AuthenticationHttp.php
-
message: '#^Property PhpMyAdmin\\Plugins\\AuthenticationPlugin\:\:\$user \(string\) does not accept mixed\.$#'
identifier: assign.propertyType
count: 1
path: src/Plugins/Auth/AuthenticationHttp.php
-
message: '''
#^Call to deprecated method getInstance\(\) of class PhpMyAdmin\\Config\:

View File

@ -1675,7 +1675,6 @@
<InvalidArrayOffset>
<code><![CDATA[$GLOBALS['language_stats']]]></code>
<code><![CDATA[$GLOBALS['language_stats']]]></code>
<code><![CDATA[$GLOBALS['show_query']]]></code>
</InvalidArrayOffset>
<MixedArgument>
<code><![CDATA[$this->config->get('ShowGitRevision') ?? true]]></code>
@ -1690,9 +1689,6 @@
<MixedArrayTypeCoercion>
<code><![CDATA[$config->settings['Servers'][Current::$server]]]></code>
</MixedArrayTypeCoercion>
<MixedAssignment>
<code><![CDATA[$GLOBALS['show_query']]]></code>
</MixedAssignment>
<PossiblyNullArgument>
<code><![CDATA[$this->config->get('TempDir')]]></code>
</PossiblyNullArgument>
@ -7017,14 +7013,9 @@
</DeprecatedMethod>
<InvalidArrayOffset>
<code><![CDATA[$GLOBALS['PHP_AUTH_PW']]]></code>
<code><![CDATA[$GLOBALS['PHP_AUTH_USER']]]></code>
</InvalidArrayOffset>
<MixedArgument>
<code><![CDATA[$this->user]]></code>
</MixedArgument>
<MixedAssignment>
<code><![CDATA[$this->password]]></code>
<code><![CDATA[$this->user]]></code>
</MixedAssignment>
<PossiblyInvalidArgument>
<code><![CDATA[$oldUser]]></code>

View File

@ -66,7 +66,6 @@ final class HomeController implements InvocableController
}
$GLOBALS['message'] ??= null;
$GLOBALS['show_query'] ??= null;
if ($request->isAjax() && ! empty($_REQUEST['access_time'])) {
return $this->response->response();
@ -79,7 +78,6 @@ final class HomeController implements InvocableController
// The DB is defined here and sent to the JS front-end to refresh the DB tree
Current::$database = $request->getParsedBodyParamAsString('db', '');
Current::$table = '';
$GLOBALS['show_query'] = '1';
if (Current::$server > 0 && $this->dbi->isSuperUser()) {
$this->dbi->selectDb('mysql');

View File

@ -1776,7 +1776,6 @@ class DatabaseInterface implements DbalInterface
/**
* returns last inserted auto_increment id for given $link
* or $GLOBALS['userlink']
*/
public function insertId(ConnectionType $connectionType = ConnectionType::User): int
{

View File

@ -476,7 +476,6 @@ interface DbalInterface
/**
* returns last inserted auto_increment id for given $link
* or $GLOBALS['userlink']
*/
public function insertId(ConnectionType $connectionType = ConnectionType::User): int;

View File

@ -210,7 +210,6 @@ class Operations
isset($_POST['drop_if_exists']) && $_POST['drop_if_exists'] === 'true',
)
) {
$GLOBALS['_error'] = true;
break;
}
@ -284,7 +283,6 @@ class Operations
true,
);
if (! $copyingSucceeded) {
$GLOBALS['_error'] = true;
break;
}
}

View File

@ -102,11 +102,6 @@ class AuthenticationHttp extends AuthenticationPlugin
*/
public function readCredentials(): bool
{
// Grabs the $PHP_AUTH_USER variable
if (isset($GLOBALS['PHP_AUTH_USER'])) {
$this->user = $GLOBALS['PHP_AUTH_USER'];
}
if ($this->user === '') {
if (Core::getEnv('PHP_AUTH_USER') !== '') {
$this->user = Core::getEnv('PHP_AUTH_USER');