From 5a79ac768dedfa1f39a24a98c822fa2237115d6c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= Date: Thu, 28 Sep 2023 19:18:25 -0300 Subject: [PATCH] Replace is_resource with different than false MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This will avoid an issue when proc_open will return an object instead of a resource in future PHP versions. Signed-off-by: MaurĂ­cio Meneghini Fauth --- .../Transformations/Abs/ExternalTransformationsPlugin.php | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libraries/classes/Plugins/Transformations/Abs/ExternalTransformationsPlugin.php b/libraries/classes/Plugins/Transformations/Abs/ExternalTransformationsPlugin.php index 1932bf306d..6e374eee3d 100644 --- a/libraries/classes/Plugins/Transformations/Abs/ExternalTransformationsPlugin.php +++ b/libraries/classes/Plugins/Transformations/Abs/ExternalTransformationsPlugin.php @@ -17,7 +17,6 @@ use function feof; use function fgets; use function fwrite; use function htmlspecialchars; -use function is_resource; use function proc_close; use function proc_open; use function sprintf; @@ -140,7 +139,7 @@ abstract class ExternalTransformationsPlugin extends TransformationsPlugin ], ]; $process = proc_open($program . ' ' . $options[1], $descriptorspec, $pipes); - if (is_resource($process)) { + if ($process !== false) { fwrite($pipes[0], $buffer); fclose($pipes[0]);