gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simplify finding largest table

Browse Source 
We really do not need intermediate array for that.

Signed-off-by: Michal Čihař <michal@cihar.com>
This commit is contained in:
Michal Čihař 2016-06-20 18:20:57 +02:00
parent b03587fb8a
commit 5b8608657f
1 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libraries/DbQbe.php
View File

@ -1470,17 +1470,21 @@ class DbQbe
// Of course we only want to check each table once
$checked_tables = $candidate_columns;
$tsize = array();
$csize = array();
$maxsize = -1;
$result = '';
foreach ($candidate_columns as $table) {
if ($checked_tables[$table] != 1) {
$_table = new Table($table, $this->_db);
$tsize[$table] = $_table->countRecords();
$checked_tables[$table] = 1;
}
$csize[$table] = $tsize[$table];
if ($tsize[$table] > $maxsize) {
$maxsize = $tsize[$table];
$result = $table;
}
}
// Return largest table
return array_search(max($csize), $csize);
return $result;
}
/**