diff --git a/ChangeLog b/ChangeLog index 0ddb165f0a..5a07d9023c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -13,6 +13,8 @@ phpMyAdmin - ChangeLog - bug #4483 'New window' link (selflink) disappears, causing Javascript error - bug #4489 Incorrect detection of privileges for routine creation - bug #4459 First few characters of database name aren't clickable when expanded +- bug #4486 [security] XSS injection due to unescaped table comment +- bug #4488 [security] XSS injection due to unescaped table name (triggers) 4.2.5.0 (2014-06-26) - bug #4467 shell_exec() has been disabled for security reasons diff --git a/libraries/rte/rte_list.lib.php b/libraries/rte/rte_list.lib.php index 71fe0311bd..61a110a51c 100644 --- a/libraries/rte/rte_list.lib.php +++ b/libraries/rte/rte_list.lib.php @@ -253,9 +253,9 @@ function PMA_TRI_getRowForList($trigger, $rowclass = '') $retval .= " \n"; if (empty($table)) { $retval .= " \n"; - $retval .= " " - . $trigger['table'] . "\n"; + $retval .= "" + . urlencode($trigger['table']) . ""; $retval .= " \n"; } $retval .= " \n"; diff --git a/libraries/structure.lib.php b/libraries/structure.lib.php index 27ddcc384c..f8bf4bf5f9 100644 --- a/libraries/structure.lib.php +++ b/libraries/structure.lib.php @@ -53,7 +53,8 @@ function PMA_getHtmlForActionLinks($current_table, $table_is_view, $tbl_url_quer $search_table .= ''; $browse_table_label = '' + . '&pos=0" title="' + . htmlspecialchars($current_table['TABLE_COMMENT']) . '">' . $truename . ''; if (!$db_is_system_schema) {