From b13550af11b6a79401ac688f525e9f460e7038cc Mon Sep 17 00:00:00 2001 From: Deven Bansod Date: Sat, 26 Sep 2015 01:37:43 +0530 Subject: [PATCH 1/3] Fix issue #11500 Signed-off-by: Deven Bansod --- libraries/server_privileges.lib.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libraries/server_privileges.lib.php b/libraries/server_privileges.lib.php index 7c62918adf..1396c1e297 100644 --- a/libraries/server_privileges.lib.php +++ b/libraries/server_privileges.lib.php @@ -4913,12 +4913,14 @@ function PMA_getSqlQueriesForDisplayAndAddUser($username, $hostname, $password) ); if (PMA_MYSQL_INT_VERSION >= 50507 + && PMA_Util::getServerType() == 'MySQL' && isset($_REQUEST['authentication_plugin']) ) { $create_user_stmt .= ' IDENTIFIED WITH ' . $_REQUEST['authentication_plugin']; } if (PMA_MYSQL_INT_VERSION >= 50707 + && PMA_Util::getServerType() == 'MySQL' && strpos($create_user_stmt, '%') !== false ) { $create_user_stmt = str_replace( @@ -4944,7 +4946,9 @@ function PMA_getSqlQueriesForDisplayAndAddUser($username, $hostname, $password) ); $real_sql_query = $sql_query = $sql_query_stmt; - if (PMA_MYSQL_INT_VERSION < 50707) { + if (PMA_MYSQL_INT_VERSION < 50707 + || PMA_Util::getServerType() != 'MySQL' + ) { if ($_POST['pred_password'] == 'keep') { $password_set_real = sprintf( $password_set_stmt, From a8e66a58538b0951ec30c8ed65761b31b833578d Mon Sep 17 00:00:00 2001 From: Marc Delisle Date: Fri, 25 Sep 2015 13:44:50 -0400 Subject: [PATCH 2/3] ChangeLog entry Signed-off-by: Marc Delisle --- ChangeLog | 1 + 1 file changed, 1 insertion(+) diff --git a/ChangeLog b/ChangeLog index 3bf1b00151..6000b00a0a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -10,6 +10,7 @@ phpMyAdmin - ChangeLog - issue #11464 phpMyAdmin suggests upgrading to newer version not usable on that system - issue #11495 'PMA_Microhistory' is undefined - issue #11496 Incorrect definition for getTablesWhenOpen() +- issue #11500 Error when creating new user on MariaDB 10.0.21 4.5.0.2 (2015-09-25) - issue #11497 Incorrect indexes when exporting From 62a4e61a65971ebc10ce4989cb54f5ce455f0878 Mon Sep 17 00:00:00 2001 From: Marc Delisle Date: Fri, 25 Sep 2015 13:48:55 -0400 Subject: [PATCH 3/3] Optimize function call Signed-off-by: Marc Delisle --- libraries/server_privileges.lib.php | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libraries/server_privileges.lib.php b/libraries/server_privileges.lib.php index 1396c1e297..32de29e54f 100644 --- a/libraries/server_privileges.lib.php +++ b/libraries/server_privileges.lib.php @@ -4905,6 +4905,7 @@ function PMA_getSqlQueriesForDisplayAndAddUser($username, $hostname, $password) $slashedUsername = PMA_Util::sqlAddSlashes($username); $slashedHostname = PMA_Util::sqlAddSlashes($hostname); $slashedPassword = PMA_Util::sqlAddSlashes($password); + $serverType = PMA_Util::getServerType(); $create_user_stmt = sprintf( 'CREATE USER \'%s\'@\'%s\'', @@ -4913,14 +4914,14 @@ function PMA_getSqlQueriesForDisplayAndAddUser($username, $hostname, $password) ); if (PMA_MYSQL_INT_VERSION >= 50507 - && PMA_Util::getServerType() == 'MySQL' + && $serverType == 'MySQL' && isset($_REQUEST['authentication_plugin']) ) { $create_user_stmt .= ' IDENTIFIED WITH ' . $_REQUEST['authentication_plugin']; } if (PMA_MYSQL_INT_VERSION >= 50707 - && PMA_Util::getServerType() == 'MySQL' + && $serverType == 'MySQL' && strpos($create_user_stmt, '%') !== false ) { $create_user_stmt = str_replace( @@ -4947,7 +4948,7 @@ function PMA_getSqlQueriesForDisplayAndAddUser($username, $hostname, $password) $real_sql_query = $sql_query = $sql_query_stmt; if (PMA_MYSQL_INT_VERSION < 50707 - || PMA_Util::getServerType() != 'MySQL' + || $serverType != 'MySQL' ) { if ($_POST['pred_password'] == 'keep') { $password_set_real = sprintf( @@ -5032,7 +5033,7 @@ function PMA_getSqlQueriesForDisplayAndAddUser($username, $hostname, $password) $sql_query = ''; } - if (PMA_Util::getServerType() == 'MySQL' + if ($serverType == 'MySQL' && PMA_MYSQL_INT_VERSION >= 50700 ) { $password_set_real = null;