From 9bfb7dd35bf05e65bda790f5a8bb23af785f55e8 Mon Sep 17 00:00:00 2001
From: Nisarg Jhaveri <nisargjhaveri@gmail.com>
Date: Thu, 4 Dec 2014 18:40:57 +0530
Subject: [PATCH] Better implementation of placeholder in dropdowns

If something else is selected, show placeholder as disabled option.
Previously it was ignoring `$active_choice` if placeholder is given.

Signed-off-by: Nisarg Jhaveri <nisargjhaveri@gmail.com>
---
 libraries/Util.class.php | 26 +++++++++++++++++---------
 1 file changed, 17 insertions(+), 9 deletions(-)

diff --git a/libraries/Util.class.php b/libraries/Util.class.php
index 2e291c1701..34f6b80d57 100644
--- a/libraries/Util.class.php
+++ b/libraries/Util.class.php
@@ -2704,20 +2704,28 @@ class PMA_Util
             . (! empty($class) ? ' class="' . htmlspecialchars($class) . '"' : '')
             . '>';
 
-        if (!empty($placeholder)) {
-            $result .= '<option value="" disabled="disabled"'
-                . ' selected="selected">' . $placeholder . '</option>';
-        }
+        $resultOptions = '';
+        $selected = false;
 
         foreach ($choices as $one_choice_value => $one_choice_label) {
-            $result .= '<option value="' . htmlspecialchars($one_choice_value) . '"';
+            $resultOptions .= '<option value="' . htmlspecialchars($one_choice_value) . '"';
 
-            if ($one_choice_value == $active_choice && empty($placeholder)) {
-                $result .= ' selected="selected"';
+            if ($one_choice_value == $active_choice) {
+                $resultOptions .= ' selected="selected"';
+                $selected = true;
             }
-            $result .= '>' . htmlspecialchars($one_choice_label) . '</option>';
+            $resultOptions .= '>' . htmlspecialchars($one_choice_label) . '</option>';
         }
-        $result .= '</select>';
+
+        if (!empty($placeholder)) {
+            $resultOptions = '<option value="" disabled="disabled"'
+                . ( !$selected ? ' selected="selected"' : '' )
+                . '>' . $placeholder . '</option>'
+                . $resultOptions;
+        }
+
+        $result .= $resultOptions
+            . '</select>';
 
         return $result;
     }