diff --git a/db_operations.php b/db_operations.php index c13bc4f360..f55baa568c 100644 --- a/db_operations.php +++ b/db_operations.php @@ -37,7 +37,7 @@ $sql_query = ''; /** * Rename/move or copy database */ -if (/*overload*/mb_strlen($GLOBALS['db']) +if (mb_strlen($GLOBALS['db']) && (! empty($_REQUEST['db_rename']) || ! empty($_REQUEST['db_copy'])) ) { if (! empty($_REQUEST['db_rename'])) { @@ -47,7 +47,7 @@ if (/*overload*/mb_strlen($GLOBALS['db']) } if (! isset($_REQUEST['newname']) - || ! /*overload*/mb_strlen($_REQUEST['newname']) + || ! mb_strlen($_REQUEST['newname']) ) { $message = PMA\libraries\Message::error(__('The database name is empty!')); } else { diff --git a/examples/openid.php b/examples/openid.php index e402d4e26d..852c97b7e3 100644 --- a/examples/openid.php +++ b/examples/openid.php @@ -79,7 +79,7 @@ $base .= '://' . $_SERVER['SERVER_NAME'] . ':' . $_SERVER['SERVER_PORT']; $realm = $base . '/'; $returnTo = $base . dirname($_SERVER['PHP_SELF']); -if ($returnTo[/*overload*/mb_strlen($returnTo) - 1] != '/') { +if ($returnTo[mb_strlen($returnTo) - 1] != '/') { $returnTo .= '/'; } $returnTo .= 'openid.php'; diff --git a/export.php b/export.php index d2e5feed9a..75fc590d59 100644 --- a/export.php +++ b/export.php @@ -254,7 +254,7 @@ if (!defined('TESTSUITE')) { if ($export_type == 'server') { $err_url = 'server_export.php' . PMA_URL_getCommon(); } elseif ($export_type == 'database' - && /*overload*/mb_strlen($db) + && mb_strlen($db) ) { $err_url = 'db_export.php' . PMA_URL_getCommon(array('db' => $db)); // Check if we have something to export @@ -263,8 +263,8 @@ if (!defined('TESTSUITE')) { } else { $tables = array(); } - } elseif ($export_type == 'table' && /*overload*/mb_strlen($db) - && /*overload*/mb_strlen($table) + } elseif ($export_type == 'table' && mb_strlen($db) + && mb_strlen($table) ) { $err_url = 'tbl_export.php' . PMA_URL_getCommon( array( diff --git a/file_echo.php b/file_echo.php index a94f67432e..0d65f0f7be 100644 --- a/file_echo.php +++ b/file_echo.php @@ -43,9 +43,9 @@ if (isset($_REQUEST['filename']) && isset($_REQUEST['image'])) { /* Decode data */ if ($extension != 'svg') { - $data = /*overload*/mb_substr( + $data = mb_substr( $_REQUEST['image'], - /*overload*/mb_strpos($_REQUEST['image'], ',') + 1 + mb_strpos($_REQUEST['image'], ',') + 1 ); $data = base64_decode($data); } else { @@ -56,7 +56,7 @@ if (isset($_REQUEST['filename']) && isset($_REQUEST['image'])) { PMA_downloadHeader( $filename, $_REQUEST['type'], - /*overload*/mb_strlen($data) + mb_strlen($data) ); /* Send data */ diff --git a/gis_data_editor.php b/gis_data_editor.php index 126acfe8c2..d38db8d319 100644 --- a/gis_data_editor.php +++ b/gis_data_editor.php @@ -43,14 +43,14 @@ $gis_types = array( // Extract from field's values if available, if not use the column type passed. if (! isset($gis_data['gis_type'])) { if (isset($_REQUEST['type']) && $_REQUEST['type'] != '') { - $gis_data['gis_type'] = /*overload*/mb_strtoupper($_REQUEST['type']); + $gis_data['gis_type'] = mb_strtoupper($_REQUEST['type']); } if (isset($_REQUEST['value']) && trim($_REQUEST['value']) != '') { $start = (substr($_REQUEST['value'], 0, 1) == "'") ? 1 : 0; - $gis_data['gis_type'] = /*overload*/mb_substr( + $gis_data['gis_type'] = mb_substr( $_REQUEST['value'], $start, - /*overload*/mb_strpos($_REQUEST['value'], "(") - $start + mb_strpos($_REQUEST['value'], "(") - $start ); } if ((! isset($gis_data['gis_type'])) diff --git a/import.php b/import.php index 3463409802..c8d0f5c1bb 100644 --- a/import.php +++ b/import.php @@ -257,17 +257,17 @@ if ($import_type == 'table') { $goto = 'server_import.php'; } else { if (empty($goto) || !preg_match('@^(server|db|tbl)(_[a-z]*)*\.php$@i', $goto)) { - if (/*overload*/mb_strlen($table) && /*overload*/mb_strlen($db)) { + if (mb_strlen($table) && mb_strlen($db)) { $goto = 'tbl_structure.php'; - } elseif (/*overload*/mb_strlen($db)) { + } elseif (mb_strlen($db)) { $goto = 'db_structure.php'; } else { $goto = 'server_sql.php'; } } - if (/*overload*/mb_strlen($table) && /*overload*/mb_strlen($db)) { + if (mb_strlen($table) && mb_strlen($db)) { $common = PMA_URL_getCommon(array('db' => $db, 'table' => $table)); - } elseif (/*overload*/mb_strlen($db)) { + } elseif (mb_strlen($db)) { $common = PMA_URL_getCommon(array('db' => $db)); } else { $common = PMA_URL_getCommon(); @@ -285,7 +285,7 @@ if (basename($_SERVER['SCRIPT_NAME']) === 'import.php') { } -if (/*overload*/mb_strlen($db)) { +if (mb_strlen($db)) { $GLOBALS['dbi']->selectDb($db); } @@ -407,7 +407,7 @@ if ($memory_limit == -1) { } // Calculate value of the limit -$memoryUnit = /*overload*/mb_strtolower(substr($memory_limit, -1)); +$memoryUnit = mb_strtolower(substr($memory_limit, -1)); if ('m' == $memoryUnit) { $memory_limit = (int)substr($memory_limit, 0, -1) * 1024 * 1024; } elseif ('k' == $memoryUnit) { @@ -729,7 +729,7 @@ if (isset($message)) { // in case of a query typed in the query window // (but if the query is too large, in case of an imported file, the parser // can choke on it so avoid parsing) -$sqlLength = /*overload*/mb_strlen($sql_query); +$sqlLength = mb_strlen($sql_query); if ($sqlLength <= $GLOBALS['cfg']['MaxCharactersInDisplayedSQL']) { include_once 'libraries/parse_analyze.lib.php'; diff --git a/index.php b/index.php index 03bb911840..09ee1c8104 100644 --- a/index.php +++ b/index.php @@ -591,8 +591,8 @@ if (isset($GLOBALS['dbi']) ) { $_client_info = $GLOBALS['dbi']->getClientInfo(); if ($server > 0 - && /*overload*/mb_strpos($_client_info, 'mysqlnd') === false - && /*overload*/mb_strpos(PMA_MYSQL_STR_VERSION, 'MariaDB') === false + && mb_strpos($_client_info, 'mysqlnd') === false + && mb_strpos(PMA_MYSQL_STR_VERSION, 'MariaDB') === false && substr(PMA_MYSQL_CLIENT_API, 0, 3) != substr( PMA_MYSQL_INT_VERSION, 0, 3 ) diff --git a/libraries/Advisor.php b/libraries/Advisor.php index 87657604ea..0c14c45d49 100644 --- a/libraries/Advisor.php +++ b/libraries/Advisor.php @@ -529,7 +529,7 @@ class Advisor continue; } $rules[$ruleNo][$ruleSyntax[$ruleLine]] = chop( - /*overload*/mb_substr($line, 1) + mb_substr($line, 1) ); $lines[$ruleNo][$ruleSyntax[$ruleLine]] = $i + 1; ++$ruleLine; diff --git a/libraries/Config.php b/libraries/Config.php index 19ae3a6b20..4be7e98d74 100644 --- a/libraries/Config.php +++ b/libraries/Config.php @@ -168,15 +168,15 @@ class Config */ private function _setClientPlatform($user_agent) { - if (/*overload*/mb_strstr($user_agent, 'Win')) { + if (mb_strstr($user_agent, 'Win')) { $this->set('PMA_USR_OS', 'Win'); - } elseif (/*overload*/mb_strstr($user_agent, 'Mac')) { + } elseif (mb_strstr($user_agent, 'Mac')) { $this->set('PMA_USR_OS', 'Mac'); - } elseif (/*overload*/mb_strstr($user_agent, 'Linux')) { + } elseif (mb_strstr($user_agent, 'Linux')) { $this->set('PMA_USR_OS', 'Linux'); - } elseif (/*overload*/mb_strstr($user_agent, 'Unix')) { + } elseif (mb_strstr($user_agent, 'Unix')) { $this->set('PMA_USR_OS', 'Unix'); - } elseif (/*overload*/mb_strstr($user_agent, 'OS/2')) { + } elseif (mb_strstr($user_agent, 'OS/2')) { $this->set('PMA_USR_OS', 'OS/2'); } else { $this->set('PMA_USR_OS', 'Other'); @@ -271,7 +271,7 @@ class Config ); $this->set('PMA_USR_BROWSER_AGENT', 'SAFARI'); // Firefox - } elseif (! /*overload*/mb_strstr($HTTP_USER_AGENT, 'compatible') + } elseif (! mb_strstr($HTTP_USER_AGENT, 'compatible') && preg_match('@Firefox/([\w.]+)@', $HTTP_USER_AGENT, $log_version) ) { $this->set( @@ -314,7 +314,7 @@ class Config if (@function_exists('gd_info')) { $gd_nfo = gd_info(); - if (/*overload*/mb_strstr($gd_nfo["GD Version"], '2.')) { + if (mb_strstr($gd_nfo["GD Version"], '2.')) { $this->set('PMA_IS_GD2', 1); } else { $this->set('PMA_IS_GD2', 0); @@ -449,10 +449,10 @@ class Config $branch = false; // are we on any branch? - if (/*overload*/mb_strstr($ref_head, '/')) { - $ref_head = /*overload*/mb_substr(trim($ref_head), 5); + if (mb_strstr($ref_head, '/')) { + $ref_head = mb_substr(trim($ref_head), 5); if (substr($ref_head, 0, 11) === 'refs/heads/') { - $branch = /*overload*/mb_substr($ref_head, 11); + $branch = mb_substr($ref_head, 11); } else { $branch = basename($ref_head); } @@ -1306,7 +1306,7 @@ class Config $pma_absolute_uri = $this->get('PmaAbsoluteUri'); $is_https = $this->detectHttps(); - if (/*overload*/mb_strlen($pma_absolute_uri) < 5) { + if (mb_strlen($pma_absolute_uri) < 5) { $url = array(); // If we don't have scheme, we didn't have full URL so we need to @@ -1407,7 +1407,7 @@ class Config $path = ''; } // in vhost situations, there could be already an ending slash - if (/*overload*/mb_substr($path, -1) != '/') { + if (mb_substr($path, -1) != '/') { $path .= '/'; } $pma_absolute_uri .= $path; @@ -1429,20 +1429,20 @@ class Config // Adds a trailing slash et the end of the phpMyAdmin uri if it // does not exist. - if (/*overload*/mb_substr($pma_absolute_uri, -1) != '/') { + if (mb_substr($pma_absolute_uri, -1) != '/') { $pma_absolute_uri .= '/'; } // If URI doesn't start with http:// or https://, we will add // this. - if (/*overload*/mb_substr($pma_absolute_uri, 0, 7) != 'http://' - && /*overload*/mb_substr($pma_absolute_uri, 0, 8) != 'https://' + if (mb_substr($pma_absolute_uri, 0, 7) != 'http://' + && mb_substr($pma_absolute_uri, 0, 8) != 'https://' ) { $pma_absolute_uri = ($is_https ? 'https' : 'http') . ':' . ( - /*overload*/mb_substr($pma_absolute_uri, 0, 2) == '//' + mb_substr($pma_absolute_uri, 0, 2) == '//' ? '' : '//' ) @@ -1588,7 +1588,7 @@ class Config // CloudFlare Flexible SSL compatibility $this->set('force_protocol', in_array(PMA_getenv('HTTP_X_FORWARDED_PROTO'), array('http', 'https'), true)); - + $is_https = $this->get('force_protocol') ? PMA_getenv('HTTP_X_FORWARDED_PROTO') : isset($url['scheme']) && $url['scheme'] == 'https'; $this->set('is_https', $is_https); @@ -1864,7 +1864,7 @@ class Config public function setCookie($cookie, $value, $default = null, $validity = null, $httponly = true ) { - if (/*overload*/mb_strlen($value) && null !== $default && $value === $default + if (mb_strlen($value) && null !== $default && $value === $default ) { // default value is used if (isset($_COOKIE[$cookie])) { @@ -1874,7 +1874,7 @@ class Config return false; } - if (!/*overload*/mb_strlen($value) && isset($_COOKIE[$cookie])) { + if (!mb_strlen($value) && isset($_COOKIE[$cookie])) { // remove cookie, value is empty return $this->removeCookie($cookie); } diff --git a/libraries/DatabaseInterface.php b/libraries/DatabaseInterface.php index da9f60f725..46753f0627 100644 --- a/libraries/DatabaseInterface.php +++ b/libraries/DatabaseInterface.php @@ -680,14 +680,14 @@ class DatabaseInterface return $tables[$database]; } - if (isset($tables[/*overload*/mb_strtolower($database)])) { + if (isset($tables[mb_strtolower($database)])) { // on windows with lower_case_table_names = 1 // MySQL returns // with SHOW DATABASES or information_schema.SCHEMATA: `Test` // but information_schema.TABLES gives `test` // bug #2036 // https://sourceforge.net/p/phpmyadmin/bugs/2036/ - return $tables[/*overload*/mb_strtolower($database)]; + return $tables[mb_strtolower($database)]; } return $tables; @@ -762,7 +762,7 @@ class DatabaseInterface $tables[$table_name]['TABLE_COMMENT'] =& $tables[$table_name]['Comment']; - $commentUpper = /*overload*/mb_strtoupper( + $commentUpper = mb_strtoupper( $tables[$table_name]['Comment'] ); if ($commentUpper === 'VIEW' diff --git a/libraries/DbQbe.php b/libraries/DbQbe.php index 7cc2f4aa8a..a1192f4733 100644 --- a/libraries/DbQbe.php +++ b/libraries/DbQbe.php @@ -346,7 +346,7 @@ class DbQbe $this->_columnNames[] = $each_column; // increase the width if necessary $this->_form_column_width = max( - /*overload*/mb_strlen($each_column), + mb_strlen($each_column), $this->_form_column_width ); } // end foreach @@ -587,7 +587,7 @@ class DbQbe // then sorting is not available, Fix for Bug #570698 if (isset($_REQUEST['criteriaSort'][$colInd]) && isset($_REQUEST['criteriaColumn'][$colInd]) - && /*overload*/mb_substr($_REQUEST['criteriaColumn'][$colInd], -2) == '.*' + && mb_substr($_REQUEST['criteriaColumn'][$colInd], -2) == '.*' ) { $_REQUEST['criteriaSort'][$colInd] = ''; } //end if @@ -1174,7 +1174,7 @@ class DbQbe && isset($this->_curAndOrCol) ) { $where_clause .= ' ' - . /*overload*/mb_strtoupper($this->_curAndOrCol[$last_where]) + . mb_strtoupper($this->_curAndOrCol[$last_where]) . ' '; } if (! empty($this->_curField[$column_index]) @@ -1211,7 +1211,7 @@ class DbQbe && $column_index ) { $qry_orwhere .= ' ' - . /*overload*/mb_strtoupper( + . mb_strtoupper( $this->_curAndOrCol[$last_orwhere] ) . ' '; @@ -1232,7 +1232,7 @@ class DbQbe } if (! empty($qry_orwhere)) { $where_clause .= "\n" - . /*overload*/mb_strtoupper( + . mb_strtoupper( isset($this->_curAndOrRow[$row_index]) ? $this->_curAndOrRow[$row_index] . ' ' : '' @@ -1283,7 +1283,7 @@ class DbQbe continue; } - if (/*overload*/mb_substr($field[$column_index], -2) == '.*') { + if (mb_substr($field[$column_index], -2) == '.*') { continue; } @@ -1511,7 +1511,7 @@ class DbQbe // Now we know that our array has the same numbers as $criteria // we can check which of our columns has a where clause if (! empty($this->_criteria[$column_index])) { - if (/*overload*/mb_substr($this->_criteria[$column_index], 0, 1) == '=' + if (mb_substr($this->_criteria[$column_index], 0, 1) == '=' || stristr($this->_criteria[$column_index], 'is') ) { $where_clause_columns[$column] = $column; diff --git a/libraries/DbSearch.php b/libraries/DbSearch.php index 645d68e567..96965ce13f 100644 --- a/libraries/DbSearch.php +++ b/libraries/DbSearch.php @@ -214,14 +214,14 @@ class DbSearch foreach ($search_words as $search_word) { // Eliminates empty values - if (/*overload*/mb_strlen($search_word) === 0) { + if (mb_strlen($search_word) === 0) { continue; } $likeClausesPerColumn = array(); // for each column in the table foreach ($allColumns as $column) { if (! isset($this->_criteriaColumnName) - || /*overload*/mb_strlen($this->_criteriaColumnName) == 0 + || mb_strlen($this->_criteriaColumnName) == 0 || $column['Field'] == $this->_criteriaColumnName ) { $column = 'CONVERT(' . Util::backquote($column['Field']) diff --git a/libraries/DisplayResults.php b/libraries/DisplayResults.php index a7b5f9aa9c..93f1adeabd 100644 --- a/libraries/DisplayResults.php +++ b/libraries/DisplayResults.php @@ -627,7 +627,7 @@ class DisplayResults $the_total = $unlim_num_rows; } elseif ((($displayParts['nav_bar'] == '1') || ($displayParts['sort_lnk'] == '1')) - && (/*overload*/mb_strlen($db) && !empty($table)) + && (mb_strlen($db) && !empty($table)) ) { $the_total = $GLOBALS['dbi']->getTable($db, $table)->countRecords(); } @@ -1904,8 +1904,8 @@ class DisplayResults $comments = ''; $limitChars = $GLOBALS['cfg']['LimitChars']; - if (/*overload*/mb_strlen($sanitized_comments) > $limitChars) { - $sanitized_comments = /*overload*/mb_substr( + if (mb_strlen($sanitized_comments) > $limitChars) { + $sanitized_comments = mb_substr( $sanitized_comments, 0, $limitChars ) . '…'; } @@ -1952,7 +1952,7 @@ class DisplayResults // FROM `PMA_relation` AS `1` , `PMA_relation` AS `2` $sort_tbl = (isset($fields_meta->table) - && /*overload*/mb_strlen($fields_meta->table) + && mb_strlen($fields_meta->table) && $fields_meta->orgname == $fields_meta->name) ? Util::backquote( $fields_meta->table @@ -2070,7 +2070,7 @@ class DisplayResults $sort_tbl_new = $sort_tbl; // Test to detect if the column name is a standard name // Standard name has the table name prefixed to the column name - if (/*overload*/mb_strpos($name_to_use_in_sort, '.') !== false) { + if (mb_strpos($name_to_use_in_sort, '.') !== false) { $matches = explode('.', $name_to_use_in_sort); // Matches[0] has the table name // Matches[1] has the column name @@ -2089,10 +2089,10 @@ class DisplayResults // order by clause to the column name $query_head = $is_first_clause ? "\nORDER BY " : ""; // Again a check to see if the given column is a aggregate column - if (/*overload*/mb_strpos($name_to_use_in_sort, '(') !== false) { + if (mb_strpos($name_to_use_in_sort, '(') !== false) { $sort_order .= $query_head . $name_to_use_in_sort . ' ' ; } else { - if (/*overload*/mb_strlen($sort_tbl_new) > 0) { + if (mb_strlen($sort_tbl_new) > 0) { $sort_tbl_new .= "."; } $sort_order .= $query_head . $sort_tbl_new @@ -2106,7 +2106,7 @@ class DisplayResults $sort_order = preg_replace("/\.\./", ".", $sort_order); // Incase this is the current column save $single_sort_order if ($current_name == $name_to_use_in_sort) { - if (/*overload*/mb_strpos($current_name, '(') !== false) { + if (mb_strpos($current_name, '(') !== false) { $single_sort_order = "\n" . 'ORDER BY ' . $current_name . ' '; } else { $single_sort_order = "\n" . 'ORDER BY ' . $sort_tbl @@ -2140,10 +2140,10 @@ class DisplayResults } // remove the comma from the last column name in the newly // constructed clause - $sort_order = /*overload*/mb_substr( + $sort_order = mb_substr( $sort_order, 0, - /*overload*/mb_strlen($sort_order)-2 + mb_strlen($sort_order)-2 ); if (empty($order_img)) { $order_img = ''; @@ -2173,7 +2173,7 @@ class DisplayResults $index_in_expression = 0; foreach ($sort_expression_nodirection as $index => $clause) { - if (/*overload*/mb_strpos($clause, '.') !== false) { + if (mb_strpos($clause, '.') !== false) { $fragments = explode('.', $clause); $clause2 = $fragments[0] . "." . str_replace('`', '', $fragments[1]); } else { @@ -2196,10 +2196,10 @@ class DisplayResults // Another query to test this: // SELECT p.*, FROM_UNIXTIME(p.temps) FROM mytable AS p // (and try clicking on each column's header twice) - $noSortTable = empty($sort_tbl) || /*overload*/mb_strpos( + $noSortTable = empty($sort_tbl) || mb_strpos( $sort_expression_nodirection[$index_in_expression], $sort_tbl ) === false; - $noOpenParenthesis = /*overload*/mb_strpos( + $noOpenParenthesis = mb_strpos( $sort_expression_nodirection[$index_in_expression], '(' ) === false; if (! empty($sort_tbl) && $noSortTable && $noOpenParenthesis) { @@ -2292,10 +2292,10 @@ class DisplayResults ) { $order_link_params = array(); if (isset($order_img) && ($order_img != '')) { - if (/*overload*/mb_strstr($order_img, 'asc')) { + if (mb_strstr($order_img, 'asc')) { $order_link_params['onmouseover'] = "$('.soimg$col_index').toggle()"; $order_link_params['onmouseout'] = "$('.soimg$col_index').toggle()"; - } elseif (/*overload*/mb_strstr($order_img, 'desc')) { + } elseif (mb_strstr($order_img, 'desc')) { $order_link_params['onmouseover'] = "$('.soimg$col_index').toggle()"; $order_link_params['onmouseout'] = "$('.soimg$col_index').toggle()"; } @@ -2625,12 +2625,12 @@ class DisplayResults ); foreach ($matches as $key => $value) { - if (/*overload*/mb_strpos($meta->flags, $key) !== false) { + if (mb_strpos($meta->flags, $key) !== false) { $classes[] = $value; } } - if (/*overload*/mb_strpos($meta->type, 'bit') !== false) { + if (mb_strpos($meta->type, 'bit') !== false) { $classes[] = 'bit'; } @@ -3070,9 +3070,9 @@ class DisplayResults // Check whether the field needs to display with syntax highlighting - $dbLower = /*overload*/mb_strtolower($this->__get('db')); - $tblLower = /*overload*/mb_strtolower($meta->orgtable); - $nameLower = /*overload*/mb_strtolower($meta->orgname); + $dbLower = mb_strtolower($this->__get('db')); + $tblLower = mb_strtolower($meta->orgtable); + $nameLower = mb_strtolower($meta->orgname); if (! empty($this->transformation_info[$dbLower][$tblLower][$nameLower]) && (trim($row[$i]) != '') && ! $_SESSION['tmpval']['hide_transformation'] @@ -3091,8 +3091,8 @@ class DisplayResults $meta->mimetype = str_replace( '_', '/', $this->transformation_info[$dbLower] - [/*overload*/mb_strtolower($meta->orgtable)] - [/*overload*/mb_strtolower($meta->orgname)][2] + [mb_strtolower($meta->orgtable)] + [mb_strtolower($meta->orgname)][2] ); } @@ -3105,7 +3105,7 @@ class DisplayResults ) { $linking_url = $this->_getSpecialLinkUrl( - $row[$i], $row_info, /*overload*/mb_strtolower($meta->orgname) + $row[$i], $row_info, mb_strtolower($meta->orgname) ); $transformation_plugin = new Text_Plain_Link(); @@ -3252,8 +3252,8 @@ class DisplayResults $linking_url_params = array(); $link_relations = $GLOBALS['special_schema_links'] - [/*overload*/mb_strtolower($this->__get('db'))] - [/*overload*/mb_strtolower($this->__get('table'))] + [mb_strtolower($this->__get('db'))] + [mb_strtolower($this->__get('table'))] [$field_name]; if (! is_array($link_relations['link_param'])) { @@ -3284,7 +3284,7 @@ class DisplayResults } $linking_url_params[$new_param['param_info']] - = $row_info[/*overload*/mb_strtolower($new_param['column_name'])]; + = $row_info[mb_strtolower($new_param['column_name'])]; // Special case 1 - when executing routines, according // to the type of the routine, url param changes @@ -3314,7 +3314,7 @@ class DisplayResults for ($n = 0; $n < $this->__get('fields_cnt'); ++$n) { $m = $col_order ? $col_order[$n] : $n; - $row_info[/*overload*/mb_strtolower($fields_meta[$m]->name)] + $row_info[mb_strtolower($fields_meta[$m]->name)] = $row[$m]; } @@ -3336,7 +3336,7 @@ class DisplayResults private function _getUrlSqlQuery($analyzed_sql_results) { if (($analyzed_sql_results['querytype'] != 'SELECT') - || (/*overload*/mb_strlen($this->__get('sql_query')) < 200) + || (mb_strlen($this->__get('sql_query')) < 200) ) { return $this->__get('sql_query'); } @@ -4336,7 +4336,7 @@ class DisplayResults } // 2.3 Prepare the navigation bars - if (!/*overload*/mb_strlen($this->__get('table'))) { + if (!mb_strlen($this->__get('table'))) { if ($analyzed_sql_results['querytype'] == 'SELECT') { // table does not always contain a real table name, @@ -4387,7 +4387,7 @@ class DisplayResults } } - if (/*overload*/mb_strlen($this->__get('table'))) { + if (mb_strlen($this->__get('table'))) { // This method set the values for $map array $this->_setParamForLinkForeignKeyRelatedTables($map); @@ -4527,7 +4527,7 @@ class DisplayResults return null; } - if (/*overload*/mb_strpos($sort_expression_nodirection, '.') === false) { + if (mb_strpos($sort_expression_nodirection, '.') === false) { $sort_table = $this->__get('table'); $sort_column = $sort_expression_nodirection; } else { @@ -4578,8 +4578,8 @@ class DisplayResults $column_for_first_row = $row[$sorted_column_index]; } - $column_for_first_row = /*overload*/mb_strtoupper( - /*overload*/mb_substr( + $column_for_first_row = mb_strtoupper( + mb_substr( $column_for_first_row, 0, $GLOBALS['cfg']['LimitChars'] ) . '...' ); @@ -4604,8 +4604,8 @@ class DisplayResults $column_for_last_row = $row[$sorted_column_index]; } - $column_for_last_row = /*overload*/mb_strtoupper( - /*overload*/mb_substr( + $column_for_last_row = mb_strtoupper( + mb_substr( $column_for_last_row, 0, $GLOBALS['cfg']['LimitChars'] ) . '...' ); @@ -5243,7 +5243,7 @@ class DisplayResults if (isset($content)) { - $size = /*overload*/mb_strlen($content, '8bit'); + $size = mb_strlen($content, '8bit'); $display_size = Util::formatByteDown($size, 3, 1); $result .= ' - ' . $display_size[0] . ' ' . $display_size[1]; @@ -5435,7 +5435,7 @@ class DisplayResults // Field to display from the foreign table? if (isset($map[$meta->name][2]) - && /*overload*/mb_strlen($map[$meta->name][2]) + && mb_strlen($map[$meta->name][2]) ) { $dispval = $this->_getFromForeign( $map, $meta, $where_comparison @@ -5807,11 +5807,11 @@ class DisplayResults */ private function _getPartialText($str) { - $original_length = /*overload*/mb_strlen($str); + $original_length = mb_strlen($str); if ($original_length > $GLOBALS['cfg']['LimitChars'] && $_SESSION['tmpval']['pftext'] === self::DISPLAY_PARTIAL_TEXT ) { - $str = /*overload*/mb_substr( + $str = mb_substr( $str, 0, $GLOBALS['cfg']['LimitChars'] ) . '...'; $truncated = true; diff --git a/libraries/Error.php b/libraries/Error.php index c1887b9f48..6993a8e97f 100644 --- a/libraries/Error.php +++ b/libraries/Error.php @@ -239,7 +239,7 @@ class Error extends Message public function getHtmlTitle() { return htmlspecialchars( - /*overload*/mb_substr($this->getTitle(), 0, 100) + mb_substr($this->getTitle(), 0, 100) ); } diff --git a/libraries/File.php b/libraries/File.php index c1010e4af9..b70a448c2f 100644 --- a/libraries/File.php +++ b/libraries/File.php @@ -723,7 +723,7 @@ class File */ public function getContentLength() { - return /*overload*/mb_strlen($this->_content); + return mb_strlen($this->_content); } /** diff --git a/libraries/Font.php b/libraries/Font.php index 49028caac8..dd4bd81042 100644 --- a/libraries/Font.php +++ b/libraries/Font.php @@ -101,18 +101,18 @@ class Font $count = 0; foreach ($charLists as $charList) { - $count += ((/*overload*/mb_strlen($text) - - /*overload*/mb_strlen(str_replace($charList["chars"], "", $text)) + $count += ((mb_strlen($text) + - mb_strlen(str_replace($charList["chars"], "", $text)) ) * $charList["modifier"]); } $text = str_replace(" ", "", $text);//remove the " "'s //all other chars $count = $count - + (/*overload*/mb_strlen(preg_replace("/[a-z0-9]/i", "", $text)) * 0.3); + + (mb_strlen(preg_replace("/[a-z0-9]/i", "", $text)) * 0.3); $modifier = 1; - $font = /*overload*/mb_strtolower($font); + $font = mb_strtolower($font); switch ($font) { /* * no modifier for arial and sans-serif diff --git a/libraries/Header.php b/libraries/Header.php index 34020d4338..b78d87f88b 100644 --- a/libraries/Header.php +++ b/libraries/Header.php @@ -625,8 +625,8 @@ class Header $retval = ""; $retval .= ""; $retval .= ''; @@ -780,7 +780,7 @@ class Header { $retval = ''; if ($this->_menuEnabled - && /*overload*/mb_strlen($table) + && mb_strlen($table) && $GLOBALS['cfg']['NumRecentTables'] > 0 ) { $tmp_result = RecentFavoriteTable::getInstance('recent') diff --git a/libraries/Index.php b/libraries/Index.php index d2496ee9e9..76b804b849 100644 --- a/libraries/Index.php +++ b/libraries/Index.php @@ -129,7 +129,7 @@ class Index Index::_loadIndexes($table, $schema); if (! isset(Index::$_registry[$schema][$table][$index_name])) { $index = new Index; - if (/*overload*/mb_strlen($index_name)) { + if (mb_strlen($index_name)) { $index->setName($index_name); Index::$_registry[$schema][$table][$index->getName()] = $index; } @@ -260,7 +260,7 @@ class Index public function addColumn($params) { if (isset($params['Column_name']) - && /*overload*/mb_strlen($params['Column_name']) + && mb_strlen($params['Column_name']) ) { $this->_columns[$params['Column_name']] = new IndexColumn($params); } @@ -433,7 +433,7 @@ class Index public function getComments() { $comments = $this->getRemarks(); - if (/*overload*/mb_strlen($comments)) { + if (mb_strlen($comments)) { $comments .= "\n"; } $comments .= $this->getComment(); diff --git a/libraries/Linter.php b/libraries/Linter.php index b5d02e5a43..5d0dd49515 100644 --- a/libraries/Linter.php +++ b/libraries/Linter.php @@ -92,7 +92,7 @@ class Linter public static function lint($query) { // Disabling lint for huge queries to save some resources. - if (/*overload*/mb_strlen($query) > 10000) { + if (mb_strlen($query) > 10000) { return array( array( 'message' => __( @@ -156,7 +156,7 @@ class Linter // Ending position of the string that caused the error. list($toLine, $toColumn) = static::findLineNumberAndColumn( - $lines, $error[3] + /*overload*/mb_strlen($error[2]) + $lines, $error[3] + mb_strlen($error[2]) ); // Building the response. diff --git a/libraries/ListDatabase.php b/libraries/ListDatabase.php index 789989c301..468a528b74 100644 --- a/libraries/ListDatabase.php +++ b/libraries/ListDatabase.php @@ -138,7 +138,7 @@ class ListDatabase extends ListAbstract protected function checkOnlyDatabase() { if (is_string($GLOBALS['cfg']['Server']['only_db']) - && /*overload*/mb_strlen($GLOBALS['cfg']['Server']['only_db']) + && mb_strlen($GLOBALS['cfg']['Server']['only_db']) ) { $GLOBALS['cfg']['Server']['only_db'] = array( $GLOBALS['cfg']['Server']['only_db'] @@ -176,7 +176,7 @@ class ListDatabase extends ListAbstract */ public function getDefault() { - if (/*overload*/mb_strlen($GLOBALS['db'])) { + if (mb_strlen($GLOBALS['db'])) { return $GLOBALS['db']; } diff --git a/libraries/Menu.php b/libraries/Menu.php index 340188ef73..eb2eb27b75 100644 --- a/libraries/Menu.php +++ b/libraries/Menu.php @@ -95,11 +95,11 @@ class Menu { $url_params = array('db' => $this->_db); - if (/*overload*/mb_strlen($this->_table)) { + if (mb_strlen($this->_table)) { $tabs = $this->_getTableTabs(); $url_params['table'] = $this->_table; $level = 'table'; - } else if (/*overload*/mb_strlen($this->_db)) { + } else if (mb_strlen($this->_db)) { $tabs = $this->_getDbTabs(); $level = 'db'; } else { @@ -144,9 +144,9 @@ class Menu $result = PMA_queryAsControlUser($sql_query, false); if ($result) { while ($row = $GLOBALS['dbi']->fetchAssoc($result)) { - $tabName = /*overload*/mb_substr( + $tabName = mb_substr( $row['tab'], - /*overload*/mb_strpos($row['tab'], '_') + 1 + mb_strpos($row['tab'], '_') + 1 ); unset($allowedTabs[$tabName]); } @@ -201,7 +201,7 @@ class Menu __('Server') ); - if (/*overload*/mb_strlen($this->_db)) { + if (mb_strlen($this->_db)) { $retval .= $separator; if (Util::showIcons('TabsMode')) { $retval .= Util::getImage( @@ -221,7 +221,7 @@ class Menu ); // if the table is being dropped, $_REQUEST['purge'] is set to '1' // so do not display the table name in upper div - if (/*overload*/mb_strlen($this->_table) + if (mb_strlen($this->_table) && ! (isset($_REQUEST['purge']) && $_REQUEST['purge'] == '1') ) { include './libraries/tbl_info.inc.php'; @@ -255,7 +255,7 @@ class Menu if (! empty($show_comment) && ! isset($GLOBALS['avoid_show_comment']) ) { - if (/*overload*/mb_strstr($show_comment, '; InnoDB free')) { + if (mb_strstr($show_comment, '; InnoDB free')) { $show_comment = preg_replace( '@; InnoDB free:.*?$@', '', diff --git a/libraries/Message.php b/libraries/Message.php index 45a0ab17ff..1b500aff39 100644 --- a/libraries/Message.php +++ b/libraries/Message.php @@ -502,7 +502,7 @@ class Message */ public function addMessage($message, $separator = ' ') { - if (/*overload*/mb_strlen($separator)) { + if (mb_strlen($separator)) { $this->addedMessages[] = $separator; } @@ -629,11 +629,11 @@ class Message { $message = $this->message; - if (0 === /*overload*/mb_strlen($message)) { + if (0 === mb_strlen($message)) { $string = $this->getString(); if (isset($GLOBALS[$string])) { $message = $GLOBALS[$string]; - } elseif (0 === /*overload*/mb_strlen($string)) { + } elseif (0 === mb_strlen($string)) { $message = ''; } else { $message = $string; diff --git a/libraries/PDF.php b/libraries/PDF.php index 94f4e695ef..c31c2caa35 100644 --- a/libraries/PDF.php +++ b/libraries/PDF.php @@ -143,7 +143,7 @@ class PDF extends TCPDF PMA_downloadHeader( $filename, 'application/pdf', - /*overload*/mb_strlen($pdfData) + mb_strlen($pdfData) ); echo $pdfData; } diff --git a/libraries/Response.php b/libraries/Response.php index b1bd6be9fa..b9a188a13a 100644 --- a/libraries/Response.php +++ b/libraries/Response.php @@ -320,13 +320,13 @@ class Response $debug = $this->_footer->getDebugMessage(); if (empty($_REQUEST['no_debug']) - && /*overload*/mb_strlen($debug) + && mb_strlen($debug) ) { $this->addJSON('_debug', $debug); } $errors = $this->_footer->getErrorMessages(); - if (/*overload*/mb_strlen($errors)) { + if (mb_strlen($errors)) { $this->addJSON('_errors', $errors); } $promptPhpErrors = $GLOBALS['error_handler']->hasErrorsForPrompt(); @@ -338,7 +338,7 @@ class Response $query = ''; $maxChars = $GLOBALS['cfg']['MaxCharactersInDisplayedSQL']; if (isset($GLOBALS['sql_query']) - && /*overload*/mb_strlen($GLOBALS['sql_query']) < $maxChars + && mb_strlen($GLOBALS['sql_query']) < $maxChars ) { $query = $GLOBALS['sql_query']; } diff --git a/libraries/Scripts.php b/libraries/Scripts.php index 32a6e18205..8457ed787f 100644 --- a/libraries/Scripts.php +++ b/libraries/Scripts.php @@ -53,7 +53,7 @@ class Scripts $scripts = array(); $separator = PMA_URL_getArgSeparator(); foreach ($files as $value) { - if (/*overload*/mb_strpos($value['filename'], "?") !== false) { + if (mb_strpos($value['filename'], "?") !== false) { $file_name = $value['filename'] . $separator . Header::getVersionParameter(); if ($value['before_statics'] === true) { diff --git a/libraries/ServerStatusData.php b/libraries/ServerStatusData.php index 4d57554a06..f5085c9c50 100644 --- a/libraries/ServerStatusData.php +++ b/libraries/ServerStatusData.php @@ -286,7 +286,7 @@ class ServerStatusData foreach ($server_status as $name => $value) { $section_found = false; foreach ($allocations as $filter => $section) { - if (/*overload*/mb_strpos($name, $filter) !== false) { + if (mb_strpos($name, $filter) !== false) { $allocationMap[$name] = $section; $sectionUsed[$section] = true; $section_found = true; @@ -369,7 +369,7 @@ class ServerStatusData // Set all class properties $this->db_isLocal = false; - $serverHostToLower = /*overload*/mb_strtolower( + $serverHostToLower = mb_strtolower( $GLOBALS['cfg']['Server']['host'] ); if ($serverHostToLower === 'localhost' diff --git a/libraries/StorageEngine.php b/libraries/StorageEngine.php index f7b52cbe0e..71aa8ef0bc 100644 --- a/libraries/StorageEngine.php +++ b/libraries/StorageEngine.php @@ -145,7 +145,7 @@ class StorageEngine $selected = null, $offerUnavailableEngines = false, $addEmpty = false ) { - $selected = /*overload*/mb_strtolower($selected); + $selected = mb_strtolower($selected); $output = ''; $html_output .= "\n" . ' ' . $backup_field . "\n"; - if (/*overload*/mb_strlen($column['Type']) > 20) { + if (mb_strlen($column['Type']) > 20) { $html_output .= PMA_getDropDownDependingOnLength( $column, $column_name_appendix, $onChangeClause, $tabindex, $tabindex_for_value, $idindex, $data, $column_enum_values @@ -1051,7 +1051,7 @@ function PMA_getBinaryAndBlobColumn( $html_output .= __('Binary - do not edit'); if (isset($data)) { $data_size = PMA\libraries\Util::formatByteDown( - /*overload*/mb_strlen(stripslashes($data)), 3, 1 + mb_strlen(stripslashes($data)), 3, 1 ); $html_output .= ' (' . $data_size[0] . ' ' . $data_size[1] . ')'; unset($data_size); @@ -1263,7 +1263,7 @@ function PMA_getValueColumnForOtherDatatypes($column, $default_char_editing, $html_output = $backup_field . "\n"; if ($column['is_char'] && ($GLOBALS['cfg']['CharEditing'] == 'textarea' - || /*overload*/mb_strpos($data, "\n") !== false) + || mb_strpos($data, "\n") !== false) ) { $html_output .= "\n"; $GLOBALS['cfg']['CharEditing'] = $default_char_editing; @@ -1628,7 +1628,7 @@ function PMA_getSpecialCharsAndBackupFieldForExistingRow( } elseif ((substr($column['True_Type'], 0, 9) == 'timestamp' || $column['True_Type'] == 'datetime' || $column['True_Type'] == 'time') - && (/*overload*/mb_strpos($current_row[$column['Field']], ".") !== false) + && (mb_strpos($current_row[$column['Field']], ".") !== false) ) { $current_row[$column['Field']] = $as_is ? $current_row[$column['Field']] @@ -1671,7 +1671,7 @@ function PMA_getSpecialCharsAndBackupFieldForExistingRow( && $_REQUEST['default_action'] === 'insert' ) { if ($column['Key'] === 'PRI' - && /*overload*/mb_strpos($column['Extra'], 'auto_increment') !== false + && mb_strpos($column['Extra'], 'auto_increment') !== false ) { $data = $special_chars_encoded = $special_chars = null; } @@ -1856,13 +1856,13 @@ function PMA_getGotoInclude($goto_include) $goto_include = $GLOBALS['goto']; } if ($GLOBALS['goto'] == 'db_sql.php' - && /*overload*/mb_strlen($GLOBALS['table']) + && mb_strlen($GLOBALS['table']) ) { $GLOBALS['table'] = ''; } } if (! $goto_include) { - if (! /*overload*/mb_strlen($GLOBALS['table'])) { + if (! mb_strlen($GLOBALS['table'])) { $goto_include = 'db_sql.php'; } else { $goto_include = 'tbl_sql.php'; @@ -2019,7 +2019,7 @@ function PMA_getDisplayValueForForeignTableColumn($where_comparison, $foreigner['foreign_table'] ); // Field to display from the foreign table? - if (isset($display_field) && /*overload*/mb_strlen($display_field)) { + if (isset($display_field) && mb_strlen($display_field)) { $dispsql = 'SELECT ' . PMA\libraries\Util::backquote($display_field) . ' FROM ' . PMA\libraries\Util::backquote($foreigner['foreign_db']) . '.' . PMA\libraries\Util::backquote($foreigner['foreign_table']) @@ -2172,7 +2172,7 @@ function PMA_getCurrentValueAsAnArrayForMultipleEdit( $multi_edit_funcs, || in_array($multi_edit_funcs[$key], $gis_from_wkb_functions) ) { // Remove enclosing apostrophes - $current_value = /*overload*/mb_substr($current_value, 1, -1); + $current_value = mb_substr($current_value, 1, -1); // Remove escaping apostrophes $current_value = str_replace("''", "'", $current_value); return $multi_edit_funcs[$key] . '(' . $current_value . ')'; @@ -2226,7 +2226,7 @@ function PMA_getQueryValuesForInsertAndUpdateInMultipleEdit($multi_edit_columns_ // i n s e r t if ($is_insert) { // no need to add column into the valuelist - if (/*overload*/mb_strlen($current_value_as_an_array)) { + if (mb_strlen($current_value_as_an_array)) { $query_values[] = $current_value_as_an_array; // first inserted row so prepare the list of fields if (empty($value_sets)) { @@ -2313,7 +2313,7 @@ function PMA_getCurrentValueForDifferentTypes($possibly_uploaded_val, $key, } if ($type != 'protected' && $type != 'set' - && 0 === /*overload*/mb_strlen($current_value) + && 0 === mb_strlen($current_value) ) { // best way to avoid problems in strict mode // (works also in non-strict mode) @@ -2591,7 +2591,7 @@ function PMA_getHtmlForFunctionOption($odd_row, $column, $column_name_appendix) return '' . ' -1 - || /*overload*/mb_strpos($ipToTest, ':') > -1 + if (mb_strpos($testRange, ':') > -1 + || mb_strpos($ipToTest, ':') > -1 ) { // assume IPv6 $result = PMA_ipv6MaskTest($testRange, $ipToTest); @@ -176,11 +176,11 @@ function PMA_ipv6MaskTest($test_range, $ip_to_test) $result = true; // convert to lowercase for easier comparison - $test_range = /*overload*/mb_strtolower($test_range); - $ip_to_test = /*overload*/mb_strtolower($ip_to_test); + $test_range = mb_strtolower($test_range); + $ip_to_test = mb_strtolower($ip_to_test); - $is_cidr = /*overload*/mb_strpos($test_range, '/') > -1; - $is_range = /*overload*/mb_strpos($test_range, '[') > -1; + $is_cidr = mb_strpos($test_range, '/') > -1; + $is_range = mb_strpos($test_range, '[') > -1; $is_single = ! $is_cidr && ! $is_range; $ip_hex = bin2hex(inet_pton($ip_to_test)); @@ -229,7 +229,7 @@ function PMA_ipv6MaskTest($test_range, $ip_to_test) $pos = 31; while ($flexbits > 0) { // Get the character at this position - $orig = /*overload*/mb_substr($last_hex, $pos, 1); + $orig = mb_substr($last_hex, $pos, 1); // Convert it to an integer $origval = hexdec($orig); diff --git a/libraries/mime.lib.php b/libraries/mime.lib.php index 3d3c95cc80..f1a7757ac0 100644 --- a/libraries/mime.lib.php +++ b/libraries/mime.lib.php @@ -16,14 +16,14 @@ */ function PMA_detectMIME(&$test) { - $len = /*overload*/mb_strlen($test); + $len = mb_strlen($test); if ($len >= 2 && $test[0] == chr(0xff) && $test[1] == chr(0xd8)) { return 'image/jpeg'; } if ($len >= 3 && substr($test, 0, 3) == 'GIF') { return 'image/gif'; } - if ($len >= 4 && /*overload*/mb_substr($test, 0, 4) == "\x89PNG") { + if ($len >= 4 && mb_substr($test, 0, 4) == "\x89PNG") { return 'image/png'; } return 'application/octet-stream'; diff --git a/libraries/mult_submits.inc.php b/libraries/mult_submits.inc.php index 7e18841a8e..47282fdab3 100644 --- a/libraries/mult_submits.inc.php +++ b/libraries/mult_submits.inc.php @@ -159,11 +159,11 @@ $views = $GLOBALS['dbi']->getVirtualTables($db); if (!empty($submit_mult) && !empty($what)) { unset($message); - if (/*overload*/mb_strlen($table)) { + if (mb_strlen($table)) { include './libraries/tbl_common.inc.php'; $url_query .= '&goto=tbl_sql.php&back=tbl_sql.php'; include './libraries/tbl_info.inc.php'; - } elseif (/*overload*/mb_strlen($db)) { + } elseif (mb_strlen($db)) { include './libraries/db_common.inc.php'; list( diff --git a/libraries/mult_submits.lib.php b/libraries/mult_submits.lib.php index 3f89e8af04..6cd4ded4bb 100644 --- a/libraries/mult_submits.lib.php +++ b/libraries/mult_submits.lib.php @@ -32,9 +32,9 @@ function PMA_getUrlParams( 'query_type' => $what, 'reload' => (! empty($reload) ? 1 : 0), ); - if (/*overload*/mb_strpos(' ' . $action, 'db_') == 1) { + if (mb_strpos(' ' . $action, 'db_') == 1) { $_url_params['db']= $db; - } elseif (/*overload*/mb_strpos(' ' . $action, 'tbl_') == 1 + } elseif (mb_strpos(' ' . $action, 'tbl_') == 1 || $what == 'row_delete' ) { $_url_params['db']= $db; @@ -236,16 +236,16 @@ function PMA_buildOrExecuteQueryForMulti( case 'replace_prefix_tbl': $current = $selected[$i]; - $subFromPrefix = /*overload*/mb_substr( + $subFromPrefix = mb_substr( $current, 0, - /*overload*/mb_strlen($from_prefix) + mb_strlen($from_prefix) ); if ($subFromPrefix == $from_prefix) { $newtablename = $to_prefix - . /*overload*/mb_substr( + . mb_substr( $current, - /*overload*/mb_strlen($from_prefix) + mb_strlen($from_prefix) ); } else { $newtablename = $current; @@ -261,7 +261,7 @@ function PMA_buildOrExecuteQueryForMulti( case 'copy_tbl_change_prefix': $current = $selected[$i]; $newtablename = $to_prefix . - /*overload*/mb_substr($current, /*overload*/mb_strlen($from_prefix)); + mb_substr($current, mb_strlen($from_prefix)); // COPY TABLE AND CHANGE PREFIX PATTERN $a_query = 'CREATE TABLE ' . PMA\libraries\Util::backquote($newtablename) diff --git a/libraries/navigation/NavigationTree.php b/libraries/navigation/NavigationTree.php index 11dd19a58f..9bacea9f41 100644 --- a/libraries/navigation/NavigationTree.php +++ b/libraries/navigation/NavigationTree.php @@ -691,9 +691,9 @@ class NavigationTree foreach ($node->children as $child) { $prefix_pos = false; foreach ($separators as $separator) { - $sep_pos = /*overload*/mb_strpos($child->name, $separator); + $sep_pos = mb_strpos($child->name, $separator); if ($sep_pos != false - && $sep_pos != /*overload*/mb_strlen($child->name) + && $sep_pos != mb_strlen($child->name) && $sep_pos != 0 && ($prefix_pos == false || $sep_pos < $prefix_pos) ) { @@ -701,9 +701,7 @@ class NavigationTree } } if ($prefix_pos !== false) { - $prefix - = /*overload*/ - mb_substr($child->name, 0, $prefix_pos); + $prefix = mb_substr($child->name, 0, $prefix_pos); if (!isset($prefixes[$prefix])) { $prefixes[$prefix] = 1; } else { @@ -782,14 +780,12 @@ class NavigationTree $separatorLength = strlen($separator); // FIXME: this could be more efficient foreach ($node->children as $child) { - $keySeparatorLength - = /*overload*/mb_strlen($key) + $separatorLength; - $name_substring - = /*overload*/mb_substr( - $child->name, - 0, - $keySeparatorLength - ); + $keySeparatorLength = mb_strlen($key) + $separatorLength; + $name_substring = mb_substr( + $child->name, + 0, + $keySeparatorLength + ); if (($name_substring != $key . $separator && $child->name != $key) || $child->type != Node::OBJECT @@ -801,7 +797,6 @@ class NavigationTree unset($class); $new_child = NodeFactory::getInstance( $className, - /*overload*/ mb_substr( $child->name, $keySeparatorLength diff --git a/libraries/normalization.lib.php b/libraries/normalization.lib.php index 513978e9c5..36e866ac12 100644 --- a/libraries/normalization.lib.php +++ b/libraries/normalization.lib.php @@ -41,7 +41,7 @@ function PMA_getHtmlForColumnsList( $type = $extracted_columnspec['type']; } if (empty($columnTypeList) - || in_array(/*overload*/mb_strtoupper($type), $columnTypeList) + || in_array(mb_strtoupper($type), $columnTypeList) ) { if ($listType == 'checkbox') { $selectColHtml .= '' @@ -1135,7 +1135,7 @@ function PMA_getTableOptionFieldset($comment, $tbl_collation, if (isset($possible_row_formats[$tbl_storage_engine])) { $current_row_format - = /*overload*/mb_strtoupper($GLOBALS['showtable']['Row_format']); + = mb_strtoupper($GLOBALS['showtable']['Row_format']); $html_output .= '' . '' . ''; @@ -1778,7 +1778,7 @@ function PMA_getTableAltersArray($is_myisam_or_aria, $is_isam, $pack_keys, } if (! empty($newTblStorageEngine) - && /*overload*/mb_strtolower($newTblStorageEngine) !== /*overload*/mb_strtolower($GLOBALS['tbl_storage_engine']) + && mb_strtolower($newTblStorageEngine) !== mb_strtolower($GLOBALS['tbl_storage_engine']) ) { $table_alters[] = 'ENGINE = ' . $newTblStorageEngine; } @@ -1838,10 +1838,10 @@ function PMA_getTableAltersArray($is_myisam_or_aria, $is_isam, $pack_keys, if (! empty($_REQUEST['new_row_format'])) { $newRowFormat = $_REQUEST['new_row_format']; - $newRowFormatLower = /*overload*/mb_strtolower($newRowFormat); + $newRowFormatLower = mb_strtolower($newRowFormat); if (($is_myisam_or_aria || $is_innodb || $is_pbxt) - && (!/*overload*/mb_strlen($row_format) - || $newRowFormatLower !== /*overload*/mb_strtolower($row_format)) + && (!mb_strlen($row_format) + || $newRowFormatLower !== mb_strtolower($row_format)) ) { $table_alters[] = 'ROW_FORMAT = ' . PMA\libraries\Util::sqlAddSlashes($newRowFormat); diff --git a/libraries/plugin_interface.lib.php b/libraries/plugin_interface.lib.php index 5be7a5e3ad..c8df3875af 100644 --- a/libraries/plugin_interface.lib.php +++ b/libraries/plugin_interface.lib.php @@ -29,10 +29,10 @@ function PMA_getPlugin( $plugin_param = false ) { $GLOBALS['plugin_param'] = $plugin_param; - $class_name = /*overload*/mb_strtoupper($plugin_type[0]) - . /*overload*/mb_strtolower(/*overload*/mb_substr($plugin_type, 1)) - . /*overload*/mb_strtoupper($plugin_format[0]) - . /*overload*/mb_strtolower(/*overload*/mb_substr($plugin_format, 1)); + $class_name = mb_strtoupper($plugin_type[0]) + . mb_strtolower(mb_substr($plugin_type, 1)) + . mb_strtoupper($plugin_format[0]) + . mb_strtolower(mb_substr($plugin_format, 1)); $file = $class_name . ".php"; if (is_file($plugins_dir . $file)) { //include_once $plugins_dir . $file; @@ -65,7 +65,7 @@ function PMA_getPlugins($plugin_type, $plugins_dir, $plugin_param) $namespace = 'PMA\\' . str_replace('/', '\\', $plugins_dir); $class_type = mb_strtoupper($plugin_type[0], 'UTF-8') - . mb_strtolower(/*overload*/mb_substr($plugin_type, 1), 'UTF-8'); + . mb_strtolower(mb_substr($plugin_type, 1), 'UTF-8'); $prefix_class_name = $namespace . $class_type; @@ -202,10 +202,10 @@ function PMA_pluginGetChoice($section, $name, &$list, $cfgname = null) $elem = explode('\\', get_class($plugin)); $plugin_name = array_pop($elem); unset($elem); - $plugin_name = /*overload*/mb_strtolower( - /*overload*/mb_substr( + $plugin_name = mb_strtolower( + mb_substr( $plugin_name, - /*overload*/mb_strlen($section) + mb_strlen($section) ) ); $ret .= ' false); } else { diff --git a/libraries/plugins/auth/AuthenticationCookie.php b/libraries/plugins/auth/AuthenticationCookie.php index 001f4b5de7..f51a517147 100644 --- a/libraries/plugins/auth/AuthenticationCookie.php +++ b/libraries/plugins/auth/AuthenticationCookie.php @@ -579,10 +579,10 @@ class AuthenticationCookie extends AuthenticationPlugin // any parameters to pass? $url_params = array(); - if (/*overload*/mb_strlen($GLOBALS['db'])) { + if (mb_strlen($GLOBALS['db'])) { $url_params['db'] = $GLOBALS['db']; } - if (/*overload*/mb_strlen($GLOBALS['table'])) { + if (mb_strlen($GLOBALS['table'])) { $url_params['table'] = $GLOBALS['table']; } // any target to pass? diff --git a/libraries/plugins/export/ExportCsv.php b/libraries/plugins/export/ExportCsv.php index 419a63014c..d9ddc24879 100644 --- a/libraries/plugins/export/ExportCsv.php +++ b/libraries/plugins/export/ExportCsv.php @@ -129,7 +129,7 @@ class ExportCsv extends ExportPlugin } } else { if (empty($csv_terminated) - || /*overload*/mb_strtolower($csv_terminated) == 'auto' + || mb_strtolower($csv_terminated) == 'auto' ) { $csv_terminated = $GLOBALS['crlf']; } else { @@ -248,7 +248,7 @@ class ExportCsv extends ExportPlugin } $schema_insert .= $csv_separator; } // end for - $schema_insert = trim(/*overload*/mb_substr($schema_insert, 0, -1)); + $schema_insert = trim(mb_substr($schema_insert, 0, -1)); if (!PMA_exportOutputHandler($schema_insert . $csv_terminated)) { return false; } diff --git a/libraries/plugins/export/ExportLatex.php b/libraries/plugins/export/ExportLatex.php index 08640c0d91..6ca0236baf 100644 --- a/libraries/plugins/export/ExportLatex.php +++ b/libraries/plugins/export/ExportLatex.php @@ -349,10 +349,7 @@ class ExportLatex extends ExportPlugin . self::texEscape(stripslashes($columns_alias[$i])) . '}} & '; } - $buffer - = /*overload*/ - mb_substr($buffer, 0, -2) - . '\\\\ \\hline \hline '; + $buffer = mb_substr($buffer, 0, -2) . '\\\\ \\hline \hline '; if (!PMA_exportOutputHandler($buffer . ' \\endfirsthead ' . $crlf)) { return false; } @@ -619,23 +616,19 @@ class ExportLatex extends ExportPlugin } $local_buffer = self::texEscape($local_buffer); if ($row['Key'] == 'PRI') { - $pos - = /*overload*/ - mb_strpos($local_buffer, "\000"); + $pos = mb_strpos($local_buffer, "\000"); $local_buffer = '\\textit{' - . /*overload*/ + . mb_substr($local_buffer, 0, $pos) - . '}' . /*overload*/ + . '}' . mb_substr($local_buffer, $pos); } if (in_array($field_name, $unique_keys)) { - $pos - = /*overload*/ - mb_strpos($local_buffer, "\000"); + $pos = mb_strpos($local_buffer, "\000"); $local_buffer = '\\textbf{' - . /*overload*/ + . mb_substr($local_buffer, 0, $pos) - . '}' . /*overload*/ + . '}' . mb_substr($local_buffer, $pos); } $buffer = str_replace("\000", ' & ', $local_buffer); diff --git a/libraries/plugins/export/ExportSql.php b/libraries/plugins/export/ExportSql.php index f3c2810a24..3df120d0ef 100644 --- a/libraries/plugins/export/ExportSql.php +++ b/libraries/plugins/export/ExportSql.php @@ -806,12 +806,12 @@ class ExportSql extends ExportPlugin isset($GLOBALS['sql_backquotes']) ); $collation = PMA_getDbCollation($db); - if (/*overload*/mb_strpos($collation, '_')) { + if (mb_strpos($collation, '_')) { $create_query .= ' DEFAULT CHARACTER SET ' - . /*overload*/mb_substr( + . mb_substr( $collation, 0, - /*overload*/mb_strpos($collation, '_') + mb_strpos($collation, '_') ) . ' COLLATE ' . $collation; } else { @@ -1485,11 +1485,11 @@ class ExportSql extends ExportPlugin // Convert end of line chars to one that we want (note that MySQL // doesn't return query it will accept in all cases) - if (/*overload*/mb_strpos($create_query, "(\r\n ")) { + if (mb_strpos($create_query, "(\r\n ")) { $create_query = str_replace("\r\n", $crlf, $create_query); - } elseif (/*overload*/mb_strpos($create_query, "(\n ")) { + } elseif (mb_strpos($create_query, "(\n ")) { $create_query = str_replace("\n", $crlf, $create_query); - } elseif (/*overload*/mb_strpos($create_query, "(\r ")) { + } elseif (mb_strpos($create_query, "(\r ")) { $create_query = str_replace("\r", $crlf, $create_query); } @@ -2433,9 +2433,7 @@ class ExportSql extends ExportPlugin . implode(', ', $values) . ')'; } else { $insert_line = '(' . implode(', ', $values) . ')'; - $insertLineSize - = /*overload*/ - mb_strlen($insert_line); + $insertLineSize = mb_strlen($insert_line); $sql_max_size = $GLOBALS['sql_max_query_size']; if (isset($sql_max_size) && $sql_max_size > 0 @@ -2449,9 +2447,7 @@ class ExportSql extends ExportPlugin $insert_line = $schema_insert . $insert_line; } } - $query_size - += /*overload*/ - mb_strlen($insert_line); + $query_size += mb_strlen($insert_line); // Other inserts case } else { $insert_line = $schema_insert diff --git a/libraries/plugins/export/ExportXml.php b/libraries/plugins/export/ExportXml.php index 92b698fbf4..7eba9e7bca 100644 --- a/libraries/plugins/export/ExportXml.php +++ b/libraries/plugins/export/ExportXml.php @@ -17,7 +17,7 @@ use PMA\libraries\DatabaseInterface; use PMA\libraries\plugins\ExportPlugin; use PMA\libraries\Util; -if (!/*overload*/mb_strlen($GLOBALS['db'])) { /* Can't do server export */ +if (!mb_strlen($GLOBALS['db'])) { /* Can't do server export */ $GLOBALS['skip_import'] = true; return; } @@ -258,9 +258,7 @@ class ExportXml extends ExportPlugin . $trigger['name'] . '">' . $crlf; // Do some formatting - $code - = /*overload*/ - mb_substr(rtrim($code), 0, -3); + $code = mb_substr(rtrim($code), 0, -3); $code = " " . htmlspecialchars($code); $code = str_replace("\n", "\n ", $code); diff --git a/libraries/plugins/export/TableProperty.php b/libraries/plugins/export/TableProperty.php index a14d130c78..d76baa6279 100644 --- a/libraries/plugins/export/TableProperty.php +++ b/libraries/plugins/export/TableProperty.php @@ -80,9 +80,9 @@ class TableProperty */ public function getPureType() { - $pos = /*overload*/mb_strpos($this->type, "("); + $pos = mb_strpos($this->type, "("); if ($pos > 0) { - return /*overload*/mb_substr($this->type, 0, $pos); + return mb_substr($this->type, 0, $pos); } return $this->type; } @@ -114,28 +114,28 @@ class TableProperty */ public function getDotNetPrimitiveType() { - if (/*overload*/mb_strpos($this->type, "int") === 0) { + if (mb_strpos($this->type, "int") === 0) { return "int"; } - if (/*overload*/mb_strpos($this->type, "longtext") === 0) { + if (mb_strpos($this->type, "longtext") === 0) { return "string"; } - if (/*overload*/mb_strpos($this->type, "long") === 0) { + if (mb_strpos($this->type, "long") === 0) { return "long"; } - if (/*overload*/mb_strpos($this->type, "char") === 0) { + if (mb_strpos($this->type, "char") === 0) { return "string"; } - if (/*overload*/mb_strpos($this->type, "varchar") === 0) { + if (mb_strpos($this->type, "varchar") === 0) { return "string"; } - if (/*overload*/mb_strpos($this->type, "text") === 0) { + if (mb_strpos($this->type, "text") === 0) { return "string"; } - if (/*overload*/mb_strpos($this->type, "tinyint") === 0) { + if (mb_strpos($this->type, "tinyint") === 0) { return "bool"; } - if (/*overload*/mb_strpos($this->type, "datetime") === 0) { + if (mb_strpos($this->type, "datetime") === 0) { return "DateTime"; } return "unknown"; @@ -148,28 +148,28 @@ class TableProperty */ public function getDotNetObjectType() { - if (/*overload*/mb_strpos($this->type, "int") === 0) { + if (mb_strpos($this->type, "int") === 0) { return "Int32"; } - if (/*overload*/mb_strpos($this->type, "longtext") === 0) { + if (mb_strpos($this->type, "longtext") === 0) { return "String"; } - if (/*overload*/mb_strpos($this->type, "long") === 0) { + if (mb_strpos($this->type, "long") === 0) { return "Long"; } - if (/*overload*/mb_strpos($this->type, "char") === 0) { + if (mb_strpos($this->type, "char") === 0) { return "String"; } - if (/*overload*/mb_strpos($this->type, "varchar") === 0) { + if (mb_strpos($this->type, "varchar") === 0) { return "String"; } - if (/*overload*/mb_strpos($this->type, "text") === 0) { + if (mb_strpos($this->type, "text") === 0) { return "String"; } - if (/*overload*/mb_strpos($this->type, "tinyint") === 0) { + if (mb_strpos($this->type, "tinyint") === 0) { return "Boolean"; } - if (/*overload*/mb_strpos($this->type, "datetime") === 0) { + if (mb_strpos($this->type, "datetime") === 0) { return "DateTime"; } return "Unknown"; @@ -182,7 +182,7 @@ class TableProperty */ public function getIndexName() { - if (/*overload*/mb_strlen($this->key) > 0) { + if (mb_strlen($this->key) > 0) { return "index=\"" . htmlspecialchars($this->name, ENT_COMPAT, 'UTF-8') . "\""; diff --git a/libraries/plugins/import/ImportCsv.php b/libraries/plugins/import/ImportCsv.php index 5a8691ef8a..bb1de840c3 100644 --- a/libraries/plugins/import/ImportCsv.php +++ b/libraries/plugins/import/ImportCsv.php @@ -113,7 +113,7 @@ class ImportCsv extends AbstractImportCsv $csv_new_line = strtr($csv_new_line, $replacements); $param_error = false; - if (/*overload*/mb_strlen($csv_terminated) < 1) { + if (mb_strlen($csv_terminated) < 1) { $message = PMA\libraries\Message::error( __('Invalid parameter for CSV import: %s') ); @@ -128,7 +128,7 @@ class ImportCsv extends AbstractImportCsv // confuses this script. // But the parser won't work correctly with strings so we allow just // one character. - } elseif (/*overload*/mb_strlen($csv_enclosed) > 1) { + } elseif (mb_strlen($csv_enclosed) > 1) { $message = PMA\libraries\Message::error( __('Invalid parameter for CSV import: %s') ); @@ -139,14 +139,14 @@ class ImportCsv extends AbstractImportCsv // confuses this script. // But the parser won't work correctly with strings so we allow just // one character. - } elseif (/*overload*/mb_strlen($csv_escaped) > 1) { + } elseif (mb_strlen($csv_escaped) > 1) { $message = PMA\libraries\Message::error( __('Invalid parameter for CSV import: %s') ); $message->addParam(__('Columns escaped with'), false); $error = true; $param_error = true; - } elseif (/*overload*/mb_strlen($csv_new_line) != 1 + } elseif (mb_strlen($csv_new_line) != 1 && $csv_new_line != 'auto' ) { $message = PMA\libraries\Message::error( @@ -238,9 +238,7 @@ class ImportCsv extends AbstractImportCsv $col_count = 0; $max_cols = 0; - $csv_terminated_len - = /*overload*/ - mb_strlen($csv_terminated); + $csv_terminated_len = mb_strlen($csv_terminated); while (!($finished && $i >= $len) && !$error && !$timeout_passed) { $data = PMA_importGetNextChunk(); if ($data === false) { @@ -256,9 +254,7 @@ class ImportCsv extends AbstractImportCsv // Force a trailing new line at EOF to prevent parsing problems if ($finished && $buffer) { - $finalch - = /*overload*/ - mb_substr($buffer, -1); + $finalch = mb_substr($buffer, -1); if ($csv_new_line == 'auto' && $finalch != "\r" && $finalch != "\n" @@ -274,19 +270,17 @@ class ImportCsv extends AbstractImportCsv // Do not parse string when we're not at the end // and don't have new line inside if (($csv_new_line == 'auto' - && /*overload*/mb_strpos($buffer, "\r") === false - && /*overload*/mb_strpos($buffer, "\n") === false) + && mb_strpos($buffer, "\r") === false + && mb_strpos($buffer, "\n") === false) || ($csv_new_line != 'auto' - && /*overload*/mb_strpos($buffer, $csv_new_line) === false) + && mb_strpos($buffer, $csv_new_line) === false) ) { continue; } } // Current length of our buffer - $len - = /*overload*/ - mb_strlen($buffer); + $len = mb_strlen($buffer); // Currently parsed char $ch = mb_substr($buffer, $i, 1); @@ -583,17 +577,11 @@ class ImportCsv extends AbstractImportCsv $line++; $csv_finish = false; $values = array(); - $buffer - = /*overload*/ - mb_substr($buffer, $i + 1); - $len - = /*overload*/ - mb_strlen($buffer); + $buffer = mb_substr($buffer, $i + 1); + $len = mb_strlen($buffer); $i = 0; $lasti = -1; - $ch - = /*overload*/ - mb_substr($buffer, 0, 1); + $ch = mb_substr($buffer, 0, 1); } } // End of parser loop } // End of import loop @@ -625,7 +613,7 @@ class ImportCsv extends AbstractImportCsv } } - if (/*overload*/mb_strlen($db)) { + if (mb_strlen($db)) { $result = $GLOBALS['dbi']->fetchResult('SHOW TABLES'); $tbl_name = 'TABLE ' . (count($result) + 1); } else { diff --git a/libraries/plugins/import/ImportMediawiki.php b/libraries/plugins/import/ImportMediawiki.php index 1f7e4d9d0a..eb0223972e 100644 --- a/libraries/plugins/import/ImportMediawiki.php +++ b/libraries/plugins/import/ImportMediawiki.php @@ -94,9 +94,7 @@ class ImportMediawiki extends ImportPlugin if ($data === false) { // Subtract data we didn't handle yet and stop processing - $GLOBALS['offset'] - -= /*overload*/ - mb_strlen($buffer); + $GLOBALS['offset'] -= mb_strlen($buffer); break; } elseif ($data === true) { // Handle rest of buffer @@ -106,7 +104,7 @@ class ImportMediawiki extends ImportPlugin unset($data); // Don't parse string if we're not at the end // and don't have a new line inside - if (/*overload*/mb_strpos($buffer, $mediawiki_new_line) === false) { + if (mb_strpos($buffer, $mediawiki_new_line) === false) { continue; } } @@ -139,12 +137,12 @@ class ImportMediawiki extends ImportPlugin $matches = array(); // Check beginning of comment - if (!strcmp(/*overload*/mb_substr($cur_buffer_line, 0, 4), "") + if (!strcmp(mb_substr($cur_buffer_line, 0, 4), "-->") ) { // Only data comments are closed. The structure comments // will be closed when a data comment begins (in order to @@ -201,9 +199,9 @@ class ImportMediawiki extends ImportPlugin $in_table_header = false; // End processing because the current line does not // contain any column information - } elseif (/*overload*/mb_substr($cur_buffer_line, 0, 2) === '|-' - || /*overload*/mb_substr($cur_buffer_line, 0, 2) === '|+' - || /*overload*/mb_substr($cur_buffer_line, 0, 2) === '|}' + } elseif (mb_substr($cur_buffer_line, 0, 2) === '|-' + || mb_substr($cur_buffer_line, 0, 2) === '|+' + || mb_substr($cur_buffer_line, 0, 2) === '|}' ) { // Check begin row or end table @@ -225,7 +223,7 @@ class ImportMediawiki extends ImportPlugin $cur_temp_line = array(); // No more processing required at the end of the table - if (/*overload*/mb_substr($cur_buffer_line, 0, 2) === '|}') { + if (mb_substr($cur_buffer_line, 0, 2) === '|}') { $current_table = array( $cur_table_name, $cur_temp_table_headers, @@ -548,7 +546,7 @@ class ImportMediawiki extends ImportPlugin // A '|' inside an invalid link should not // be mistaken as delimiting cell parameters - if (/*overload*/mb_strpos($cell_data[0], '[[') === false) { + if (mb_strpos($cell_data[0], '[[') === false) { return $cell; } @@ -586,8 +584,8 @@ class ImportMediawiki extends ImportPlugin */ private function _getCellContent($cell, $col_start_char) { - if (/*overload*/mb_strpos($cell, $col_start_char) === 0) { - $cell = trim(/*overload*/mb_substr($cell, 1)); + if (mb_strpos($cell, $col_start_char) === 0) { + $cell = trim(mb_substr($cell, 1)); } return $cell; diff --git a/libraries/plugins/import/ImportShp.php b/libraries/plugins/import/ImportShp.php index ab73334b85..9d590d0ebc 100644 --- a/libraries/plugins/import/ImportShp.php +++ b/libraries/plugins/import/ImportShp.php @@ -103,14 +103,11 @@ class ImportShp extends ImportPlugin $temp_dbf_file = true; // Replace the .dbf with .*, as required // by the bsShapeFiles library. - $file_name - = /*overload*/ - mb_substr( - $dbf_file_path, - 0, - /*overload*/ - mb_strlen($dbf_file_path) - 4 - ) . '.*'; + $file_name = mb_substr( + $dbf_file_path, + 0, + mb_strlen($dbf_file_path) - 4 + ) . '.*'; $shp->FileName = $file_name; } } @@ -122,14 +119,11 @@ class ImportShp extends ImportPlugin // to load extra data. // Replace the .shp with .*, // so the bsShapeFiles library correctly locates .dbf file. - $file_name - = /*overload*/ - mb_substr( - $import_file, - 0, - /*overload*/ - mb_strlen($import_file) - 4 - ) . '.*'; + $file_name = mb_substr( + $import_file, + 0, + mb_strlen($import_file) - 4 + ) . '.*'; $shp->FileName = $file_name; } } @@ -265,7 +259,7 @@ class ImportShp extends ImportPlugin } // Set table name based on the number of tables - if (/*overload*/mb_strlen($db)) { + if (mb_strlen($db)) { $result = $GLOBALS['dbi']->fetchResult('SHOW TABLES'); $table_name = 'TABLE ' . (count($result) + 1); } else { @@ -283,7 +277,7 @@ class ImportShp extends ImportPlugin $analyses[$table_no][FORMATTEDSQL][$spatial_col] = true; // Set database name to the currently selected one, if applicable - if (/*overload*/mb_strlen($db)) { + if (mb_strlen($db)) { $db_name = $db; $options = array('create_db' => false); } else { diff --git a/libraries/plugins/schema/dia/Dia.php b/libraries/plugins/schema/dia/Dia.php index 1060da8594..54f0deb108 100644 --- a/libraries/plugins/schema/dia/Dia.php +++ b/libraries/plugins/schema/dia/Dia.php @@ -181,9 +181,8 @@ class Dia extends XMLWriter PMA_downloadHeader( $fileName, 'application/x-dia-diagram', - /*overload*/ mb_strlen($output) ); print $output; } -} \ No newline at end of file +} diff --git a/libraries/plugins/schema/eps/Eps.php b/libraries/plugins/schema/eps/Eps.php index 622b837a67..84fdda68e1 100644 --- a/libraries/plugins/schema/eps/Eps.php +++ b/libraries/plugins/schema/eps/Eps.php @@ -270,9 +270,8 @@ class Eps PMA_downloadHeader( $fileName, 'image/x-eps', - /*overload*/ mb_strlen($output) ); print $output; } -} \ No newline at end of file +} diff --git a/libraries/plugins/schema/pdf/Pdf.php b/libraries/plugins/schema/pdf/Pdf.php index befcc4d9e7..ad4665b348 100644 --- a/libraries/plugins/schema/pdf/Pdf.php +++ b/libraries/plugins/schema/pdf/Pdf.php @@ -338,7 +338,7 @@ class Pdf extends PDF_lib } $wmax = ($w-2 * $this->cMargin) * 1000 / $this->FontSize; $s = str_replace("\r", '', $txt); - $nb = /*overload*/mb_strlen($s); + $nb = mb_strlen($s); if ($nb > 0 and $s[$nb-1] == "\n") { $nb--; } @@ -360,7 +360,7 @@ class Pdf extends PDF_lib if ($c == ' ') { $sep = $i; } - $l += isset($cw[/*overload*/mb_ord($c)])?$cw[/*overload*/mb_ord($c)]:0 ; + $l += isset($cw[mb_ord($c)])?$cw[mb_ord($c)]:0 ; if ($l > $wmax) { if ($sep == -1) { if ($i == $j) { @@ -393,4 +393,4 @@ class Pdf extends PDF_lib { $this->_offline = $value; } -} \ No newline at end of file +} diff --git a/libraries/plugins/schema/svg/Svg.php b/libraries/plugins/schema/svg/Svg.php index c880ec0e83..cb9e75c0ad 100644 --- a/libraries/plugins/schema/svg/Svg.php +++ b/libraries/plugins/schema/svg/Svg.php @@ -193,7 +193,6 @@ class Svg extends XMLWriter PMA_downloadHeader( $fileName, 'image/svg+xml', - /*overload*/ mb_strlen($output) ); print $output; diff --git a/libraries/plugins/transformations/abs/DateFormatTransformationsPlugin.php b/libraries/plugins/transformations/abs/DateFormatTransformationsPlugin.php index 47f53ecedb..238004284c 100644 --- a/libraries/plugins/transformations/abs/DateFormatTransformationsPlugin.php +++ b/libraries/plugins/transformations/abs/DateFormatTransformationsPlugin.php @@ -59,9 +59,7 @@ abstract class DateFormatTransformationsPlugin extends TransformationsPlugin if (empty($options[2])) { $options[2] = 'local'; } else { - $options[2] - = /*overload*/ - mb_strtolower($options[2]); + $options[2] = mb_strtolower($options[2]); } if (empty($options[1])) { @@ -87,26 +85,24 @@ abstract class DateFormatTransformationsPlugin extends TransformationsPlugin } else { if (preg_match('/^(\d{2}){3,7}$/', $buffer)) { - if (/*overload*/mb_strlen($buffer) == 14 - || /*overload*/mb_strlen($buffer) == 8 - ) { + if (mb_strlen($buffer) == 14 || mb_strlen($buffer) == 8) { $offset = 4; } else { $offset = 2; } $aDate = array(); - $aDate['year'] = (int)/*overload*/ + $aDate['year'] = (int) mb_substr($buffer, 0, $offset); - $aDate['month'] = (int)/*overload*/ + $aDate['month'] = (int) mb_substr($buffer, $offset, 2); - $aDate['day'] = (int)/*overload*/ + $aDate['day'] = (int) mb_substr($buffer, $offset + 2, 2); - $aDate['hour'] = (int)/*overload*/ + $aDate['hour'] = (int) mb_substr($buffer, $offset + 4, 2); - $aDate['minute'] = (int)/*overload*/ + $aDate['minute'] = (int) mb_substr($buffer, $offset + 6, 2); - $aDate['second'] = (int)/*overload*/ + $aDate['second'] = (int) mb_substr($buffer, $offset + 8, 2); if (checkdate($aDate['month'], $aDate['day'], $aDate['year'])) { diff --git a/libraries/plugins/transformations/abs/SubstringTransformationsPlugin.php b/libraries/plugins/transformations/abs/SubstringTransformationsPlugin.php index 432b673c4b..fcf48b00e0 100644 --- a/libraries/plugins/transformations/abs/SubstringTransformationsPlugin.php +++ b/libraries/plugins/transformations/abs/SubstringTransformationsPlugin.php @@ -50,25 +50,17 @@ abstract class SubstringTransformationsPlugin extends TransformationsPlugin $options = $this->getOptions($options, array(0, 'all', '…')); if ($options[1] != 'all') { - $newtext - = /*overload*/ - mb_substr( - $buffer, - $options[0], - $options[1] - ); + $newtext = mb_substr( + $buffer, + $options[0], + $options[1] + ); } else { - $newtext - = /*overload*/ - mb_substr($buffer, $options[0]); + $newtext = mb_substr($buffer, $options[0]); } - $length - = /*overload*/ - mb_strlen($newtext); - $baselength - = /*overload*/ - mb_strlen($buffer); + $length = mb_strlen($newtext); + $baselength = mb_strlen($buffer); if ($length != $baselength) { if ($options[0] != 0) { $newtext = $options[2] . $newtext; diff --git a/libraries/pmd_common.php b/libraries/pmd_common.php index ae512b4e4e..5b84015bf1 100644 --- a/libraries/pmd_common.php +++ b/libraries/pmd_common.php @@ -57,7 +57,7 @@ function PMA_getTablesInfo() $one_table['TABLE_NAME'], ENT_QUOTES ); - $GLOBALS['PMD']['TABLE_TYPE'][$i] = /*overload*/mb_strtoupper( + $GLOBALS['PMD']['TABLE_TYPE'][$i] = mb_strtoupper( $one_table['ENGINE'] ); @@ -533,9 +533,9 @@ function PMA_saveDisplayField($db, $table, $field) function PMA_addNewRelation($db, $T1, $F1, $T2, $F2, $on_delete, $on_update) { $tables = $GLOBALS['dbi']->getTablesFull($db, $T1); - $type_T1 = /*overload*/mb_strtoupper($tables[$T1]['ENGINE']); + $type_T1 = mb_strtoupper($tables[$T1]['ENGINE']); $tables = $GLOBALS['dbi']->getTablesFull($db, $T2); - $type_T2 = /*overload*/mb_strtoupper($tables[$T2]['ENGINE']); + $type_T2 = mb_strtoupper($tables[$T2]['ENGINE']); // native foreign key if (PMA\libraries\Util::isForeignKeySupported($type_T1) @@ -659,9 +659,9 @@ function PMA_removeRelation($T1, $F1, $T2, $F2) list($DB2, $T2) = explode(".", $T2); $tables = $GLOBALS['dbi']->getTablesFull($DB1, $T1); - $type_T1 = /*overload*/mb_strtoupper($tables[$T1]['ENGINE']); + $type_T1 = mb_strtoupper($tables[$T1]['ENGINE']); $tables = $GLOBALS['dbi']->getTablesFull($DB2, $T2); - $type_T2 = /*overload*/mb_strtoupper($tables[$T2]['ENGINE']); + $type_T2 = mb_strtoupper($tables[$T2]['ENGINE']); if (PMA\libraries\Util::isForeignKeySupported($type_T1) && PMA\libraries\Util::isForeignKeySupported($type_T2) diff --git a/libraries/relation.lib.php b/libraries/relation.lib.php index 2caf5c4de6..3fccc67df7 100644 --- a/libraries/relation.lib.php +++ b/libraries/relation.lib.php @@ -753,7 +753,7 @@ function PMA_getForeigners($db, $table, $column = '', $source = 'both') WHERE `master_db` = \'' . PMA\libraries\Util::sqlAddSlashes($db) . '\' AND `master_table` = \'' . PMA\libraries\Util::sqlAddSlashes($table) . '\' '; - if (/*overload*/mb_strlen($column)) { + if (mb_strlen($column)) { $rel_query .= ' AND `master_field` = ' . '\'' . PMA\libraries\Util::sqlAddSlashes($column) . '\''; } @@ -762,7 +762,7 @@ function PMA_getForeigners($db, $table, $column = '', $source = 'both') ); } - if (($source == 'both' || $source == 'foreign') && /*overload*/mb_strlen($table) + if (($source == 'both' || $source == 'foreign') && mb_strlen($table) ) { $tableObj = new Table($table, $db); $show_create_table = $tableObj->showCreate(); @@ -781,8 +781,8 @@ function PMA_getForeigners($db, $table, $column = '', $source = 'both') /** * Emulating relations for some information_schema tables */ - $isInformationSchema = /*overload*/mb_strtolower($db) == 'information_schema'; - $isMysql = /*overload*/mb_strtolower($db) == 'mysql'; + $isInformationSchema = mb_strtolower($db) == 'information_schema'; + $isMysql = mb_strtolower($db) == 'mysql'; if (($isInformationSchema || $isMysql) && ($source == 'internal' || $source == 'both') ) { @@ -795,9 +795,9 @@ function PMA_getForeigners($db, $table, $column = '', $source = 'both') } if (isset($GLOBALS[$relations_key][$table])) { foreach ($GLOBALS[$relations_key][$table] as $field => $relations) { - if ((! /*overload*/mb_strlen($column) || $column == $field) + if ((! mb_strlen($column) || $column == $field) && (! isset($foreign[$field]) - || ! /*overload*/mb_strlen($foreign[$field])) + || ! mb_strlen($foreign[$field])) ) { $foreign[$field] = $relations; } @@ -983,7 +983,7 @@ function PMA_setDbComment($db, $comment = '') return false; } - if (/*overload*/mb_strlen($comment)) { + if (mb_strlen($comment)) { $upd_query = 'INSERT INTO ' . PMA\libraries\Util::backquote($cfgRelation['db']) . '.' . PMA\libraries\Util::backquote($cfgRelation['column_info']) @@ -1029,7 +1029,7 @@ function PMA_setHistory($db, $table, $username, $sqlquery) $maxCharactersInDisplayedSQL = $GLOBALS['cfg']['MaxCharactersInDisplayedSQL']; // Prevent to run this automatically on Footer class destroying in testsuite if (defined('TESTSUITE') - || /*overload*/mb_strlen($sqlquery) > $maxCharactersInDisplayedSQL + || mb_strlen($sqlquery) > $maxCharactersInDisplayedSQL ) { return; } @@ -1198,14 +1198,14 @@ function PMA_buildForeignDropdown($foreign, $data, $mode) } foreach ($foreign as $key => $value) { - if (/*overload*/mb_strlen($value) <= $GLOBALS['cfg']['LimitChars'] + if (mb_strlen($value) <= $GLOBALS['cfg']['LimitChars'] ) { $vtitle = ''; $value = htmlspecialchars($value); } else { $vtitle = htmlspecialchars($value); $value = htmlspecialchars( - /*overload*/mb_substr( + mb_substr( $value, 0, $GLOBALS['cfg']['LimitChars'] ) . '...' ); diff --git a/libraries/replication.inc.php b/libraries/replication.inc.php index 0c808047af..f4a4cd4aa4 100644 --- a/libraries/replication.inc.php +++ b/libraries/replication.inc.php @@ -226,8 +226,8 @@ function PMA_extractDbOrTable($string, $what = 'db') */ function PMA_Replication_Slave_control($action, $control = null, $link = null) { - $action = /*overload*/mb_strtoupper($action); - $control = /*overload*/mb_strtoupper($control); + $action = mb_strtoupper($action); + $control = mb_strtoupper($control); if ($action != "START" && $action != "STOP") { return -1; diff --git a/libraries/replication_gui.lib.php b/libraries/replication_gui.lib.php index 476245d143..1f5f5086e6 100644 --- a/libraries/replication_gui.lib.php +++ b/libraries/replication_gui.lib.php @@ -686,7 +686,7 @@ function PMA_getHtmlForReplicationMasterAddSlaveuser() = PMA_replicationGetUsernameHostnameLength(); if (isset($_REQUEST['username']) - && /*overload*/mb_strlen($_REQUEST['username']) === 0 + && mb_strlen($_REQUEST['username']) === 0 ) { $GLOBALS['pred_username'] = 'any'; } @@ -711,9 +711,9 @@ function PMA_getHtmlForReplicationMasterAddSlaveuser() $thishost = str_replace( "'", '', - /*overload*/mb_substr( + mb_substr( $_current_user, - (/*overload*/mb_strrpos($_current_user, '@') + 1) + (mb_strrpos($_current_user, '@') + 1) ) ); if ($thishost == 'localhost' || $thishost == '127.0.0.1') { @@ -735,7 +735,7 @@ function PMA_getHtmlForReplicationMasterAddSlaveuser() // when we start editing a user, $GLOBALS['pred_hostname'] is not defined if (! isset($GLOBALS['pred_hostname']) && isset($_REQUEST['hostname'])) { - switch (/*overload*/mb_strtolower($_REQUEST['hostname'])) { + switch (mb_strtolower($_REQUEST['hostname'])) { case 'localhost': case '127.0.0.1': $GLOBALS['pred_hostname'] = 'localhost'; diff --git a/libraries/rte/rte_events.lib.php b/libraries/rte/rte_events.lib.php index 4b2dc2b4f6..cd446e886b 100644 --- a/libraries/rte/rte_events.lib.php +++ b/libraries/rte/rte_events.lib.php @@ -187,7 +187,7 @@ function PMA_EVN_handleEditor() $response->addJSON( 'name', htmlspecialchars( - /*overload*/mb_strtoupper($_REQUEST['item_name']) + mb_strtoupper($_REQUEST['item_name']) ) ); $response->addJSON('new_row', PMA_EVN_getRowForList($event)); @@ -336,7 +336,7 @@ function PMA_EVN_getEditorForm($mode, $operation, $item) { global $db, $table, $event_status, $event_type, $event_interval; - $modeToUpper = /*overload*/mb_strtoupper($mode); + $modeToUpper = mb_strtoupper($mode); // Escape special characters $need_escape = array( @@ -529,7 +529,7 @@ function PMA_EVN_getQueryFromRequest() $query = 'CREATE '; if (! empty($_REQUEST['item_definer'])) { - if (/*overload*/mb_strpos($_REQUEST['item_definer'], '@') !== false + if (mb_strpos($_REQUEST['item_definer'], '@') !== false ) { $arr = explode('@', $_REQUEST['item_definer']); $query .= 'DEFINER=' . PMA\libraries\Util::backquote($arr[0]); diff --git a/libraries/rte/rte_footer.lib.php b/libraries/rte/rte_footer.lib.php index dd969da638..c3252a2d4c 100644 --- a/libraries/rte/rte_footer.lib.php +++ b/libraries/rte/rte_footer.lib.php @@ -22,7 +22,7 @@ function PMA_RTE_getFooterLinks($docu, $priv, $name) { global $db, $table, $url_query, $ajax_class; - $icon = /*overload*/mb_strtolower($name) . '_add.png'; + $icon = mb_strtolower($name) . '_add.png'; $retval = ""; $retval .= "\n"; $retval .= "
\n"; @@ -30,7 +30,7 @@ function PMA_RTE_getFooterLinks($docu, $priv, $name) $retval .= "
\n"; if (PMA\libraries\Util::currentUserHasPrivilege($priv, $db, $table)) { $retval .= " array( 'label' => __('OFF'), diff --git a/libraries/rte/rte_main.inc.php b/libraries/rte/rte_main.inc.php index 4da4477ef9..5c45255c4f 100644 --- a/libraries/rte/rte_main.inc.php +++ b/libraries/rte/rte_main.inc.php @@ -47,7 +47,7 @@ if ($GLOBALS['is_ajax_request'] != true) { * to manually select the required database and * create the missing $url_query variable */ - if (/*overload*/mb_strlen($db)) { + if (mb_strlen($db)) { $GLOBALS['dbi']->selectDb($db); if (! isset($url_query)) { $url_query = PMA_URL_getCommon( diff --git a/libraries/rte/rte_routines.lib.php b/libraries/rte/rte_routines.lib.php index 5c024d7846..65611466cc 100644 --- a/libraries/rte/rte_routines.lib.php +++ b/libraries/rte/rte_routines.lib.php @@ -300,7 +300,6 @@ function PMA_RTN_handleRequestCreateOrEdit($errors, $db) $response->addJSON( 'name', htmlspecialchars( - /*overload*/ mb_strtoupper($_REQUEST['item_name']) ) ); @@ -540,7 +539,7 @@ function PMA_RTN_getDataFromRequest() $retval['item_isdeterministic'] = ''; if (isset($_REQUEST['item_isdeterministic']) - && /*overload*/mb_strtolower($_REQUEST['item_isdeterministic']) == 'on' + && mb_strtolower($_REQUEST['item_isdeterministic']) == 'on' ) { $retval['item_isdeterministic'] = " checked='checked'"; } @@ -877,7 +876,7 @@ function PMA_RTN_getEditorForm($mode, $operation, $routine) // Create the output $retval = ""; - $retval .= "\n\n"; $retval .= "
\n"; $retval .= "\n"; @@ -1066,7 +1065,7 @@ function PMA_RTN_getEditorForm($mode, $operation, $routine) $retval .= "
"; } $retval .= ""; - $retval .= ""; + $retval .= ""; return $retval; } // end PMA_RTN_getEditorForm() @@ -1085,7 +1084,7 @@ function PMA_RTN_getQueryFromRequest() $query = 'CREATE '; if (! empty($_REQUEST['item_definer'])) { - if (/*overload*/mb_strpos($_REQUEST['item_definer'], '@') !== false) { + if (mb_strpos($_REQUEST['item_definer'], '@') !== false) { $arr = explode('@', $_REQUEST['item_definer']); $query .= 'DEFINER=' . PMA\libraries\Util::backquote($arr[0]); $query .= '@' . PMA\libraries\Util::backquote($arr[1]) . ' '; @@ -1170,7 +1169,7 @@ function PMA_RTN_getQueryFromRequest() if (! empty($_REQUEST['item_param_opts_text'][$i])) { if ($PMA_Types->getTypeClass($item_param_type[$i]) == 'CHAR') { $params .= ' CHARSET ' - . /*overload*/mb_strtolower( + . mb_strtolower( $_REQUEST['item_param_opts_text'][$i] ); } @@ -1178,7 +1177,7 @@ function PMA_RTN_getQueryFromRequest() if (! empty($_REQUEST['item_param_opts_num'][$i])) { if ($PMA_Types->getTypeClass($item_param_type[$i]) == 'NUMBER') { $params .= ' ' - . /*overload*/mb_strtoupper( + . mb_strtoupper( $_REQUEST['item_param_opts_num'][$i] ); } @@ -1232,13 +1231,13 @@ function PMA_RTN_getQueryFromRequest() if (! empty($_REQUEST['item_returnopts_text'])) { if ($PMA_Types->getTypeClass($item_returntype) == 'CHAR') { $query .= ' CHARSET ' - . /*overload*/mb_strtolower($_REQUEST['item_returnopts_text']); + . mb_strtolower($_REQUEST['item_returnopts_text']); } } if (! empty($_REQUEST['item_returnopts_num'])) { if ($PMA_Types->getTypeClass($item_returntype) == 'NUMBER') { $query .= ' ' - . /*overload*/mb_strtoupper($_REQUEST['item_returnopts_num']); + . mb_strtoupper($_REQUEST['item_returnopts_num']); } } $query .= ' '; @@ -1609,14 +1608,14 @@ function PMA_RTN_getExecuteForm($routine) if (stristr($routine['item_param_type'][$i], 'enum') || stristr($routine['item_param_type'][$i], 'set') || in_array( - /*overload*/mb_strtolower($routine['item_param_type'][$i]), + mb_strtolower($routine['item_param_type'][$i]), $no_support_types ) ) { $retval .= "--\n"; } else { $field = array( - 'True_Type' => /*overload*/mb_strtolower( + 'True_Type' => mb_strtolower( $routine['item_param_type'][$i] ), 'Type' => '', @@ -1658,7 +1657,7 @@ function PMA_RTN_getExecuteForm($routine) . $value . "
\n"; } } else if (in_array( - /*overload*/mb_strtolower($routine['item_param_type'][$i]), + mb_strtolower($routine['item_param_type'][$i]), $no_support_types )) { $retval .= "\n"; diff --git a/libraries/rte/rte_triggers.lib.php b/libraries/rte/rte_triggers.lib.php index 64fd970d63..fc077ad501 100644 --- a/libraries/rte/rte_triggers.lib.php +++ b/libraries/rte/rte_triggers.lib.php @@ -174,7 +174,7 @@ function PMA_TRI_handleEditor() $response->addJSON( 'name', htmlspecialchars( - /*overload*/mb_strtoupper( + mb_strtoupper( $_REQUEST['item_name'] ) ) @@ -292,7 +292,7 @@ function PMA_TRI_getEditorForm($mode, $item) { global $db, $table, $event_manipulations, $action_timings; - $modeToUpper = /*overload*/mb_strtoupper($mode); + $modeToUpper = mb_strtoupper($mode); // Escape special characters $need_escape = array( @@ -415,7 +415,7 @@ function PMA_TRI_getQueryFromRequest() $query = 'CREATE '; if (! empty($_REQUEST['item_definer'])) { - if (/*overload*/mb_strpos($_REQUEST['item_definer'], '@') !== false + if (mb_strpos($_REQUEST['item_definer'], '@') !== false ) { $arr = explode('@', $_REQUEST['item_definer']); $query .= 'DEFINER=' . PMA\libraries\Util::backquote($arr[0]); diff --git a/libraries/sanitizing.lib.php b/libraries/sanitizing.lib.php index a2d3eb3285..6b766fbd56 100644 --- a/libraries/sanitizing.lib.php +++ b/libraries/sanitizing.lib.php @@ -27,7 +27,7 @@ function PMA_checkLink($url) $valid_starts[] = '?page=servers&'; } foreach ($valid_starts as $val) { - if (/*overload*/mb_substr($url, 0, /*overload*/mb_strlen($val)) == $val) { + if (mb_substr($url, 0, mb_strlen($val)) == $val) { return true; } } diff --git a/libraries/select_lang.lib.php b/libraries/select_lang.lib.php index 8ce3e50e5d..a3f4a04699 100644 --- a/libraries/select_lang.lib.php +++ b/libraries/select_lang.lib.php @@ -16,7 +16,7 @@ function PMA_languageName($tmplang) { $lang_name = ucfirst( - /*overload*/mb_substr(/*overload*/mb_strrchr($tmplang[0], '|'), 1) + mb_substr(mb_strrchr($tmplang[0], '|'), 1) ); // Include native name if non empty @@ -84,7 +84,7 @@ function PMA_langCheck() // prevent XSS $accepted_languages = PMA_getenv('HTTP_ACCEPT_LANGUAGE'); if ($accepted_languages - && false === /*overload*/mb_strpos($accepted_languages, '<') + && false === mb_strpos($accepted_languages, '<') ) { foreach (explode(',', $accepted_languages) as $lang) { if (PMA_langDetect($lang, 1)) { @@ -154,7 +154,7 @@ function PMA_langDetect($str, $envType) // $envType = 1 for the 'HTTP_ACCEPT_LANGUAGE' environment variable, // 2 for the 'HTTP_USER_AGENT' one $expr = $value[0]; - if (/*overload*/mb_strpos($expr, '[-_]') === false) { + if (mb_strpos($expr, '[-_]') === false) { $expr = str_replace('|', '([-_][[:alpha:]]{2,3})?|', $expr); } $pattern1 = '/^(' . addcslashes($expr, '/') . ')(;q=[0-9]\\.[0-9])?$/i'; diff --git a/libraries/server_privileges.lib.php b/libraries/server_privileges.lib.php index ddacbfe5ba..a2dae63342 100644 --- a/libraries/server_privileges.lib.php +++ b/libraries/server_privileges.lib.php @@ -52,10 +52,10 @@ function PMA_getHtmlForUserGroupDialog($username, $is_menuswork) */ function PMA_wildcardEscapeForGrant($dbname, $tablename) { - if (!/*overload*/mb_strlen($dbname)) { + if (!mb_strlen($dbname)) { $db_and_table = '*.*'; } else { - if (/*overload*/mb_strlen($tablename)) { + if (mb_strlen($tablename)) { $db_and_table = Util::backquote( Util::unescapeMysqlWildcards($dbname) ) @@ -85,7 +85,7 @@ function PMA_rangeOfUsers($initial = '') $ret = " WHERE `User` LIKE '" . Util::sqlAddSlashes($initial, true) . "%'" . " OR `User` LIKE '" - . Util::sqlAddSlashes(/*overload*/mb_strtolower($initial), true) + . Util::sqlAddSlashes(mb_strtolower($initial), true) . "%'"; return $ret; } // end function @@ -128,11 +128,11 @@ function PMA_fillInTablePrivileges(&$row) $av_grants = explode( '\',\'', - /*overload*/mb_substr( + mb_substr( $row1['Type'], - /*overload*/mb_strpos($row1['Type'], '(') + 2, - /*overload*/mb_strpos($row1['Type'], ')') - - /*overload*/mb_strpos($row1['Type'], '(') - 3 + mb_strpos($row1['Type'], '(') + 2, + mb_strpos($row1['Type'], ')') + - mb_strpos($row1['Type'], '(') - 3 ) ); @@ -1187,10 +1187,10 @@ function PMA_getHtmlForNotAttachedPrivilegesToTableSpecificColumn($row) . 'title="'; $privGlobalName = 'strPrivDesc' - . /*overload*/mb_substr( + . mb_substr( $tmp_current_grant, 0, - (/*overload*/mb_strlen($tmp_current_grant) - 5) + (mb_strlen($tmp_current_grant) - 5) ); $html_output .= (isset($GLOBALS[$privGlobalName]) ? $GLOBALS[$privGlobalName] @@ -1199,7 +1199,7 @@ function PMA_getHtmlForNotAttachedPrivilegesToTableSpecificColumn($row) . '"/>' . "\n"; $privGlobalName1 = 'strPrivDesc' - . /*overload*/mb_substr( + . mb_substr( $tmp_current_grant, 0, - 5 @@ -1211,8 +1211,8 @@ function PMA_getHtmlForNotAttachedPrivilegesToTableSpecificColumn($row) : $GLOBALS[$privGlobalName1 . 'Tbl'] ) . '">' - . /*overload*/mb_strtoupper( - /*overload*/mb_substr( + . mb_strtoupper( + mb_substr( $current_grant, 0, -5 @@ -1603,7 +1603,7 @@ function PMA_getHtmlForLoginInformationFields( list($username_length, $hostname_length) = PMA_getUsernameAndHostnameLength(); if (isset($GLOBALS['username']) - && /*overload*/mb_strlen($GLOBALS['username']) === 0 + && mb_strlen($GLOBALS['username']) === 0 ) { $GLOBALS['pred_username'] = 'any'; } @@ -1688,9 +1688,9 @@ function PMA_getHtmlForLoginInformationFields( $thishost = str_replace( "'", '', - /*overload*/mb_substr( + mb_substr( $_current_user, - (/*overload*/mb_strrpos($_current_user, '@') + 1) + (mb_strrpos($_current_user, '@') + 1) ) ); if ($thishost == 'localhost' || $thishost == '127.0.0.1') { @@ -1721,7 +1721,7 @@ function PMA_getHtmlForLoginInformationFields( // when we start editing a user, $GLOBALS['pred_hostname'] is not defined if (! isset($GLOBALS['pred_hostname']) && isset($GLOBALS['hostname'])) { - switch (/*overload*/mb_strtolower($GLOBALS['hostname'])) { + switch (mb_strtolower($GLOBALS['hostname'])) { case 'localhost': case '127.0.0.1': $GLOBALS['pred_hostname'] = 'localhost'; @@ -3009,7 +3009,7 @@ function PMA_getExtraDataForAjaxBehavior( } $extra_data = array(); - if (/*overload*/mb_strlen($sql_query)) { + if (mb_strlen($sql_query)) { $extra_data['sql_query'] = Util::getMessage(null, $sql_query); } @@ -3092,8 +3092,8 @@ function PMA_getExtraDataForAjaxBehavior( * Generate the string for this alphabet's initial, to update the user * pagination */ - $new_user_initial = /*overload*/mb_strtoupper( - /*overload*/mb_substr($username, 0, 1) + $new_user_initial = mb_strtoupper( + mb_substr($username, 0, 1) ); $newUserInitialString = '
' @@ -3214,7 +3214,7 @@ function PMA_getLinkToDbAndTable($url_dbname, $dbname, $tablename) ) . " ]\n"; - if (/*overload*/mb_strlen($tablename)) { + if (mb_strlen($tablename)) { $html_output .= ' [ ' . __('Table') . ' array(), 'sum' => array()); while ($row = $GLOBALS['dbi']->fetchAssoc($result)) { - $type = /*overload*/mb_strtolower( - /*overload*/mb_substr( + $type = mb_strtolower( + mb_substr( $row['sql_text'], 0, - /*overload*/mb_strpos($row['sql_text'], ' ') + mb_strpos($row['sql_text'], ' ') ) ); @@ -584,14 +584,14 @@ function PMA_getJsonForLogDataTypeSlow($start, $end) case 'insert': case 'update': //Cut off big inserts and updates, but append byte count instead - if (/*overload*/mb_strlen($row['sql_text']) > 220) { + if (mb_strlen($row['sql_text']) > 220) { $implode_sql_text = implode( ' ', PMA\libraries\Util::formatByteDown( - /*overload*/mb_strlen($row['sql_text']), 2, 2 + mb_strlen($row['sql_text']), 2, 2 ) ); - $row['sql_text'] = /*overload*/mb_substr($row['sql_text'], 0, 200) + $row['sql_text'] = mb_substr($row['sql_text'], 0, 200) . '... [' . $implode_sql_text . ']'; } break; @@ -648,7 +648,7 @@ function PMA_getJsonForLogDataTypeGeneral($start, $end) while ($row = $GLOBALS['dbi']->fetchAssoc($result)) { preg_match('/^(\w+)\s/', $row['argument'], $match); - $type = /*overload*/mb_strtolower($match[1]); + $type = mb_strtolower($match[1]); if (! isset($return['sum'][$type])) { $return['sum'][$type] = 0; @@ -675,7 +675,7 @@ function PMA_getJsonForLogDataTypeGeneral($start, $end) $temp = $return['rows'][$insertTablesFirst]['argument']; $return['rows'][$insertTablesFirst]['argument'] .= PMA_getSuspensionPoints( - $temp[/*overload*/mb_strlen($temp) - 1] + $temp[mb_strlen($temp) - 1] ); // Group this value, thus do not add to the result list @@ -690,13 +690,13 @@ function PMA_getJsonForLogDataTypeGeneral($start, $end) case 'update': // Cut off big inserts and updates, // but append byte count therefor - if (/*overload*/mb_strlen($row['argument']) > 220) { - $row['argument'] = /*overload*/mb_substr($row['argument'], 0, 200) + if (mb_strlen($row['argument']) > 220) { + $row['argument'] = mb_substr($row['argument'], 0, 200) . '... [' . implode( ' ', PMA\libraries\Util::formatByteDown( - /*overload*/mb_strlen($row['argument']), + mb_strlen($row['argument']), 2, 2 ) @@ -775,7 +775,7 @@ function PMA_getJsonForQueryAnalyzer() { $return = array(); - if (/*overload*/mb_strlen($_REQUEST['database'])) { + if (mb_strlen($_REQUEST['database'])) { $GLOBALS['dbi']->selectDb($_REQUEST['database']); } diff --git a/libraries/server_status_processes.lib.php b/libraries/server_status_processes.lib.php index 8af3d71a24..ff065dc3d7 100644 --- a/libraries/server_status_processes.lib.php +++ b/libraries/server_status_processes.lib.php @@ -255,7 +255,7 @@ function PMA_getHtmlForServerProcessItem($process, $odd_row, $show_full_sql) || (! empty($_REQUEST['showExecuting'])) ) { foreach (array_keys($process) as $key) { - $new_key = ucfirst(/*overload*/mb_strtolower($key)); + $new_key = ucfirst(mb_strtolower($key)); if ($new_key !== $key) { $process[$new_key] = $process[$key]; unset($process[$key]); @@ -276,7 +276,7 @@ function PMA_getHtmlForServerProcessItem($process, $odd_row, $show_full_sql) $retval .= '' . htmlspecialchars($process['User']) . ''; $retval .= '' . htmlspecialchars($process['Host']) . ''; $retval .= '' . ((! isset($process['db']) - || !/*overload*/mb_strlen($process['db'])) + || !mb_strlen($process['db'])) ? '' . __('None') . '' : htmlspecialchars($process['db'])) . ''; $retval .= '' . htmlspecialchars($process['Command']) . ''; diff --git a/libraries/server_status_variables.lib.php b/libraries/server_status_variables.lib.php index d63ab26fb6..98ab500f04 100644 --- a/libraries/server_status_variables.lib.php +++ b/libraries/server_status_variables.lib.php @@ -233,7 +233,7 @@ function PMA_getHtmlForRenderVariables($ServerStatusData, $alerts, $strShowStatu $retval .= htmlspecialchars(str_replace('_', ' ', $name)); // Fields containing % are calculated, // they can not be described in MySQL documentation - if (/*overload*/mb_strpos($name, '%') === false) { + if (mb_strpos($name, '%') === false) { $retval .= PMA\libraries\Util::showMySQLDocu( 'server-status-variables', false, diff --git a/libraries/server_user_groups.lib.php b/libraries/server_user_groups.lib.php index 6a96276617..32c85189e2 100644 --- a/libraries/server_user_groups.lib.php +++ b/libraries/server_user_groups.lib.php @@ -256,13 +256,13 @@ function PMA_getHtmlToEditUserGroup($userGroup = null) $key = $row['tab']; $value = $row['allowed']; if (substr($key, 0, 7) == 'server_' && $value == 'Y') { - $allowedTabs['server'][] = /*overload*/mb_substr($key, 7); + $allowedTabs['server'][] = mb_substr($key, 7); } elseif (substr($key, 0, 3) == 'db_' && $value == 'Y') { - $allowedTabs['db'][] = /*overload*/mb_substr($key, 3); + $allowedTabs['db'][] = mb_substr($key, 3); } elseif (substr($key, 0, 6) == 'table_' && $value == 'Y' ) { - $allowedTabs['table'][] = /*overload*/mb_substr($key, 6); + $allowedTabs['table'][] = mb_substr($key, 6); } } } diff --git a/libraries/sql.lib.php b/libraries/sql.lib.php index b31e588405..6d7dd1b33d 100644 --- a/libraries/sql.lib.php +++ b/libraries/sql.lib.php @@ -1051,7 +1051,7 @@ function PMA_getNumberOfRowsAffectedOrChanged($is_affected, $result) */ function PMA_hasCurrentDbChanged($db) { - if (/*overload*/mb_strlen($db)) { + if (mb_strlen($db)) { $current_db = $GLOBALS['dbi']->fetchValue('SELECT DATABASE()'); // $current_db is false, except when a USE statement was sent return ($current_db != false) && ($db !== $current_db); @@ -1074,9 +1074,9 @@ function PMA_cleanupRelations($db, $table, $column, $purge) { include_once 'libraries/relation_cleanup.lib.php'; - if (! empty($purge) && /*overload*/mb_strlen($db)) { - if (/*overload*/mb_strlen($table)) { - if (isset($column) && /*overload*/mb_strlen($column)) { + if (! empty($purge) && mb_strlen($db)) { + if (mb_strlen($table)) { + if (isset($column) && mb_strlen($column)) { PMA_relationsCleanupColumn($db, $table, $column); } else { PMA_relationsCleanupTable($db, $table); @@ -1262,8 +1262,8 @@ function PMA_executeTheQuery($analyzed_sql_results, $full_sql_query, $is_gotofil ); if (isset($_REQUEST['dropped_column']) - && /*overload*/mb_strlen($db) - && /*overload*/mb_strlen($table) + && mb_strlen($db) + && mb_strlen($table) ) { // to refresh the list of indexes (Ajax mode) $extra_data['indexes_list'] = PMA\libraries\Index::getHtmlForIndexes( diff --git a/libraries/sql_query_form.lib.php b/libraries/sql_query_form.lib.php index 4dc04b57f3..35ee7b701c 100644 --- a/libraries/sql_query_form.lib.php +++ b/libraries/sql_query_form.lib.php @@ -59,11 +59,11 @@ function PMA_getHtmlForSqlQueryForm( $table = ''; $db = ''; - if (! /*overload*/mb_strlen($GLOBALS['db'])) { + if (! mb_strlen($GLOBALS['db'])) { // prepare for server related $goto = empty($GLOBALS['goto']) ? 'server_sql.php' : $GLOBALS['goto']; - } elseif (! /*overload*/mb_strlen($GLOBALS['table'])) { + } elseif (! mb_strlen($GLOBALS['table'])) { // prepare for db related $db = $GLOBALS['db']; $goto = empty($GLOBALS['goto']) ? @@ -130,7 +130,7 @@ function PMA_getHtmlForSqlQueryForm( function PMA_initQueryForm($query) { $columns_list = array(); - if (! /*overload*/mb_strlen($GLOBALS['db'])) { + if (! mb_strlen($GLOBALS['db'])) { // prepare for server related $legend = sprintf( __('Run SQL query/queries on server %s'), @@ -140,7 +140,7 @@ function PMA_initQueryForm($query) : $GLOBALS['cfg']['Servers'][$GLOBALS['server']]['host'] ) . '"' ); - } elseif (! /*overload*/mb_strlen($GLOBALS['table'])) { + } elseif (! mb_strlen($GLOBALS['table'])) { // prepare for db related $db = $GLOBALS['db']; // if you want navigation: @@ -271,7 +271,7 @@ function PMA_getHtmlForSqlQueryFormInsert( . PMA\libraries\Util::backquote(htmlspecialchars($field['Field'])) . '"'; if (isset($field['Field']) - && /*overload*/mb_strlen($field['Field']) + && mb_strlen($field['Field']) && isset($field['Comment']) ) { $html .= ' title="' . htmlspecialchars($field['Comment']) . '"'; diff --git a/libraries/tbl_columns_definition_form.inc.php b/libraries/tbl_columns_definition_form.inc.php index 4835ca2f0a..1dc5abeb1f 100644 --- a/libraries/tbl_columns_definition_form.inc.php +++ b/libraries/tbl_columns_definition_form.inc.php @@ -326,15 +326,11 @@ for ($columnNumber = 0; $columnNumber < $num_fields; $columnNumber++) { // old column type if (isset($columnMeta['Type'])) { // keep in uppercase because the new type will be in uppercase - $form_params['field_type_orig[' . $columnNumber . ']'] - = /*overload*/ - mb_strtoupper($type); + $form_params['field_type_orig[' . $columnNumber . ']'] = mb_strtoupper($type); if (isset($columnMeta['column_status']) && !$columnMeta['column_status']['isEditable'] ) { - $form_params['field_type[' . $columnNumber . ']'] - = /*overload*/ - mb_strtoupper($type); + $form_params['field_type[' . $columnNumber . ']'] = mb_strtoupper($type); } } else { $form_params['field_type_orig[' . $columnNumber . ']'] = ''; @@ -381,7 +377,7 @@ for ($columnNumber = 0; $columnNumber < $num_fields; $columnNumber++) { $content_cells[$columnNumber] = array( 'columnNumber' => $columnNumber, 'columnMeta' => $columnMeta, - 'type_upper' => /*overload*/mb_strtoupper($type), + 'type_upper' => mb_strtoupper($type), 'length_values_input_size' => $length_values_input_size, 'length' => $length, 'extracted_columnspec' => $extracted_columnspec, diff --git a/libraries/tbl_info.inc.php b/libraries/tbl_info.inc.php index 752af2c604..1ce1e84b94 100644 --- a/libraries/tbl_info.inc.php +++ b/libraries/tbl_info.inc.php @@ -63,7 +63,7 @@ if ($showtable) { } else { $tbl_is_view = false; $tbl_storage_engine = isset($showtable['Engine']) - ? /*overload*/mb_strtoupper($showtable['Engine']) + ? mb_strtoupper($showtable['Engine']) : ''; $show_comment = ''; if (isset($showtable['Comment'])) { @@ -100,7 +100,7 @@ if ($showtable) { } } // we need explicit DEFAULT value here (different from '0') - $pack_keys = (! isset($pack_keys) || /*overload*/mb_strlen($pack_keys) == 0) + $pack_keys = (! isset($pack_keys) || mb_strlen($pack_keys) == 0) ? 'DEFAULT' : $pack_keys; unset($create_options, $each_create_option); diff --git a/libraries/tracking.lib.php b/libraries/tracking.lib.php index de734088ab..6fc9f4253b 100644 --- a/libraries/tracking.lib.php +++ b/libraries/tracking.lib.php @@ -84,25 +84,25 @@ function PMA_getHtmlForDataDefinitionAndManipulationStatements($url_query, if ($type == 'both' || $type == 'table') { $html .= ' ALTER TABLE
'; $html .= ' RENAME TABLE
'; $html .= ' CREATE TABLE
'; $html .= ' ALTER VIEW
'; $html .= ' CREATE VIEW
'; $html .= ' CREATE INDEX
'; $html .= ' DROP INDEX
'; $html .= '

' . __('Track these data manipulation statements:') . '

'; $html .= ' INSERT
'; $html .= ' UPDATE
'; $html .= ' DELETE
'; $html .= ' 1 + if (mb_strlen($trimmed) > 1 && $trimmed[0] == "'" - && $trimmed[/*overload*/mb_strlen($trimmed) - 1] == "'" + && $trimmed[mb_strlen($trimmed) - 1] == "'" ) { // '...' - $option = /*overload*/mb_substr($trimmed, 1, -1); + $option = mb_substr($trimmed, 1, -1); } elseif (isset($trimmed[0]) && $trimmed[0] == "'") { // '..., $trimmed = ltrim($option); @@ -62,12 +62,12 @@ function PMA_Transformation_getOptions($option_string) // ..., $trimmed .= ',' . $option; $rtrimmed = rtrim($trimmed); - if ($rtrimmed[/*overload*/mb_strlen($rtrimmed) - 1] == "'") { + if ($rtrimmed[mb_strlen($rtrimmed) - 1] == "'") { // ,...' break; } } - $option = /*overload*/mb_substr($rtrimmed, 1, -1); + $option = mb_substr($rtrimmed, 1, -1); } $result[] = stripslashes($option); } @@ -313,8 +313,8 @@ function PMA_setMIME($db, $table, $key, $mimetype, $transformation, } // lowercase mimetype & transformation - $mimetype = /*overload*/mb_strtolower($mimetype); - $transformation = /*overload*/mb_strtolower($transformation); + $mimetype = mb_strtolower($mimetype); + $transformation = mb_strtolower($transformation); $test_qry = ' SELECT `mimetype`, @@ -333,11 +333,11 @@ function PMA_setMIME($db, $table, $key, $mimetype, $transformation, $row = @$GLOBALS['dbi']->fetchAssoc($test_rs); $GLOBALS['dbi']->freeResult($test_rs); - $transformationLength = /*overload*/mb_strlen($transformation); + $transformationLength = mb_strlen($transformation); if (! $forcedelete - && (/*overload*/mb_strlen($mimetype) || $transformationLength - || /*overload*/mb_strlen($transformationOpts) - || /*overload*/mb_strlen($row['comment'])) + && (mb_strlen($mimetype) || $transformationLength + || mb_strlen($transformationOpts) + || mb_strlen($row['comment'])) ) { $upd_query = 'UPDATE ' . PMA\libraries\Util::backquote($cfgRelation['db']) . '.' @@ -364,9 +364,9 @@ function PMA_setMIME($db, $table, $key, $mimetype, $transformation, . '\' AND `column_name` = \'' . PMA\libraries\Util::sqlAddSlashes($key) . '\''; - } elseif (/*overload*/mb_strlen($mimetype) - || /*overload*/mb_strlen($transformation) - || /*overload*/mb_strlen($transformationOpts) + } elseif (mb_strlen($mimetype) + || mb_strlen($transformation) + || mb_strlen($transformationOpts) ) { $upd_query = 'INSERT INTO ' diff --git a/libraries/url_generating.lib.php b/libraries/url_generating.lib.php index acdb5fdeea..3bcd1d7a6e 100644 --- a/libraries/url_generating.lib.php +++ b/libraries/url_generating.lib.php @@ -36,10 +36,10 @@ function PMA_URL_getHiddenInputs($db = '', $table = '', $skip =& $_skip; } else { $params = array(); - if (/*overload*/mb_strlen($db)) { + if (mb_strlen($db)) { $params['db'] = $db; } - if (/*overload*/mb_strlen($table)) { + if (mb_strlen($table)) { $params['table'] = $table; } } @@ -226,9 +226,9 @@ function PMA_URL_getArgSeparator($encode = 'none') // (see http://www.w3.org/TR/1999/REC-html401-19991224/appendix // /notes.html#h-B.2.2) $arg_separator = ini_get('arg_separator.input'); - if (/*overload*/mb_strpos($arg_separator, ';') !== false) { + if (mb_strpos($arg_separator, ';') !== false) { $separator = ';'; - } elseif (/*overload*/mb_strlen($arg_separator) > 0) { + } elseif (mb_strlen($arg_separator) > 0) { $separator = $arg_separator{0}; } else { $separator = '&'; diff --git a/prefs_manage.php b/prefs_manage.php index c1a82aa4ef..ab69878b16 100644 --- a/prefs_manage.php +++ b/prefs_manage.php @@ -177,12 +177,12 @@ if (isset($_POST['submit_export']) $return_url = parse_url($return_url, PHP_URL_PATH); foreach ($query as $q) { - $pos = /*overload*/mb_strpos($q, '='); - $k = /*overload*/mb_substr($q, 0, $pos); + $pos = mb_strpos($q, '='); + $k = mb_substr($q, 0, $pos); if ($k == 'token') { continue; } - $params[$k] = /*overload*/mb_substr($q, $pos + 1); + $params[$k] = mb_substr($q, $pos + 1); } } else { $return_url = 'prefs_manage.php'; diff --git a/setup/frames/index.inc.php b/setup/frames/index.inc.php index 2a1c01aece..545a4bb0ce 100644 --- a/setup/frames/index.inc.php +++ b/setup/frames/index.inc.php @@ -69,7 +69,7 @@ if (!$config_writable || !$config_readable) { // Check https connection // $is_https = !empty($_SERVER['HTTPS']) - && /*overload*/mb_strtolower($_SERVER['HTTPS']) == 'on'; + && mb_strtolower($_SERVER['HTTPS']) == 'on'; if (!$is_https) { $text = __( 'You are not using a secure connection; all data (including potentially ' diff --git a/setup/lib/ConfigGenerator.php b/setup/lib/ConfigGenerator.php index 7b8da909a2..4476ca132c 100644 --- a/setup/lib/ConfigGenerator.php +++ b/setup/lib/ConfigGenerator.php @@ -58,7 +58,7 @@ class ConfigGenerator } // keep 1d array keys which are present in $persist_keys (config.values.php) foreach (array_keys($persistKeys) as $k) { - if (/*overload*/mb_strpos($k, '/') === false) { + if (mb_strpos($k, '/') === false) { $k = preg_replace('/[^A-Za-z0-9_]/', '_', $k); $ret .= self::_getVarExport($k, $cf->getDefault($k), $crlf); } diff --git a/sql.php b/sql.php index 9d356afe28..a569b04dd7 100644 --- a/sql.php +++ b/sql.php @@ -61,8 +61,8 @@ if (empty($goto)) { if (! isset($err_url)) { $err_url = (! empty($back) ? $back : $goto) . '?' . PMA_URL_getCommon(array('db' => $GLOBALS['db'])) - . ((/*overload*/mb_strpos(' ' . $goto, 'db_') != 1 - && /*overload*/mb_strlen($table)) + . ((mb_strpos(' ' . $goto, 'db_') != 1 + && mb_strlen($table)) ? '&table=' . urlencode($table) : '' ); @@ -122,8 +122,8 @@ if (isset($_REQUEST['set_col_prefs']) && $_REQUEST['set_col_prefs'] == true) { // Default to browse if no query set and we have table // (needed for browsing from DefaultTabTable) -$tableLength = /*overload*/mb_strlen($table); -$dbLength = /*overload*/mb_strlen($db); +$tableLength = mb_strlen($table); +$dbLength = mb_strlen($db); if (empty($sql_query) && $tableLength && $dbLength) { $sql_query = PMA_getDefaultSqlQueryForBrowse($db, $table); diff --git a/tbl_addfield.php b/tbl_addfield.php index 319ac521f8..18455dc899 100644 --- a/tbl_addfield.php +++ b/tbl_addfield.php @@ -70,7 +70,7 @@ if (isset($_REQUEST['do_save_data'])) { ) { foreach ($_REQUEST['field_mimetype'] as $fieldindex => $mimetype) { if (isset($_REQUEST['field_name'][$fieldindex]) - && /*overload*/mb_strlen($_REQUEST['field_name'][$fieldindex]) + && mb_strlen($_REQUEST['field_name'][$fieldindex]) ) { PMA_setMIME( $db, $table, diff --git a/tbl_change.php b/tbl_change.php index 0690a842af..45461539cb 100644 --- a/tbl_change.php +++ b/tbl_change.php @@ -54,7 +54,7 @@ require_once 'libraries/file_listing.lib.php'; * (at this point, $GLOBALS['goto'] will be set but could be empty) */ if (empty($GLOBALS['goto'])) { - if (/*overload*/mb_strlen($table)) { + if (mb_strlen($table)) { // avoid a problem (see bug #2202709) $GLOBALS['goto'] = 'tbl_sql.php'; } else { diff --git a/tbl_create.php b/tbl_create.php index 79577fe5a9..c465c28cf7 100644 --- a/tbl_create.php +++ b/tbl_create.php @@ -16,7 +16,7 @@ require_once 'libraries/create_addfield.lib.php'; PMA\libraries\Util::checkParameters(array('db')); /* Check if database name is empty */ -if (/*overload*/mb_strlen($db) == 0) { +if (mb_strlen($db) == 0) { PMA\libraries\Util::mysqlDie( __('The database name is empty!'), '', false, 'index.php' ); @@ -73,7 +73,7 @@ if (isset($_REQUEST['do_save_data'])) { ) { foreach ($_REQUEST['field_mimetype'] as $fieldindex => $mimetype) { if (isset($_REQUEST['field_name'][$fieldindex]) - && /*overload*/mb_strlen($_REQUEST['field_name'][$fieldindex]) + && mb_strlen($_REQUEST['field_name'][$fieldindex]) ) { PMA_setMIME( $db, $table, diff --git a/tbl_get_field.php b/tbl_get_field.php index 90fc363092..3e21c870aa 100644 --- a/tbl_get_field.php +++ b/tbl_get_field.php @@ -52,6 +52,6 @@ if ($result === false) { PMA_downloadHeader( $table . '-' . $_GET['transform_key'] . '.bin', PMA_detectMIME($result), - /*overload*/mb_strlen($result, '8bit') + mb_strlen($result, '8bit') ); echo $result; diff --git a/tbl_operations.php b/tbl_operations.php index 3068edb387..ba3c0b3886 100644 --- a/tbl_operations.php +++ b/tbl_operations.php @@ -129,7 +129,7 @@ if (isset($_REQUEST['submitoptions'])) { } if (! empty($_REQUEST['new_tbl_storage_engine']) - && /*overload*/mb_strtolower($_REQUEST['new_tbl_storage_engine']) !== $tbl_storage_engine + && mb_strtolower($_REQUEST['new_tbl_storage_engine']) !== $tbl_storage_engine ) { $new_tbl_storage_engine = $_REQUEST['new_tbl_storage_engine']; // reset the globals for the new engine @@ -312,8 +312,8 @@ if (! $hideOrderTable) { */ $response->addHTML(PMA_getHtmlForMoveTable()); -if (/*overload*/mb_strstr($show_comment, '; InnoDB free') === false) { - if (/*overload*/mb_strstr($show_comment, 'InnoDB free') === false) { +if (mb_strstr($show_comment, '; InnoDB free') === false) { + if (mb_strstr($show_comment, 'InnoDB free') === false) { // only user entered comment $comment = $show_comment; } else { diff --git a/tbl_relation.php b/tbl_relation.php index 9c725831e2..f2f1a3bdac 100644 --- a/tbl_relation.php +++ b/tbl_relation.php @@ -46,10 +46,9 @@ $options_array = array( 'RESTRICT' => 'RESTRICT', ); $cfgRelation = PMA_getRelationsParam(); -$tbl_storage_engine = /*overload*/ - mb_strtoupper( - $dbi->getTable($db, $table)->getStatusInfo('Engine') - ); +$tbl_storage_engine = mb_strtoupper( + $dbi->getTable($db, $table)->getStatusInfo('Engine') +); $upd_query = new Table($table, $db, $dbi); $dependency_definitions = array( diff --git a/templates/columns_definitions/column_attribute.phtml b/templates/columns_definitions/column_attribute.phtml index a489c8f6a0..c279a14e94 100644 --- a/templates/columns_definitions/column_attribute.phtml +++ b/templates/columns_definitions/column_attribute.phtml @@ -19,7 +19,7 @@ $attribute = mb_strtoupper($attribute); id="field__">