gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Ref #16584 - Replace exit code ints by constants

Browse Source 
They where added in console version 5.1

Signed-off-by: William Desportes <williamdes@wdes.fr>
This commit is contained in:
William Desportes 2021-02-23 15:47:44 +01:00
parent a106fa6cfe
commit 66255ffbf9
No known key found for this signature in database
GPG Key ID: 90A0EF1B8251A889
2 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libraries/classes/Command/CacheWarmupCommand.php
View File

@ -55,7 +55,7 @@ final class CacheWarmupCommand extends Command
if ($input->getOption('twig') === true && $input->getOption('routing') === true) {
$output->writeln('Please specify --twig or --routing');
return 1;
return Command::FAILURE;
}
if ($input->getOption('twig') === true) {
@ -81,7 +81,7 @@ final class CacheWarmupCommand extends Command
}
$output->writeln('Warm up of all caches done.', OutputInterface::VERBOSITY_VERBOSE);
return 0;
return Command::SUCCESS;
}
private function warmUpRoutingCache(OutputInterface $output): int
@ -92,7 +92,7 @@ final class CacheWarmupCommand extends Command
if (is_file(Routing::ROUTES_CACHE_FILE)) {
$output->writeln('Warm up done.', OutputInterface::VERBOSITY_VERBOSE);
return 0;
return Command::SUCCESS;
}
$output->writeln(
sprintf(
@ -102,7 +102,7 @@ final class CacheWarmupCommand extends Command
OutputInterface::VERBOSITY_NORMAL
);
return 1;
return Command::FAILURE;
}
private function warmUpTwigCache(OutputInterface $output): int
@ -178,13 +178,13 @@ final class CacheWarmupCommand extends Command
// Store replacements in JSON
$handle = fopen($tmpDir . '/replace.json', 'w');
if ($handle === false) {
return 1;
return Command::FAILURE;
}
fwrite($handle, (string) json_encode($replacements));
fclose($handle);
$output->writeln('Warm up done.', OutputInterface::VERBOSITY_VERBOSE);
return 0;
return Command::SUCCESS;
}
}

6
libraries/classes/Command/SetVersionCommand.php
View File

@ -61,14 +61,12 @@ PHP;
$generatedClass = $this->getGeneratedClass($version);
if (! $this->writeGeneratedClassFile($generatedClass)) {
// failure
return 1;
return Command::FAILURE;
}
$output->writeln('PhpMyAdmin\Version class successfully generated!');
// success
return 0;
return Command::SUCCESS;
}
private function getGeneratedClass(string $version): string