';
$html_output .= '| ' . __('Inside tables:') . ' | ';
$html_output .= '';
@@ -480,7 +489,7 @@ class PMA_DbSearch
$html_output .= '';
$html_output .= '';
$html_output .= $this->_getResultDivs();
-
+
return $html_output;
}
diff --git a/libraries/Index.class.php b/libraries/Index.class.php
index 989b9d0556..078c7c5edd 100644
--- a/libraries/Index.class.php
+++ b/libraries/Index.class.php
@@ -96,6 +96,15 @@ class PMA_Index
$this->set($params);
}
+ /**
+ * Creates(if not already created) and returns the corresponding Index object
+ *
+ * @param string $schema database name
+ * @param string $table table name
+ * @param string $index_name index name
+ *
+ * @return object corresponding Index object
+ */
static public function singleton($schema, $table, $index_name = '')
{
PMA_Index::_loadIndexes($table, $schema);
@@ -193,6 +202,13 @@ class PMA_Index
}
}
+ /**
+ * Adds a list of columns to the index
+ *
+ * @param array $columns array containing details about the columns
+ *
+ * @return void
+ */
public function addColumns($columns)
{
$_columns = array();
@@ -234,6 +250,13 @@ class PMA_Index
return isset($this->_columns[$column]);
}
+ /**
+ * Sets index details
+ *
+ * @param array $params index details
+ *
+ * @return void
+ */
public function set($params)
{
if (isset($params['columns'])) {
@@ -276,21 +299,41 @@ class PMA_Index
}
}
+ /**
+ * Returns the number of columns of the index
+ *
+ * @return integer the number of the columns
+ */
public function getColumnCount()
{
return count($this->_columns);
}
+ /**
+ * Returns the index comment
+ *
+ * @return string index comment
+ */
public function getComment()
{
return $this->_comment;
}
+ /**
+ * Returns index remarks
+ *
+ * @return string index remarks
+ */
public function getRemarks()
{
return $this->_remarks;
}
+ /**
+ * Returns concatenated remarks and comment
+ *
+ * @return string concatenated remarks and comment
+ */
public function getComments()
{
$comments = $this->getRemarks();
@@ -302,11 +345,21 @@ class PMA_Index
return $comments;
}
+ /**
+ * Returns index type ((BTREE, SPATIAL, FULLTEXT, HASH, RTREE)
+ *
+ * @return string index type
+ */
public function getType()
{
return $this->_type;
}
+ /**
+ * Returns index choice (PRIMARY, UNIQUE, INDEX, SPATIAL, FULLTEXT)
+ *
+ * @return index choice
+ */
public function getChoice()
{
return $this->_choice;
@@ -328,6 +381,11 @@ class PMA_Index
);
}
+ /**
+ * Returns HTML for the index choice selector
+ *
+ * @return string HTML for the index choice selector
+ */
public function generateIndexSelector()
{
$html_options = '';
@@ -348,11 +406,24 @@ class PMA_Index
return $html_options;
}
+ /**
+ * Returns how the index is packed
+ *
+ * @return string how the index is packed
+ */
public function getPacked()
{
return $this->_packed;
}
+ /**
+ * Returns 'No'/false if the index is not packed,
+ * how the index is packed if packed
+ *
+ * @param boolean $as_text whether to output should be in text
+ *
+ * @return mixed how index is paked
+ */
public function isPacked($as_text = false)
{
if ($as_text) {
@@ -374,11 +445,23 @@ class PMA_Index
return $this->_packed;
}
+ /**
+ * Returns integer 0 if the index cannot contain duplicates, 1 if it can
+ *
+ * @return integer 0 if the index cannot contain duplicates, 1 if it can
+ */
public function getNonUnique()
{
return $this->_non_unique;
}
+ /**
+ * Returns whether the index is a 'Unique' index
+ *
+ * @param boolean $as_text whether to output should be in text
+ *
+ * @return mixed whether the index is a 'Unique' index
+ */
public function isUnique($as_text = false)
{
if ($as_text) {
@@ -396,16 +479,33 @@ class PMA_Index
return $r[$this->_non_unique];
}
+ /**
+ * Returns the name of the index
+ *
+ * @return string the name of the index
+ */
public function getName()
{
return $this->_name;
}
+ /**
+ * Sets the name of the index
+ *
+ * @param string $name index name
+ *
+ * @return void
+ */
public function setName($name)
{
$this->_name = (string) $name;
}
+ /**
+ * Returns the columns of the index
+ *
+ * @return array the columns of the index
+ */
public function getColumns()
{
return $this->_columns;
@@ -424,7 +524,7 @@ class PMA_Index
*/
static public function getView($table, $schema, $print_mode = false)
{
-
+
$common_functions = PMA_CommonFunctions::getInstance();
$indexes = PMA_Index::getFromTable($table, $schema);
@@ -508,7 +608,7 @@ class PMA_Index
$this_params['message_to_show'] = sprintf(
__('Index %s has been dropped'), $index->getName()
);
-
+
$js_msg = PMA_jsFormat(
'ALTER TABLE ' . $table . ' DROP INDEX '
. $index->getName() . ';'
diff --git a/libraries/database_interface.lib.php b/libraries/database_interface.lib.php
index c97aeae01d..5096f883c2 100644
--- a/libraries/database_interface.lib.php
+++ b/libraries/database_interface.lib.php
@@ -181,7 +181,7 @@ function PMA_DBI_try_query($query, $link = null, $options = 0,
* Run multi query statement and return results
*
* @param string $multi_query multi query statement to execute
- * @param mysqli $link mysqli object
+ * @param mysqli $link mysqli object
*
* @return mysqli_result collection | boolean(false)
*/
diff --git a/libraries/db_common.inc.php b/libraries/db_common.inc.php
index e4e7df0e40..e7b8a4295e 100644
--- a/libraries/db_common.inc.php
+++ b/libraries/db_common.inc.php
@@ -60,8 +60,9 @@ if (! isset($is_db) || ! $is_db) {
*/
if (isset($submitcollation) && !empty($db_collation)) {
list($db_charset) = explode('_', $db_collation);
- $sql_query = 'ALTER DATABASE ' . PMA_CommonFunctions::getInstance()->backquote($db) . ' DEFAULT'
- . PMA_generateCharsetQueryPart($db_collation);
+ $sql_query = 'ALTER DATABASE '
+ . PMA_CommonFunctions::getInstance()->backquote($db)
+ . ' DEFAULT' . PMA_generateCharsetQueryPart($db_collation);
$result = PMA_DBI_query($sql_query);
$message = PMA_Message::success();
unset($db_charset, $db_collation);
diff --git a/libraries/db_info.inc.php b/libraries/db_info.inc.php
index 2e83a9ac3f..c4a362bb51 100644
--- a/libraries/db_info.inc.php
+++ b/libraries/db_info.inc.php
@@ -42,9 +42,9 @@ $pos = $_SESSION['tmp_user_values']['table_limit_offset'];
*/
function PMA_fillTooltip(&$tooltip_truename, &$tooltip_aliasname, $table)
{
-
+
$common_functions = PMA_CommonFunctions::getInstance();
-
+
if (strstr($table['Comment'], '; InnoDB free') === false) {
if (!strstr($table['Comment'], 'InnoDB free') === false) {
// here we have just InnoDB generated part
@@ -169,7 +169,8 @@ if (true === $cfg['SkipLockedTables']) {
$sts_tmp['Type'] =& $sts_tmp['Engine'];
}
- if (! empty($tbl_group) && $cfg['ShowTooltipAliasTB']
+ if (! empty($tbl_group)
+ && $cfg['ShowTooltipAliasTB']
&& ! preg_match('@' . preg_quote($tbl_group, '@') . '@i', $sts_tmp['Comment'])
) {
continue;
diff --git a/libraries/display_import.lib.php b/libraries/display_import.lib.php
index ebf6758ffd..1e1e3244d4 100644
--- a/libraries/display_import.lib.php
+++ b/libraries/display_import.lib.php
@@ -226,13 +226,13 @@ if ($GLOBALS['is_upload'] && !empty($cfg['UploadDir'])) { ?>
getBrowseUploadFileBlock($max_upload_size);
+ echo $common_functions->getBrowseUploadFileBlock($max_upload_size);
?>
getSelectUploadFileBlock($import_list, $cfg['UploadDir']);
+ echo $common_functions->getSelectUploadFileBlock($import_list, $cfg['UploadDir']);
?>
diff --git a/libraries/import.lib.php b/libraries/import.lib.php
index 1bdcc1bd7d..1c8d7b1d20 100644
--- a/libraries/import.lib.php
+++ b/libraries/import.lib.php
@@ -77,12 +77,14 @@ function PMA_detectCompression($filepath)
* @param string $sql query to run
* @param string $full query to display, this might be commented
* @param bool $controluser whether to use control user for queries
+ * @param array &$sql_data
*
* @return void
* @access public
*/
-function PMA_importRunQuery($sql = '', $full = '', $controluser = false, &$sql_data = array())
-{
+function PMA_importRunQuery($sql = '', $full = '', $controluser = false,
+ &$sql_data = array()
+) {
global $import_run_buffer, $go_sql, $complete_query, $display_query,
$sql_query, $my_die, $error, $reload,
$last_query_with_results,
@@ -97,14 +99,14 @@ function PMA_importRunQuery($sql = '', $full = '', $controluser = false, &$sql_d
if (! empty($import_run_buffer['sql'])
&& trim($import_run_buffer['sql']) != ''
) {
-
+
// USE query changes the database, son need to track
// while running multiple queries
$is_use_query
= (stripos($import_run_buffer['sql'], "use ") !== false)
? true
: false;
-
+
$max_sql_len = max($max_sql_len, strlen($import_run_buffer['sql']));
if (! $sql_query_disabled) {
$sql_query .= $import_run_buffer['full'];
@@ -116,9 +118,9 @@ function PMA_importRunQuery($sql = '', $full = '', $controluser = false, &$sql_d
$GLOBALS['message'] = PMA_Message::error(__('"DROP DATABASE" statements are disabled.'));
$error = true;
} else {
-
+
$executed_queries++;
-
+
if ($run_query
&& $GLOBALS['finished']
&& empty($sql)
@@ -138,7 +140,7 @@ function PMA_importRunQuery($sql = '', $full = '', $controluser = false, &$sql_d
$sql_query = $import_run_buffer['sql'];
$sql_data['valid_sql'][] = $import_run_buffer['sql'];
$sql_data['valid_queries']++;
-
+
// If a 'USE ' SQL-clause was found,
// set our current $db to the new one
list($db, $reload) = PMA_lookForUse(
@@ -147,7 +149,7 @@ function PMA_importRunQuery($sql = '', $full = '', $controluser = false, &$sql_d
$reload
);
} elseif ($run_query) {
-
+
if ($controluser) {
$result = PMA_queryAsControlUser(
$import_run_buffer['sql']
@@ -155,7 +157,7 @@ function PMA_importRunQuery($sql = '', $full = '', $controluser = false, &$sql_d
} else {
$result = PMA_DBI_try_query($import_run_buffer['sql']);
}
-
+
$msg = '# ';
if ($result === false) { // execution failed
if (! isset($my_die)) {
@@ -184,12 +186,12 @@ function PMA_importRunQuery($sql = '', $full = '', $controluser = false, &$sql_d
} else {
$msg .= __('MySQL returned an empty result set (i.e. zero rows).');
}
-
+
if (($a_num_rows > 0) || $is_use_query) {
$sql_data['valid_sql'][] = $import_run_buffer['sql'];
$sql_data['valid_queries']++;
}
-
+
}
if (! $sql_query_disabled) {
$sql_query .= $msg . "\n";
@@ -915,9 +917,9 @@ $import_notice = null;
function PMA_buildSQL($db_name, &$tables, &$analyses = null,
&$additional_sql = null, $options = null
) {
-
+
$common_functions = PMA_CommonFunctions::getInstance();
-
+
/* Take care of the options */
if (isset($options['db_collation'])&& ! is_null($options['db_collation'])) {
$collation = $options['db_collation'];
diff --git a/libraries/plugins/auth/swekey/swekey.auth.lib.php b/libraries/plugins/auth/swekey/swekey.auth.lib.php
index def135d3ae..fd2b6c1b40 100644
--- a/libraries/plugins/auth/swekey/swekey.auth.lib.php
+++ b/libraries/plugins/auth/swekey/swekey.auth.lib.php
@@ -18,7 +18,9 @@ function Swekey_auth_check()
$_SESSION['SWEKEY']['ENABLED'] = (! empty($confFile) && file_exists($confFile));
// Load the swekey.conf file the first time
- if ($_SESSION['SWEKEY']['ENABLED'] && empty($_SESSION['SWEKEY']['CONF_LOADED'])) {
+ if ($_SESSION['SWEKEY']['ENABLED']
+ && empty($_SESSION['SWEKEY']['CONF_LOADED'])
+ ) {
$_SESSION['SWEKEY']['CONF_LOADED'] = true;
$_SESSION['SWEKEY']['VALID_SWEKEYS'] = array();
$valid_swekeys = explode("\n", @file_get_contents($confFile));
diff --git a/libraries/plugins/export/ExportLatex.class.php b/libraries/plugins/export/ExportLatex.class.php
index e5a52baaee..fa94e3c87f 100644
--- a/libraries/plugins/export/ExportLatex.class.php
+++ b/libraries/plugins/export/ExportLatex.class.php
@@ -347,11 +347,11 @@ class ExportLatex extends ExportPlugin
'\\caption{'
. $common_functions->expandUserString(
$GLOBALS['latex_data_continued_caption'],
- array(
- 'texEscape',
- get_class($this),
- 'libraries/plugins/export/' . get_class($this) . ".class.php"
- ),
+ array(
+ 'texEscape',
+ get_class($this),
+ 'libraries/plugins/export/' . get_class($this) . ".class.php"
+ ),
array('table' => $table, 'database' => $db)
)
. '} \\\\ '
diff --git a/libraries/plugins/import/ImportSql.class.php b/libraries/plugins/import/ImportSql.class.php
index 5f0f1e0b48..0b705772dc 100644
--- a/libraries/plugins/import/ImportSql.class.php
+++ b/libraries/plugins/import/ImportSql.class.php
@@ -115,7 +115,7 @@ class ImportSql extends ImportPlugin
/**
* Handles the whole import logic
*
- * @param &$sql_data array 2-element array with sql data
+ * @param array &$sql_data 2-element array with sql data
*
* @return void
*/
|