Possible XSS in chart page

This commit is contained in:
Herman van Rink 2011-07-30 16:24:26 +02:00
parent 490d614825
commit 66c0be92d7

View File

@ -102,10 +102,10 @@ url_query = '<?php echo $url_query;?>';
foreach ($keys as $idx => $key) {
if ($yaxis == -1 && (($idx == count($data[0]) - 1) || preg_match("/(date|time)/i", $key))) {
echo '<option value="' . $idx . '" selected>' . $key . '</option>';
echo '<option value="' . htmlspecialchars($idx) . '" selected>' . htmlspecialchars($key) . '</option>';
$yaxis=$idx;
} else {
echo '<option value="' . $idx . '">' . $key . '</option>';
echo '<option value="' . htmlspecialchars($idx) . '">' . htmlspecialchars($key) . '</option>';
}
}
@ -116,7 +116,7 @@ url_query = '<?php echo $url_query;?>';
<option value="columns"><?php echo __('The remaining columns'); ?></option>
<?php
foreach ($keys as $idx => $key) {
echo '<option>' . $key . '</option>';
echo '<option>' . htmlspecialchars($key) . '</option>';
}
?>
</select>