diff --git a/db_sql.php b/db_sql.php index c4418b4e7f..f5a17061f4 100644 --- a/db_sql.php +++ b/db_sql.php @@ -32,9 +32,13 @@ $back = 'db_sql.php'; /** * Query box, bookmark, insert data from textfile */ -PMA_sqlQueryForm( - true, false, - isset($_REQUEST['delimiter']) ? htmlspecialchars($_REQUEST['delimiter']) : ';' +$response->addHTML( + PMA_getHtmlForSqlQueryForm( + true, false, + isset($_REQUEST['delimiter']) + ? htmlspecialchars($_REQUEST['delimiter']) + : ';' + ) ); ?> diff --git a/libraries/sql_query_form.lib.php b/libraries/sql_query_form.lib.php index 8bd1f9b48d..5f1b58ebb2 100644 --- a/libraries/sql_query_form.lib.php +++ b/libraries/sql_query_form.lib.php @@ -22,7 +22,7 @@ require_once './libraries/file_listing.lib.php'; // used for file listing require_once './libraries/bookmark.lib.php'; // used for bookmarks /** - * Prints the sql query boxes + * return HTML for the sql query boxes * * @param boolean|string $query query to display in the textarea * or true to display last executed @@ -31,7 +31,7 @@ require_once './libraries/bookmark.lib.php'; // used for bookmarks * false if not inside querywindow * @param string $delimiter delimeter * - * @return void + * @return string * * @usedby server_sql.php * @usedby db_sql.php @@ -40,8 +40,9 @@ require_once './libraries/bookmark.lib.php'; // used for bookmarks * @usedby tbl_tracking.php * @usedby querywindow.php */ -function PMA_sqlQueryForm($query = true, $display_tab = false, $delimiter = ';') -{ +function PMA_getHtmlForSqlQueryForm( + $query = true, $display_tab = false, $delimiter = ';' +) { $html = ''; // check tab to display if inside querywindow if (! $display_tab) { @@ -81,18 +82,16 @@ function PMA_sqlQueryForm($query = true, $display_tab = false, $delimiter = ';') 'tbl_sql.php' : $GLOBALS['goto']; } - // start output if ($is_querywindow) { - ?> -