diff --git a/js/src/functions.js b/js/src/functions.js index 2f207f5fb3..d1fa52e0f8 100644 --- a/js/src/functions.js +++ b/js/src/functions.js @@ -1114,9 +1114,9 @@ AJAX.registerOnload('functions.js', function () { var checked = $this.prop('checked'); $checkbox.prop('checked', checked).trigger('change'); if (checked) { - $tr.addClass('marked'); + $tr.addClass('marked table-active'); } else { - $tr.removeClass('marked'); + $tr.removeClass('marked table-active'); } lastClickChecked = checked; @@ -1140,7 +1140,7 @@ AJAX.registerOnload('functions.js', function () { } $tr.parent().find('tr:not(.noclick)') .slice(start, end + 1) - .removeClass('marked') + .removeClass('marked table-active') .find(':checkbox') .prop('checked', false) .trigger('change'); @@ -1157,7 +1157,7 @@ AJAX.registerOnload('functions.js', function () { } $tr.parent().find('tr:not(.noclick)') .slice(start, end + 1) - .addClass('marked') + .addClass('marked table-active') .find(':checkbox') .prop('checked', true) .trigger('change'); @@ -4734,7 +4734,7 @@ $(document).on('change', checkboxesSel, Functions.checkboxesChanged); $(document).on('change', 'input.checkall_box', function () { var isChecked = $(this).is(':checked'); $(this.form).find(checkboxesSel).not('.row-hidden').prop('checked', isChecked) - .parents('tr').toggleClass('marked', isChecked); + .parents('tr').toggleClass('marked table-active', isChecked); }); $(document).on('click', '.checkall-filter', function () { diff --git a/js/src/server/privileges.js b/js/src/server/privileges.js index 6da1823f40..5bfc50ca32 100644 --- a/js/src/server/privileges.js +++ b/js/src/server/privileges.js @@ -167,7 +167,7 @@ AJAX.registerOnload('server/privileges.js', function () { $(this).remove(); // If this is the last user with this_user_initial, remove the link from #initials_table - if ($('#tableuserrights').find('input:checkbox[value^="' + thisUserInitial + '"], input:checkbox[value^="' + thisUserInitial.toLowerCase() + '"]').length === 0) { + if ($('#userRightsTable').find('input:checkbox[value^="' + thisUserInitial + '"], input:checkbox[value^="' + thisUserInitial.toLowerCase() + '"]').length === 0) { $('#initials_table').find('td > a:contains(' + thisUserInitial + ')').parent('td').html(thisUserInitial); } diff --git a/js/src/server/status/sorter.js b/js/src/server/status/sorter.js index 4c7d2f85b7..7a60052001 100644 --- a/js/src/server/status/sorter.js +++ b/js/src/server/status/sorter.js @@ -5,7 +5,7 @@ function initTableSorter (tabid) { var opts; switch (tabid) { case 'statustabs_queries': - $table = $('#serverstatusqueriesdetails'); + $table = $('#serverStatusQueriesDetails'); opts = { sortList: [[3, 1]], headers: { diff --git a/js/src/server/status/variables.js b/js/src/server/status/variables.js index fd19cd9de1..aafd773810 100644 --- a/js/src/server/status/variables.js +++ b/js/src/server/status/variables.js @@ -34,10 +34,11 @@ AJAX.registerOnload('server/status/variables.js', function () { $('#dontFormat').on('change', function () { // Hiding the table while changing values speeds up the process a lot - $('#serverstatusvariables').hide(); - $('#serverstatusvariables').find('td.value span.original').toggle(this.checked); - $('#serverstatusvariables').find('td.value span.formatted').toggle(! this.checked); - $('#serverstatusvariables').show(); + const serverStatusVariables = $('#serverStatusVariables'); + serverStatusVariables.hide(); + serverStatusVariables.find('td.value span.original').toggle(this.checked); + serverStatusVariables.find('td.value span.formatted').toggle(! this.checked); + serverStatusVariables.show(); }).trigger('change'); $('#filterText').on('keyup', function () { @@ -85,7 +86,7 @@ AJAX.registerOnload('server/status/variables.js', function () { $('#linkSuggestions').css('display', 'none'); } - $('#serverstatusvariables').find('th.name').each(function () { + $('#serverStatusVariables').find('th.name').each(function () { if ((textFilter === null || textFilter.exec($(this).text())) && (! alertFilter || $(this).next().find('span.attention').length > 0) && (categoryFilter.length === 0 || $(this).parent().hasClass('s_' + categoryFilter)) diff --git a/js/src/server/variables.js b/js/src/server/variables.js index a29cfe6b44..ddc8faf4da 100644 --- a/js/src/server/variables.js +++ b/js/src/server/variables.js @@ -83,7 +83,7 @@ AJAX.registerOnload('server/variables.js', function () { var $editor = $('
', { 'class': 'serverVariableEditor' }) .append( $('
').append( - $('', { type: 'text' }).val(data.message) + $('', { type: 'text', 'class': 'form-control form-control-sm' }).val(data.message) ) ); // Save and replace content diff --git a/libraries/classes/Database/Routines.php b/libraries/classes/Database/Routines.php index bec979fece..5ec151ffdb 100644 --- a/libraries/classes/Database/Routines.php +++ b/libraries/classes/Database/Routines.php @@ -839,7 +839,7 @@ class Routines $retval .= Url::getHiddenInputs($db) . "\n"; $retval .= "
\n"; $retval .= '' . __('Details') . "\n"; - $retval .= "\n"; + $retval .= '
' . "\n"; $retval .= "\n"; $retval .= ' \n"; $retval .= "
' . __('Routine name') . "\n"; $retval .= " \n"; // parameter handling start - $retval .= " \n"; + $retval .= "
\n"; $retval .= " \n"; $retval .= " \n"; $retval .= " \n"; diff --git a/libraries/classes/Database/Triggers.php b/libraries/classes/Database/Triggers.php index 9f4564e57a..08f592e809 100644 --- a/libraries/classes/Database/Triggers.php +++ b/libraries/classes/Database/Triggers.php @@ -387,7 +387,7 @@ class Triggers $retval .= Url::getHiddenInputs($db, $table) . "\n"; $retval .= "
\n"; $retval .= '' . __('Details') . "\n"; - $retval .= "
\n"; + $retval .= "
\n"; $retval .= "\n"; $retval .= ' \n"; $retval .= "
' . __('Trigger name') . "fetchResult($sql, 0, 1); - $output = '' . "\n" - . '
' . "\n" + $output = '' . "\n" + . ' ' . "\n" - . ' ' . "\n" + . ' ' . "\n" . ' ' . "\n" . ' ' . "\n" . ' ' . "\n" . ' ' . "\n" - . ' ' . "\n" - . ' ' . "\n" + . ' ' . "\n" . ' ' . "\n" . ' ' . "\n" - . ' ' . "\n" - . ' ' . "\n" + . ' ' . "\n" . ' ' . "\n" . ' ' . "\n" - . ' ' . "\n" - . ' ' . "\n" + . ' ' . "\n" . ' ' . "\n" . ' ' . "\n" - . ' ' . "\n" - . ' ' . "\n" + . ' ' . "\n" . ' ' . "\n" . ' ' . "\n" - . ' ' . "\n" - . ' ' . "\n" + . ' ' - . ' ' - . ' ' + . ' ' . "\n" . '
' . "\n" . ' ' . __('Buffer Pool Usage') . "\n" . '
' . "\n" - . ' ' . __('Total') . "\n" - . ' : ' + . ' ' . __('Total:') . ' ' . Util::formatNumber( $status['Innodb_buffer_pool_pages_total'], 0 @@ -158,8 +157,8 @@ class Innodb extends StorageEngine . '
' . __('Free pages') . '' + . ' ' . __('Free pages') . '' . Util::formatNumber( $status['Innodb_buffer_pool_pages_free'], 0 @@ -167,8 +166,8 @@ class Innodb extends StorageEngine . '
' . __('Dirty pages') . '' + . ' ' . __('Dirty pages') . '' . Util::formatNumber( $status['Innodb_buffer_pool_pages_dirty'], 0 @@ -176,8 +175,8 @@ class Innodb extends StorageEngine . '
' . __('Pages containing data') . '' + . ' ' . __('Pages containing data') . '' . Util::formatNumber( $status['Innodb_buffer_pool_pages_data'], 0 @@ -185,8 +184,8 @@ class Innodb extends StorageEngine . '
' . __('Pages to be flushed') . '' + . ' ' . __('Pages to be flushed') . '' . Util::formatNumber( $status['Innodb_buffer_pool_pages_flushed'], 0 @@ -194,8 +193,8 @@ class Innodb extends StorageEngine . '
' . __('Busy pages') . '' + . ' ' . __('Busy pages') . '' . Util::formatNumber( $status['Innodb_buffer_pool_pages_misc'], 0 @@ -206,8 +205,8 @@ class Innodb extends StorageEngine // not present at least since MySQL 5.1.40 if (isset($status['Innodb_buffer_pool_pages_latched'])) { $output .= '
' . __('Latched pages') . '' + . ' ' . __('Latched pages') . '' . Util::formatNumber( $status['Innodb_buffer_pool_pages_latched'], 0 @@ -218,14 +217,14 @@ class Innodb extends StorageEngine $output .= '
' . "\n\n" - . '' . "\n" - . '
' . "\n" + . '' . "\n" + . ' ' . "\n" . ' ' . "\n" . ' ' . "\n" - . ' ' . "\n" - . ' ' . "\n" + . ' ' . "\n" . ' ' . "\n" . ' ' . "\n" - . ' ' . "\n" - . ' ' . "\n" + . ' ' . "\n" . ' ' . "\n" . ' ' . "\n" - . ' ' . "\n" - . ' ' . "\n" + . ' ' . "\n" . ' ' . "\n" . ' ' . "\n" - . ' ' . "\n" - . ' ' . "\n" + . ' ' . "\n" . ' ' . "\n" . ' ' . "\n" - . ' ' . "\n" - . ' ' . "\n" + . ' ' . "\n" . ' ' . "\n" . ' ' . "\n" - . ' ' . "\n" - . ' ' . "\n" + . ' ' . "\n" - . ' ' + . ' ' . "\n" - . '
' . "\n" . ' ' . __('Buffer Pool Activity') . "\n" . '
' . __('Read requests') . '' + . ' ' . __('Read requests') . '' . Util::formatNumber( $status['Innodb_buffer_pool_read_requests'], 0 @@ -233,8 +232,8 @@ class Innodb extends StorageEngine . '
' . __('Write requests') . '' + . ' ' . __('Write requests') . '' . Util::formatNumber( $status['Innodb_buffer_pool_write_requests'], 0 @@ -242,8 +241,8 @@ class Innodb extends StorageEngine . '
' . __('Read misses') . '' + . ' ' . __('Read misses') . '' . Util::formatNumber( $status['Innodb_buffer_pool_reads'], 0 @@ -251,8 +250,8 @@ class Innodb extends StorageEngine . '
' . __('Write waits') . '' + . ' ' . __('Write waits') . '' . Util::formatNumber( $status['Innodb_buffer_pool_wait_free'], 0 @@ -260,8 +259,8 @@ class Innodb extends StorageEngine . '
' . __('Read misses in %') . '' + . ' ' . __('Read misses in %') . '' . ($status['Innodb_buffer_pool_read_requests'] == 0 ? '---' : htmlspecialchars( @@ -275,8 +274,8 @@ class Innodb extends StorageEngine . '
' . __('Write waits in %') . '' + . ' ' . __('Write waits in %') . '' . ($status['Innodb_buffer_pool_write_requests'] == 0 ? '---' : htmlspecialchars( diff --git a/libraries/classes/StorageEngine.php b/libraries/classes/StorageEngine.php index 13db341079..a49c9e4541 100644 --- a/libraries/classes/StorageEngine.php +++ b/libraries/classes/StorageEngine.php @@ -233,9 +233,9 @@ class StorageEngine . "\n"; } $ret .= ' ' . htmlspecialchars($details['title']) . '' . htmlspecialchars($details['title']) . ''; + . ' '; switch ($details['type']) { case PMA_ENGINE_DETAILS_TYPE_SIZE: $parsed_size = $this->resolveTypeSize($details['value']); @@ -262,7 +262,8 @@ class StorageEngine . "\n" . '

' . "\n"; } else { - $ret = '' . "\n" . $ret . '
' . "\n"; + $ret = '' + . "\n" . $ret . '
' . "\n"; } return $ret; diff --git a/templates/database/central_columns/main.twig b/templates/database/central_columns/main.twig index cff87c829b..0e738633ae 100644 --- a/templates/database/central_columns/main.twig +++ b/templates/database/central_columns/main.twig @@ -7,12 +7,11 @@ method="post" action="{{ url('/database/central-columns') }}"> {{ get_hidden_inputs(db) }} -
- - +
+
+ - - + + @@ -131,7 +131,7 @@ {% trans 'The central list of columns for the current database is empty' %} {% else %} -
{% trans 'Name' %}
@@ -45,6 +44,7 @@ {% trans 'A_I' %}
+ {% if pos - max_rows >= 0 %} @@ -172,8 +172,8 @@ {% endif %} -{# getHtmlForAddColumn #} - + +