diff --git a/libraries/classes/Navigation/Nodes/Node.php b/libraries/classes/Navigation/Nodes/Node.php index 062df7dfec..69bb4dd6a4 100644 --- a/libraries/classes/Navigation/Nodes/Node.php +++ b/libraries/classes/Navigation/Nodes/Node.php @@ -58,10 +58,10 @@ class Node */ public $visible = false; /** - * @var Node A reference to the parent object of + * @var Node|null A reference to the parent object of * this node, NULL for the root node. */ - public $parent; + public $parent = null; /** * @var Node[] An array of Node objects that are * direct children of this node diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index ac7fcbeccc..cd68140353 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -5000,6 +5000,11 @@ parameters: count: 1 path: libraries/classes/Navigation/Navigation.php + - + message: "#^Cannot access property \\$pos2 on PhpMyAdmin\\\\Navigation\\\\Nodes\\\\Node\\|null\\.$#" + count: 1 + path: libraries/classes/Navigation/NavigationTree.php + - message: "#^Casting to string something that's already string\\.$#" count: 6 @@ -5090,6 +5095,11 @@ parameters: count: 1 path: libraries/classes/Navigation/NodeFactory.php + - + message: "#^Cannot access property \\$children on PhpMyAdmin\\\\Navigation\\\\Nodes\\\\Node\\|null\\.$#" + count: 1 + path: libraries/classes/Navigation/Nodes/Node.php + - message: "#^Casting to bool something that's already bool\\.$#" count: 1 diff --git a/psalm-baseline.xml b/psalm-baseline.xml index 7f20da5107..838af81390 100644 --- a/psalm-baseline.xml +++ b/psalm-baseline.xml @@ -8614,6 +8614,9 @@ $database + + $container->parent->pos2 + (int) $GLOBALS['cfg']['FirstLevelNavigationItems'] (int) $GLOBALS['cfg']['FirstLevelNavigationItems'] @@ -8657,18 +8660,25 @@ $db $paths['aPath_clean'] - + + $child $db $db $db $db $db + + hasChildren + $GLOBALS['cfg']['Server']['hide_db'] $db $db + + $child->type + $databases @@ -8688,12 +8698,17 @@ $prefixMap $prefixMap + + $this->parent->children + $arr[0] - + + $this->parent->children + + $displayName - $parent $title @@ -8721,14 +8736,12 @@ $retval $retval - - NodeColumn + NodeColumn - - NodeColumnContainer + NodeColumnContainer NodeColumnContainer @@ -8749,8 +8762,7 @@ $item - - NodeDatabase + NodeDatabase NodeDatabase @@ -8761,8 +8773,7 @@ - - NodeDatabaseChildContainer + NodeDatabaseChildContainer NodeDatabaseChildContainer @@ -8771,64 +8782,55 @@ - - NodeDatabaseContainer + NodeDatabaseContainer NodeDatabaseContainer - - NodeEvent + NodeEvent NodeEvent - - NodeEventContainer + NodeEventContainer NodeEventContainer - - NodeFunction + NodeFunction NodeFunction - - NodeFunctionContainer + NodeFunctionContainer NodeFunctionContainer - - NodeIndex + NodeIndex NodeIndex - - NodeIndexContainer + NodeIndexContainer NodeIndexContainer - - NodeProcedure + NodeProcedure NodeProcedure - - NodeProcedureContainer + NodeProcedureContainer NodeProcedureContainer @@ -8841,42 +8843,36 @@ $arr['Type'] - - NodeTable + NodeTable - - NodeTableContainer + NodeTableContainer NodeTableContainer - - NodeTrigger + NodeTrigger NodeTrigger - - NodeTriggerContainer + NodeTriggerContainer NodeTriggerContainer - - NodeView + NodeView NodeView - - NodeViewContainer + NodeViewContainer NodeViewContainer