From 756c6552c275d66adbbf3a60c934e5678bc78495 Mon Sep 17 00:00:00 2001
From: Shreyas Sinha <shreyas.sinha14@gmail.com>
Date: Fri, 20 Jan 2017 11:17:03 +0530
Subject: [PATCH] Using CreateElement for adding HTML

Signed-off-by: Shreyas Sinha <shreyas.sinha14@gmail.com>
---
 js/functions.js | 27 ++++++++++++++++++++-------
 1 file changed, 20 insertions(+), 7 deletions(-)

diff --git a/js/functions.js b/js/functions.js
index 81f5fbfa19..986bff6559 100644
--- a/js/functions.js
+++ b/js/functions.js
@@ -521,10 +521,15 @@ function PMA_current_version(data)
         var current = parseVersionString($('span.version').text());
         var latest = parseVersionString(data.version);
         var url = 'https://web.phpmyadmin.net/files/' + escapeHtml(encodeURIComponent(data.version)) + '/';
-        var version_information_message = '<span class="latest">' +
-            PMA_messages.strLatestAvailable +
-            ' <a href="' + url + '" class="disableAjax">' + escapeHtml(data.version) + '</a>' +
-            '</span>';
+        var version_information_message = document.createElement('span');
+        version_information_message.class = 'latest';
+        var version_information_message_link = document.createElement('a');
+        version_information_message_link.href = url;
+        version_information_message_link.class = 'disableAjax';
+        version_information_message_link.innerHTML = escapeHtml(data.version);
+        var prefix_message = document.createTextNode(PMA_messages.strLatestAvailable);
+        version_information_message.appendChild(prefix_message);
+        version_information_message.appendChild(version_information_message_link);
         if (latest > current) {
             var message = PMA_sprintf(
                 PMA_messages.strNewerVersion,
@@ -537,14 +542,22 @@ function PMA_current_version(data)
                 htmlClass = 'error';
             }
             $('#newer_version_notice').remove();
-            $('#maincontainer').after('<div id="newer_version_notice" class="' + htmlClass + '"><a href="' + url + '" class="disableAjax">' + message + '</a></div>');
+            var maincontainer_div = document.createElement('div');
+            maincontainer_div.id = 'newer_version_notice';
+            maincontainer_div.class = htmlClass;
+            var maincontainer_div_link = document.createElement('a');
+            maincontainer_div_link.href = url;
+            maincontainer_div_link.class = "disableAjax";
+            maincontainer_div_link.innerHTML = message;
+            maincontainer_div.appendChild(maincontainer_div_link);
+            document.getElementById("maincontainer").appendChild(maincontainer_div);
         }
         if (latest === current) {
-            version_information_message = ' (' + PMA_messages.strUpToDate + ')';
+            version_information_message = document.createTextNode(' (' + PMA_messages.strUpToDate + ')');
         }
         var $liPmaVersion = $('#li_pma_version');
         $liPmaVersion.find('span.latest').remove();
-        $liPmaVersion.append(version_information_message);
+        document.getElementById("li_pma_version").appendChild(version_information_message);
     }
 }