Remove optional $onclick parameter

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>

libraries/classes/Display/Results.php

@@ -716,7 +716,6 @@ class Results
      * @param bool   $back            whether 'begin' or 'previous'
      * @param string $onsubmit        optional onsubmit clause
      * @param string $inputForRealEnd optional hidden field for special treatment
-     * @param string $onclick         optional onclick clause
      *
      * @return string                     html content
      */
@@ -727,8 +726,7 @@ class Results
         $htmlSqlQuery,
         $back,
         $onsubmit = '',
-        $inputForRealEnd = '',
-        $onclick = ''
+        $inputForRealEnd = ''
     ): string {
         $captionOutput = '';
         if ($back) {
@@ -760,7 +758,6 @@ class Results
             'caption_output' => $captionOutput,
             'title' => $title,
             'onsubmit' => $onsubmit,
-            'onclick' => $onclick,
         ]);
     }
 

templates/display/results/table_navigation_button.twig

@@ -6,7 +6,6 @@
         <input type="hidden" name="is_browse_distinct" value="{{ is_browse_distinct }}">
         <input type="hidden" name="goto" value="{{ goto }}">
         {{ input_for_real_end|raw }}
-        <input type="submit" name="navig" class="btn btn-secondary ajax" value="{{ caption_output|raw }}" title="{{ title }}"
-            {{- onclick|raw }}>
+        <input type="submit" name="navig" class="btn btn-secondary ajax" value="{{ caption_output|raw }}" title="{{ title }}">
     </form>
 </td>