From 7664eda783771db7e8b69e7c8fe6f492bf6adc0c Mon Sep 17 00:00:00 2001 From: Kamil Tekiela Date: Tue, 9 Jan 2024 23:17:32 +0100 Subject: [PATCH] Remove unhelpful comments Signed-off-by: Kamil Tekiela --- src/ConfigStorage/Relation.php | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/ConfigStorage/Relation.php b/src/ConfigStorage/Relation.php index 7f2cdf351e..1e67ad90a7 100644 --- a/src/ConfigStorage/Relation.php +++ b/src/ConfigStorage/Relation.php @@ -247,7 +247,6 @@ class Relation || $config->selectedServer['pmadb'] === '' || ! $this->dbi->selectDb($config->selectedServer['pmadb'], Connection::TYPE_CONTROL) ) { - // No server selected -> no bookmark table $config->selectedServer['pmadb'] = ''; return $relationParams; @@ -256,22 +255,13 @@ class Relation $relationParams['user'] = $config->selectedServer['user']; $relationParams['db'] = $config->selectedServer['pmadb']; - // Now I just check if all tables that i need are present so I can for - // example enable relations but not pdf... - // I was thinking of checking if they have all required columns but I - // fear it might be too slow - $relationParamsFilled = $this->fillRelationParamsWithTableNames($relationParams); if ($relationParamsFilled === null) { - // query failed ... ? return $relationParams; } - // Filling did success - $relationParams = $relationParamsFilled; - - $relationParams = $this->checkTableAccess($relationParams); + $relationParams = $this->checkTableAccess($relationParamsFilled); $allWorks = true; foreach ($workToTable as $work => $table) {