diff --git a/db_central_columns.php b/db_central_columns.php index 0f92d3ab0c..6eebb40a0a 100644 --- a/db_central_columns.php +++ b/db_central_columns.php @@ -84,9 +84,9 @@ $pmadb = $cfgCentralColumns['db']; $pmatable = $cfgCentralColumns['table']; $max_rows = intval($GLOBALS['cfg']['MaxRows']); -if (isset($_REQUEST['edit_central_columns_page'])) { - $selected_fld = $_REQUEST['selected_fld']; - $selected_db = $_REQUEST['db']; +if (isset($_POST['edit_central_columns_page'])) { + $selected_fld = $_POST['selected_fld']; + $selected_db = $_POST['db']; $edit_central_column_page = $centralColumns->getHtmlForEditingPage( $selected_fld, $selected_db @@ -109,15 +109,15 @@ if (isset($_POST['delete_save'])) { false ); } -if (!empty($_REQUEST['total_rows']) - && Core::isValid($_REQUEST['total_rows'], 'integer') +if (!empty($_POST['total_rows']) + && Core::isValid($_POST['total_rows'], 'integer') ) { - $total_rows = $_REQUEST['total_rows']; + $total_rows = $_POST['total_rows']; } else { $total_rows = $centralColumns->getCount($db); } -if (Core::isValid($_REQUEST['pos'], 'integer')) { - $pos = intval($_REQUEST['pos']); +if (Core::isValid($_POST['pos'], 'integer')) { + $pos = intval($_POST['pos']); } else { $pos = 0; } diff --git a/js/db_central_columns.js b/js/db_central_columns.js index 88b0ce78ac..f6e4477913 100644 --- a/js/db_central_columns.js +++ b/js/db_central_columns.js @@ -65,10 +65,10 @@ AJAX.registerOnload('db_central_columns.js', function () { return false; } var argsep = PMA_commonParams.get('arg_separator'); - var editColumnData = editColumnList + '' + argsep + 'edit_central_columns_page=true' + argsep + 'ajax_request=true' + argsep + 'ajax_page_request=true' + argsep + 'db=' + PMA_commonParams.get('db'); + var editColumnData = editColumnList + '' + argsep + 'edit_central_columns_page=true' + argsep + 'ajax_request=true' + argsep + 'ajax_page_request=true' + argsep + 'db=' + encodeURIComponent(PMA_commonParams.get('db')); PMA_ajaxShowMessage(); AJAX.source = $(this); - $.get('db_central_columns.php', editColumnData, AJAX.responseHandler); + $.post('db_central_columns.php', editColumnData, AJAX.responseHandler); }); $('#multi_edit_central_columns').submit(function (event) { event.preventDefault(); diff --git a/libraries/classes/CentralColumns.php b/libraries/classes/CentralColumns.php index 555195c95d..7379cee484 100644 --- a/libraries/classes/CentralColumns.php +++ b/libraries/classes/CentralColumns.php @@ -299,7 +299,7 @@ class CentralColumns if (empty($cfgCentralColumns)) { return $this->configErrorMessage(); } - $db = $_REQUEST['db']; + $db = $_POST['db']; $pmadb = $cfgCentralColumns['db']; $central_list_table = $cfgCentralColumns['table']; $this->dbi->selectDb($db); @@ -333,7 +333,7 @@ class CentralColumns } } else { if ($table === null) { - $table = $_REQUEST['table']; + $table = $_POST['table']; } foreach ($field_select as $column) { $cols .= "'" . $this->dbi->escapeString($column) . "',"; @@ -406,7 +406,7 @@ class CentralColumns if (empty($cfgCentralColumns)) { return $this->configErrorMessage(); } - $db = $_REQUEST['db']; + $db = $_POST['db']; $pmadb = $cfgCentralColumns['db']; $central_list_table = $cfgCentralColumns['table']; $this->dbi->selectDb($db); diff --git a/test/classes/CentralColumnsTest.php b/test/classes/CentralColumnsTest.php index 8640c2cd11..9294ea5c9c 100644 --- a/test/classes/CentralColumnsTest.php +++ b/test/classes/CentralColumnsTest.php @@ -227,8 +227,8 @@ class CentralColumnsTest extends TestCase */ public function testSyncUniqueColumns() { - $_REQUEST['db'] = 'PMA_db'; - $_REQUEST['table'] = 'PMA_table'; + $_POST['db'] = 'PMA_db'; + $_POST['table'] = 'PMA_table'; $this->assertTrue( $this->centralColumns->syncUniqueColumns( @@ -244,8 +244,8 @@ class CentralColumnsTest extends TestCase */ public function testDeleteColumnsFromList() { - $_REQUEST['db'] = 'PMA_db'; - $_REQUEST['table'] = 'PMA_table'; + $_POST['db'] = 'PMA_db'; + $_POST['table'] = 'PMA_table'; // when column exists in the central column list $GLOBALS['dbi']->expects($this->at(4))