diff --git a/db_operations.php b/db_operations.php index 6d0db1982a..3b2a782394 100644 --- a/db_operations.php +++ b/db_operations.php @@ -237,7 +237,7 @@ if (!$is_information_schema) { // You won't be able to. Believe me. You won't. // Don't allow to easily drop mysql database, RFE #1327514. if (($is_superuser || $GLOBALS['cfg']['AllowUserDropDatabase']) - && ! $db_is_information_schema + && ! $db_is_system_schema && (PMA_DRIZZLE || $db != 'mysql') ) { $response->addHTML(PMA_getHtmlForDropDatabaseLink($db)); diff --git a/db_structure.php b/db_structure.php index 0eed9ad925..eba2b5e1e7 100644 --- a/db_structure.php +++ b/db_structure.php @@ -67,7 +67,7 @@ if ($num_tables == 0) { $response->addHTML( '
' . __('No tables found in database.') . '
' . "\n" ); - if (empty($db_is_information_schema)) { + if (empty($db_is_system_schema)) { ob_start(); include 'libraries/display_create_table.lib.php'; $content = ob_get_contents(); @@ -114,7 +114,7 @@ $response->addHTML( $response->addHTML(PMA_URL_getHiddenInputs($db)); $response->addHTML( - PMA_tableHeader($db_is_information_schema, $server_slave_status) + PMA_tableHeader($db_is_system_schema, $server_slave_status) ); $i = $sum_entries = 0; @@ -149,7 +149,7 @@ foreach ($tables as $keyname => $current_table) { list($current_table, $formatted_size, $unit, $formatted_overhead, $overhead_unit, $overhead_size, $table_is_view, $sum_size) = PMA_getStuffForEngineTypeTable( - $current_table, $db_is_information_schema, + $current_table, $db_is_system_schema, $is_show_stats, $table_is_view, $sum_size, $overhead_size ); @@ -226,10 +226,10 @@ foreach ($tables as $keyname => $current_table) { list($browse_table, $search_table, $browse_table_label, $empty_table, $tracking_icon) = PMA_getHtmlForActionLinks( $current_table, $table_is_view, $tbl_url_query, - $titles, $truename, $db_is_information_schema, $url_query + $titles, $truename, $db_is_system_schema, $url_query ); - if (! $db_is_information_schema) { + if (! $db_is_system_schema) { list($drop_query, $drop_message) = PMA_getTableDropQueryAndMessage($table_is_view, $current_table); } @@ -255,7 +255,7 @@ foreach ($tables as $keyname => $current_table) { list($html_output, $odd_row) = PMA_getHtmlForStructureTableRow( $i, $odd_row, $table_is_view, $current_table, $browse_table_label, $tracking_icon, $server_slave_status, - $browse_table, $tbl_url_query, $search_table, $db_is_information_schema, + $browse_table, $tbl_url_query, $search_table, $db_is_system_schema, $titles, $empty_table, $drop_query, $drop_message, $collation, $formatted_size, $unit, $overhead, (isset ($create_time) ? $create_time : ''), @@ -271,7 +271,7 @@ foreach ($tables as $keyname => $current_table) { $response->addHTML(''); $response->addHTML( PMA_getHtmlBodyForTableSummary( - $num_tables, $server_slave_status, $db_is_information_schema, $sum_entries, + $num_tables, $server_slave_status, $db_is_system_schema, $sum_entries, $db_collation, $is_show_stats, $sum_size, $overhead_size, $create_time_all, $update_time_all, $check_time_all, $sum_row_count_pre ) @@ -281,7 +281,7 @@ $response->addHTML(''); $response->addHTML( PMA_getHtmlForCheckAllTables( $pmaThemeImage, $text_dir, $overhead_check, - $db_is_information_schema, $hidden_fields + $db_is_system_schema, $hidden_fields ) ); $response->addHTML(''); //end of form @@ -306,7 +306,7 @@ $response->addHTML( . PMA_getHtmlForDataDictionaryLink($url_query) ); -if (empty($db_is_information_schema)) { +if (empty($db_is_system_schema)) { ob_start(); include 'libraries/display_create_table.lib.php'; $content = ob_get_contents(); diff --git a/db_tracking.php b/db_tracking.php index bcd552c13b..2615315594 100644 --- a/db_tracking.php +++ b/db_tracking.php @@ -50,7 +50,7 @@ $data = PMA_Tracker::getTrackedData($_REQUEST['db'], '', '1'); if ($num_tables == 0 && count($data['ddlog']) == 0) { echo '' . __('No tables found in database.') . '
' . "\n"; - if (empty($db_is_information_schema)) { + if (empty($db_is_system_schema)) { include 'libraries/display_create_table.lib.php'; } exit; diff --git a/libraries/Menu.class.php b/libraries/Menu.class.php index 6f07b59417..cbf3dad8f8 100644 --- a/libraries/Menu.class.php +++ b/libraries/Menu.class.php @@ -285,7 +285,7 @@ class PMA_Menu */ private function _getTableTabs() { - $db_is_information_schema = $GLOBALS['dbi']->isSystemSchema($this->_db); + $db_is_system_schema = $GLOBALS['dbi']->isSystemSchema($this->_db); $tbl_is_view = PMA_Table::isView($this->_db, $this->_table); $is_superuser = $GLOBALS['dbi']->isSuperuser(); @@ -312,7 +312,7 @@ class PMA_Menu array('tbl_select.php', 'tbl_zoom_select.php', 'tbl_find_replace.php') ); - if (! $db_is_information_schema) { + if (! $db_is_system_schema) { $tabs['insert']['icon'] = 'b_insrow.png'; $tabs['insert']['link'] = 'tbl_change.php'; $tabs['insert']['text'] = __('Insert'); @@ -326,12 +326,12 @@ class PMA_Menu /** * Don't display "Import" for views and information_schema */ - if (! $tbl_is_view && ! $db_is_information_schema) { + if (! $tbl_is_view && ! $db_is_system_schema) { $tabs['import']['icon'] = 'b_tblimport.png'; $tabs['import']['link'] = 'tbl_import.php'; $tabs['import']['text'] = __('Import'); } - if ($is_superuser && ! PMA_DRIZZLE && ! $db_is_information_schema) { + if ($is_superuser && ! PMA_DRIZZLE && ! $db_is_system_schema) { $tabs['privileges']['link'] = 'server_privileges.php'; $tabs['privileges']['args']['checkprivsdb'] = $this->_db; $tabs['privileges']['args']['checkprivstable'] = $this->_table; @@ -343,7 +343,7 @@ class PMA_Menu /** * Don't display "Operations" for views and information_schema */ - if (! $tbl_is_view && ! $db_is_information_schema) { + if (! $tbl_is_view && ! $db_is_system_schema) { $tabs['operation']['icon'] = 'b_tblops.png'; $tabs['operation']['link'] = 'tbl_operations.php'; $tabs['operation']['text'] = __('Operations'); @@ -353,7 +353,7 @@ class PMA_Menu $tabs['tracking']['text'] = __('Tracking'); $tabs['tracking']['link'] = 'tbl_tracking.php'; } - if (! $db_is_information_schema + if (! $db_is_system_schema && ! PMA_DRIZZLE && PMA_Util::currentUserHasPrivilege( 'TRIGGER', @@ -370,7 +370,7 @@ class PMA_Menu /** * Views support a limited number of operations */ - if ($tbl_is_view && ! $db_is_information_schema) { + if ($tbl_is_view && ! $db_is_system_schema) { $tabs['operation']['icon'] = 'b_tblops.png'; $tabs['operation']['link'] = 'view_operations.php'; $tabs['operation']['text'] = __('Operations'); @@ -386,7 +386,7 @@ class PMA_Menu */ private function _getDbTabs() { - $db_is_information_schema = $GLOBALS['dbi']->isSystemSchema($this->_db); + $db_is_system_schema = $GLOBALS['dbi']->isSystemSchema($this->_db); $num_tables = count($GLOBALS['dbi']->getTables($this->_db)); $is_superuser = $GLOBALS['dbi']->isSuperuser(); @@ -426,7 +426,7 @@ class PMA_Menu $tabs['export']['warning'] = __('Database seems to be empty!'); } - if (! $db_is_information_schema) { + if (! $db_is_system_schema) { $tabs['import']['link'] = 'db_import.php'; $tabs['import']['text'] = __('Import'); $tabs['import']['icon'] = 'b_import.png'; @@ -471,7 +471,7 @@ class PMA_Menu $tabs['tracking']['link'] = 'db_tracking.php'; } - if (! $db_is_information_schema && $cfgRelation['designerwork']) { + if (! $db_is_system_schema && $cfgRelation['designerwork']) { $tabs['designer']['text'] = __('Designer'); $tabs['designer']['icon'] = 'b_relations.png'; $tabs['designer']['link'] = 'pmd_general.php'; diff --git a/libraries/db_common.inc.php b/libraries/db_common.inc.php index a16a700890..eb6d813afb 100644 --- a/libraries/db_common.inc.php +++ b/libraries/db_common.inc.php @@ -18,8 +18,8 @@ PMA_Util::checkParameters(array('db')); $is_show_stats = $cfg['ShowStats']; -$db_is_information_schema = $GLOBALS['dbi']->isSystemSchema($db); -if ($db_is_information_schema) { +$db_is_system_schema = $GLOBALS['dbi']->isSystemSchema($db); +if ($db_is_system_schema) { $is_show_stats = false; } diff --git a/libraries/db_info.inc.php b/libraries/db_info.inc.php index ea964a6a61..7acd5ea35a 100644 --- a/libraries/db_info.inc.php +++ b/libraries/db_info.inc.php @@ -5,7 +5,7 @@ * tables if possible * * fills tooltip arrays and provides $tables, $num_tables, $is_show_stats - * and $db_is_information_schema + * and $db_is_system_schema * * speedup view on locked tables * @@ -39,11 +39,11 @@ $is_show_stats = $cfg['ShowStats']; /** * @global bool whether selected db is information_schema */ -$db_is_information_schema = false; +$db_is_system_schema = false; if ($GLOBALS['dbi']->isSystemSchema($db)) { $is_show_stats = false; - $db_is_information_schema = true; + $db_is_system_schema = true; } /** diff --git a/libraries/display_structure.inc.php b/libraries/display_structure.inc.php index 60eeba3c00..949acb821a 100644 --- a/libraries/display_structure.inc.php +++ b/libraries/display_structure.inc.php @@ -34,7 +34,7 @@ $response->addHTML($html_form); $response->addHTML(PMA_URL_getHiddenInputs($db, $table)); $tabletype = ''; } else if ($tbl_is_view) { $tabletype .= '"view" />'; @@ -49,7 +49,7 @@ $response->addHTML($tablestructure); $response->addHTML( PMA_getHtmlForTableStructureHeader( - $db_is_information_schema, + $db_is_system_schema, $tbl_is_view ) ); @@ -173,11 +173,11 @@ foreach ($fields as $row) { $row, $rownum, $displayed_field_name, $type_nowrap, $extracted_columnspec, $type_mime, $field_charset, $attribute, $tbl_is_view, - $db_is_information_schema, $url_query, $field_encoded, $titles, $table + $db_is_system_schema, $url_query, $field_encoded, $titles, $table ) ); - if (! $tbl_is_view && ! $db_is_information_schema) { + if (! $tbl_is_view && ! $db_is_system_schema) { $response->addHTML( PMA_getHtmlForActionsInTableStructure( $type, $tbl_storage_engine, $primary, @@ -185,7 +185,7 @@ foreach ($fields as $row) { $hidden_titles, $columns_with_unique_index ) ); - } // end if (! $tbl_is_view && ! $db_is_information_schema) + } // end if (! $tbl_is_view && ! $db_is_system_schema) $response->addHTML(''); @@ -197,7 +197,7 @@ $response->addHTML(''); $response->addHTML( PMA_getHtmlForCheckAllTableColumn( $pmaThemeImage, $text_dir, $tbl_is_view, - $db_is_information_schema, $tbl_storage_engine + $db_is_system_schema, $tbl_storage_engine ) ); @@ -217,12 +217,12 @@ if ($tbl_is_view) { } $response->addHTML( PMA_getHtmlForOptionalActionLinks( - $url_query, $tbl_is_view, $db_is_information_schema, + $url_query, $tbl_is_view, $db_is_system_schema, $tbl_storage_engine, $cfgRelation ) ); -if (! $tbl_is_view && ! $db_is_information_schema) { +if (! $tbl_is_view && ! $db_is_system_schema) { $response->addHTML('