From 7b6149ba0e528c15ee10ffdc067f381da9497987 Mon Sep 17 00:00:00 2001 From: Kamil Tekiela Date: Fri, 14 Oct 2022 21:59:37 +0100 Subject: [PATCH] RedundantCastGivenDocblockType Signed-off-by: Kamil Tekiela --- libraries/classes/Display/Results.php | 4 ++-- phpstan-baseline.neon | 5 ----- psalm-baseline.xml | 4 ---- 3 files changed, 2 insertions(+), 11 deletions(-) diff --git a/libraries/classes/Display/Results.php b/libraries/classes/Display/Results.php index d1471157b9..d0e1965093 100644 --- a/libraries/classes/Display/Results.php +++ b/libraries/classes/Display/Results.php @@ -871,9 +871,9 @@ class Results $displayParams['desc'][] = ' ' - . htmlspecialchars((string) $fieldsMeta[$i]->name) + . htmlspecialchars($fieldsMeta[$i]->name) . $comments . ' '; } diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index c81a57a1f6..3fbccd57ef 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -2895,11 +2895,6 @@ parameters: count: 2 path: libraries/classes/Display/Results.php - - - message: "#^Casting to string something that's already string\\.$#" - count: 2 - path: libraries/classes/Display/Results.php - - message: "#^Method PhpMyAdmin\\\\Display\\\\Results\\:\\:getCommentForRow\\(\\) has parameter \\$commentsMap with no value type specified in iterable type array\\.$#" count: 1 diff --git a/psalm-baseline.xml b/psalm-baseline.xml index f0914aed0c..3d15a1d80f 100644 --- a/psalm-baseline.xml +++ b/psalm-baseline.xml @@ -6463,10 +6463,6 @@ (int) $GLOBALS['cfg']['LimitChars'] (int) $GLOBALS['cfg']['LimitChars'] - - (string) $fieldsMeta[$i]->name - (string) $fieldsMeta[$i]->name - empty($statementInfo->statement->from) isset($sessionMaxRows)