From 96a87eb66a18ea8cb86ab8c2ac623457954d7b66 Mon Sep 17 00:00:00 2001 From: kerorero Date: Mon, 20 Apr 2020 22:08:16 +0200 Subject: [PATCH] close #16049, checking if select input exists before retrieving the value, but not checking hostname select input value Signed-off-by: Kamil Bacia --- js/server/privileges.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/js/server/privileges.js b/js/server/privileges.js index f3888b5a80..1cd509c2bd 100644 --- a/js/server/privileges.js +++ b/js/server/privileges.js @@ -14,13 +14,13 @@ * @return boolean whether the form is validated or not */ function checkAddUser (theForm) { - if (theForm.elements.pred_hostname.value === 'userdefined' && theForm.elements.hostname.value === '') { + if (theForm.elements.hostname.value === '') { alert(Messages.strHostEmpty); theForm.elements.hostname.focus(); return false; } - if (theForm.elements.pred_username.value === 'userdefined' && theForm.elements.username.value === '') { + if ((theForm.elements.pred_username && theForm.elements.pred_username.value === 'userdefined') && theForm.elements.username.value === '') { alert(Messages.strUserEmpty); theForm.elements.username.focus(); return false;