Increase the PHPStan level and update the baseline file

Signed-off-by: Maurício Meneghini Fauth <mauricio@fauth.dev>
This commit is contained in:
Maurício Meneghini Fauth 2021-12-03 12:53:19 -03:00
parent a42803297c
commit 7d3c84a881
No known key found for this signature in database
GPG Key ID: 6A16FD38AFC89CC8
3 changed files with 10726 additions and 21 deletions

File diff suppressed because it is too large Load Diff

View File

@ -1,14 +1,13 @@
includes:
- phpstan-baseline.neon
parameters:
level: 8
level: max
paths:
- .
scanFiles:
- libraries/vendor_config.php
bootstrapFiles:
- test/phpstan-constants.php
checkMissingIterableValueType: false
excludePaths:
- examples/openid.php
- node_modules/*

View File

@ -1,11 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<files psalm-version="4.13.1@5cf660f63b548ccd4a56f62d916ee4d6028e01a3">
<file src="config.inc.php">
<MixedAssignment occurrences="2">
<code>$cfg['Servers'][$i]['port']</code>
<code>$cfg['Servers'][$i]['port']</code>
</MixedAssignment>
</file>
<file src="index.php">
<InvalidGlobal occurrences="1">
<code>global $route, $containerBuilder, $request;</code>
@ -226,13 +220,12 @@
</MixedArgumentTypeCoercion>
</file>
<file src="libraries/classes/CheckUserPrivileges.php">
<MixedArgument occurrences="7">
<MixedArgument occurrences="6">
<code>$row[0]</code>
<code>$showGrantsDbName</code>
<code>$showGrantsResult</code>
<code>$showGrantsResult</code>
<code>$showGrantsString</code>
<code>$showGrantsString</code>
<code>$showGrantsTableName</code>
</MixedArgument>
<MixedAssignment occurrences="11">
@ -2911,8 +2904,7 @@
<PossiblyInvalidArgument occurrences="1">
<code>$current_result</code>
</PossiblyInvalidArgument>
<PossiblyNullArgument occurrences="2">
<code>$GLOBALS['goto']</code>
<PossiblyNullArgument occurrences="1">
<code>$isUpload</code>
</PossiblyNullArgument>
<PossiblyNullOperand occurrences="1">
@ -5072,7 +5064,7 @@
</RedundantPropertyInitializationCheck>
</file>
<file src="libraries/classes/Database/Routines.php">
<MixedArgument occurrences="85">
<MixedArgument occurrences="84">
<code>$_GET['item_name']</code>
<code>$_GET['item_name']</code>
<code>$_GET['item_name']</code>
@ -5107,7 +5099,6 @@
<code>$db</code>
<code>$errors</code>
<code>$itemDefiner</code>
<code>$itemDefiner</code>
<code>$itemName</code>
<code>$itemParamOpsNum[$i]</code>
<code>$itemParamOpsText[$i]</code>
@ -5493,7 +5484,7 @@
<code>$a</code>
<code>$b</code>
</MissingClosureParamType>
<MixedArgument occurrences="66">
<MixedArgument occurrences="65">
<code>$_SERVER['SCRIPT_NAME']</code>
<code>$a</code>
<code>$arrayKeys</code>
@ -5502,7 +5493,6 @@
<code>$database_name</code>
<code>$grant</code>
<code>$grant</code>
<code>$grant</code>
<code>$host</code>
<code>$host</code>
<code>$link</code>
@ -5849,7 +5839,7 @@
<InvalidScalarArgument occurrences="1">
<code>$originalLength</code>
</InvalidScalarArgument>
<MixedArgument occurrences="88">
<MixedArgument occurrences="84">
<code>$_SESSION['tmpval']['max_rows']</code>
<code>$_SESSION['tmpval']['pos'] / $_SESSION['tmpval']['max_rows']</code>
<code>$_SESSION['tmpval']['query']</code>
@ -5863,8 +5853,6 @@
<code>$analyzedSqlResults['statement']</code>
<code>$analyzedSqlResults['statement']-&gt;from</code>
<code>$clause</code>
<code>$clause</code>
<code>$clause</code>
<code>$clauseIsUnique</code>
<code>$clauseIsUnique</code>
<code>$colOrder</code>
@ -5906,8 +5894,6 @@
<code>$multipleUrlParams['sql_query']</code>
<code>$multipleUrlParams['sql_query']</code>
<code>$nameToUseInSort</code>
<code>$nameToUseInSort</code>
<code>$nameToUseInSort</code>
<code>$newSortExpressionNoDirection</code>
<code>$oneKey['ref_db_name'] ?? $GLOBALS['db']</code>
<code>$oneKey['ref_table_name']</code>