From 10603e65933eb28d8ab8e45e9e14817820c4f819 Mon Sep 17 00:00:00 2001 From: ayushchd Date: Sun, 18 Aug 2013 19:21:31 +0530 Subject: [PATCH 1/2] Fix spaces and argument issues --- libraries/tbl_columns_definition_form.lib.php | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libraries/tbl_columns_definition_form.lib.php b/libraries/tbl_columns_definition_form.lib.php index 3c265fd487..00f29f8ad1 100644 --- a/libraries/tbl_columns_definition_form.lib.php +++ b/libraries/tbl_columns_definition_form.lib.php @@ -76,7 +76,7 @@ function PMA_getHtmlForTableConfigurations() . '' . __('Collation:') . '' . '' . ' Date: Sun, 18 Aug 2013 19:22:05 +0530 Subject: [PATCH 2/2] Tests for libraries/tbl_columns_definition_form.lib.php --- .../PMA_tbl_columns_definition_form_test.php | 1116 +++++++++++++++++ 1 file changed, 1116 insertions(+) create mode 100644 test/libraries/PMA_tbl_columns_definition_form_test.php diff --git a/test/libraries/PMA_tbl_columns_definition_form_test.php b/test/libraries/PMA_tbl_columns_definition_form_test.php new file mode 100644 index 0000000000..ee4c948cea --- /dev/null +++ b/test/libraries/PMA_tbl_columns_definition_form_test.php @@ -0,0 +1,1116 @@ +assertEquals( + array( + 'db' => 'dbname', + 'reload' => 1, + 'orig_num_fields' => 22, + 'orig_field_where' => 'fwhere', + 'orig_after_field' => 'affield', + 'selected[0]' => 12, + 'selected[1]' => 13 + ), + $result + ); + + // case 2 + $result = PMA_getFormsParameters( + "dbname", "tablename", "tbl_addfield.php", null, 1 + ); + + $this->assertEquals( + array( + 'db' => 'dbname', + 'table' => 'tablename', + 'orig_field_where' => 'fwhere', + 'orig_after_field' => 'affield', + 'field_where' => 'fwhere', + 'after_field' => 'affield' + ), + $result + ); + + // case 3 + $_REQUEST['after_field'] = null; + $_REQUEST['field_where'] = null; + + $result = PMA_getFormsParameters( + "dbname", "tablename", null, 0, null + ); + + $this->assertEquals( + array( + 'db' => 'dbname', + 'table' => 'tablename', + 'orig_num_fields' => 0 + ), + $result + ); + } + + /** + * Test for PMA_getHtmlForTableConfigurations + * + * @return void + */ + public function testGetHtmlForTableConfigurations() + { + $_REQUEST['comment'] = 'c&d'; + $_REQUEST['tbl_storage_engine'] = 'engine'; + $_REQUEST['tbl_collation'] = 'latin1_swedish_ci'; + $_REQUEST['partition_definition'] = "partition>"; + + $dbi = $this->getMockBuilder('PMA_DatabaseInterface') + ->disableOriginalConstructor() + ->getMock(); + + $dbi->expects($this->any()) + ->method('fetchResult') + ->will( + $this->returnValue( + array( + array( + 'Name' => 'partition', + 'Support' => 'NO' + ) + ) + ) + ); + + $GLOBALS['dbi'] = $dbi; + + $result = PMA_getHtmlForTableConfigurations(); + + $this->assertTag( + PMA_getTagArray( + 'assertTag( + PMA_getTagArray( + '' + ), + $result + ); + + $this->assertTag( + PMA_getTagArray( + '' + ), + $result + ); + + $this->assertTag( + PMA_getTagArray( + '' + ), + $result + ); + } + + /** + * Test for PMA_getHtmlForFooter + * + * @return void + */ + public function testGetHtmlForFooter() + { + $result = PMA_getHtmlForFooter(); + + $this->assertTag( + PMA_getTagArray( + '' + ), + $result + ); + + $this->assertTag( + PMA_getTagArray( + '
' + ), + $result + ); + + $this->assertTag( + PMA_getTagArray( + '