From 7f05587905c97cc58e33d96a14a111c70cd1eba3 Mon Sep 17 00:00:00 2001 From: Kamil Tekiela Date: Fri, 21 Apr 2023 15:44:31 +0100 Subject: [PATCH] Remove method_exists Signed-off-by: Kamil Tekiela --- libraries/classes/InsertEdit.php | 6 ++---- psalm-baseline.xml | 9 +-------- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/libraries/classes/InsertEdit.php b/libraries/classes/InsertEdit.php index 91d9220129..1a09de16b1 100644 --- a/libraries/classes/InsertEdit.php +++ b/libraries/classes/InsertEdit.php @@ -7,6 +7,7 @@ namespace PhpMyAdmin; use PhpMyAdmin\ConfigStorage\Relation; use PhpMyAdmin\Dbal\ResultInterface; use PhpMyAdmin\Html\Generator; +use PhpMyAdmin\Plugins\IOTransformationsPlugin; use PhpMyAdmin\Plugins\TransformationsPlugin; use PhpMyAdmin\Utils\Gis; @@ -33,7 +34,6 @@ use function mb_stripos; use function mb_strlen; use function mb_strstr; use function md5; -use function method_exists; use function min; use function password_hash; use function preg_match; @@ -1847,7 +1847,7 @@ class InsertEdit $currentValue = $currentRow[$column['Field']]; } - if (method_exists($transformationPlugin, 'getInputHtml')) { + if ($transformationPlugin instanceof IOTransformationsPlugin) { $transformedHtml = $transformationPlugin->getInputHtml( $column, $rowId, @@ -1858,9 +1858,7 @@ class InsertEdit $tabindex, $idindex, ); - } - if (method_exists($transformationPlugin, 'getScripts')) { $GLOBALS['plugin_scripts'] = array_merge( $GLOBALS['plugin_scripts'], $transformationPlugin->getScripts(), diff --git a/psalm-baseline.xml b/psalm-baseline.xml index d0fe2c8593..42b72e9597 100644 --- a/psalm-baseline.xml +++ b/psalm-baseline.xml @@ -7944,6 +7944,7 @@ + $currentValue $defaultValue @@ -7959,7 +7960,6 @@ $rows[$keyId] $singleQuery $singleQuery - getScripts()]]> $whereClause $whereClause @@ -8031,7 +8031,6 @@ $setSelectSize $singleQuery $specialChars - $transformedHtml $whereClause $whereClause $whereClause @@ -10268,12 +10267,6 @@ bool - - - getInputHtml - getScripts - - $nameArray === false