';
+ $html .= '
';
$html .= '
';
- $html .= '
';
+ $html .= '
';
+ $html .= '
';
+ $html .= '
';
+ $html .= PMA_Util::getImage('b_saveimage', __('Save'));
+ $html .= ' ';
- $html .= '
';
- $html .= '
';
- $html .= '';
- $html .= '';
-
- $html .= '
';
- $html .= '
';
- $html .= '';
$html .= '
';
$html .= '
';
diff --git a/tbl_gis_visualization.php b/tbl_gis_visualization.php
index 3888c05069..3448ba103c 100644
--- a/tbl_gis_visualization.php
+++ b/tbl_gis_visualization.php
@@ -67,11 +67,7 @@ while ($row = $GLOBALS['dbi']->fetchAssoc($modified_result)) {
if (isset($_REQUEST['saveToFile'])) {
$response->disable();
- $file_name = $_REQUEST['fileName'];
- if ($file_name == '') {
- $file_name = $visualizationSettings['spatialColumn'];
- }
-
+ $file_name = $visualizationSettings['spatialColumn'];
$save_format = $_REQUEST['fileFormat'];
PMA_GIS_saveToFile($data, $visualizationSettings, $save_format, $file_name);
exit();
diff --git a/test/libraries/PMA_tbl_gis_visualization_test.php b/test/libraries/PMA_tbl_gis_visualization_test.php
index dcb8b81457..457c4bbad8 100644
--- a/test/libraries/PMA_tbl_gis_visualization_test.php
+++ b/test/libraries/PMA_tbl_gis_visualization_test.php
@@ -91,18 +91,18 @@ class PMA_TblGisVisualizaionTest extends PHPUnit_Framework_TestCase
}
/**
- * Tests for PMA_getHtmlForColumn() method.
+ * Tests for PMA_getHtmlForSelect() method.
*
* @return void
* @test
*/
- public function testPMAGetHtmlForColumn()
+ public function testPMAGetHtmlForSelect()
{
$column = 0;
$columnCandidates = array("option1", "option2");
$visualizationSettings = array("option2", "option3");
- $html = PMA_getHtmlForColumn(
+ $html = PMA_getHtmlForSelect(
$column, $columnCandidates, $visualizationSettings
);
@@ -164,7 +164,7 @@ class PMA_TblGisVisualizaionTest extends PHPUnit_Framework_TestCase
$html
);
- $output = PMA_getHtmlForColumn(
+ $output = PMA_getHtmlForSelect(
"labelColumn", $labelCandidates, $visualizationSettings
);
$this->assertContains(
@@ -172,7 +172,7 @@ class PMA_TblGisVisualizaionTest extends PHPUnit_Framework_TestCase
$html
);
- $output = PMA_getHtmlForColumn(
+ $output = PMA_getHtmlForSelect(
"spatialColumn", $spatialCandidates, $visualizationSettings
);
$this->assertContains(
@@ -180,28 +180,18 @@ class PMA_TblGisVisualizaionTest extends PHPUnit_Framework_TestCase
$html
);
- $this->assertContains(
- __('Redraw'),
- $html
- );
-
- $this->assertContains(
- __('Download'),
- $html
- );
-
$this->assertContains(
htmlspecialchars($sql_query),
$html
);
$this->assertContains(
- '
PNG ',
+ '>PNG',
$html
);
$this->assertContains(
- '
PDF ',
+ '>PDF',
$html
);
diff --git a/themes/original/css/common.css.php b/themes/original/css/common.css.php
index 22fad0cb7a..57a5e275f3 100644
--- a/themes/original/css/common.css.php
+++ b/themes/original/css/common.css.php
@@ -2049,7 +2049,7 @@ fieldset .disabled-field td {
#placeholder {
position: relative;
border: 1px solid #aaa;
- float: right;
+ float: ;
overflow: hidden;
}
diff --git a/themes/pmahomme/css/gis.css.php b/themes/pmahomme/css/gis.css.php
index 66348e344e..f0de2111ae 100644
--- a/themes/pmahomme/css/gis.css.php
+++ b/themes/pmahomme/css/gis.css.php
@@ -13,19 +13,6 @@ if (! defined('PMA_MINIMUM_COMMON') && ! defined('TESTSUITE')) {
}
?>
-.gis_table td {
- vertical-align: middle;
-}
-
-.gis_table select {
- min-width: 151px;
- margin: 6px;
-}
-
-.gis_table .button {
- text-align: ;
-}
-
/**
* GIS data editor styles
*/