gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix grid edit Enter on datetime fields triggering SQL modal When editing a datetime cell a second time, focus can be inside the datepicker widget instead of the text input. Enter was only handled on keyup for the input, so the key bubbled and submitted the SQL query form. Handle Enter on keydown for the input and for the cEdit container, and clean up datepicker/event state when closing the editor. Fixes #20323 Signed-off-by: Prabin Devkota <prabindev789@gmail.com>

Browse Source
This commit is contained in:
PrabinDevkota 2026-06-02 02:31:03 +05:30 committed by GitHub
parent 2743a0a7ef
commit 81ae47f588
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
resources/js/makegrid.ts
View File

@ -1191,7 +1191,10 @@ const makeGrid = function (t, enableResize = undefined, enableReorder = undefine
firstDay: window.firstDayOfCalendar,
});
$inputField.on('keyup', function (e) {
$inputField.off('keydown.gridEditDateTime keyup.gridEditDateTime');
$(g.cEdit).off('keydown.gridEditDateTime');
$inputField.on('keydown.gridEditDateTime', function (e) {
if (e.which === 13) {
// post on pressing "Enter"
e.preventDefault();
@ -1202,6 +1205,15 @@ const makeGrid = function (t, enableResize = undefined, enableReorder = undefine
}
});
// Catch Enter when focus is in the datepicker UI (inside cEdit)
$(g.cEdit).on('keydown.gridEditDateTime', function (e) {
if (e.which === 13 && ! $(e.target).is('.edit_box')) {
e.preventDefault();
e.stopPropagation();
g.saveOrPostEditedCell();
}
});
$inputField.datepicker('show');
toggleDatepickerIfInvalid($td, $inputField);