From aaef71a2fc3d8f778b2df7503d1a50e7840f3346 Mon Sep 17 00:00:00 2001
From: xmujay <xmujay@gmail.com>
Date: Wed, 8 May 2013 23:41:41 +0800
Subject: [PATCH 1/2] refactor server_engines.php, split to small function

---
 server_engines.php | 68 +++++++++++++++++++++++++++++++++++++---------
 1 file changed, 55 insertions(+), 13 deletions(-)

diff --git a/server_engines.php b/server_engines.php
index b0f6955341..338fca783d 100644
--- a/server_engines.php
+++ b/server_engines.php
@@ -18,22 +18,55 @@ require 'libraries/server_common.inc.php';
 require 'libraries/StorageEngine.class.php';
 
 /**
- * Did the user request information about a certain storage engine?
+ * start output
  */
-$html = '';
-if (empty($_REQUEST['engine'])
-    || ! PMA_StorageEngine::isValid($_REQUEST['engine'])
-) {
+$response = PMA_Response::getInstance();
+$response->addHTML(PMA_getServerEnginesHtml());
 
+exit;
+
+
+/**
+ * Prints server Engines information
+ *
+ * @param null
+ *
+ * @return string
+ */
+function PMA_getServerEnginesHtml()
+{
+	/**
+	 * Did the user request information about a certain storage engine?
+	 */
+	$html = '';
+	if (empty($_REQUEST['engine'])
+	    || ! PMA_StorageEngine::isValid($_REQUEST['engine'])
+	) {
+	    $html .= PMA_getAllServerEnginesHtml();	
+	} else {
+	    $html .= PMA_getSpecifiedServerEnginesHtml();
+	}
+	
+	return $html;
+}
+
+/**
+ * Prints server all Engines information
+ *
+ * @param null
+ *
+ * @return string
+ */
+function PMA_getAllServerEnginesHtml()
+{
     /**
      * Displays the sub-page heading
      */
-    $html .= '<h2>' . "\n"
+    $html = '<h2>' . "\n"
         . PMA_Util::getImage('b_engine.png')
         . "\n" . __('Storage Engines') . "\n"
         . '</h2>' . "\n";
 
-
     /**
      * Displays the table header
      */
@@ -68,13 +101,23 @@ if (empty($_REQUEST['engine'])
     unset($odd_row, $engine, $details);
     $html .= '</tbody>' . "\n"
         . '</table>' . "\n";
+    
+    return $html;
+}
 
-} else {
-
+/**
+ * Prints a given Storage Engine
+ *
+ * @param null
+ *
+ * @return string
+ */
+function PMA_getSpecifiedServerEnginesHtml()
+{
     /**
      * Displays details about a given Storage Engine
      */
-
+    $html = ''; 
     $engine_plugin = PMA_StorageEngine::getEngine($_REQUEST['engine']);
     $html .= '<h2>' . "\n"
         . PMA_Util::getImage('b_engine.png')
@@ -124,9 +167,8 @@ if (empty($_REQUEST['engine'])
            . '</p>' . "\n"
            . $engine_plugin->getHtmlVariables();
     }
+    
+    return $html;
 }
 
-$response = PMA_Response::getInstance();
-$response->addHTML($html);
-
 ?>

From 48f14a12f7db44ba8d8dfd8386e5fd16a3973b02 Mon Sep 17 00:00:00 2001
From: xmujay <xmujay@gmail.com>
Date: Thu, 9 May 2013 15:21:08 +0800
Subject: [PATCH 2/2] modify the comment which is not print HTML

---
 server_engines.php | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/server_engines.php b/server_engines.php
index 338fca783d..892d523096 100644
--- a/server_engines.php
+++ b/server_engines.php
@@ -27,7 +27,7 @@ exit;
 
 
 /**
- * Prints server Engines information
+ * setup HTML for server Engines information
  *
  * @param null
  *
@@ -51,7 +51,7 @@ function PMA_getServerEnginesHtml()
 }
 
 /**
- * Prints server all Engines information
+ * setup HTML for server all Engines information
  *
  * @param null
  *
@@ -106,7 +106,7 @@ function PMA_getAllServerEnginesHtml()
 }
 
 /**
- * Prints a given Storage Engine
+ * setup HTML for a given Storage Engine
  *
  * @param null
  *