diff --git a/libraries/classes/Tracker.php b/libraries/classes/Tracker.php index 242d4efd59..fb97c6de32 100644 --- a/libraries/classes/Tracker.php +++ b/libraries/classes/Tracker.php @@ -950,7 +950,7 @@ class Tracker " AND `db_name` = '" . $dbi->escapeString($dbname ?? '') . "' " . " AND `table_name` = '" . $dbi->escapeString($result['tablename']) . "' " . - " AND `version` = '" . $dbi->escapeString($version ?? '') . "' "; + " AND `version` = '" . $dbi->escapeString((string) $version) . "' "; $dbi->queryAsControlUser($sqlQuery); } diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index 14f8a450e9..5b763d74ba 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -8370,11 +8370,6 @@ parameters: count: 1 path: libraries/classes/Tracker.php - - - message: "#^Variable \\$version on left side of \\?\\? always exists and is not nullable\\.$#" - count: 1 - path: libraries/classes/Tracker.php - - message: "#^Cannot access offset 'COLUMNS' on mixed\\.$#" count: 1 diff --git a/psalm-baseline.xml b/psalm-baseline.xml index e1464246c1..35f1fc76d3 100644 --- a/psalm-baseline.xml +++ b/psalm-baseline.xml @@ -13412,8 +13412,7 @@ - - '' + null null null @@ -13463,9 +13462,6 @@ mb_strpos($logEntry, "\n") mb_strpos($logEntry, "\n") - - $version ?? '' - $statement->body[2]->value $statement->body[3]->value @@ -13481,10 +13477,9 @@ $dbname - + $statement->name !== null $statement->name !== null - $version isset($statement->options) diff --git a/test/selenium/Table/CreateTest.php b/test/selenium/Table/CreateTest.php index 54c67e8f2f..8faed4697d 100644 --- a/test/selenium/Table/CreateTest.php +++ b/test/selenium/Table/CreateTest.php @@ -65,7 +65,7 @@ class CreateTest extends TestBase $column_dropdown_details = [ 'field_0_6' => 'UNSIGNED', 'field_1_2' => 'VARCHAR', - 'field_1_5' => 'utf8_general_ci', + 'field_1_5' => 'utf8mb4_general_ci', 'field_1_4' => 'As defined:', ]; @@ -83,7 +83,7 @@ class CreateTest extends TestBase $this->moveto($ele); // post $ele->click(); - $this->waitForElement('cssSelector', 'li.last.table'); + $this->waitForElement('cssSelector', 'li.last.nav_node_table'); $this->waitAjax(); @@ -162,7 +162,7 @@ class CreateTest extends TestBase ); $this->assertEquals( - 'utf8_general_ci', + 'utf8mb4_general_ci', $this->getCellByTableId('tablestructure', 2, 5) );