From 8f943ae1c08cddacdff09a80eab050edf457b51e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= Date: Thu, 6 Jul 2017 21:19:57 -0300 Subject: [PATCH] Move classes to PhpMyAdmin namespace MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Move Sanitize to PhpMyAdmin namespace - Move SavedSearches to PhpMyAdmin namespace - Move Scripts to PhpMyAdmin namespace - Move ServerStatusData to PhpMyAdmin namespace - Move Sql to PhpMyAdmin namespace - Move StorageEngine to PhpMyAdmin namespace - Move SubPartition to PhpMyAdmin namespace - Move SysInfoLinux to PhpMyAdmin namespace - Move SysInfoSunOS to PhpMyAdmin namespace - Move SysInfoWINNT to PhpMyAdmin namespace - Move SysInfo to PhpMyAdmin namespace - Move SystemDatabase to PhpMyAdmin namespace Signed-off-by: MaurĂ­cio Meneghini Fauth --- db_qbe.php | 4 ++-- export.php | 2 +- import.php | 2 +- index.php | 2 +- js/messages.php | 2 +- libraries/Util.php | 2 +- libraries/classes/Core.php | 2 +- libraries/classes/DatabaseInterface.php | 2 +- libraries/classes/DbSearch.php | 2 +- libraries/classes/DisplayResults.php | 4 ++-- libraries/classes/Footer.php | 4 ++-- libraries/classes/Header.php | 4 ++-- libraries/classes/Index.php | 2 +- libraries/classes/Message.php | 2 +- libraries/classes/Partition.php | 2 +- libraries/{ => classes}/Sanitize.php | 24 +++++++++---------- libraries/{ => classes}/SavedSearches.php | 6 ++++- libraries/{ => classes}/Scripts.php | 4 ++-- libraries/{ => classes}/ServerStatusData.php | 5 ++-- libraries/{ => classes}/Sql.php | 10 ++++---- libraries/{ => classes}/StorageEngine.php | 15 ++++++------ libraries/{ => classes}/SubPartition.php | 4 ++-- libraries/{ => classes}/SysInfo.php | 10 ++++---- libraries/{ => classes}/SysInfoLinux.php | 12 ++++++---- libraries/{ => classes}/SysInfoSunOS.php | 14 ++++++----- libraries/{ => classes}/SysInfoWINNT.php | 11 +++++---- libraries/{ => classes}/SystemDatabase.php | 9 +++---- libraries/common.inc.php | 2 +- libraries/config/FormDisplay.php | 2 +- libraries/config/FormDisplay.tpl.php | 2 +- libraries/config/config_functions.lib.php | 2 +- .../database/DatabaseStructureController.php | 2 +- .../server/ServerEnginesController.php | 2 +- .../table/TableSearchController.php | 2 +- .../table/TableStructureController.php | 2 +- libraries/display_import.lib.php | 2 +- libraries/engines/Bdb.php | 2 +- libraries/engines/Binlog.php | 2 +- libraries/engines/Innodb.php | 2 +- libraries/engines/Memory.php | 2 +- libraries/engines/Merge.php | 2 +- libraries/engines/Myisam.php | 2 +- libraries/engines/Ndbcluster.php | 2 +- libraries/engines/Pbxt.php | 2 +- libraries/engines/PerformanceSchema.php | 2 +- libraries/error.inc.php | 2 +- libraries/export.lib.php | 2 +- libraries/gis/GISVisualization.php | 2 +- libraries/insert_edit.lib.php | 2 +- libraries/mult_submits.inc.php | 2 +- libraries/mult_submits.lib.php | 2 +- libraries/navigation/NavigationHeader.php | 2 +- libraries/operations.lib.php | 2 +- libraries/plugins/AuthenticationPlugin.php | 2 +- .../abs/DateFormatTransformationsPlugin.php | 2 +- .../TextImageLinkTransformationsPlugin.php | 2 +- .../abs/TextLinkTransformationsPlugin.php | 2 +- libraries/server_status.lib.php | 2 +- libraries/server_status_monitor.lib.php | 2 +- libraries/server_status_processes.lib.php | 2 +- libraries/server_status_queries.lib.php | 2 +- libraries/server_status_variables.lib.php | 2 +- libraries/sysinfo.lib.php | 10 ++++---- libraries/tracking.lib.php | 2 +- libraries/twig/SanitizeExtension.php | 2 +- libraries/user_preferences.inc.php | 2 +- prefs_manage.php | 2 +- server_status.php | 2 +- server_status_advisor.php | 2 +- server_status_monitor.php | 2 +- server_status_processes.php | 2 +- server_status_queries.php | 2 +- server_status_variables.php | 2 +- setup/frames/index.inc.php | 2 +- setup/lib/index.lib.php | 2 +- sql.php | 2 +- tbl_row_action.php | 2 +- .../column_definitions_form.phtml | 2 +- .../columns_definitions/partitions.phtml | 2 +- .../database/structure/table_header.phtml | 2 +- templates/server/databases/table_row.phtml | 2 +- .../table/relation/foreign_key_row.phtml | 2 +- test/classes/CoreTest.php | 2 +- test/classes/DatabaseInterfaceTest.php | 2 +- test/classes/SanitizeTest.php | 2 +- test/classes/ScriptsTest.php | 4 ++-- test/classes/ServerStatusDataTest.php | 2 +- test/classes/SqlTest.php | 6 ++--- test/classes/StorageEngineTest.php | 6 ++--- test/classes/SystemDatabaseTest.php | 2 +- .../ServerEnginesControllerTest.php | 2 +- test/libraries/PMA_insert_edit_test.php | 2 +- .../PMA_server_status_advisor_test.php | 2 +- .../PMA_server_status_monitor_test.php | 2 +- .../PMA_server_status_queries_test.php | 2 +- test/libraries/PMA_server_status_test.php | 2 +- .../PMA_server_status_variables_test.php | 2 +- test/libraries/sysinfo_test.php | 2 +- url.php | 2 +- 99 files changed, 168 insertions(+), 156 deletions(-) rename libraries/{ => classes}/Sanitize.php (95%) rename libraries/{ => classes}/SavedSearches.php (99%) rename libraries/{ => classes}/Scripts.php (99%) rename libraries/{ => classes}/ServerStatusData.php (99%) rename libraries/{ => classes}/Sql.php (99%) rename libraries/{ => classes}/StorageEngine.php (98%) rename libraries/{ => classes}/SubPartition.php (99%) rename libraries/{ => classes}/SysInfo.php (86%) rename libraries/{ => classes}/SysInfoLinux.php (91%) rename libraries/{ => classes}/SysInfoSunOS.php (91%) rename libraries/{ => classes}/SysInfoWINNT.php (94%) rename libraries/{ => classes}/SystemDatabase.php (96%) diff --git a/db_qbe.php b/db_qbe.php index 52071b3daf..b31f84ff93 100644 --- a/db_qbe.php +++ b/db_qbe.php @@ -7,8 +7,8 @@ */ use PhpMyAdmin\Response; -use PMA\libraries\SavedSearches; -use PMA\libraries\Sql; +use PhpMyAdmin\SavedSearches; +use PhpMyAdmin\Sql; use PMA\libraries\URL; /** diff --git a/export.php b/export.php index a5940fcf73..60c91fcac2 100644 --- a/export.php +++ b/export.php @@ -10,7 +10,7 @@ use PhpMyAdmin\Core; use PhpMyAdmin\Encoding; use PMA\libraries\plugins\ExportPlugin; use PMA\libraries\URL; -use PMA\libraries\Sanitize; +use PhpMyAdmin\Sanitize; /** * Get the variables sent or posted to this script and a core script diff --git a/import.php b/import.php index d47f9adbc6..9a963a7db0 100644 --- a/import.php +++ b/import.php @@ -12,7 +12,7 @@ use PhpMyAdmin\Encoding; use PhpMyAdmin\File; use PMA\libraries\plugins\ImportPlugin; use PhpMyAdmin\Response; -use PMA\libraries\Sql; +use PhpMyAdmin\Sql; use PMA\libraries\URL; /* Enable LOAD DATA LOCAL INFILE for LDI plugin */ diff --git a/index.php b/index.php index c2948b4d43..1759ec0ec0 100644 --- a/index.php +++ b/index.php @@ -12,7 +12,7 @@ use PhpMyAdmin\LanguageManager; use PhpMyAdmin\Message; use PhpMyAdmin\RecentFavoriteTable; use PhpMyAdmin\Response; -use PMA\libraries\Sanitize; +use PhpMyAdmin\Sanitize; use PMA\libraries\ThemeManager; use PMA\libraries\URL; diff --git a/js/messages.php b/js/messages.php index dc9d64a9ad..aecf237699 100644 --- a/js/messages.php +++ b/js/messages.php @@ -26,7 +26,7 @@ if (!defined('TESTSUITE')) { } // But this one is needed for Sanitize::escapeJsString() -use PMA\libraries\Sanitize; +use PhpMyAdmin\Sanitize; $buffer = PhpMyAdmin\OutputBuffering::getInstance(); diff --git a/libraries/Util.php b/libraries/Util.php index 7afb7d3648..a3033febd6 100644 --- a/libraries/Util.php +++ b/libraries/Util.php @@ -12,7 +12,7 @@ use PhpMyAdmin\DatabaseInterface; use PhpMyAdmin\Message; use PMA\libraries\plugins\ImportPlugin; use PhpMyAdmin\Response; -use PMA\libraries\Sanitize; +use PhpMyAdmin\Sanitize; use PhpMyAdmin\SqlParser\Context; use PhpMyAdmin\SqlParser\Lexer; use PhpMyAdmin\SqlParser\Parser; diff --git a/libraries/classes/Core.php b/libraries/classes/Core.php index 1f42732bcf..87c8c47f95 100644 --- a/libraries/classes/Core.php +++ b/libraries/classes/Core.php @@ -12,7 +12,7 @@ namespace PhpMyAdmin; use PhpMyAdmin\DatabaseInterface; use PhpMyAdmin\Message; use PhpMyAdmin\Response; -use PMA\libraries\Sanitize; +use PhpMyAdmin\Sanitize; use PMA\libraries\Template; use PMA\libraries\URL; use PMA\libraries\Util; diff --git a/libraries/classes/DatabaseInterface.php b/libraries/classes/DatabaseInterface.php index 101b4e2efb..3feaa45e68 100644 --- a/libraries/classes/DatabaseInterface.php +++ b/libraries/classes/DatabaseInterface.php @@ -12,7 +12,7 @@ use PMA\libraries\dbi\DBIExtension; use PhpMyAdmin\Error; use PhpMyAdmin\Index; use PhpMyAdmin\LanguageManager; -use PMA\libraries\SystemDatabase; +use PhpMyAdmin\SystemDatabase; use PMA\libraries\Table; use PMA\libraries\Tracker; use PMA\libraries\URL; diff --git a/libraries/classes/DbSearch.php b/libraries/classes/DbSearch.php index e1b70009e8..34546618f3 100644 --- a/libraries/classes/DbSearch.php +++ b/libraries/classes/DbSearch.php @@ -7,7 +7,7 @@ */ namespace PhpMyAdmin; -use PMA\libraries\Sanitize; +use PhpMyAdmin\Sanitize; use PMA\libraries\URL; use PMA\libraries\Util; diff --git a/libraries/classes/DisplayResults.php b/libraries/classes/DisplayResults.php index dc313264af..e4d5a711b9 100644 --- a/libraries/classes/DisplayResults.php +++ b/libraries/classes/DisplayResults.php @@ -13,8 +13,8 @@ use PhpMyAdmin\Index; use PhpMyAdmin\Message; use PMA\libraries\plugins\transformations\Text_Plain_Link; use PhpMyAdmin\Response; -use PMA\libraries\Sanitize; -use PMA\libraries\Sql; +use PhpMyAdmin\Sanitize; +use PhpMyAdmin\Sql; use PhpMyAdmin\SqlParser\Utils\Query; use PMA\libraries\Table; use PMA\libraries\Template; diff --git a/libraries/classes/Footer.php b/libraries/classes/Footer.php index 3b045b636b..5077493223 100644 --- a/libraries/classes/Footer.php +++ b/libraries/classes/Footer.php @@ -11,8 +11,8 @@ use PhpMyAdmin\Config; use PhpMyAdmin\Core; use PhpMyAdmin\Message; use PhpMyAdmin\Response; -use PMA\libraries\Sanitize; -use PMA\libraries\Scripts; +use PhpMyAdmin\Sanitize; +use PhpMyAdmin\Scripts; use PMA\libraries\URL; use PMA\libraries\Util; use Traversable; diff --git a/libraries/classes/Header.php b/libraries/classes/Header.php index 816ae7815e..4eab447e43 100644 --- a/libraries/classes/Header.php +++ b/libraries/classes/Header.php @@ -14,8 +14,8 @@ use PhpMyAdmin\Menu; use PhpMyAdmin\Message; use PMA\libraries\navigation\Navigation; use PhpMyAdmin\RecentFavoriteTable; -use PMA\libraries\Sanitize; -use PMA\libraries\Scripts; +use PhpMyAdmin\Sanitize; +use PhpMyAdmin\Scripts; use PMA\libraries\URL; use PMA\libraries\Util; diff --git a/libraries/classes/Index.php b/libraries/classes/Index.php index 1e11ea5b94..c2d6d57170 100644 --- a/libraries/classes/Index.php +++ b/libraries/classes/Index.php @@ -9,7 +9,7 @@ namespace PhpMyAdmin; use PhpMyAdmin\IndexColumn; use PhpMyAdmin\Message; -use PMA\libraries\Sanitize; +use PhpMyAdmin\Sanitize; use PMA\libraries\URL; use PMA\libraries\Util; diff --git a/libraries/classes/Message.php b/libraries/classes/Message.php index 79988d3842..212d5636e4 100644 --- a/libraries/classes/Message.php +++ b/libraries/classes/Message.php @@ -7,7 +7,7 @@ */ namespace PhpMyAdmin; -use PMA\libraries\Sanitize; +use PhpMyAdmin\Sanitize; use PMA\libraries\Util; /** diff --git a/libraries/classes/Partition.php b/libraries/classes/Partition.php index 6006cb3041..7f721199eb 100644 --- a/libraries/classes/Partition.php +++ b/libraries/classes/Partition.php @@ -7,7 +7,7 @@ */ namespace PhpMyAdmin; -use PMA\libraries\SubPartition; +use PhpMyAdmin\SubPartition; /** * base Partition Class diff --git a/libraries/Sanitize.php b/libraries/classes/Sanitize.php similarity index 95% rename from libraries/Sanitize.php rename to libraries/classes/Sanitize.php index e05340a5ca..b71705d42b 100644 --- a/libraries/Sanitize.php +++ b/libraries/classes/Sanitize.php @@ -5,7 +5,7 @@ * * @package PhpMyAdmin */ -namespace PMA\libraries; +namespace PhpMyAdmin; use PhpMyAdmin\Core; use PMA\libraries\Util; @@ -91,7 +91,7 @@ class Sanitize public static function replaceBBLink($found) { /* Check for valid link */ - if (! Sanitize::checkLink($found[1])) { + if (! self::checkLink($found[1])) { return $found[0]; } /* a-z and _ allowed in target */ @@ -197,14 +197,14 @@ class Sanitize /* Find and replace all links */ $message = preg_replace_callback($pattern, function($match){ - return Sanitize::replaceBBLink($match); + return self::replaceBBLink($match); }, $message); /* Replace documentation links */ $message = preg_replace_callback( '/\[doc@([a-zA-Z0-9_-]+)(@([a-zA-Z0-9_-]*))?\]/', function($match){ - return Sanitize::replaceDocLink($match); + return self::replaceDocLink($match); }, $message ); @@ -262,7 +262,7 @@ class Sanitize public static function jsFormat($a_string = '', $add_backquotes = true) { $a_string = htmlspecialchars($a_string); - $a_string = Sanitize::escapeJsString($a_string); + $a_string = self::escapeJsString($a_string); // Needed for inline javascript to prevent some browsers // treating it as a anchor $a_string = str_replace('#', '\\#', $a_string); @@ -270,7 +270,7 @@ class Sanitize return $add_backquotes ? Util::backquote($a_string) : $a_string; - } // end of the 'Sanitize::jsFormat()' function + } // end of the 'jsFormat' function /** * escapes a string to be inserted as string a JavaScript block @@ -323,7 +323,7 @@ class Sanitize return (int)$value; } - return '"' . Sanitize::escapeJsString($value) . '"'; + return '"' . self::escapeJsString($value) . '"'; } /** @@ -345,11 +345,11 @@ class Sanitize } elseif (is_array($value)) { $result .= '['; foreach ($value as $val) { - $result .= Sanitize::formatJsVal($val) . ","; + $result .= self::formatJsVal($val) . ","; } $result .= "];\n"; } else { - $result .= Sanitize::formatJsVal($value) . ";\n"; + $result .= self::formatJsVal($value) . ";\n"; } return $result; } @@ -365,7 +365,7 @@ class Sanitize */ public static function printJsValue($key, $value) { - echo Sanitize::getJsValue($key, $value); + echo self::getJsValue($key, $value); } /** @@ -385,7 +385,7 @@ class Sanitize if ($addOn) { $result .= '$.validator.format('; } - $result .= Sanitize::formatJsVal($value); + $result .= self::formatJsVal($value); if ($addOn) { $result .= ')'; } @@ -408,7 +408,7 @@ class Sanitize */ public static function printJsValueForFormValidation($key, $value, $addOn=false, $comma=true) { - echo Sanitize::getJsValueForFormValidation($key, $value, $addOn, $comma); + echo self::getJsValueForFormValidation($key, $value, $addOn, $comma); } /** diff --git a/libraries/SavedSearches.php b/libraries/classes/SavedSearches.php similarity index 99% rename from libraries/SavedSearches.php rename to libraries/classes/SavedSearches.php index 9cd652afaa..221da4f725 100644 --- a/libraries/SavedSearches.php +++ b/libraries/classes/SavedSearches.php @@ -5,7 +5,11 @@ * * @package PhpMyAdmin */ -namespace PMA\libraries; +namespace PhpMyAdmin; + +use PhpMyAdmin\Message; +use PhpMyAdmin\Response; +use PMA\libraries\Util; /** * Saved searches managing diff --git a/libraries/Scripts.php b/libraries/classes/Scripts.php similarity index 99% rename from libraries/Scripts.php rename to libraries/classes/Scripts.php index 551d0102b3..66283bcdd3 100644 --- a/libraries/Scripts.php +++ b/libraries/classes/Scripts.php @@ -5,11 +5,11 @@ * * @package PhpMyAdmin */ -namespace PMA\libraries; +namespace PhpMyAdmin; use PhpMyAdmin\Header; +use PhpMyAdmin\Sanitize; use PMA\libraries\URL; -use PMA\libraries\Sanitize; /** * Collects information about which JavaScript diff --git a/libraries/ServerStatusData.php b/libraries/classes/ServerStatusData.php similarity index 99% rename from libraries/ServerStatusData.php rename to libraries/classes/ServerStatusData.php index 52ddf19283..4fa649a61e 100644 --- a/libraries/ServerStatusData.php +++ b/libraries/classes/ServerStatusData.php @@ -6,7 +6,7 @@ * * @package PhpMyAdmin */ -namespace PMA\libraries; +namespace PhpMyAdmin; use PMA\libraries\URL; @@ -477,7 +477,7 @@ class ServerStatusData */ public static function getHtmlForRefreshList($name, $defaultRate = 5, - $refreshRates = Array(1, 2, 5, 10, 20, 40, 60, 120, 300, 600) + $refreshRates = array(1, 2, 5, 10, 20, 40, 60, 120, 300, 600) ) { $return = '