From 0b64827930ef5232149ea211647cb7c95719d2d5 Mon Sep 17 00:00:00 2001 From: Durgesh <007durgesh219@gmail.com> Date: Fri, 19 Feb 2016 19:03:11 +0530 Subject: [PATCH 1/2] Refactored url parmeters generating, Issue #11990 Signed-off-by: Durgesh <007durgesh219@gmail.com> --- db_central_columns.php | 4 +- db_datadict.php | 3 +- db_qbe.php | 3 +- export.php | 7 +- gis_data_editor.php | 3 +- import.php | 13 +- index.php | 9 +- libraries/Advisor.php | 3 +- libraries/Config.php | 3 +- libraries/DatabaseInterface.php | 3 +- libraries/DbQbe.php | 6 +- libraries/DbSearch.php | 10 +- libraries/DisplayResults.php | 55 ++-- libraries/Footer.php | 5 +- libraries/Header.php | 8 +- libraries/Index.php | 6 +- libraries/Menu.php | 8 +- libraries/RecentFavoriteTable.php | 12 +- libraries/Scripts.php | 6 +- libraries/ServerStatusData.php | 16 +- libraries/Theme.php | 4 +- libraries/ThemeManager.php | 4 +- libraries/URL.php | 251 ++++++++++++++++++ libraries/Util.php | 41 +-- libraries/browse_foreigners.lib.php | 3 +- libraries/central_columns.lib.php | 13 +- libraries/common.inc.php | 5 - libraries/config/FormDisplay.tpl.php | 5 +- libraries/config/ServerConfigChecks.php | 30 ++- .../database/DatabaseStructureController.php | 3 +- .../server/ServerBinlogController.php | 9 +- .../server/ServerDatabasesController.php | 7 +- .../server/ServerVariablesController.php | 3 +- .../table/TableGisVisualizationController.php | 3 +- .../table/TableStructureController.php | 5 +- libraries/core.lib.php | 9 +- libraries/db_common.inc.php | 9 +- libraries/db_table_exists.lib.php | 3 +- libraries/display_change_password.lib.php | 3 +- libraries/display_export.lib.php | 7 +- libraries/display_import.lib.php | 11 +- libraries/display_select_lang.lib.php | 3 +- libraries/error_report.lib.php | 5 +- libraries/export.lib.php | 8 +- libraries/import.lib.php | 13 +- libraries/index.lib.php | 3 +- libraries/insert_edit.lib.php | 17 +- libraries/mult_submits.lib.php | 9 +- libraries/navigation/Navigation.php | 5 +- libraries/navigation/NavigationHeader.php | 9 +- libraries/navigation/NavigationTree.php | 7 +- libraries/navigation/nodes/NodeDatabase.php | 3 +- .../navigation/nodes/NodeDatabaseChild.php | 3 +- libraries/normalization.lib.php | 3 +- libraries/operations.lib.php | 27 +- .../plugins/auth/AuthenticationConfig.php | 3 +- .../plugins/auth/AuthenticationCookie.php | 5 +- .../plugins/schema/ExportRelationSchema.php | 3 +- libraries/relation.lib.php | 3 +- libraries/replication_gui.lib.php | 31 +-- libraries/rte/rte_events.lib.php | 3 +- libraries/rte/rte_list.lib.php | 4 +- libraries/rte/rte_main.inc.php | 4 +- libraries/rte/rte_routines.lib.php | 5 +- libraries/rte/rte_triggers.lib.php | 3 +- libraries/select_server.lib.php | 4 +- libraries/server_common.inc.php | 4 +- libraries/server_privileges.lib.php | 45 ++-- libraries/server_status_processes.lib.php | 11 +- libraries/server_status_variables.lib.php | 3 +- libraries/server_user_groups.lib.php | 13 +- libraries/server_users.lib.php | 3 +- libraries/sql.lib.php | 9 +- libraries/sql_query_form.lib.php | 8 +- libraries/tbl_common.inc.php | 8 +- libraries/tracking.lib.php | 21 +- libraries/url_generating.lib.php | 248 ----------------- libraries/user_preferences.lib.php | 5 +- normalization.php | 5 +- prefs_forms.php | 3 +- prefs_manage.php | 9 +- setup/config.php | 11 +- setup/frames/index.inc.php | 11 +- setup/frames/menu.inc.php | 7 +- setup/frames/servers.inc.php | 3 +- setup/lib/common.inc.php | 1 - setup/lib/form_processing.lib.php | 11 +- sql.php | 5 +- tbl_addfield.php | 3 +- tbl_change.php | 5 +- tbl_create.php | 3 +- tbl_row_action.php | 5 +- .../column_definitions_form.phtml | 5 +- .../table_fields_definitions.phtml | 6 +- templates/database/create_table.phtml | 4 +- .../database/designer/edit_delete_pages.phtml | 4 +- .../database/designer/page_save_as.phtml | 4 +- .../database/designer/query_details.phtml | 4 +- .../database/designer/schema_export.phtml | 4 +- .../structure/body_for_table_summary.phtml | 4 +- .../database/structure/favorite_anchor.phtml | 4 +- .../database/structure/sortable_header.phtml | 4 +- .../structure/structure_table_row.phtml | 4 +- .../database/structure/table_header.phtml | 4 +- .../privileges/edit_routine_privileges.phtml | 4 +- templates/privileges/privileges_summary.phtml | 4 +- templates/server/binlog/log_selector.phtml | 4 +- templates/server/databases/create.phtml | 4 +- templates/server/databases/table_header.phtml | 6 +- templates/server/engines/engine.phtml | 6 +- templates/server/engines/engines.phtml | 4 +- templates/table/chart/tbl_chart.phtml | 5 +- .../gis_visualization/gis_visualization.phtml | 2 +- templates/table/index_form.phtml | 4 +- templates/table/relation/common_form.phtml | 4 +- .../table/relation/foreign_key_row.phtml | 5 +- templates/table/search/form_tag.phtml | 4 +- templates/table/search/input_box.phtml | 6 +- templates/table/search/replace_preview.phtml | 4 +- templates/table/search/zoom_result_form.phtml | 4 +- templates/table/structure/add_column.phtml | 4 +- .../table/structure/display_partitions.phtml | 7 +- .../table/structure/display_structure.phtml | 5 +- .../table/structure/move_columns_dialog.phtml | 4 +- .../structure/partition_definition_form.phtml | 4 +- test/classes/AdvisorTest.php | 1 - test/classes/ConfigTest.php | 1 - test/classes/DbSearchTest.php | 1 - test/classes/DisplayResultsTest.php | 1 - test/classes/FooterTest.php | 1 - test/classes/HeaderTest.php | 1 - test/classes/MenuTest.php | 1 - test/classes/ScriptsTest.php | 1 - test/classes/ServerStatusDataTest.php | 1 - test/classes/TableTest.php | 1 - test/classes/ThemeManagerTest.php | 1 - test/classes/ThemeTest.php | 1 - .../URL.php} | 33 ++- .../ServerBinlogControllerTest.php | 1 - .../ServerCollationsControllerTest.php | 3 - .../ServerDatabasesControllerTest.php | 1 - .../ServerEnginesControllerTest.php | 7 +- .../ServerVariablesControllerTest.php | 4 +- .../TableIndexesControllerTest.php | 6 +- .../TableRelationControllerTest.php | 1 - test/classes/dbi/DBIMysqlTest.php | 1 - test/classes/dbi/DBIMysqliTest.php | 1 - test/classes/navigation/NavigationTest.php | 4 +- .../classes/navigation/NavigationTreeTest.php | 1 - .../navigation/NodeDatabaseChildTest.php | 4 +- test/classes/plugin/import/ImportCsvTest.php | 1 - test/classes/plugin/import/ImportLdiTest.php | 1 - .../plugin/import/ImportMediawikiTest.php | 1 - test/classes/plugin/import/ImportOdsTest.php | 1 - test/classes/plugin/import/ImportShpTest.php | 1 - test/classes/plugin/import/ImportSqlTest.php | 1 - test/classes/plugin/import/ImportXmlTest.php | 1 - test/classes/schema/DiaRelationSchemaTest.php | 1 - test/classes/schema/EpsRelationSchemaTest.php | 1 - .../schema/ExportRelationSchemaTest.php | 1 - test/classes/schema/PdfRelationSchemaTest.php | 1 - test/classes/schema/SvgRelationSchemaTest.php | 1 - test/libraries/PMA_FormDisplay_tpl_test.php | 1 - test/libraries/PMA_browse_foreigners_test.php | 2 - test/libraries/PMA_central_columns_test.php | 10 +- test/libraries/PMA_designer_test.php | 1 - .../PMA_display_change_password_test.php | 6 +- .../PMA_display_create_table_test.php | 7 +- test/libraries/PMA_display_export_test.php | 5 +- test/libraries/PMA_import_test.php | 4 +- test/libraries/PMA_insert_edit_test.php | 1 - test/libraries/PMA_mult_submits_test.php | 11 +- test/libraries/PMA_normalization_test.php | 1 - test/libraries/PMA_operations_test.php | 1 - test/libraries/PMA_sanitize_test.php | 2 - test/libraries/PMA_select_server_test.php | 1 - test/libraries/PMA_server_common_test.php | 1 - test/libraries/PMA_server_privileges_test.php | 59 ++-- .../libraries/PMA_server_replication_test.php | 2 - .../PMA_server_status_advisor_test.php | 1 - .../PMA_server_status_monitor_test.php | 2 - .../PMA_server_status_processes_test.php | 4 +- .../PMA_server_status_queries_test.php | 2 - test/libraries/PMA_server_status_test.php | 2 - .../PMA_server_status_variables_test.php | 1 - .../libraries/PMA_server_user_groups_test.php | 10 +- test/libraries/PMA_server_users_test.php | 2 - test/libraries/PMA_sql_query_form_test.php | 4 +- test/libraries/PMA_tbl_tracking_test.php | 6 +- test/libraries/PMA_user_preferences_test.php | 1 - test/libraries/common/PMA_getDbLink_test.php | 6 - test/libraries/core/PMA_fatalError_test.php | 2 - test/libraries/core/PMA_getLinks_test.php | 4 - .../core/PMA_getTableCount_test_dis.php | 2 - .../core/PMA_headerLocation_test.php | 6 +- .../rte/PMA_EVN_getEditorForm_test.php | 2 - .../rte/PMA_RTN_getEditorForm_test.php | 2 - .../rte/PMA_RTN_getExecuteForm_test.php | 2 - .../rte/PMA_TRI_getEditorForm_test.php | 2 - user_password.php | 5 +- view_create.php | 3 +- view_operations.php | 3 +- 202 files changed, 848 insertions(+), 831 deletions(-) create mode 100644 libraries/URL.php delete mode 100644 libraries/url_generating.lib.php rename test/{libraries/PMA_generateCommonUrl_test.php => classes/URL.php} (78%) diff --git a/db_central_columns.php b/db_central_columns.php index 29b71832e8..493b8937ef 100644 --- a/db_central_columns.php +++ b/db_central_columns.php @@ -6,6 +6,8 @@ * * @package PhpMyAdmin */ +use PMA\libraries\URL; + /** * Gets some core libraries */ @@ -114,7 +116,7 @@ $response->addHTML($table_navigation_html); $columnAdd = PMA_getHTMLforAddCentralColumn($total_rows, $pos, $db); $response->addHTML($columnAdd); $deleteRowForm = '