From 8fddd36d750051d79e3dbc812761ae37fbd426ee Mon Sep 17 00:00:00 2001 From: William Desportes Date: Mon, 7 Dec 2020 01:29:34 +0100 Subject: [PATCH] Ref #16467 - fetch page name in a safer way Signed-off-by: William Desportes --- libraries/classes/Plugins/Schema/Pdf/Pdf.php | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libraries/classes/Plugins/Schema/Pdf/Pdf.php b/libraries/classes/Plugins/Schema/Pdf/Pdf.php index f8b0212fa2..d6e1f53ea4 100644 --- a/libraries/classes/Plugins/Schema/Pdf/Pdf.php +++ b/libraries/classes/Plugins/Schema/Pdf/Pdf.php @@ -18,6 +18,7 @@ use function mb_ord; use function str_replace; use function strlen; use function ucfirst; +use function is_array; // phpcs:disable PSR1.Files.SideEffects /** @@ -304,8 +305,12 @@ class Pdf extends PdfLib . ' WHERE db_name = \'' . $dbi->escapeString($this->db) . '\' AND page_nr = \'' . $this->pageNumber . '\''; $test_rs = $this->relation->queryAsControlUser($test_query); - $pages = @$dbi->fetchAssoc($test_rs); - $pg_name = ucfirst((string) $pages['page_descr']); + $pageDesc = ''; + $pages = $dbi->fetchAssoc($test_rs); + if (is_array($pages)) { + $pageDesc = (string) $pages['page_descr']; + } + $pg_name = ucfirst($pageDesc); } $this->SetFont($this->ff, 'B', 14);