gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove md5 twig extension

Browse Source 
Adapt templates to remove md5 from PhpFuncionsExtension.php

Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>
This commit is contained in:
Leonardo Strozzi 2018-05-22 07:49:14 -03:00
parent 83f433695b
commit 927fed774c
7 changed files with 14 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libraries/classes/Controllers/Database/DatabaseStructureController.php
View File

@ -659,6 +659,8 @@ class DatabaseStructureController extends DatabaseController
Template::get('database/structure/structure_table_row')
->render(
array(
'table_name_hash' => md5($current_table['TABLE_NAME']),
'db_table_name_hash' => md5($this->db . '.' . $current_table['TABLE_NAME']),
'db' => $this->db,
'curr' => $i,
'input_class' => implode(' ', $input_class),

1
libraries/classes/Controllers/Table/TableRelationController.php
View File

@ -189,6 +189,7 @@ class TableRelationController extends TableController
|| ! empty($column['Key'])
) {
$column_array[$column['Field']] = $column['Field'];
$column_array[$column['Field'] . '_hash'] = md5($column['Field']);
}
}
if ($GLOBALS['cfg']['NaturalOrder']) {

7
libraries/classes/Controllers/Table/TableSearchController.php
View File

@ -371,11 +371,18 @@ class TableSearchController extends TableController
__('Browse foreign values')
)
);
$column_names_hashes = [];
foreach ($this->_columnNames as $columnName) {
$column_names_hashes[$columnName] = md5($columnName);
}
$this->response->addHTML(
Template::get('table/search/zoom_result_form')->render([
'db' => $this->db,
'table' => $this->table,
'column_names' => $this->_columnNames,
'column_names_hashes' => $column_names_hashes,
'foreigners' => $this->_foreigners,
'column_null_flags' => $this->_columnNullFlags,
'column_types' => $this->_columnTypes,

1
libraries/classes/Twig/PhpFunctionsExtension.php
View File

@ -30,7 +30,6 @@ class PhpFunctionsExtension extends AbstractExtension
new TwigFunction('array_search', 'array_search'),
new TwigFunction('bin2hex', 'bin2hex'),
new TwigFunction('htmlentities', 'htmlentities'),
new TwigFunction('md5', 'md5'),
new TwigFunction('preg_quote', 'preg_quote'),
new TwigFunction('preg_replace', 'preg_replace'),
new TwigFunction('strpos', 'strpos'),

26
templates/database/structure/structure_table_row.twig
View File

@ -28,8 +28,8 @@
((already_favorite ? 'remove' : 'add') ~ '_favorite'): true
} %}
{% include 'database/structure/favorite_anchor.twig' with {
'table_name_hash': md5(current_table['TABLE_NAME']),
'db_table_name_hash': md5(db ~ '.' ~ current_table['TABLE_NAME']),
'table_name_hash': table_name_hash,
'db_table_name_hash': db_table_name_hash,
'fav_params': fav_params,
'already_favorite': already_favorite,
'titles': titles
@ -184,28 +184,6 @@
{% endif %}
{% else %}
{% set count = 0 %}
{% if properties_num_columns %}
{% set count = count + 2 %}
{% endif %}
{% if is_show_stats %}
{% set count = count + 2 %}
{% endif %}
{% if show_charset %}
{% set count = count + 1 %}
{% endif %}
{% if show_comment %}
{% set count = count + 1 %}
{% endif %}
{% if show_creation %}
{% set count = count + 1 %}
{% endif %}
{% if show_last_update %}
{% set count = count + 1 %}
{% endif %}
{% if show_last_check %}
{% set count = count + 1 %}
{% endif %}
{% if db_is_system_schema %}
{% set action_colspan = 3 %}

2
templates/table/relation/common_form.twig
View File

@ -117,7 +117,7 @@
{% set myfield = save_row[i]['Field'] %}
{# Use an md5 as array index to avoid having special characters
in the name attribute (see bug #1746964 ) #}
{% set myfield_md5 = md5(myfield) %}
{% set myfield_md5 = column_array[myfield ~ '_hash'] %}
{% set foreign_table = false %}
{% set foreign_column = false %}

2
templates/table/search/zoom_result_form.twig
View File

@ -65,7 +65,7 @@
'in_zoom_search_edit': true,
'foreigners': foreigners,
'column_name': field_popup,
'column_name_hash': md5(field_popup),
'column_name_hash': column_name_hashes[field_popup],
'foreign_data': foreign_data,
'table': table,
'column_index': column_index,