gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #18460 from kamil-tekiela/Globals-in-Status

Browse Source 
Remove unused globals
This commit is contained in:
Maurício Meneghini Fauth 2023-06-05 12:50:55 -03:00 committed by GitHub
commit 9481236388
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libraries/classes/Controllers/Import/StatusController.php
View File

@ -31,11 +31,9 @@ class StatusController
public function __invoke(ServerRequest $request): void
{
$GLOBALS['SESSION_KEY'] ??= null;
$GLOBALS['upload_id'] ??= null;
$GLOBALS['plugins'] ??= null;
$GLOBALS['timestamp'] ??= null;
[$GLOBALS['SESSION_KEY'], $GLOBALS['upload_id'], $GLOBALS['plugins']] = Ajax::uploadProgressSetup();
[$GLOBALS['SESSION_KEY']] = Ajax::uploadProgressSetup();
// $_GET["message"] is used for asking for an import message
if ($request->hasQueryParam('message')) {

4
psalm-baseline.xml
View File

@ -2154,9 +2154,7 @@
</file>
<file src="libraries/classes/Controllers/Import/StatusController.php">
<InvalidArrayOffset>
<code><![CDATA[$GLOBALS['plugins']]]></code>
<code><![CDATA[$GLOBALS['timestamp']]]></code>
<code><![CDATA[$GLOBALS['upload_id']]]></code>
</InvalidArrayOffset>
<MixedArgument>
<code><![CDATA[$_SESSION['Import_message']['message'] ?? '']]></code>
@ -2166,9 +2164,7 @@
<code><![CDATA[$_SESSION['Import_message']['message']]]></code>
</MixedArrayAssignment>
<MixedAssignment>
<code><![CDATA[$GLOBALS['plugins']]]></code>
<code><![CDATA[$GLOBALS['timestamp']]]></code>
<code><![CDATA[$GLOBALS['upload_id']]]></code>
</MixedAssignment>
<PossiblyUnusedMethod>
<code>__construct</code>