From 95af8a812c08eb5f798aa96c1cc0b50589e64ae1 Mon Sep 17 00:00:00 2001
From: Kamil Tekiela <tekiela246@gmail.com>
Date: Thu, 12 Dec 2024 21:45:51 +0000
Subject: [PATCH] Remove dead code

Signed-off-by: Kamil Tekiela <tekiela246@gmail.com>
---
 psalm-baseline.xml                            | 34 -------------------
 .../Status/Monitor/ChartingDataController.php |  2 --
 .../Status/Monitor/GeneralLogController.php   |  2 --
 .../Status/Monitor/LogVarsController.php      |  2 --
 .../Monitor/QueryAnalyzerController.php       |  2 --
 .../Status/Monitor/SlowLogController.php      |  2 --
 .../Server/Status/VariablesController.php     |  2 --
 7 files changed, 46 deletions(-)

diff --git a/psalm-baseline.xml b/psalm-baseline.xml
index 4661441ba9..69eb80c16e 100644
--- a/psalm-baseline.xml
+++ b/psalm-baseline.xml
@@ -2531,56 +2531,26 @@
     </PossiblyUnusedReturnValue>
   </file>
   <file src="src/Controllers/Server/Status/Monitor/ChartingDataController.php">
-    <InvalidArrayOffset>
-      <code><![CDATA[$GLOBALS['errorUrl']]]></code>
-    </InvalidArrayOffset>
-    <MixedAssignment>
-      <code><![CDATA[$GLOBALS['errorUrl']]]></code>
-    </MixedAssignment>
     <PossiblyUnusedMethod>
       <code><![CDATA[__construct]]></code>
     </PossiblyUnusedMethod>
   </file>
   <file src="src/Controllers/Server/Status/Monitor/GeneralLogController.php">
-    <InvalidArrayOffset>
-      <code><![CDATA[$GLOBALS['errorUrl']]]></code>
-    </InvalidArrayOffset>
-    <MixedAssignment>
-      <code><![CDATA[$GLOBALS['errorUrl']]]></code>
-    </MixedAssignment>
     <PossiblyUnusedReturnValue>
       <code><![CDATA[Response]]></code>
     </PossiblyUnusedReturnValue>
   </file>
   <file src="src/Controllers/Server/Status/Monitor/LogVarsController.php">
-    <InvalidArrayOffset>
-      <code><![CDATA[$GLOBALS['errorUrl']]]></code>
-    </InvalidArrayOffset>
-    <MixedAssignment>
-      <code><![CDATA[$GLOBALS['errorUrl']]]></code>
-    </MixedAssignment>
     <PossiblyUnusedReturnValue>
       <code><![CDATA[Response]]></code>
     </PossiblyUnusedReturnValue>
   </file>
   <file src="src/Controllers/Server/Status/Monitor/QueryAnalyzerController.php">
-    <InvalidArrayOffset>
-      <code><![CDATA[$GLOBALS['errorUrl']]]></code>
-    </InvalidArrayOffset>
-    <MixedAssignment>
-      <code><![CDATA[$GLOBALS['errorUrl']]]></code>
-    </MixedAssignment>
     <PossiblyUnusedReturnValue>
       <code><![CDATA[Response]]></code>
     </PossiblyUnusedReturnValue>
   </file>
   <file src="src/Controllers/Server/Status/Monitor/SlowLogController.php">
-    <InvalidArrayOffset>
-      <code><![CDATA[$GLOBALS['errorUrl']]]></code>
-    </InvalidArrayOffset>
-    <MixedAssignment>
-      <code><![CDATA[$GLOBALS['errorUrl']]]></code>
-    </MixedAssignment>
     <PossiblyUnusedReturnValue>
       <code><![CDATA[Response]]></code>
     </PossiblyUnusedReturnValue>
@@ -2677,9 +2647,6 @@
     </PossiblyUnusedReturnValue>
   </file>
   <file src="src/Controllers/Server/Status/VariablesController.php">
-    <InvalidArrayOffset>
-      <code><![CDATA[$GLOBALS['errorUrl']]]></code>
-    </InvalidArrayOffset>
     <MixedArgument>
       <code><![CDATA[$flush]]></code>
     </MixedArgument>
@@ -2688,7 +2655,6 @@
       <code><![CDATA[$name]]></code>
     </MixedArgumentTypeCoercion>
     <MixedAssignment>
-      <code><![CDATA[$GLOBALS['errorUrl']]]></code>
       <code><![CDATA[$dontFormat]]></code>
       <code><![CDATA[$filterAlert]]></code>
       <code><![CDATA[$filterCategory]]></code>
diff --git a/src/Controllers/Server/Status/Monitor/ChartingDataController.php b/src/Controllers/Server/Status/Monitor/ChartingDataController.php
index 9349a09e31..b3958957be 100644
--- a/src/Controllers/Server/Status/Monitor/ChartingDataController.php
+++ b/src/Controllers/Server/Status/Monitor/ChartingDataController.php
@@ -29,8 +29,6 @@ final class ChartingDataController extends AbstractController implements Invocab
 
     public function __invoke(ServerRequest $request): Response
     {
-        $GLOBALS['errorUrl'] ??= null;
-
         $requiredData = $request->getParsedBodyParamAsString('requiredData', '');
         $GLOBALS['errorUrl'] = Url::getFromRoute('/');
 
diff --git a/src/Controllers/Server/Status/Monitor/GeneralLogController.php b/src/Controllers/Server/Status/Monitor/GeneralLogController.php
index 9636d57385..fd1a67988e 100644
--- a/src/Controllers/Server/Status/Monitor/GeneralLogController.php
+++ b/src/Controllers/Server/Status/Monitor/GeneralLogController.php
@@ -29,8 +29,6 @@ final class GeneralLogController extends AbstractController implements Invocable
 
     public function __invoke(ServerRequest $request): Response
     {
-        $GLOBALS['errorUrl'] ??= null;
-
         $GLOBALS['errorUrl'] = Url::getFromRoute('/');
 
         if ($this->dbi->isSuperUser()) {
diff --git a/src/Controllers/Server/Status/Monitor/LogVarsController.php b/src/Controllers/Server/Status/Monitor/LogVarsController.php
index cb614691cc..3bbdc4303f 100644
--- a/src/Controllers/Server/Status/Monitor/LogVarsController.php
+++ b/src/Controllers/Server/Status/Monitor/LogVarsController.php
@@ -29,8 +29,6 @@ final class LogVarsController extends AbstractController implements InvocableCon
 
     public function __invoke(ServerRequest $request): Response
     {
-        $GLOBALS['errorUrl'] ??= null;
-
         $GLOBALS['errorUrl'] = Url::getFromRoute('/');
 
         if ($this->dbi->isSuperUser()) {
diff --git a/src/Controllers/Server/Status/Monitor/QueryAnalyzerController.php b/src/Controllers/Server/Status/Monitor/QueryAnalyzerController.php
index 04ea58e1de..d918de9c64 100644
--- a/src/Controllers/Server/Status/Monitor/QueryAnalyzerController.php
+++ b/src/Controllers/Server/Status/Monitor/QueryAnalyzerController.php
@@ -29,8 +29,6 @@ final class QueryAnalyzerController extends AbstractController implements Invoca
 
     public function __invoke(ServerRequest $request): Response
     {
-        $GLOBALS['errorUrl'] ??= null;
-
         $GLOBALS['errorUrl'] = Url::getFromRoute('/');
 
         if ($this->dbi->isSuperUser()) {
diff --git a/src/Controllers/Server/Status/Monitor/SlowLogController.php b/src/Controllers/Server/Status/Monitor/SlowLogController.php
index 658efb1fd6..9650db9a90 100644
--- a/src/Controllers/Server/Status/Monitor/SlowLogController.php
+++ b/src/Controllers/Server/Status/Monitor/SlowLogController.php
@@ -29,8 +29,6 @@ final class SlowLogController extends AbstractController implements InvocableCon
 
     public function __invoke(ServerRequest $request): Response
     {
-        $GLOBALS['errorUrl'] ??= null;
-
         $GLOBALS['errorUrl'] = Url::getFromRoute('/');
 
         if ($this->dbi->isSuperUser()) {
diff --git a/src/Controllers/Server/Status/VariablesController.php b/src/Controllers/Server/Status/VariablesController.php
index a8149e23bc..5a959eb8e8 100644
--- a/src/Controllers/Server/Status/VariablesController.php
+++ b/src/Controllers/Server/Status/VariablesController.php
@@ -35,8 +35,6 @@ final class VariablesController extends AbstractController implements InvocableC
 
     public function __invoke(ServerRequest $request): Response
     {
-        $GLOBALS['errorUrl'] ??= null;
-
         $filterAlert = $request->getParsedBodyParam('filterAlert');
         $filterText = $request->getParsedBodyParam('filterText');
         $filterCategory = $request->getParsedBodyParam('filterCategory');