gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix selenium tests warnings on private test methods after removing _

Browse Source 
Signed-off-by: William Desportes <williamdes@wdes.fr>
This commit is contained in:
William Desportes 2020-06-03 00:07:03 +02:00
parent a13e5d1c16
commit 9668731fe6
No known key found for this signature in database
GPG Key ID: 90A0EF1B8251A889
2 changed files with 4 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/selenium/NormalizationTest.php
View File

@ -67,15 +67,13 @@ class NormalizationTest extends TestBase
);
$this->byCssSelector('input[name=submit_normalize]')->click();
$this->waitForElement('id', 'mainContent');
$this->test1NFSteps();
$this->assert1NFSteps();
}
/**
* assertions in 1NF steps 1.1, 1.2, 1.3
*
* @return void
*/
private function test1NFSteps()
private function assert1NFSteps(): void
{
$this->assertEquals(
'First step of normalization (1NF)',

7
test/selenium/SqlQueryTest.php
View File

@ -147,13 +147,10 @@ class SqlQueryTest extends TestBase
);
// test inline edit button
$this->testInlineEdit();
$this->assertInlineEdit();
}
/**
* @return void
*/
private function testInlineEdit()
private function assertInlineEdit(): void
{
$this->waitForElement('cssSelector', 'a.inline_edit_sql')->click();
// empty current query