gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Less local variables

Browse Source
This commit is contained in:
Michal Čihař 2012-05-10 10:10:47 +02:00
parent e2e3de0392
commit 9fd0edb33c
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libraries/common.lib.php
View File

@ -3661,11 +3661,8 @@ function PMA_getFunctionsForField($field, $insert_mode)
global $cfg, $analyzed_sql, $data;
$selected = '';
$dropdown = array();
$default_function = '';
$dropdown = $GLOBALS['PMA_Types']->getFunctions($field['True_Type']);
// Can we get field class based values?
$current_class = $GLOBALS['PMA_Types']->getTypeClass($field['True_Type']);
if (! empty($current_class)) {
@ -3707,13 +3704,14 @@ function PMA_getFunctionsForField($field, $insert_mode)
$retval = '<option></option>' . "\n";
// loop on the dropdown array and print all available options for that
// field.
foreach ($dropdown as $each_dropdown) {
$functions = $GLOBALS['PMA_Types']->getFunctions($field['True_Type']);
foreach ($functions as $function) {
$retval .= '<option';
if ($default_function === $each_dropdown) {
if ($default_function === $function) {
$retval .= ' selected="selected"';
}
$retval .= '>' . $each_dropdown . '</option>' . "\n";
$dropdown_built[$each_dropdown] = true;
$retval .= '>' . $function . '</option>' . "\n";
$dropdown_built[$function] = true;
$op_spacing_needed = true;
}