Add unit test for CentralColumns\PopulateColumnsController

Signed-off-by: Maurício Meneghini Fauth <mauricio@mfauth.net>
This commit is contained in:
Maurício Meneghini Fauth 2026-02-27 10:51:28 -03:00
parent cfd767235c
commit a19dba215f
No known key found for this signature in database
GPG Key ID: 6A16FD38AFC89CC8
3 changed files with 44 additions and 10 deletions

View File

@ -691,11 +691,6 @@
<code><![CDATA[Response]]></code>
</PossiblyUnusedReturnValue>
</file>
<file src="src/Controllers/Database/CentralColumns/PopulateColumnsController.php">
<PossiblyUnusedMethod>
<code><![CDATA[__construct]]></code>
</PossiblyUnusedMethod>
</file>
<file src="src/Controllers/Database/DataDictionaryController.php">
<MixedArgument>
<code><![CDATA[Current::$database]]></code>

View File

@ -13,12 +13,10 @@ use PhpMyAdmin\ResponseRenderer;
use PhpMyAdmin\Routing\Route;
#[Route('/database/central-columns/populate', ['POST'])]
final class PopulateColumnsController implements InvocableController
final readonly class PopulateColumnsController implements InvocableController
{
public function __construct(
private readonly ResponseRenderer $response,
private readonly CentralColumns $centralColumns,
) {
public function __construct(private ResponseRenderer $response, private CentralColumns $centralColumns)
{
}
public function __invoke(ServerRequest $request): Response

View File

@ -0,0 +1,41 @@
<?php
declare(strict_types=1);
namespace PhpMyAdmin\Tests\Controllers\Database\CentralColumns;
use Fig\Http\Message\StatusCodeInterface;
use PhpMyAdmin\Controllers\Database\CentralColumns\PopulateColumnsController;
use PhpMyAdmin\Current;
use PhpMyAdmin\Database\CentralColumns;
use PhpMyAdmin\Http\Factory\ServerRequestFactory;
use PhpMyAdmin\Tests\AbstractTestCase;
use PhpMyAdmin\Tests\Stubs\ResponseRenderer;
use PHPUnit\Framework\Attributes\CoversClass;
#[CoversClass(PopulateColumnsController::class)]
final class PopulateColumnsControllerTest extends AbstractTestCase
{
public function testPopulateColumns(): void
{
$dbi = $this->createDatabaseInterface();
Current::$database = 'test_db';
$request = ServerRequestFactory::create()->createServerRequest('POST', 'https://example.com/')
->withQueryParams(['route' => '/database/central-columns/populate'])
->withParsedBody(['db' => 'test_db', 'selectedTable' => 'test_table']);
$response = (new PopulateColumnsController(new ResponseRenderer(), new CentralColumns($dbi)))($request);
self::assertSame(StatusCodeInterface::STATUS_OK, $response->getStatusCode());
self::assertSame(
<<<'HTML'
<option value="id">id</option>
<option value="name">name</option>
<option value="datetimefield">datetimefield</option>
HTML,
(string) $response->getBody(),
);
}
}