From feda222da9e9a968f467ce4d4f0cac693161b7c1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= Date: Wed, 26 Jan 2022 10:02:26 -0300 Subject: [PATCH 1/3] Fix failing tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Maurício Meneghini Fauth --- libraries/classes/DatabaseInterface.php | 8 +- .../Plugins/Import/Upload/UploadProgress.php | 4 +- phpstan-baseline.neon | 79 +++++++++++-------- test/classes/ConfigTest.php | 9 +++ 4 files changed, 63 insertions(+), 37 deletions(-) diff --git a/libraries/classes/DatabaseInterface.php b/libraries/classes/DatabaseInterface.php index 9c7066ea4b..ec5ae36777 100644 --- a/libraries/classes/DatabaseInterface.php +++ b/libraries/classes/DatabaseInterface.php @@ -288,6 +288,10 @@ class DatabaseInterface implements DbalInterface */ public function getTables(string $database, $link = self::CONNECT_USER): array { + if ($database === '') { + return []; + } + $tables = $this->fetchResult( 'SHOW TABLES FROM ' . Util::backquote($database) . ';', null, @@ -1170,9 +1174,7 @@ class DatabaseInterface implements DbalInterface { $storageDbName = $GLOBALS['cfg']['Server']['pmadb'] ?? ''; // Use "phpmyadmin" as a default database name to check to keep the behavior consistent - $storageDbName = $storageDbName !== null && is_string($storageDbName) && $storageDbName !== '' - ? $storageDbName - : 'phpmyadmin'; + $storageDbName = is_string($storageDbName) && $storageDbName !== '' ? $storageDbName : 'phpmyadmin'; // This will make users not having explicitly listed databases // have config values filled by the default phpMyAdmin storage table name values diff --git a/libraries/classes/Plugins/Import/Upload/UploadProgress.php b/libraries/classes/Plugins/Import/Upload/UploadProgress.php index 35dbb2ae6c..1bb8345e77 100644 --- a/libraries/classes/Plugins/Import/Upload/UploadProgress.php +++ b/libraries/classes/Plugins/Import/Upload/UploadProgress.php @@ -12,7 +12,6 @@ use PhpMyAdmin\Plugins\UploadInterface; use function array_key_exists; use function function_exists; use function trim; -use function uploadprogress_get_info; /** * Implementation for upload progress @@ -65,7 +64,8 @@ class UploadProgress implements UploadInterface $status = null; // @see https://pecl.php.net/package/uploadprogress if (function_exists('uploadprogress_get_info')) { - $status = uploadprogress_get_info($id); + // phpcs:ignore SlevomatCodingStandard.Namespaces.ReferenceUsedNamesOnly.ReferenceViaFullyQualifiedName + $status = \uploadprogress_get_info($id); } if ($status) { diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index dfdf327e12..7bded6e89f 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -1,5 +1,15 @@ parameters: ignoreErrors: + - + message: "#^Static property PhpMyAdmin\\\\Charsets\\:\\:\\$charsets \\(array\\\\) does not accept array\\\\.$#" + count: 1 + path: libraries/classes/Charsets.php + + - + message: "#^Static property PhpMyAdmin\\\\Charsets\\:\\:\\$collations \\(array\\\\>\\) does not accept array\\\\>\\.$#" + count: 1 + path: libraries/classes/Charsets.php + - message: "#^Strict comparison using \\=\\=\\= between non\\-empty\\-array\\ and false will always evaluate to false\\.$#" count: 1 @@ -316,7 +326,7 @@ parameters: path: libraries/classes/Controllers/Table/StructureController.php - - message: "#^Method PhpMyAdmin\\\\Controllers\\\\Table\\\\StructureController\\:\\:extractPartitionDetails\\(\\) should return array\\\\|null but returns array\\\\>\\|bool\\|int\\|string\\>\\.$#" + message: "#^Method PhpMyAdmin\\\\Controllers\\\\Table\\\\StructureController\\:\\:extractPartitionDetails\\(\\) should return array\\\\|null but returns array\\, array\\\\>\\|bool\\|int\\|string\\>\\.$#" count: 1 path: libraries/classes/Controllers/Table/StructureController.php @@ -361,7 +371,7 @@ parameters: path: libraries/classes/Core.php - - message: "#^Offset 'pass'\\|'port'\\|'user' does not exist on array\\{scheme\\?\\: string, host\\: string, port\\?\\: int, user\\?\\: string, pass\\?\\: string, path\\?\\: string, query\\?\\: string, fragment\\?\\: string\\}\\.$#" + message: "#^Offset 'pass'\\|'port'\\|'user' does not exist on array\\{host\\: non\\-empty\\-string, scheme\\?\\: string, port\\?\\: int, user\\?\\: string, pass\\?\\: string, path\\?\\: string, query\\?\\: string, fragment\\?\\: string\\}\\.$#" count: 1 path: libraries/classes/Core.php @@ -371,22 +381,22 @@ parameters: path: libraries/classes/Database/CentralColumns.php - - message: "#^Offset 'DCN' does not exist on array\\{C_NAME\\: array\\, DCN\\?\\: non\\-empty\\-array\\, DTN\\?\\: non\\-empty\\-array\\, SCN\\?\\: non\\-empty\\-array\\, STN\\?\\: non\\-empty\\-array\\\\}\\.$#" + message: "#^Offset 'DCN' does not exist on array\\{C_NAME\\: array\\, string\\>, DCN\\?\\: non\\-empty\\-array\\, string\\>, DTN\\?\\: non\\-empty\\-array\\, non\\-empty\\-string\\>, SCN\\?\\: non\\-empty\\-array\\, string\\>, STN\\?\\: non\\-empty\\-array\\, non\\-empty\\-string\\>\\}\\.$#" count: 1 path: libraries/classes/Database/Designer/Common.php - - message: "#^Offset 'DTN' does not exist on array\\{C_NAME\\: array\\, DCN\\?\\: non\\-empty\\-array\\, DTN\\?\\: non\\-empty\\-array\\, SCN\\?\\: non\\-empty\\-array\\, STN\\?\\: non\\-empty\\-array\\\\}\\.$#" + message: "#^Offset 'DTN' does not exist on array\\{C_NAME\\: array\\, string\\>, DCN\\?\\: non\\-empty\\-array\\, string\\>, DTN\\?\\: non\\-empty\\-array\\, non\\-empty\\-string\\>, SCN\\?\\: non\\-empty\\-array\\, string\\>, STN\\?\\: non\\-empty\\-array\\, non\\-empty\\-string\\>\\}\\.$#" count: 1 path: libraries/classes/Database/Designer/Common.php - - message: "#^Offset 'SCN' does not exist on array\\{C_NAME\\: array\\, DCN\\?\\: non\\-empty\\-array\\, DTN\\?\\: non\\-empty\\-array\\, SCN\\?\\: non\\-empty\\-array\\, STN\\?\\: non\\-empty\\-array\\\\}\\.$#" + message: "#^Offset 'SCN' does not exist on array\\{C_NAME\\: array\\, string\\>, DCN\\?\\: non\\-empty\\-array\\, string\\>, DTN\\?\\: non\\-empty\\-array\\, non\\-empty\\-string\\>, SCN\\?\\: non\\-empty\\-array\\, string\\>, STN\\?\\: non\\-empty\\-array\\, non\\-empty\\-string\\>\\}\\.$#" count: 1 path: libraries/classes/Database/Designer/Common.php - - message: "#^Offset 'STN' does not exist on array\\{C_NAME\\: array\\, DCN\\?\\: non\\-empty\\-array\\, DTN\\?\\: non\\-empty\\-array\\, SCN\\?\\: non\\-empty\\-array\\, STN\\?\\: non\\-empty\\-array\\\\}\\.$#" + message: "#^Offset 'STN' does not exist on array\\{C_NAME\\: array\\, string\\>, DCN\\?\\: non\\-empty\\-array\\, string\\>, DTN\\?\\: non\\-empty\\-array\\, non\\-empty\\-string\\>, SCN\\?\\: non\\-empty\\-array\\, string\\>, STN\\?\\: non\\-empty\\-array\\, non\\-empty\\-string\\>\\}\\.$#" count: 2 path: libraries/classes/Database/Designer/Common.php @@ -545,6 +555,11 @@ parameters: count: 1 path: libraries/classes/Display/Results.php + - + message: "#^Negated boolean expression is always false\\.$#" + count: 1 + path: libraries/classes/Display/Results.php + - message: "#^Offset 0 does not exist on array\\|null\\.$#" count: 1 @@ -571,37 +586,37 @@ parameters: path: libraries/classes/Display/Results.php - - message: "#^Parameter \\#5 \\$default_function of method PhpMyAdmin\\\\Display\\\\Results\\:\\:handleNonPrintableContents\\(\\) expects string, array\\ given\\.$#" + message: "#^Parameter \\#5 \\$default_function of method PhpMyAdmin\\\\Display\\\\Results\\:\\:handleNonPrintableContents\\(\\) expects string, array\\ given\\.$#" count: 2 path: libraries/classes/Display/Results.php - - message: "#^Parameter \\#7 \\$transformation_plugin of method PhpMyAdmin\\\\Display\\\\Results\\:\\:getDataCellForGeometryColumns\\(\\) expects PhpMyAdmin\\\\Plugins\\\\TransformationsPlugin, array\\\\|object given\\.$#" + message: "#^Parameter \\#7 \\$transformation_plugin of method PhpMyAdmin\\\\Display\\\\Results\\:\\:getDataCellForGeometryColumns\\(\\) expects PhpMyAdmin\\\\Plugins\\\\TransformationsPlugin, array\\\\|object given\\.$#" count: 1 path: libraries/classes/Display/Results.php - - message: "#^Parameter \\#7 \\$transformation_plugin of method PhpMyAdmin\\\\Display\\\\Results\\:\\:getDataCellForNonNumericColumns\\(\\) expects PhpMyAdmin\\\\Plugins\\\\TransformationsPlugin, array\\\\|object given\\.$#" + message: "#^Parameter \\#7 \\$transformation_plugin of method PhpMyAdmin\\\\Display\\\\Results\\:\\:getDataCellForNonNumericColumns\\(\\) expects PhpMyAdmin\\\\Plugins\\\\TransformationsPlugin, array\\\\|object given\\.$#" count: 1 path: libraries/classes/Display/Results.php - - message: "#^Parameter \\#8 \\$default_function of method PhpMyAdmin\\\\Display\\\\Results\\:\\:getDataCellForGeometryColumns\\(\\) expects string, array\\ given\\.$#" + message: "#^Parameter \\#8 \\$default_function of method PhpMyAdmin\\\\Display\\\\Results\\:\\:getDataCellForGeometryColumns\\(\\) expects string, array\\ given\\.$#" count: 1 path: libraries/classes/Display/Results.php - - message: "#^Parameter \\#8 \\$default_function of method PhpMyAdmin\\\\Display\\\\Results\\:\\:getDataCellForNonNumericColumns\\(\\) expects string, array\\ given\\.$#" + message: "#^Parameter \\#8 \\$default_function of method PhpMyAdmin\\\\Display\\\\Results\\:\\:getDataCellForNonNumericColumns\\(\\) expects string, array\\ given\\.$#" count: 1 path: libraries/classes/Display/Results.php - - message: "#^Parameter \\#8 \\$transformation_plugin of method PhpMyAdmin\\\\Display\\\\Results\\:\\:getDataCellForNumericColumns\\(\\) expects PhpMyAdmin\\\\Plugins\\\\TransformationsPlugin, array\\\\|object given\\.$#" + message: "#^Parameter \\#8 \\$transformation_plugin of method PhpMyAdmin\\\\Display\\\\Results\\:\\:getDataCellForNumericColumns\\(\\) expects PhpMyAdmin\\\\Plugins\\\\TransformationsPlugin, array\\\\|object given\\.$#" count: 1 path: libraries/classes/Display/Results.php - - message: "#^Parameter \\#9 \\$default_function of method PhpMyAdmin\\\\Display\\\\Results\\:\\:getDataCellForNumericColumns\\(\\) expects string, array\\ given\\.$#" + message: "#^Parameter \\#9 \\$default_function of method PhpMyAdmin\\\\Display\\\\Results\\:\\:getDataCellForNumericColumns\\(\\) expects string, array\\ given\\.$#" count: 1 path: libraries/classes/Display/Results.php @@ -831,7 +846,7 @@ parameters: path: libraries/classes/Gis/GisGeometryCollection.php - - message: "#^Parameter \\#1 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getBoundsForOl\\(\\) expects string, int given\\.$#" + message: "#^Parameter \\#1 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getBoundsForOl\\(\\) expects string, int\\\\|int\\<1, max\\> given\\.$#" count: 1 path: libraries/classes/Gis/GisLineString.php @@ -841,7 +856,7 @@ parameters: path: libraries/classes/Gis/GisLineString.php - - message: "#^Parameter \\#2 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getLineForOpenLayers\\(\\) expects string, int given\\.$#" + message: "#^Parameter \\#2 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getLineForOpenLayers\\(\\) expects string, int\\\\|int\\<1, max\\> given\\.$#" count: 1 path: libraries/classes/Gis/GisLineString.php @@ -871,7 +886,7 @@ parameters: path: libraries/classes/Gis/GisLineString.php - - message: "#^Parameter \\#1 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getBoundsForOl\\(\\) expects string, int given\\.$#" + message: "#^Parameter \\#1 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getBoundsForOl\\(\\) expects string, int\\\\|int\\<1, max\\> given\\.$#" count: 1 path: libraries/classes/Gis/GisMultiLineString.php @@ -881,7 +896,7 @@ parameters: path: libraries/classes/Gis/GisMultiLineString.php - - message: "#^Parameter \\#2 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getLineArrayForOpenLayers\\(\\) expects string, int given\\.$#" + message: "#^Parameter \\#2 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getLineArrayForOpenLayers\\(\\) expects string, int\\\\|int\\<1, max\\> given\\.$#" count: 1 path: libraries/classes/Gis/GisMultiLineString.php @@ -911,7 +926,7 @@ parameters: path: libraries/classes/Gis/GisMultiLineString.php - - message: "#^Parameter \\#1 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getBoundsForOl\\(\\) expects string, int given\\.$#" + message: "#^Parameter \\#1 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getBoundsForOl\\(\\) expects string, int\\\\|int\\<1, max\\> given\\.$#" count: 1 path: libraries/classes/Gis/GisMultiPoint.php @@ -921,7 +936,7 @@ parameters: path: libraries/classes/Gis/GisMultiPoint.php - - message: "#^Parameter \\#2 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisMultiPoint\\:\\:getPointsArrayForOpenLayers\\(\\) expects string, int given\\.$#" + message: "#^Parameter \\#2 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisMultiPoint\\:\\:getPointsArrayForOpenLayers\\(\\) expects string, int\\\\|int\\<1, max\\> given\\.$#" count: 1 path: libraries/classes/Gis/GisMultiPoint.php @@ -951,7 +966,7 @@ parameters: path: libraries/classes/Gis/GisMultiPoint.php - - message: "#^Parameter \\#1 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getBoundsForOl\\(\\) expects string, int given\\.$#" + message: "#^Parameter \\#1 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getBoundsForOl\\(\\) expects string, int\\\\|int\\<1, max\\> given\\.$#" count: 1 path: libraries/classes/Gis/GisMultiPolygon.php @@ -961,7 +976,7 @@ parameters: path: libraries/classes/Gis/GisMultiPolygon.php - - message: "#^Parameter \\#2 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getPolygonArrayForOpenLayers\\(\\) expects string, int given\\.$#" + message: "#^Parameter \\#2 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getPolygonArrayForOpenLayers\\(\\) expects string, int\\\\|int\\<1, max\\> given\\.$#" count: 1 path: libraries/classes/Gis/GisMultiPolygon.php @@ -996,7 +1011,7 @@ parameters: path: libraries/classes/Gis/GisMultiPolygon.php - - message: "#^Parameter \\#1 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getBoundsForOl\\(\\) expects string, int given\\.$#" + message: "#^Parameter \\#1 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getBoundsForOl\\(\\) expects string, int\\\\|int\\<1, max\\> given\\.$#" count: 1 path: libraries/classes/Gis/GisPoint.php @@ -1006,7 +1021,7 @@ parameters: path: libraries/classes/Gis/GisPoint.php - - message: "#^Parameter \\#2 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getPointForOpenLayers\\(\\) expects string, int given\\.$#" + message: "#^Parameter \\#2 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getPointForOpenLayers\\(\\) expects string, int\\\\|int\\<1, max\\> given\\.$#" count: 1 path: libraries/classes/Gis/GisPoint.php @@ -1036,7 +1051,7 @@ parameters: path: libraries/classes/Gis/GisPoint.php - - message: "#^Parameter \\#1 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getBoundsForOl\\(\\) expects string, int given\\.$#" + message: "#^Parameter \\#1 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getBoundsForOl\\(\\) expects string, int\\\\|int\\<1, max\\> given\\.$#" count: 1 path: libraries/classes/Gis/GisPolygon.php @@ -1046,7 +1061,7 @@ parameters: path: libraries/classes/Gis/GisPolygon.php - - message: "#^Parameter \\#2 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getPolygonForOpenLayers\\(\\) expects string, int given\\.$#" + message: "#^Parameter \\#2 \\$srid of method PhpMyAdmin\\\\Gis\\\\GisGeometry\\:\\:getPolygonForOpenLayers\\(\\) expects string, int\\\\|int\\<1, max\\> given\\.$#" count: 1 path: libraries/classes/Gis/GisPolygon.php @@ -1122,7 +1137,12 @@ parameters: - message: "#^Cannot access offset int on array\\|false\\.$#" - count: 2 + count: 1 + path: libraries/classes/Git.php + + - + message: "#^Cannot access offset int\\\\|int\\<1, max\\> on array\\|false\\.$#" + count: 1 path: libraries/classes/Git.php - @@ -1131,7 +1151,7 @@ parameters: path: libraries/classes/Git.php - - message: "#^Offset int does not exist on array\\|null\\.$#" + message: "#^Offset int\\<0, max\\> does not exist on array\\|null\\.$#" count: 2 path: libraries/classes/Import.php @@ -1565,11 +1585,6 @@ parameters: count: 2 path: libraries/classes/Plugins/Import/ImportXml.php - - - message: "#^Used function uploadprogress_get_info not found\\.$#" - count: 1 - path: libraries/classes/Plugins/Import/Upload/UploadProgress.php - - message: "#^Method PhpMyAdmin\\\\Plugins\\\\Import\\\\Upload\\\\UploadSession\\:\\:getIdKey\\(\\) should return string but returns string\\|false\\.$#" count: 1 diff --git a/test/classes/ConfigTest.php b/test/classes/ConfigTest.php index 655b5c2425..a2ae82bf8e 100644 --- a/test/classes/ConfigTest.php +++ b/test/classes/ConfigTest.php @@ -1211,6 +1211,7 @@ class ConfigTest extends AbstractTestCase 'host' => '', 'controluser' => 'u2', 'controlpass' => 'p2', + 'hide_connection_errors' => false, ]; $cfg_ssl = [ 'user' => 'u', @@ -1219,6 +1220,7 @@ class ConfigTest extends AbstractTestCase 'ssl' => true, 'controluser' => 'u2', 'controlpass' => 'p2', + 'hide_connection_errors' => false, ]; $cfg_control_ssl = [ 'user' => 'u', @@ -1227,6 +1229,7 @@ class ConfigTest extends AbstractTestCase 'control_ssl' => true, 'controluser' => 'u2', 'controlpass' => 'p2', + 'hide_connection_errors' => false, ]; return [ @@ -1247,6 +1250,7 @@ class ConfigTest extends AbstractTestCase 'compress' => false, 'controluser' => 'u2', 'controlpass' => 'p2', + 'hide_connection_errors' => false, ], ], ], @@ -1263,6 +1267,7 @@ class ConfigTest extends AbstractTestCase 'port' => 0, 'ssl' => false, 'compress' => false, + 'hide_connection_errors' => false, ], ], ], @@ -1283,6 +1288,7 @@ class ConfigTest extends AbstractTestCase 'compress' => false, 'controluser' => 'u2', 'controlpass' => 'p2', + 'hide_connection_errors' => false, ], ], ], @@ -1299,6 +1305,7 @@ class ConfigTest extends AbstractTestCase 'port' => 0, 'ssl' => true, 'compress' => false, + 'hide_connection_errors' => false, ], ], ], @@ -1320,6 +1327,7 @@ class ConfigTest extends AbstractTestCase 'controluser' => 'u2', 'controlpass' => 'p2', 'control_ssl' => true, + 'hide_connection_errors' => false, ], ], ], @@ -1336,6 +1344,7 @@ class ConfigTest extends AbstractTestCase 'port' => 0, 'ssl' => true, 'compress' => false, + 'hide_connection_errors' => false, ], ], ], From 173a8bb76268297a58da4bfb4999a505915afc50 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= Date: Wed, 26 Jan 2022 10:10:35 -0300 Subject: [PATCH 2/3] Install gettext before installing PHP in CI MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Maurício Meneghini Fauth --- .github/workflows/other-tools.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/other-tools.yml b/.github/workflows/other-tools.yml index 4290946519..7405593415 100644 --- a/.github/workflows/other-tools.yml +++ b/.github/workflows/other-tools.yml @@ -27,6 +27,8 @@ jobs: if: "!contains(github.event.head_commit.message, '[ci skip]')" steps: - uses: actions/checkout@v2 + - name: Install gettext + run: sudo apt-get install -y gettext - name: Use php 7.1 uses: shivammathur/setup-php@v2 with: @@ -63,8 +65,6 @@ jobs: - uses: actions/setup-python@v2 with: python-version: '3.6' - - name: Install gettext - run: sudo apt-get install -y gettext - name: Install Sphinx for the documentation build run: pip install 'Sphinx' - name: Build the release From bbb553d037188a1b16820fedd48ee4914063de8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maur=C3=ADcio=20Meneghini=20Fauth?= Date: Wed, 26 Jan 2022 10:19:22 -0300 Subject: [PATCH 3/3] Remove Nginx and PHP installation from Selenium tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit They are already installed in the system. Signed-off-by: Maurício Meneghini Fauth --- .github/workflows/test-selenium.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.github/workflows/test-selenium.yml b/.github/workflows/test-selenium.yml index fe44790cb6..dc5cd6d0ce 100644 --- a/.github/workflows/test-selenium.yml +++ b/.github/workflows/test-selenium.yml @@ -92,8 +92,6 @@ jobs: ${{ runner.os }}-yarn- - name: Install modules run: yarn install --non-interactive --production - - name: Install nginx and php-fpm - run: sudo apt-get install -y nginx php7.1-fpm - name: Copy the config run: cp test/config.e2e.inc.php config.inc.php - name: Start server