gian/phpmyadmin
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #19058 from LHofman/fix#18451

Browse Source 
Fix #18451 - When editing inline central column, Null is always preselected

Fixes #18451
This commit is contained in:
Maurício Meneghini Fauth 2024-03-29 18:11:23 -03:00 committed by GitHub
commit a6a821adfc
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ChangeLog
View File

@ -71,6 +71,7 @@ phpMyAdmin - ChangeLog
- issue #19022 Fix case where tables from wrong database is loaded in navigation tree
- issue #18593 Fix drop db line included in server export if exporting only data
- issue #18049 Also check that curl_exec is enabled for the new version check
- issue #18451 Fix when editing inline central column, Null is always preselected
5.2.1 (2023-02-07)
- issue #17522 Fix case where the routes cache file is invalid

4
templates/database/central_columns/edit_table_row.twig
View File

@ -75,11 +75,11 @@
<td class="text-nowrap" name="col_isNull">
<input name="field_null[{{ row_num }}]" id="field_{{ row_num }}_6" type="checkbox" value="YES" class="allow_null"
{{- row['col_isNull'] is not empty and row['col_isNull'] != 'NO' and row['col_isNull'] != 'NOT NULL' ? ' checked' }}>
{{- row['col_isNull'] is not empty and row['col_isNull'] != 'NO' and row['col_isNull'] != 'NOT NULL' and row['col_isNull'] != 0 ? ' checked' }}>
</td>
<td class="text-nowrap" name="col_extra">
<input name="col_extra[{{ row_num }}]" id="field_{{ row_num }}_7" type="checkbox" value="auto_increment"
{{- row['col_extra'] is not empty and row['col_extra'] == 'auto_increment' }}>
{{- row['col_extra'] is not empty and row['col_extra'] == 'auto_increment' ? ' checked' }}>
</td>
</tr>

2
templates/database/central_columns/main.twig
View File

@ -355,7 +355,7 @@
<td class="text-nowrap" name="col_isNull">
<span>{{ row['col_isNull'] ? 'Yes' | trans : 'No' | trans }}</span>
<input name="field_null[{{ row_num }}]" id="field_{{ row_num }}_6" type="checkbox" value="YES" class="allow_null"
{{- row['col_isNull'] is not empty and row['col_isNull'] != 'NO' and row['col_isNull'] != 'NOT NULL' ? ' checked' }}>
{{- row['col_isNull'] is not empty and row['col_isNull'] != 'NO' and row['col_isNull'] != 'NOT NULL' and row['col_isNull'] != 0 ? ' checked' }}>
</td>
<td class="text-nowrap" name="col_extra">
<span>{{ row['col_extra'] }}</span>