From 9d03da9ba44c813c0d70473b14093b574737379a Mon Sep 17 00:00:00 2001 From: Kamil Tekiela Date: Tue, 14 Feb 2023 19:10:01 +0000 Subject: [PATCH] Enable PHPStan checkBenevolentUnionTypes Signed-off-by: Kamil Tekiela --- phpstan-baseline.neon | 380 ++++++++++++++++++++++++++++++++++++++++++ phpstan.neon.dist | 1 + 2 files changed, 381 insertions(+) diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon index e491593612..538377896f 100644 --- a/phpstan-baseline.neon +++ b/phpstan-baseline.neon @@ -30,6 +30,11 @@ parameters: count: 1 path: libraries/classes/Advisory/Advisor.php + - + message: "#^Parameter \\#3 \\$subject of function preg_replace_callback expects array\\|string, \\(array\\\\|string\\|null\\) given\\.$#" + count: 1 + path: libraries/classes/Advisory/Advisor.php + - message: "#^Property PhpMyAdmin\\\\Advisory\\\\Advisor\\:\\:\\$globals type has no value type specified in iterable type array\\.$#" count: 1 @@ -295,6 +300,21 @@ parameters: count: 1 path: libraries/classes/Config/ConfigFile.php + - + message: "#^Parameter \\#1 \\$path of method PhpMyAdmin\\\\Config\\\\ConfigFile\\:\\:getCanonicalPath\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Config/ConfigFile.php + + - + message: "#^Parameter \\#1 \\$path of static method PhpMyAdmin\\\\Core\\:\\:arrayRead\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Config/ConfigFile.php + + - + message: "#^Parameter \\#1 \\$path of static method PhpMyAdmin\\\\Core\\:\\:arrayWrite\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Config/ConfigFile.php + - message: "#^Parameter \\#2 \\$array of static method PhpMyAdmin\\\\Core\\:\\:arrayRead\\(\\) expects array, array\\|null given\\.$#" count: 1 @@ -450,11 +470,21 @@ parameters: count: 1 path: libraries/classes/Config/FormDisplay.php + - + message: "#^Parameter \\#1 \\$optionName of method PhpMyAdmin\\\\Config\\\\Form\\:\\:getOptionType\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Config/FormDisplay.php + - message: "#^Parameter \\#1 \\$path of method PhpMyAdmin\\\\Config\\\\ConfigFile\\:\\:getValue\\(\\) expects string, int\\|string\\|false given\\.$#" count: 1 path: libraries/classes/Config/FormDisplay.php + - + message: "#^Parameter \\#1 \\$path of method PhpMyAdmin\\\\Config\\\\ConfigFile\\:\\:set\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Config/FormDisplay.php + - message: "#^Parameter \\#1 \\$path of method PhpMyAdmin\\\\Config\\\\ConfigFile\\:\\:set\\(\\) expects string, int\\|string given\\.$#" count: 1 @@ -470,6 +500,11 @@ parameters: count: 1 path: libraries/classes/Config/FormDisplay.php + - + message: "#^Parameter \\#2 \\$field of method PhpMyAdmin\\\\Config\\\\FormDisplay\\:\\:displayFieldInput\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Config/FormDisplay.php + - message: "#^Parameter \\#2 \\$subject of function preg_match expects string, mixed given\\.$#" count: 1 @@ -540,6 +575,11 @@ parameters: count: 1 path: libraries/classes/Config/Forms/BaseForm.php + - + message: "#^Parameter \\#1 \\$formName of method PhpMyAdmin\\\\Config\\\\FormDisplay\\:\\:registerForm\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Config/Forms/BaseForm.php + - message: "#^Method PhpMyAdmin\\\\Config\\\\Forms\\\\Page\\\\BrowseForm\\:\\:getForms\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 @@ -830,6 +870,21 @@ parameters: count: 1 path: libraries/classes/Config/Validator.php + - + message: "#^Parameter \\#1 \\$haystack of function mb_strpos expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Config/Validator.php + + - + message: "#^Parameter \\#1 \\$path of method PhpMyAdmin\\\\Config\\\\ConfigFile\\:\\:getCanonicalPath\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Config/Validator.php + + - + message: "#^Parameter \\#3 \\$subject of function str_replace expects array\\|string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Config/Validator.php + - message: "#^Casting to string something that's already string\\.$#" count: 4 @@ -1495,6 +1550,11 @@ parameters: count: 1 path: libraries/classes/Controllers/Database/StructureController.php + - + message: "#^Parameter \\#1 \\$timestamp of static method PhpMyAdmin\\\\Util\\:\\:localisedDate\\(\\) expects int, \\(int\\|false\\) given\\.$#" + count: 6 + path: libraries/classes/Controllers/Database/StructureController.php + - message: "#^Parameter \\#4 \\$formattedSize of method PhpMyAdmin\\\\Controllers\\\\Database\\\\StructureController\\:\\:getValuesForAriaTable\\(\\) expects int, string given\\.$#" count: 1 @@ -1630,6 +1690,11 @@ parameters: count: 1 path: libraries/classes/Controllers/GitInfoController.php + - + message: "#^Parameter \\#1 \\$timestamp of static method PhpMyAdmin\\\\Util\\:\\:localisedDate\\(\\) expects int, \\(int\\|false\\) given\\.$#" + count: 2 + path: libraries/classes/Controllers/GitInfoController.php + - message: "#^Parameter \\#1 \\$showGitRevision of class PhpMyAdmin\\\\Git constructor expects bool, mixed given\\.$#" count: 1 @@ -1645,6 +1710,11 @@ parameters: count: 2 path: libraries/classes/Controllers/Import/ImportController.php + - + message: "#^Parameter \\#3 \\$subject of function preg_replace expects array\\|string, \\(array\\\\|string\\|null\\) given\\.$#" + count: 1 + path: libraries/classes/Controllers/Import/ImportController.php + - message: "#^Parameter \\#4 \\$sqlQueryForBookmark of method PhpMyAdmin\\\\Sql\\:\\:storeTheQueryAsBookmark\\(\\) expects string, mixed given\\.$#" count: 2 @@ -1800,6 +1870,11 @@ parameters: count: 1 path: libraries/classes/Controllers/Preferences/ManageController.php + - + message: "#^Parameter \\#3 \\$subject of function str_replace expects array\\|string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Controllers/Preferences/ManageController.php + - message: "#^Parameter \\#1 \\$name of method PhpMyAdmin\\\\TwoFactor\\:\\:configure\\(\\) expects string, mixed given\\.$#" count: 1 @@ -1865,6 +1940,11 @@ parameters: count: 1 path: libraries/classes/Controllers/Server/PrivilegesController.php + - + message: "#^Parameter \\#1 \\$string of function urlencode expects string, \\(array\\\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Controllers/Server/PrivilegesController.php + - message: "#^Parameter \\#2 \\$initial of method PhpMyAdmin\\\\Server\\\\Privileges\\:\\:getHtmlForUserOverview\\(\\) expects string, mixed given\\.$#" count: 1 @@ -1960,6 +2040,11 @@ parameters: count: 2 path: libraries/classes/Controllers/Server/Status/ProcessesController.php + - + message: "#^Parameter \\#3 \\$subject of function str_replace expects array\\|string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Controllers/Server/Status/QueriesController.php + - message: "#^Method PhpMyAdmin\\\\Controllers\\\\Server\\\\Status\\\\StatusController\\:\\:getConnectionsInfo\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 @@ -1975,6 +2060,11 @@ parameters: count: 2 path: libraries/classes/Controllers/Server/Status/StatusController.php + - + message: "#^Parameter \\#1 \\$value of static method PhpMyAdmin\\\\Util\\:\\:formatByteDown\\(\\) expects float\\|int\\|string\\|null, \\(array\\|float\\|int\\) given\\.$#" + count: 2 + path: libraries/classes/Controllers/Server/Status/StatusController.php + - message: "#^Method PhpMyAdmin\\\\Controllers\\\\Server\\\\Status\\\\VariablesController\\:\\:getAlerts\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 @@ -1990,6 +2080,16 @@ parameters: count: 1 path: libraries/classes/Controllers/Server/Status/VariablesController.php + - + message: "#^Parameter \\#1 \\$haystack of function str_contains expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Controllers/Server/Status/VariablesController.php + + - + message: "#^Parameter \\#1 \\$name of static method PhpMyAdmin\\\\Html\\\\Generator\\:\\:linkToVarDocumentation\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Controllers/Server/Status/VariablesController.php + - message: "#^Parameter \\#2 \\$userGroup of static method PhpMyAdmin\\\\ConfigStorage\\\\UserGroups\\:\\:delete\\(\\) expects string, mixed given\\.$#" count: 1 @@ -2065,6 +2165,16 @@ parameters: count: 1 path: libraries/classes/Controllers/Setup/HomeController.php + - + message: "#^Parameter \\#1 \\$id of method PhpMyAdmin\\\\Config\\\\ConfigFile\\:\\:getServerName\\(\\) expects int, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Controllers/Setup/HomeController.php + + - + message: "#^Parameter \\#1 \\$server of method PhpMyAdmin\\\\Config\\\\ConfigFile\\:\\:getServerDSN\\(\\) expects int, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Controllers/Setup/HomeController.php + - message: "#^Method PhpMyAdmin\\\\Controllers\\\\Setup\\\\ServersController\\:\\:destroy\\(\\) has parameter \\$params with no value type specified in iterable type array\\.$#" count: 1 @@ -2095,6 +2205,11 @@ parameters: count: 1 path: libraries/classes/Controllers/Sql/SetValuesController.php + - + message: "#^Parameter \\#2 \\$offset of class PhpMyAdmin\\\\SqlParser\\\\Components\\\\Limit constructor expects int, \\(float\\|int\\) given\\.$#" + count: 1 + path: libraries/classes/Controllers/Table/ChartController.php + - message: "#^Parameter \\#2 \\$list of static method PhpMyAdmin\\\\SqlParser\\\\Utils\\\\Query\\:\\:replaceClauses\\(\\) expects PhpMyAdmin\\\\SqlParser\\\\TokensList, PhpMyAdmin\\\\SqlParser\\\\TokensList\\|null given\\.$#" count: 1 @@ -2185,6 +2300,21 @@ parameters: count: 1 path: libraries/classes/Controllers/Table/SearchController.php + - + message: "#^Parameter \\#1 \\$string of function strtoupper expects string, \\(array\\\\|string\\|null\\) given\\.$#" + count: 1 + path: libraries/classes/Controllers/Table/SearchController.php + + - + message: "#^Parameter \\#1 \\$type of method PhpMyAdmin\\\\Types\\:\\:getIntegerRange\\(\\) expects string, \\(array\\\\|string\\|null\\) given\\.$#" + count: 1 + path: libraries/classes/Controllers/Table/SearchController.php + + - + message: "#^Parameter \\#1 \\$type of method PhpMyAdmin\\\\Types\\:\\:getTypeOperatorsHtml\\(\\) expects string, \\(array\\\\|string\\|null\\) given\\.$#" + count: 1 + path: libraries/classes/Controllers/Table/SearchController.php + - message: "#^Parameter \\#2 \\$foreign_field of method PhpMyAdmin\\\\ConfigStorage\\\\Relation\\:\\:foreignDropdown\\(\\) expects string, mixed given\\.$#" count: 1 @@ -2325,6 +2455,11 @@ parameters: count: 1 path: libraries/classes/Controllers/Table/StructureController.php + - + message: "#^Parameter \\#1 \\$value of static method PhpMyAdmin\\\\Util\\:\\:formatByteDown\\(\\) expects float\\|int\\|string\\|null, \\(array\\|float\\|int\\) given\\.$#" + count: 2 + path: libraries/classes/Controllers/Table/StructureController.php + - message: "#^Cannot cast mixed to string\\.$#" count: 1 @@ -2335,6 +2470,21 @@ parameters: count: 1 path: libraries/classes/Controllers/Table/ZoomSearchController.php + - + message: "#^Parameter \\#1 \\$string of function strtoupper expects string, \\(array\\\\|string\\|null\\) given\\.$#" + count: 1 + path: libraries/classes/Controllers/Table/ZoomSearchController.php + + - + message: "#^Parameter \\#1 \\$type of method PhpMyAdmin\\\\Types\\:\\:getIntegerRange\\(\\) expects string, \\(array\\\\|string\\|null\\) given\\.$#" + count: 1 + path: libraries/classes/Controllers/Table/ZoomSearchController.php + + - + message: "#^Parameter \\#1 \\$type of method PhpMyAdmin\\\\Types\\:\\:getTypeOperatorsHtml\\(\\) expects string, \\(array\\\\|string\\|null\\) given\\.$#" + count: 1 + path: libraries/classes/Controllers/Table/ZoomSearchController.php + - message: "#^Parameter \\#2 \\$column_index of method PhpMyAdmin\\\\Controllers\\\\Table\\\\ZoomSearchController\\:\\:getColumnProperties\\(\\) expects int, int\\|string\\|false given\\.$#" count: 1 @@ -2550,6 +2700,11 @@ parameters: count: 1 path: libraries/classes/Database/CentralColumns.php + - + message: "#^Parameter \\#3 \\$pageNow of static method PhpMyAdmin\\\\Util\\:\\:pageselector\\(\\) expects int, \\(float\\|int\\) given\\.$#" + count: 1 + path: libraries/classes/Database/CentralColumns.php + - message: "#^Method PhpMyAdmin\\\\Database\\\\Designer\\:\\:getDatabaseTables\\(\\) has parameter \\$tab_column with no value type specified in iterable type array\\.$#" count: 1 @@ -2840,6 +2995,11 @@ parameters: count: 1 path: libraries/classes/Database/Qbe.php + - + message: "#^Method PhpMyAdmin\\\\Database\\\\Qbe\\:\\:getMasterTable\\(\\) should return string but returns \\(int\\|string\\)\\.$#" + count: 1 + path: libraries/classes/Database/Qbe.php + - message: "#^Method PhpMyAdmin\\\\Database\\\\Qbe\\:\\:getSQLQuery\\(\\) has parameter \\$formColumns with no value type specified in iterable type array\\.$#" count: 1 @@ -3305,6 +3465,11 @@ parameters: count: 1 path: libraries/classes/DatabaseInterface.php + - + message: "#^Parameter \\#2 \\$tableName of static method PhpMyAdmin\\\\StorageEngine\\:\\:getMroongaLengths\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/DatabaseInterface.php + - message: "#^Method PhpMyAdmin\\\\Dbal\\\\DbalInterface\\:\\:connect\\(\\) has parameter \\$server with no value type specified in iterable type array\\.$#" count: 1 @@ -3635,6 +3800,11 @@ parameters: count: 4 path: libraries/classes/Display/Results.php + - + message: "#^Property PhpMyAdmin\\\\FieldMetadata\\:\\:\\$internalMediaType \\(string\\) does not accept \\(array\\\\|string\\)\\.$#" + count: 1 + path: libraries/classes/Display/Results.php + - message: "#^Property PhpMyAdmin\\\\FieldMetadata\\:\\:\\$internalMediaType \\(string\\) in isset\\(\\) is not nullable\\.$#" count: 1 @@ -3860,6 +4030,11 @@ parameters: count: 1 path: libraries/classes/Export.php + - + message: "#^Method PhpMyAdmin\\\\Export\\:\\:getMemoryLimit\\(\\) should return int but returns \\(float\\|int\\)\\.$#" + count: 1 + path: libraries/classes/Export.php + - message: "#^Method PhpMyAdmin\\\\Export\\:\\:getPostParams\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 @@ -4670,6 +4845,11 @@ parameters: count: 1 path: libraries/classes/Git.php + - + message: "#^Parameter \\#2 \\$offset of function substr expects int, \\(float\\|int\\) given\\.$#" + count: 2 + path: libraries/classes/Git.php + - message: "#^Variable \\$position might not be defined\\.$#" count: 1 @@ -4845,6 +5025,11 @@ parameters: count: 2 path: libraries/classes/Import.php + - + message: "#^Parameter \\#1 \\$sql of method PhpMyAdmin\\\\Import\\:\\:runQuery\\(\\) expects string, \\(array\\\\|string\\|null\\) given\\.$#" + count: 1 + path: libraries/classes/Import.php + - message: "#^Method PhpMyAdmin\\\\Import\\\\Ajax\\:\\:uploadProgressSetup\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 @@ -5235,6 +5420,11 @@ parameters: count: 1 path: libraries/classes/InsertEdit.php + - + message: "#^Parameter \\#2 \\$keyId of method PhpMyAdmin\\\\InsertEdit\\:\\:showEmptyResultMessageOrSetUniqueCondition\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/InsertEdit.php + - message: "#^Parameter \\#4 \\$data of method PhpMyAdmin\\\\ConfigStorage\\\\Relation\\:\\:foreignDropdown\\(\\) expects string, mixed given\\.$#" count: 1 @@ -5495,6 +5685,11 @@ parameters: count: 1 path: libraries/classes/Navigation/NavigationTree.php + - + message: "#^Parameter \\#1 \\$name of method PhpMyAdmin\\\\Navigation\\\\Nodes\\\\Node\\:\\:getChild\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Navigation/NavigationTree.php + - message: "#^Parameter \\#1 \\$string1 of function strcasecmp expects string, string\\|null given\\.$#" count: 1 @@ -5715,6 +5910,31 @@ parameters: count: 1 path: libraries/classes/Normalization.php + - + message: "#^Parameter \\#1 \\$identifier of static method PhpMyAdmin\\\\Util\\:\\:backquote\\(\\) expects string\\|Stringable\\|null, \\(int\\|string\\) given\\.$#" + count: 3 + path: libraries/classes/Normalization.php + + - + message: "#^Parameter \\#1 \\$string of function htmlspecialchars expects string, \\(int\\|string\\) given\\.$#" + count: 5 + path: libraries/classes/Normalization.php + + - + message: "#^Parameter \\#2 \\$string of function explode expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Normalization.php + + - + message: "#^Parameter \\#2 \\$table of method PhpMyAdmin\\\\DatabaseInterface\\:\\:getColumnNames\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Normalization.php + + - + message: "#^Parameter \\#2 \\$table of static method PhpMyAdmin\\\\Index\\:\\:getPrimary\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Normalization.php + - message: "#^Variable property access on object\\.$#" count: 4 @@ -5780,11 +6000,31 @@ parameters: count: 1 path: libraries/classes/Operations.php + - + message: "#^Parameter \\#1 \\$identifier of static method PhpMyAdmin\\\\Util\\:\\:backquote\\(\\) expects string\\|Stringable\\|null, \\(int\\|string\\) given\\.$#" + count: 3 + path: libraries/classes/Operations.php + - message: "#^Parameter \\#1 \\$query of method PhpMyAdmin\\\\DatabaseInterface\\:\\:query\\(\\) expects string, string\\|null given\\.$#" count: 1 path: libraries/classes/Operations.php + - + message: "#^Parameter \\#2 \\$sourceTable of static method PhpMyAdmin\\\\Table\\:\\:moveCopy\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Operations.php + + - + message: "#^Parameter \\#2 \\$view of method PhpMyAdmin\\\\Plugins\\\\Export\\\\ExportSql\\:\\:getTableDefStandIn\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Operations.php + + - + message: "#^Parameter \\#4 \\$targetTable of static method PhpMyAdmin\\\\Table\\:\\:moveCopy\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Operations.php + - message: "#^Method PhpMyAdmin\\\\Partitioning\\\\Maintenance\\:\\:analyze\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 @@ -6020,6 +6260,11 @@ parameters: count: 1 path: libraries/classes/Plugins/Export/ExportOds.php + - + message: "#^Parameter \\#2 \\$timestamp of function date expects int\\|null, \\(int\\|false\\) given\\.$#" + count: 3 + path: libraries/classes/Plugins/Export/ExportOds.php + - message: "#^Method PhpMyAdmin\\\\Plugins\\\\Export\\\\ExportOdt\\:\\:exportData\\(\\) has parameter \\$aliases with no value type specified in iterable type array\\.$#" count: 1 @@ -6065,6 +6310,11 @@ parameters: count: 1 path: libraries/classes/Plugins/Export/ExportPhparray.php + - + message: "#^Parameter \\#2 \\$subject of function preg_match expects string, \\(array\\\\|string\\|null\\) given\\.$#" + count: 1 + path: libraries/classes/Plugins/Export/ExportPhparray.php + - message: "#^Binary operation \"\\.\" between 'FOREIGN KEY ' and array\\\\|string results in an error\\.$#" count: 1 @@ -6155,6 +6405,11 @@ parameters: count: 5 path: libraries/classes/Plugins/Export/ExportSql.php + - + message: "#^Parameter \\#1 \\$list of class PhpMyAdmin\\\\SqlParser\\\\Parser constructor expects PhpMyAdmin\\\\SqlParser\\\\TokensList\\|PhpMyAdmin\\\\SqlParser\\\\UtfString\\|string\\|null, \\(array\\\\|string\\|null\\) given\\.$#" + count: 1 + path: libraries/classes/Plugins/Export/ExportSql.php + - message: "#^Parameter \\#1 \\$sqlQuery of method PhpMyAdmin\\\\Plugins\\\\Export\\\\ExportSql\\:\\:replaceWithAliases\\(\\) expects string, string\\|null given\\.$#" count: 1 @@ -6170,6 +6425,11 @@ parameters: count: 1 path: libraries/classes/Plugins/Export/ExportSql.php + - + message: "#^Parameter \\#1 \\$timestamp of static method PhpMyAdmin\\\\Util\\:\\:localisedDate\\(\\) expects int, \\(int\\|false\\) given\\.$#" + count: 3 + path: libraries/classes/Plugins/Export/ExportSql.php + - message: "#^Parameter \\#2 \\$id of method PhpMyAdmin\\\\Plugins\\\\ExportPlugin\\:\\:getAlias\\(\\) expects string, mixed given\\.$#" count: 1 @@ -6260,11 +6520,21 @@ parameters: count: 1 path: libraries/classes/Plugins/Export/Helpers/Pdf.php + - + message: "#^Parameter \\#1 \\$x1 of method TCPDF\\:\\:Line\\(\\) expects float, \\(array\\|float\\|int\\) given\\.$#" + count: 3 + path: libraries/classes/Plugins/Export/Helpers/Pdf.php + - message: "#^Parameter \\#3 \\$txt of method TCPDF\\:\\:MultiCell\\(\\) expects string, string\\|null given\\.$#" count: 1 path: libraries/classes/Plugins/Export/Helpers/Pdf.php + - + message: "#^Parameter \\#3 \\$x2 of method TCPDF\\:\\:Line\\(\\) expects float, \\(array\\|float\\|int\\) given\\.$#" + count: 3 + path: libraries/classes/Plugins/Export/Helpers/Pdf.php + - message: "#^Property PhpMyAdmin\\\\Plugins\\\\Export\\\\Helpers\\\\Pdf\\:\\:\\$aliases type has no value type specified in iterable type array\\.$#" count: 1 @@ -6515,6 +6785,11 @@ parameters: count: 1 path: libraries/classes/Plugins/Import/ImportOds.php + - + message: "#^Parameter \\#2 \\$text of method PhpMyAdmin\\\\Plugins\\\\Import\\\\ImportOds\\:\\:getValue\\(\\) expects SimpleXMLElement, \\(SimpleXMLElement\\|null\\) given\\.$#" + count: 1 + path: libraries/classes/Plugins/Import/ImportOds.php + - message: "#^Variable property access on \\(SimpleXMLElement\\|null\\)\\.$#" count: 1 @@ -6600,6 +6875,11 @@ parameters: count: 1 path: libraries/classes/Plugins/ImportPlugin.php + - + message: "#^Parameter \\#2 \\$masterField of method PhpMyAdmin\\\\Plugins\\\\Schema\\\\Dia\\\\DiaRelationSchema\\:\\:addRelation\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Plugins/Schema/Dia/DiaRelationSchema.php + - message: "#^Binary operation \"\\+\" between int\\|string\\|false and 12 results in an error\\.$#" count: 4 @@ -6620,6 +6900,11 @@ parameters: count: 1 path: libraries/classes/Plugins/Schema/Eps/EpsRelationSchema.php + - + message: "#^Parameter \\#4 \\$masterField of method PhpMyAdmin\\\\Plugins\\\\Schema\\\\Eps\\\\EpsRelationSchema\\:\\:addRelation\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Plugins/Schema/Eps/EpsRelationSchema.php + - message: "#^Call to an undefined method object\\:\\:line\\(\\)\\.$#" count: 7 @@ -6690,6 +6975,16 @@ parameters: count: 1 path: libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php + - + message: "#^Parameter \\#1 \\$timestamp of static method PhpMyAdmin\\\\Util\\:\\:localisedDate\\(\\) expects int, \\(int\\|false\\) given\\.$#" + count: 3 + path: libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php + + - + message: "#^Parameter \\#2 \\$masterField of method PhpMyAdmin\\\\Plugins\\\\Schema\\\\Pdf\\\\PdfRelationSchema\\:\\:addRelation\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Plugins/Schema/Pdf/PdfRelationSchema.php + - message: "#^Parameter \\#2 \\$master_table of class PhpMyAdmin\\\\Plugins\\\\Schema\\\\Pdf\\\\RelationStatsPdf constructor expects string, PhpMyAdmin\\\\Plugins\\\\Schema\\\\Pdf\\\\TableStatsPdf given\\.$#" count: 1 @@ -6735,6 +7030,11 @@ parameters: count: 1 path: libraries/classes/Plugins/Schema/Pdf/TableStatsPdf.php + - + message: "#^Property PhpMyAdmin\\\\Plugins\\\\Schema\\\\TableStats\\:\\:\\$width \\(int\\) does not accept \\(float\\|int\\)\\.$#" + count: 1 + path: libraries/classes/Plugins/Schema/Pdf/TableStatsPdf.php + - message: "#^Property PhpMyAdmin\\\\Plugins\\\\Schema\\\\TableStats\\:\\:\\$width \\(int\\) does not accept array\\\\|float\\|int\\.$#" count: 1 @@ -6800,6 +7100,11 @@ parameters: count: 1 path: libraries/classes/Plugins/Schema/Svg/SvgRelationSchema.php + - + message: "#^Parameter \\#4 \\$masterField of method PhpMyAdmin\\\\Plugins\\\\Schema\\\\Svg\\\\SvgRelationSchema\\:\\:addRelation\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Plugins/Schema/Svg/SvgRelationSchema.php + - message: "#^Parameter \\#4 \\$y of method PhpMyAdmin\\\\Plugins\\\\Schema\\\\Svg\\\\Svg\\:\\:startSvgDoc\\(\\) expects int, float\\|int given\\.$#" count: 1 @@ -7725,6 +8030,16 @@ parameters: count: 1 path: libraries/classes/Server/Status/Data.php + - + message: "#^Parameter \\#1 \\$haystack of function str_contains expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Server/Status/Data.php + + - + message: "#^Parameter \\#2 \\$needle of function str_contains expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Server/Status/Data.php + - message: "#^Property PhpMyAdmin\\\\Server\\\\Status\\\\Data\\:\\:\\$allocationMap type has no value type specified in iterable type array\\.$#" count: 1 @@ -7955,11 +8270,26 @@ parameters: count: 1 path: libraries/classes/Setup/ConfigGenerator.php + - + message: "#^Parameter \\#1 \\$haystack of function str_contains expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Setup/ConfigGenerator.php + + - + message: "#^Parameter \\#1 \\$id of method PhpMyAdmin\\\\Config\\\\ConfigFile\\:\\:getServerName\\(\\) expects int, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Setup/ConfigGenerator.php + - message: "#^Parameter \\#1 \\$var_name of static method PhpMyAdmin\\\\Setup\\\\ConfigGenerator\\:\\:getVarExport\\(\\) expects string, string\\|null given\\.$#" count: 2 path: libraries/classes/Setup/ConfigGenerator.php + - + message: "#^Parameter \\#3 \\$subject of function preg_replace expects array\\|string, \\(int\\|string\\) given\\.$#" + count: 2 + path: libraries/classes/Setup/ConfigGenerator.php + - message: "#^Method PhpMyAdmin\\\\Setup\\\\Index\\:\\:messagesShowHtml\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 @@ -8025,6 +8355,11 @@ parameters: count: 1 path: libraries/classes/Sql.php + - + message: "#^Method PhpMyAdmin\\\\Sql\\:\\:getDetailedProfilingStats\\(\\) should return array\\ but returns array\\\\|float\\|int\\>\\.$#" + count: 1 + path: libraries/classes/Sql.php + - message: "#^Method PhpMyAdmin\\\\Sql\\:\\:getHtmlForPreviousUpdateQuery\\(\\) has parameter \\$sqlData with no value type specified in iterable type array\\.$#" count: 1 @@ -8055,6 +8390,11 @@ parameters: count: 1 path: libraries/classes/Sql.php + - + message: "#^Method PhpMyAdmin\\\\Sql\\:\\:getStartPosToDisplayRow\\(\\) should return int but returns \\(float\\|int\\)\\.$#" + count: 1 + path: libraries/classes/Sql.php + - message: "#^Method PhpMyAdmin\\\\Sql\\:\\:getValuesForColumn\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 @@ -8155,6 +8495,11 @@ parameters: count: 1 path: libraries/classes/StorageEngine.php + - + message: "#^Method PhpMyAdmin\\\\StorageEngine\\:\\:getMroongaLengths\\(\\) should return array\\ but returns array\\\\.$#" + count: 1 + path: libraries/classes/StorageEngine.php + - message: "#^Method PhpMyAdmin\\\\StorageEngine\\:\\:getStorageEngines\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 @@ -8395,6 +8740,11 @@ parameters: count: 1 path: libraries/classes/Table.php + - + message: "#^Parameter \\#1 \\$identifier of static method PhpMyAdmin\\\\Util\\:\\:backquote\\(\\) expects string\\|Stringable\\|null, \\(int\\|string\\) given\\.$#" + count: 2 + path: libraries/classes/Table.php + - message: "#^Parameter \\#1 \\$string of function substr expects string, mixed given\\.$#" count: 2 @@ -8445,6 +8795,11 @@ parameters: count: 1 path: libraries/classes/Table/ColumnsDefinition.php + - + message: "#^Parameter \\#1 \\$string of function rtrim expects string, \\(array\\\\|string\\|null\\) given\\.$#" + count: 1 + path: libraries/classes/Table/ColumnsDefinition.php + - message: "#^Parameter \\#2 \\$string of function explode expects string, mixed given\\.$#" count: 1 @@ -8925,6 +9280,11 @@ parameters: count: 1 path: libraries/classes/Url.php + - + message: "#^Parameter \\#2 \\$pre of static method PhpMyAdmin\\\\Url\\:\\:getHiddenFields\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/Url.php + - message: "#^Method PhpMyAdmin\\\\UserPassword\\:\\:setChangePasswordMsg\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 @@ -8950,6 +9310,11 @@ parameters: count: 1 path: libraries/classes/UserPreferences.php + - + message: "#^Parameter \\#1 \\$path of static method PhpMyAdmin\\\\Core\\:\\:arrayWrite\\(\\) expects string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/UserPreferences.php + - message: "#^Parameter \\#1 \\$str of method PhpMyAdmin\\\\DatabaseInterface\\:\\:quoteString\\(\\) expects string, string\\|false given\\.$#" count: 2 @@ -8995,6 +9360,11 @@ parameters: count: 1 path: libraries/classes/Util.php + - + message: "#^Method PhpMyAdmin\\\\Util\\:\\:getDbInfo\\(\\) should return array\\{array, int, int\\} but returns array\\{\\(array\\|float\\|int\\), int\\<0, max\\>, int\\<0, max\\>\\}\\.$#" + count: 1 + path: libraries/classes/Util.php + - message: "#^Method PhpMyAdmin\\\\Util\\:\\:getMenuTabList\\(\\) return type has no value type specified in iterable type array\\.$#" count: 1 @@ -9060,6 +9430,11 @@ parameters: count: 1 path: libraries/classes/Util.php + - + message: "#^Parameter \\#1 \\$value of function count expects array\\|Countable, \\(array\\|float\\|int\\) given\\.$#" + count: 1 + path: libraries/classes/Util.php + - message: "#^Variable static method call on PhpMyAdmin\\\\Util\\.$#" count: 1 @@ -9170,6 +9545,11 @@ parameters: count: 1 path: libraries/classes/ZipExtension.php + - + message: "#^Parameter \\#3 \\$subject of function str_replace expects array\\|string, \\(int\\|string\\) given\\.$#" + count: 1 + path: libraries/classes/ZipExtension.php + - message: "#^Method PhpMyAdmin\\\\Tests\\\\AbstractTestCase\\:\\:callFunction\\(\\) has parameter \\$params with no value type specified in iterable type array\\.$#" count: 1 diff --git a/phpstan.neon.dist b/phpstan.neon.dist index 777f0e1d74..70c09c2b38 100644 --- a/phpstan.neon.dist +++ b/phpstan.neon.dist @@ -29,3 +29,4 @@ parameters: disallowedConstructs: false # Allow dynamic calls to static methods. strictCalls: false + checkBenevolentUnionTypes: true